From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75FC6CEBF83 for ; Fri, 27 Sep 2024 08:12:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C30766B00BF; Fri, 27 Sep 2024 04:12:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BDF2B6B00C0; Fri, 27 Sep 2024 04:12:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A808F6B00C1; Fri, 27 Sep 2024 04:12:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 898B16B00BF for ; Fri, 27 Sep 2024 04:12:39 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 38F94A0ADD for ; Fri, 27 Sep 2024 08:12:39 +0000 (UTC) X-FDA: 82609801638.20.E9F1FF2 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf02.hostedemail.com (Postfix) with ESMTP id DDBC98000E for ; Fri, 27 Sep 2024 08:12:36 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=dp6HvpIf; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=6LLgul8y; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="jq/VV09D"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=wRzGfh3I; dmarc=none; spf=pass (imf02.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727424667; a=rsa-sha256; cv=none; b=DSIzrsODJbZQbv7W14971mhCqUtoLO0qfVHjcS1MpCB7EIX/d2IZFwKAanJBw+1RbY/SP7 VKCg+m7phlevUHO1xkfBq3O0NP9DbimI8y8OUjdfisJaGfquFU0ZYxrly+iUhfrVaH0ozD 8E/R5HYSrRFMjPnnpVUETCmfZj4EwZQ= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=dp6HvpIf; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=6LLgul8y; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="jq/VV09D"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=wRzGfh3I; dmarc=none; spf=pass (imf02.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727424667; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7gyzWsrLWr2lx1n28TMncaCzhR/d6cRY0Yc1+0Oz+ws=; b=t/YJtfirujyTutFCdRk+u363Ampz6QsmGv+6ZVU3uSSIpo21BzBSPt0DbLShVGNYw9fMu8 52/iKHZvizAKxqhEOnKcV8gkZUX3U3P0ZpFohe1V+442wqnvdsbvHGjJWPOLw5jJOXL7My CuyVPQ42KNxFjcsoaQQbI8NPkbKWXJc= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id DA8961F88D; Fri, 27 Sep 2024 08:12:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1727424755; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=7gyzWsrLWr2lx1n28TMncaCzhR/d6cRY0Yc1+0Oz+ws=; b=dp6HvpIfVk/tVA2tZAFGXALYbkbWRJJ7KhRRKjtc2estrSfNjnBHvY+7TJ79U4TH61LqZq Xexqp1EeUmsYdRu8eS9WYIl+BZPFjlGbglnN6A1X9AyenRY/zhn2I/kdb0xf/+3dxnh23X UOjBYP0vOkGFm0waS099qVBbly3ZanU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1727424755; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=7gyzWsrLWr2lx1n28TMncaCzhR/d6cRY0Yc1+0Oz+ws=; b=6LLgul8yUv6OqzvjzF7WKIEiVbkxLtdcMa/IQHmqf6CxDcdmHtouSUjvgxS9MrLdOgNS6l sEuKROjCM7/ZndAw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1727424753; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=7gyzWsrLWr2lx1n28TMncaCzhR/d6cRY0Yc1+0Oz+ws=; b=jq/VV09D5IC2Hyye/f25hew4xosvhgzGYo1OzxiHUBaQlrCjRwDzQo7jPgVjkFb81YukKw FXnbX4gghad7C2rM5Cm0tozT1wRPeCCYBh+0BleN5dpyztmFwTTrhNILqlMk6H4qIDaDOH FVa1JWoiNFL0hSE8XpOdyzUxu/kqX9Q= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1727424753; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=7gyzWsrLWr2lx1n28TMncaCzhR/d6cRY0Yc1+0Oz+ws=; b=wRzGfh3IG4Cf2JLEXRyhsYw8L7zzakm2etGUPnQZoZvHyuYXlIqGlrtav3r2q0mZ8gKhMe EaRq2ojnEA8ZBDDA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id BD7DC13A73; Fri, 27 Sep 2024 08:12:33 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id zNvbLfFo9mYnLwAAD6G6ig (envelope-from ); Fri, 27 Sep 2024 08:12:33 +0000 Message-ID: Date: Fri, 27 Sep 2024 10:12:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] mm/madvise: unrestrict process_madvise() for current process To: Lorenzo Stoakes , Andrew Morton Cc: "Liam R . Howlett" , Suren Baghdasaryan , Arnd Bergmann , Shakeel Butt , linux-api@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Minchan Kim , Christian Brauner , pedro.falcato@gmail.com References: <20240926151019.82902-1-lorenzo.stoakes@oracle.com> Content-Language: en-US From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20240926151019.82902-1-lorenzo.stoakes@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: DDBC98000E X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: djqmnr4914tyzyccozqwspwoufus59gn X-HE-Tag: 1727424756-344005 X-HE-Meta: U2FsdGVkX197rrWwIdmRTlBQKeUOzhp/jDwALgOZ5JIUXlE9tRUI42FBb7J9h5L/eCUTs0MBNehxYu4bcUeJhjfVvQU4GBXRK7iFbcc7TLWSUGEPu1R/hWVD9i0LvnO6A9P1hjwNqagO9nIYQEw9cC5E6MS0jCRnesGsbcrXZZoQMIvuWQm8rvSNY6k0wnhz0gU2gWV7yjOx30G2DT7cNSSZJNEPU4WUJCppV2xwJ2D71sdmG6WjVRk7NXMcXfc5ef9+NsMp70kLaPRUBBbxzaGuo0X8yzMMkGI7Y0KY+0Gk+5stEWuD0pe2EcrFLXwwwt+L/33CW7XIvRnxrkgx78h0FtB3+/uKsamcl40VG1BitAD57ObgmtZNstSGB0GBOnh+/PvxCKmrfEl3CQlpoy3UlYlB+R6AAd4JfenGhuPl8SlIyvvwpnelAWpkj8+/2QE29ziqxopP3MaosbkpcyxyzbAYnCBQT6UvgQ6ud67xPVoSkH9aerlWCkhZF9VhhFsy2uwKnhR23xRNs6HH0vJ+Y0C9XP3Asl5zdOSrQDXZKpUnIC0HKBNr+gaJ1inTLzdGfLSAZZnsTogRPkd3wMtjr+3rhTGVmfHajooEYc6yZ18hIWSPjGK4UOCYr2d3rmeg+M7m827Id2fjxUqZajRjaoAo6690orvD67RTgdNbLHEzMvbVRtcilf5j2TOzsKM+iKjxAvnLuGPamBcOo3CjXykTFMDI1fMMI9/wYeMtPb2Haznkq8Q70VLeB8mY8lX3ltWgrg6fE+4oYVI6S22EHTR2nEzHaAKWnCdqRagRV/bAeOLZtA3iaqVG5GR7ae6Rlbd4mVkuXOqcW/bqHV81/5BD+CtMmVWqXHIp/gt26BesCyhLNKDaBpMvtRLCLHhfUyKnbW+unP3clryHgaIENjxLJBvT2Zyj0VE0UKaESw52z0i1NzE6rEcJh+EScCTFXoaAZGx/hIB2Mls qq/Oyluf TuXqFBby8uiX797afuF0qunIxvOSGNksnCH5A1A4SVADF0aG2IQrKXP5T3QztPs6/S5vooI0Kdqax6UXSJyc2fPOqUa+yGZRPc8mdhMy04DHLNSU60wtu6NSnmTxqtPqiTNSJQftCmEoVC99K+oIJxHV1u9X7cJxkfsh+7HgvWgYbpsQPo4pNzCQDoc/6l5nzXjs8Kuh6taMnLI3IVFYtWYk0va5jA7W3y1Yno/M4u0AM2qOe1hQeiGkFJOX1Jy04ADWAx0ZoEyxlr5hGB7Bm1qBuJas8haPeuELMcizQlkd/YVIBumzJm1aDzSkcZERKURgH34pcP0rfEdfHlYRQG3vj4gdZO6stxNU40BCe8RIaSG2GN5jRcrUTBCGN9ovSJC3bfjlxFpkjl5FxVOPfhH0dbaM6NOYSxQZxPDQ6lCzybhw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/26/24 17:10, Lorenzo Stoakes wrote: > The process_madvise() call was introduced in commit ecb8ac8b1f14 > ("mm/madvise: introduce process_madvise() syscall: an external memory > hinting API") as a means of performing madvise() operations on another > process. > > However, as it provides the means by which to perform multiple madvise() > operations in a batch via an iovec, it is useful to utilise the same > interface for performing operations on the current process rather than a > remote one. > > Commit 22af8caff7d1 ("mm/madvise: process_madvise() drop capability check > if same mm") removed the need for a caller invoking process_madvise() on > its own pidfd to possess the CAP_SYS_NICE capability, however this leaves > the restrictions on operation in place. > > Resolve this by only applying the restriction on operations when accessing > a remote process. > > Moving forward we plan to implement a simpler means of specifying this > condition other than needing to establish a self pidfd, perhaps in the form > of a sentinel pidfd. > > Also take the opportunity to refactor the system call implementation > abstracting the vectorised operation. > > Signed-off-by: Lorenzo Stoakes Acked-by: Vlastimil Babka Looks like the destructive modes should work with the vectorized version too, and with how it returns a partial success. We'll need a man page update though, right?