From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59604D767FB for ; Thu, 31 Oct 2024 19:25:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B23306B0083; Thu, 31 Oct 2024 15:25:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AD2AF6B0088; Thu, 31 Oct 2024 15:25:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 99AC96B0089; Thu, 31 Oct 2024 15:25:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 7DEFD6B0083 for ; Thu, 31 Oct 2024 15:25:04 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 23BCC81842 for ; Thu, 31 Oct 2024 19:25:04 +0000 (UTC) X-FDA: 82734874656.15.9AB51EB Received: from mail-oo1-f66.google.com (mail-oo1-f66.google.com [209.85.161.66]) by imf12.hostedemail.com (Postfix) with ESMTP id B9A564000D for ; Thu, 31 Oct 2024 19:24:49 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=rowland.harvard.edu header.s=google header.b=OErIe6JT; spf=pass (imf12.hostedemail.com: domain of stern@g.harvard.edu designates 209.85.161.66 as permitted sender) smtp.mailfrom=stern@g.harvard.edu; dmarc=pass (policy=none) header.from=rowland.harvard.edu ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730402570; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uhUAE7CiIIKadT6/yqK22wb65HeoOWbYs2QkpH1TFEc=; b=WyqQLf+6Hdrch5hcx/Xwf7CrahDqfXXW0cwhfjJUQ/sYGMFQU2eusz2CRV6/IJao+EuBWL 61/p7VhwtNsjmP9TpMWAHcRvEfvvtQzyLWroiVvhuDB6J827so1CYutUFwfd38yCMViX+k xAID69AA+bxQVq9m+Sh4DK0xXRYQ6HQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730402570; a=rsa-sha256; cv=none; b=h+/AWbLd+2LRjxK76t6wJ3BV8+pxxfYPxC7USdSuJ8ofIJg32Q7w0h4evpXYQB9CRsiBVX AfovhQ+AZ86dbGPUSLSH8Sl2JNUKAX6kesOFrovMkbo+KM+N8cCdzDmmsiFXwEwGplUgsW EZmRbhWmYS2H9IU2f3ysXZ8y++CZETw= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=rowland.harvard.edu header.s=google header.b=OErIe6JT; spf=pass (imf12.hostedemail.com: domain of stern@g.harvard.edu designates 209.85.161.66 as permitted sender) smtp.mailfrom=stern@g.harvard.edu; dmarc=pass (policy=none) header.from=rowland.harvard.edu Received: by mail-oo1-f66.google.com with SMTP id 006d021491bc7-5ebc349204cso685427eaf.3 for ; Thu, 31 Oct 2024 12:25:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rowland.harvard.edu; s=google; t=1730402701; x=1731007501; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=uhUAE7CiIIKadT6/yqK22wb65HeoOWbYs2QkpH1TFEc=; b=OErIe6JTzFKBOFF//PJfQ9kc+3vX+y3/Kf98p3V8r1lXAp51G2/EqtDvQ43PwQKli2 L8MiW5i1Vez0wau4NGfxB8fIhjS4rotBIhOlSellwudXTO9OK0wxY+DSlHeX71mztxvN L+mJGYyGupWu8qDjcMGj492eleOWn1gVhcf0Y/maAPvdj9eRslIUZuCahuAbeylHGdgn LEJDrIZrilJ9antNuRznC8SsYZucrTl+nEy/+oWW7PkUEMSMfMIOSW23qxyunxoAC90C DQ3Brr1Sh+LwJAEols+kPLCKBJxBHP0YjZiXGT8pU9lcDIDjZi1CZGheNgBfufsvn/g2 K4XA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730402701; x=1731007501; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=uhUAE7CiIIKadT6/yqK22wb65HeoOWbYs2QkpH1TFEc=; b=iD5n6KWlFjvdzn+VffUO51oaZ2hNQjjUPba6377v9OVSxorWNxda9OZ2SqrRZjYW2M 2WW3acC1LkTNmHjQ8RCg4l8I45a0rfl+/JYuAN+bDFwuZ3yddt8EvXvd9b3Mce0+T26j tpbLK8KEEVIk7cpWmmp9TBTJMyH1huVmISCh0Fk0O7LHUDLM/+9afCV4J8Ip38cBmlSr Y7D6yC2wk41SY1w+yQE9QC40w6mFIVWkwQZYhnK/6urbUW0jcUsfuCv6FUfi6Ng4hJPr S3yVF5YLlqnYj/+Hl5KpEOzTMR2w/Nlubzr33YfFCHB7CvrUgFgOobkL8pBqDx1SxXxf Fxew== X-Forwarded-Encrypted: i=1; AJvYcCUhB9fKgnj+J4d2iJbLN0yYFme6Ci+qWDmf3X7yS32EYkLHbHb1fMM7FlUi/mIl3/YmsVZG4Vds+g==@kvack.org X-Gm-Message-State: AOJu0YziBMO2qG//bJeRaGMJ6a+ZwS6qihp1S1lVCICvnVfBc9fgs9Z/ Ua5r+x7IhBeYK5bGHsZalTL5R2b9OIDEsOTyoQxA3B+6cZpTmsIpA3Z+JWcKhA== X-Google-Smtp-Source: AGHT+IE4RL0Dif6O3Ry2HBvWKw4OdWKQa4QtWRA9GyvNzx3ILrwjuqWLN3eWXUD22moyPASJ4KXWIQ== X-Received: by 2002:a05:6358:9817:b0:1c2:fcd0:d20a with SMTP id e5c5f4694b2df-1c5f9a4b3bcmr97124455d.25.1730402701046; Thu, 31 Oct 2024 12:25:01 -0700 (PDT) Received: from rowland.harvard.edu ([2607:fb60:2501:2805:c6d5:fe22:7fa3:ec54]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6d35415b1d6sm10958586d6.76.2024.10.31.12.24.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 31 Oct 2024 12:25:00 -0700 (PDT) Date: Thu, 31 Oct 2024 15:24:57 -0400 From: Alan Stern To: Lorenzo Stoakes Cc: syzbot , akpm@linux-foundation.org, jannh@google.com, liam.howlett@oracle.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-usb@vger.kernel.org, syzkaller-bugs@googlegroups.com, vbabka@suse.cz Subject: Re: [syzbot] [mm?] [input?] [usb?] INFO: rcu detected stall in brk (2) Message-ID: References: <6723b31e.050a0220.35b515.0165.GAE@google.com> <2928b6e8-3928-411d-82b8-6b17be266deb@lucifer.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2928b6e8-3928-411d-82b8-6b17be266deb@lucifer.local> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: B9A564000D X-Stat-Signature: zettufiybry8yxneweh431186unig95r X-HE-Tag: 1730402689-241586 X-HE-Meta: U2FsdGVkX1/NDecXPApMZZH2uc+NTaVrwzKjf+8tjX/2obmXZrFNiYKzx96HvqwYm0MVBYF3SzEf0ugzuhNswmFHF+14tX5zzst5tfJFgpJGLqTcIl8pLUMeYGrIS2my9TAi8cnEIEjPAe9wHIvNtHBNIa+7LThoJglsfKUujJ1NBIEBOpo8++tEfTvhjagtV7v1Ao2WEVvMG80EEUXU0ug5/gMYdjFsFFruVmWaBhbU9DtRzj+3YZ76L9PViH/qZUnSVyF+++4GxM5Dc46JKNbFVBVHQdjg2fC0c0Mqi89qNXODec1Xr0EtKWTixWcqU/gIKhKSMzuPrS+SvTg3+bvy/8FeGqvrC5CAJ0LE8vNMrssDC3ecF2WR+9L31pheWokMI/9QQclnjk6jIP2NehYgyywh2plk15t9W4TGYi9q45azJfKVbTl+i++tjCSngLwf6zk5U9nCfHkO4gJTk2ZFZKKhy9g/ZYNzN1xX0Ja3Eplkw2GZUMRjBykoe8HGou/L/Lnf1RHp/e3n86vGQheaKBT4s0ae/ooTVF6lQzg4K1I6NPeNArpehdQrjpzYRzTRBct6rc2kkJWCGXG8uMTIiVn3ZZEQFtxgqcSlxJfBjtJ3qIrxkXlcuKwAzh9FljAUSPCXn+VG2mpQJF5OXXqrtzxNXh8NnjINnT9GQhokj6MdYKZi3e4vX5myLZJ/OI0IZEsO9uaSebg4Q30tIM+xPD/hhguWJdsDHo/5Uh02og9u3bHZB9FS/spQYtPeru4jZ4hzWlCyZbO1FTjxwUkZgzzQa8hlYRwDr/+INSW/KVDgfF6fwMXUit3J7oQktEvlUcD4lmt/x4Eil5M4B3oSCkubz9+cw2ZNnsqgFFCqC1y56/0N5ufAYirAx5/ZrAT6WJEJEx6AF1Sc7mMPvJRB/VjasLwkQNxUhHic0+AgTFo5UTJ5AoIbmPmUlewM23rsyv9sGWj06cGL7uz 1Qj5N1Va LZ0/IOzctwlEFVE/7I3UgI9OjwGOEyFhfwmXM/h3vDTVprT5ZR86Otw4d2fDqDrCv1kUVqdy9i+NAANbFevkUSY4yalwXFd3hyZhGI9JEE5CzzAKM88du3jKkXef04DGh5TXyDKKhmEJO8awzvVThJXNxBJdVJc3FlqNZF8NzV/6XFDHOPtHIGugamXHQ/BJRkqK8yJ9p5sljkHwygUXJe8fcpS1Hbgr7pp0X91wYtWDBBxg9IuYZGMptiCHVy3MC8mgsowDKseeOM+iGi7NGLXcavHBt+TLscBTeCL6qkPPT4P3avLdW6KEYvu142b+l8laeG5ehExxCKxdDPGCUptvV1Ul6pWCnue16HDnlMZJYT+rTSyaUOKRa0HsB2+MQQBGc9Z6MaQjgbM0Z28/U5lEJd9vE8kpX9hRVikI2K/u7ZSN53TfgSFCZfYybyGGkaAFvxAxf90RpJ492Yf2DSnCtYeB2bz+RQIb8dRmAqtmu90CsAGdN31yJ/AUUkl2gHn1E5/WZSBieZhQGiNgkO547dFdmZfLdwIojsyiqg5FiRl9NMIE2NevafujiU2wUGZHW8qzvd2/3ngd/NBLxnl83oi9u9grldsDPitfZl5MPJ4oIUpcpyoBrAwJWB8pIiUjFQ7+XTEgesoNUOD6fYUmOzExk/f0O1qhUW6375H8/d5OTWeaqs4JMJtY3CI8MMWwQqIaLyaqjK7zBdXxoMne/YhLf5pcwU1ziDaqbMHo9RH0WWCq9n6arBmSgLpc44nEQ/U5ZOJL8KHmaugv7xCCm4g3rnTCQFmwztfZIdWj4NT/2b60B/fZldpqbntY8u2xWN/YN8GTMdiC3sa9QtD4iNJK63xBp708m7wwCVC2O8w9cProUcB5RRyzojOTNa4oXRBrSep0PkRxD+6gSdk9qduBeenNVaxTTYP6y1c1QyekbiYQ8hh2ByFujknN7eDBnBCUFfzd1qGxWUHCxYxTouk98 buNbMtg2 WHc1Uqn875Fe8VDYKDKivjCIlWN1elsBLJX2d8R4Qy0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Oct 31, 2024 at 04:58:29PM +0000, Lorenzo Stoakes wrote: > +Alan re: USB stalls > > On Thu, Oct 31, 2024 at 09:41:02AM -0700, syzbot wrote: > > Hello, > > > > syzbot has tested the proposed patch and the reproducer did not trigger any issue: > > > > Reported-by: syzbot+7402e6c8042635c93ead@syzkaller.appspotmail.com > > Tested-by: syzbot+7402e6c8042635c93ead@syzkaller.appspotmail.com > > > > Tested on: > > > > commit: cffcc47b mm/mlock: set the correct prev on failure > > git tree: git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git/ mm-hotfixes-unstable > > console output: https://syzkaller.appspot.com/x/log.txt?x=1304a630580000 > > kernel config: https://syzkaller.appspot.com/x/.config?x=6648774f7c39d413 > > dashboard link: https://syzkaller.appspot.com/bug?extid=7402e6c8042635c93ead > > compiler: gcc (Debian 12.2.0-14) 12.2.0, GNU ld (GNU Binutils for Debian) 2.40 > > > > Note: no patches were applied. > > Note: testing is done by a robot and is best-effort only. > > OK this seems likely to be intermittant (and unrelated to what's in > mm-unstable-fixes honestly) and does make me wonder if the fix referenced > in [0] really has sorted things out? Or whether it has perhaps help > mitigate the issue but not sufficiently in conjunction with debug things > that slow things down. This looks very different from the issues that were addressed by the fix I mentioned in [0]. In particular, the log traces for this series of bug reports all start with something like this: serial_out drivers/tty/serial/8250/8250.h:142 [inline] serial8250_console_fifo_write drivers/tty/serial/8250/8250_port.c:3322 [inline] serial8250_console_write+0xf9e/0x17c0 drivers/tty/serial/8250/8250_port.c:3393 console_emit_next_record kernel/printk/printk.c:3092 [inline] console_flush_all+0x800/0xc60 kernel/printk/printk.c:3180 __console_flush_and_unlock kernel/printk/printk.c:3239 [inline] console_unlock+0xd9/0x210 kernel/printk/printk.c:3279 vprintk_emit+0x424/0x6f0 kernel/printk/printk.c:2407 vprintk+0x7f/0xa0 kernel/printk/printk_safe.c:68 _printk+0xc8/0x100 kernel/printk/printk.c:2432 printk_stack_address arch/x86/kernel/dumpstack.c:72 [inline] indicating that perhaps the problem is related to the 8250 driver. Or perhaps that driver just happens to wait for long periods and so is more likely to show up when the real problem occurs. By contrast, the log traces for the [0] bug reports all show something like this: context_switch kernel/sched/core.c:5315 [inline] __schedule+0x105f/0x34b0 kernel/sched/core.c:6675 __schedule_loop kernel/sched/core.c:6752 [inline] schedule+0xe7/0x350 kernel/sched/core.c:6767 usb_kill_urb.part.0+0x1ca/0x250 drivers/usb/core/urb.c:713 usb_kill_urb+0x83/0xa0 drivers/usb/core/urb.c:702 usb_start_wait_urb+0x255/0x4c0 drivers/usb/core/message.c:65 usb_internal_control_msg drivers/usb/core/message.c:103 [inline] usb_control_msg+0x327/0x4b0 drivers/usb/core/message.c:154 because that bug involved usb_kill_urb() waiting indefinitely for an event that never happens. Alan Stern > [0]:https://lore.kernel.org/all/967f3aa0-447a-4121-b80b-299c926a33f5@rowland.harvard.edu/