From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA157C05027 for ; Thu, 26 Jan 2023 12:48:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1DDC06B0071; Thu, 26 Jan 2023 07:48:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 18DF36B0073; Thu, 26 Jan 2023 07:48:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 03B706B0071; Thu, 26 Jan 2023 07:48:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E89FF6B0071 for ; Thu, 26 Jan 2023 07:48:53 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 781E11A072F for ; Thu, 26 Jan 2023 12:48:53 +0000 (UTC) X-FDA: 80396929746.11.635759D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf06.hostedemail.com (Postfix) with ESMTP id 20B6218001D for ; Thu, 26 Jan 2023 12:48:50 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=E+WqhAtF; spf=pass (imf06.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674737331; a=rsa-sha256; cv=none; b=wh29bYkzsbQcer1/S3Z4Yr9JPLyB8EG/TFuBTHhfhhd+/zFX3hW7lCgGsUwKSf57Ku4oYA hqQHv8BJcnDhMxr9GgQP32GJLZ6DJ5xwcD5YCNfeQiGUTDjQJOeVVsfqRAHJST3kBELlnH GTANxVY7hVj3c5eHkzD35V7OfWmQSpQ= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=E+WqhAtF; spf=pass (imf06.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674737331; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0BNxvjWvId83AWW1PJTCu5WzSpdGDQh2uCQhmIg2RrI=; b=2WhWpxDW5VufImoRWJsCizoUqkGpUj/gpuIAbHLU2oz5igs1yqY0/sZJ/2ZP+5SdnlMsuj i53UnbNqjQE2iAqeynAmw3smdNg0GGnuwFr7c59iLnc0MRx+ks9kCPBsYlde0o0JkAoLTA FHaH2moIxu6cNFQPf71SqkK/VNz2xOU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674737330; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0BNxvjWvId83AWW1PJTCu5WzSpdGDQh2uCQhmIg2RrI=; b=E+WqhAtF+UhqRUP7+57bAdUSc6+V8h/IrlKImV7uFjjMgsaA1d8YWMKuzzn1AR7zuHKBmD 40TrHt9gVPg2ApW3K8O5PNdcY3YdIHBf/WJOwoTr/1nexPiUuGdwcG/0Zuw7zUVulXk3mU ZOmC9upv+B/x7RK6aHcTaUNPHuCSb78= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-636-OF2-OlQ6MVWYeFlZFqTvsQ-1; Thu, 26 Jan 2023 07:48:49 -0500 X-MC-Unique: OF2-OlQ6MVWYeFlZFqTvsQ-1 Received: by mail-wm1-f72.google.com with SMTP id p1-20020a05600c1d8100b003daff82f5edso972163wms.8 for ; Thu, 26 Jan 2023 04:48:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:subject:organization:from :references:cc:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0BNxvjWvId83AWW1PJTCu5WzSpdGDQh2uCQhmIg2RrI=; b=a09bgo+IKsuI0KBfLV59oU65KWRL7xKG2fCWYFT5osOq8f9w0R/Hx6xuLxgqVJUSz+ mWnfGxCHY2B04qT+PYo/vsA4+322XElUHb5gzWz9Pi+WlnJkBtXndFzIig/KnWyMclO3 p2G8oEUZSAQv9zRUg0LCc7dFhebNRzpHkc77xrnbc4PutcMV0pdrvyNKbJLc4j1zgddE eRsOcqPqSQFMX7sfOwQXOpmxAI/HjRUd+FNAACqC6nZWOCoROSsA1ZmkCqo7USTs+aut wl3F4We3ZzMnRDcK8qo+ymFZ63VOs76qBqsB+ZJnp//vylD0sCuuacXDrqabBmYl0kbK BPSA== X-Gm-Message-State: AFqh2krpsZLfGTVNJipB4vdolFB/Gx3lJPngGv0TbU1RIQgI47HZsRcX YEz12/gU1iexXjItbvAPr7kzyHUNeLmLg1YwgalPArw7GThUECWmJtob8Iccc+ejsFy/CmEOyRN ENcOjN4fKVK8= X-Received: by 2002:a5d:42d0:0:b0:2bf:9459:255 with SMTP id t16-20020a5d42d0000000b002bf94590255mr19454390wrr.70.1674737328101; Thu, 26 Jan 2023 04:48:48 -0800 (PST) X-Google-Smtp-Source: AMrXdXvp6hT0LzHLmcy8TtmmdQboBpIp10d0xA7Qe69Y8AA+sgf0taiLjuMR02yytNusms/1pOMNNA== X-Received: by 2002:a5d:42d0:0:b0:2bf:9459:255 with SMTP id t16-20020a5d42d0000000b002bf94590255mr19454377wrr.70.1674737327831; Thu, 26 Jan 2023 04:48:47 -0800 (PST) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id l16-20020adffe90000000b002b8fe58d6desm1215717wrr.62.2023.01.26.04.48.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Jan 2023 04:48:47 -0800 (PST) Message-ID: Date: Thu, 26 Jan 2023 13:48:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 To: Jason Gunthorpe Cc: Alistair Popple , David Howells , Christoph Hellwig , John Hubbard , linux-mm@kvack.org, "Mike Rapoport (IBM)" References: <13-v2-987e91b59705+36b-gup_tidy_jgg@nvidia.com> From: David Hildenbrand Organization: Red Hat Subject: Re: [PATCH v2 13/13] mm/gup: move private gup FOLL_ flags to internal.h In-Reply-To: <13-v2-987e91b59705+36b-gup_tidy_jgg@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 20B6218001D X-Rspamd-Server: rspam01 X-Stat-Signature: 5c4ag3jroz9p5859mhi4ymz9ahijub8y X-HE-Tag: 1674737330-796721 X-HE-Meta: U2FsdGVkX19Tl1Edqq6Glo9UFnvBHOEcPr4rS55Mxf3IWcPGT1ry0wj3ZTWZkVnfsxiXIYPPWIC78EMoJmHi3uuC3HG+L27MFugTyMg5svo3pih+KLqffWCDlCj2k1vdVWoLm3ubVhjPubZwMF5seZSpUKdZlsDSxD3Bq3FvYZxJ1H/wWXwHpe52+Vv0yN1TvRfoHe6GNwzjvqOu7rLiXxvZHvxFQNEtOGLuKLa1kCVtt/Gg9g9aGsmlGR0O2F5oEz1VHpQYjp+4C5hAxSCMoPl2osA58ELuSW1Eyhc9tK4RHM/gGpambWjNVHCqLBCAevvh/GWWcuveUFmS2yMxkR0GMU3jgCKZIJ+hWbO6HLVM3gjHet657xO/BCwWG8rDjyCb0S2PMhP8MTAh7phPRBDdF9a3jibWvP7RoO3kYurIIjFBLjqL0/x6Qse8t1UUCAiJ8OIQulJEkkyT/P8nIh2yLvdCnojb4pPaO7MDStrK3rrBMhVoB+qRFaKhCAzga8txCoi43HeQ46g68mt3WPmcdplZOjOn73wT+v7zxhbRevwlfmxZYNeSs3THszdo/+7paWJ6aVRhRtORD+Ji830hpUTZP3d4zSOCycLqUq1SOMgNao3YybUCp0o3rnVASyWw30pJKOhyBSLINEz4Xz6KH5TTUmICClkACP46usMTBS/lTPTain24PWjEjiz4cxeD5xbfu4Ek5G4UwfU21p4+Beeh2m4tRIzUW3EOo37g0zjX042ILNCmE4ygzNhJj4EQ3wvk7fRlHn7I6uAtJxhb9qI/OlhBG0Tx9aprtVOUAHToMbwyowa7BiYcPFfDR6cN1q/hR8Vr8UXYX/j2jgziODKDd3VoHERYfiMBOPbfhS3lCkARj2fg1SWMpKcGiDkshjx4kgHPfrW+MTDfj9p32a3kgJe5FJAXvGQF+Ola5sG7oA63V827gEjljYP0tq7oMygI3wAimFAhrSD 6DNI1ti+ 0Rq24eneyx2fM8Fg/rCY2ywHWBdc8pCNrBeqAQD25AInINrEwoDy93WXKPoZjCAzR1pg5RqSJqrq26MgrmkcJuLNyR0pkJzSpXtfQSmcgrkM/vxiJP35HvudzZd4j9UwPns3sB/LhjHcjOrK+9b7MqFO8UgJTtoaZXJxiUQgzApA2XtSEFuzrZLHYpkr9wdRxcFkkm1VjFRTJscH71e+2YUQraqFLmNR/dlYVSPpesaIsxZdUQZNdszXEXxqFdlc1HA5UfGA/MwWWf3nJE/9DPmCb5GbqWR/Vx2mTAwPvc4QtP0CMFuyCmJT69p2UZTjO465rr2CMb5KtFNmBJLkD+tn8DxInlnWMDx1bveY8VwXqqEkkYU8C4ziq3+ayip0ea9DY/BAW7R4QaHjUXPC9qMpeNDUYQDNBIx/5VMQZVorUCDlwiM0gKNm5Foc8AyL6pmHigfewUu/QJhAITBM+Fyq0Nw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 24.01.23 21:34, Jason Gunthorpe wrote: > Move the flags that should not/are not used outside gup.c and related into > mm/internal.h to discourage driver abuse. > > To make this more maintainable going forward compact the two FOLL ranges > with new bit numbers from 0 to 11 and 16 to 21, using shifts so it is > explict. > > Switch to an enum so the whole thing is easier to read. Using a __bitwise type would be even better, but that requires quite some adjustments ... The primary leftover for FOLL_GET seems to be follow_page(). IIRC, there is only one caller that doesn't pass FOLL_GET (s390). We could either add a new function to "probe" that anything is mapped (IIRC that's the use case), or simply ref+unref. So we might just be able to make FOLL_GET internal fairly easily, too ... Anyhow Acked-by: David Hildenbrand -- Thanks, David / dhildenb