Re: [PATCH v3 01/12] vfs: widen inode hash/lookup functions to u64

Christian Brauner
2026-03-06T13:29:42Z

On Fri, Mar 06, 2026 at 07:03:15AM -0500, Jeff Layton wrote:
> On Thu, 2026-03-05 at 06:24 -0800, Christoph Hellwig wrote:
> > >  extern struct inode *ilookup5_nowait(struct super_block *sb,
> > > - unsigned long hashval, int (*test)(struct inode *, void *),
> > > + u64 hashval, int (*test)(struct inode *, void *),
> > >   void *data, bool *isnew);
> > > -extern struct inode *ilookup5(struct super_block *sb, unsigned long hashval,
> > > +extern struct inode *ilookup5(struct super_block *sb, u64 hashval,
> > >   int (*test)(struct inode *, void *), void *data);
> >
> > ...
> >
> > Can you please drop all these pointless externs while you're at it?
> >
>
> I was planning to do that, but then Christian merged it!
>
> I'll do a patch on top of this that does this in the range of fs.h that
> the patch touches. Christian can throw it on top of the series, and
> that shouldn't be too bad for backports.

I can easily drop those so no need to resend for stuff like this as per
the usual protocol.