From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FCF1E7717D for ; Mon, 9 Dec 2024 17:09:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 246638D0090; Mon, 9 Dec 2024 12:09:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1F5798D0058; Mon, 9 Dec 2024 12:09:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 047FB8D0090; Mon, 9 Dec 2024 12:09:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D9BE08D0058 for ; Mon, 9 Dec 2024 12:09:37 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 985481208DF for ; Mon, 9 Dec 2024 17:09:37 +0000 (UTC) X-FDA: 82876056312.27.C376E3B Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf07.hostedemail.com (Postfix) with ESMTP id DFAF040013 for ; Mon, 9 Dec 2024 17:09:12 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=SA+s4wgb; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=oj3e7pbw; spf=pass (imf07.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733764158; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TswIY021muudANnfZO2nlILiqA0d0Wddabtc++z3/RA=; b=hfi13A4dN8rCjgez9X/A9YLI1GENgrF3fTrvrXhYO+IRMgGNw9sTNPDFKF37E+/n7LW+Ge lKqb3T4G7UBTvMItR+nFRdXYFFdCsEzG/ZIIJBmHH/yXxGQORSrXd6qr8yijVLGSW9fYhI zMjDn0VOEUqwKXEh0mS0c5ZZKlrWnOg= ARC-Authentication-Results: i=2; imf07.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=SA+s4wgb; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=oj3e7pbw; spf=pass (imf07.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1733764158; a=rsa-sha256; cv=pass; b=YWfyMWsgDeGa9WFCko6SusltRDtwIfPAdXmqOAi+GlTfmmQyb9KihtXwLfj6lRcBQY/fGh gBvnedzQ3qa2VVC0lkXiqGMKVlqZbXsxM1VlI+RHm1m1Pe3/wHV04nzMpi3zlyhn1L3h6Y 83OVFEAsnz8RbT9HtKBKLaPTquVl04k= Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4B9Gfr6V030210; Mon, 9 Dec 2024 17:09:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h= content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2023-11-20; bh=TswIY021muudANnfZO 2nlILiqA0d0Wddabtc++z3/RA=; b=SA+s4wgbMmXfKOUkhRFY1XXvdZAIcoXe8c b9K1yOZ0Y2llmGXnUWz7Xrs19NkLnn8/gYqvyXuLXRiNhvF+eY1A6C/wJpfuDHrv zeyUIjSKui+tM2Nwwz/T6YagwINWwuvdMphbIcVic86WKgDCo0IPPUjSwNwHIL3G M3qyWm0P7mrPft5sf5GA5ffvrJdriTuMhdNPCRWGPjGx40TyA5YJDb3YU91FZqR5 mMbKL5U/4YLn+h9zFC/L2vRIU8Rhjj9BAtyC4U4LeshTiAlHbZ52m6fqNtI7fyB7 cX8ucDdG5ftPLp/Ve2tlgTDLf1Pf94SjUtwVWwe6UDD3y3KSpx6Q== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 43ccy03syn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 09 Dec 2024 17:09:26 +0000 (GMT) Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 4B9FWQwr019344; Mon, 9 Dec 2024 17:09:25 GMT Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2177.outbound.protection.outlook.com [104.47.59.177]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 43cct7gvbe-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 09 Dec 2024 17:09:25 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NQtJmaNhm8ujb+dE7zPKfeLl4vFPWlQAh8N9e5jXMg7Xm/7Uqa+T8pzmW3vX4pV1a55Hju2xiL80iQisAb5femCJ/X+b8x3e0nL2bLP1V+H41f+qXbU5tEuDzjYIUM5dIUczNTEgiAq/hKI8/kD09SoSAC1c76OhnGz3W66hG6otV3RxP/LctG+miO6K4GgbdHzHY3nZCZjXzZ6kNMso8+d/T0pf5QhlAWKNEcJJFx9CDVmDtGLuM2JO/3wEHxBrMrOj6it98qa4OV4zGcY2Iv4u1LBSCbTufaKvjNAu8yjQNjgD/OzbrytZCQ29OlMc5Xwc7WDsemLPyuUQeh8A1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TswIY021muudANnfZO2nlILiqA0d0Wddabtc++z3/RA=; b=Aakt3BkKaVLEwXo79hAD2B2+L1oQu3GRdDHiKIDTc7iQoRrYjJWRluXmOGq2m+wfmEc2W4XJc0Wfh+jPhnrZnzjVhbdxEnnUXZZJkCjnB08MyovhSpsuBMZy9YbSBt6LtnY4zgjmzvEUKNCJi1eWs+AUt1hqFQ3BjCrGO778f/8cE0S1CkABeTpjD3mOpR6QoezfUTUaGilD/g7mwkv4PbIVE5jTfJi5keY0YXoRKba4qWVABAl3nZcyS+S9DiR9h3K21+8S9j/mv4dLn48bN18w+AxJiyipaVU/yQUACwtaG17MWbqNftL6fsRC9v4+GjDmhOXmKSECcVmz3llGsQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TswIY021muudANnfZO2nlILiqA0d0Wddabtc++z3/RA=; b=oj3e7pbw/jf1sLeRnLhaYtJdvldiPuyA/DMjm8Gtev2NrB5CRFh/JzEvz2SroDe4Ko6bPJ9liJAQXUglp2tzcXD3hG5yZa49hbf8duC9oFkjqCo9EDFyPOayNaKGK4fgPnAAgin4tbXYdWyfNiKkr02yQFjI9EbUP/s4xij/HiQ= Received: from BYAPR10MB3366.namprd10.prod.outlook.com (2603:10b6:a03:14f::25) by BLAPR10MB5057.namprd10.prod.outlook.com (2603:10b6:208:30e::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8230.18; Mon, 9 Dec 2024 17:09:22 +0000 Received: from BYAPR10MB3366.namprd10.prod.outlook.com ([fe80::baf2:dff1:d471:1c9]) by BYAPR10MB3366.namprd10.prod.outlook.com ([fe80::baf2:dff1:d471:1c9%7]) with mapi id 15.20.8230.010; Mon, 9 Dec 2024 17:09:22 +0000 Date: Mon, 9 Dec 2024 17:09:13 +0000 From: Lorenzo Stoakes To: "Liam R. Howlett" , mhiramat@kernel.org, oleg@redhat.com, peterz@infradead.org, Jann Horn , syzbot , akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, syzkaller-bugs@googlegroups.com, vbabka@suse.cz Subject: Re: [syzbot] [mm?] general protection fault in find_mergeable_anon_vma Message-ID: References: <4d05caee-d900-42e5-84e1-448cc62435b2@lucifer.local> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: LO4P123CA0608.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:314::8) To BYAPR10MB3366.namprd10.prod.outlook.com (2603:10b6:a03:14f::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR10MB3366:EE_|BLAPR10MB5057:EE_ X-MS-Office365-Filtering-Correlation-Id: e44ac062-98cf-4dfc-b3dc-08dd1874399a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|7416014|376014|921020; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?JnsQyADoJ4l9uBT4kJL2BtreQNvFDsXBVezEcMgKWV2reL96IfpyS9yZsdBS?= =?us-ascii?Q?RqKaxgU1NEzduND2owyEOzA2Qjrn8tPRtghbj06vTMy47GrQl8qjMxmE7+tm?= =?us-ascii?Q?lP27ZS3hhNBKzVbjMouav5vxIPbXIiPkBUMskyzZRhG1FAry3gxK0xRPgaQW?= =?us-ascii?Q?65jwQaFsNtfAWqgm/1r03EQa+JcR524D6qmdxccTHlyX3SOodCzbucO2tXHV?= =?us-ascii?Q?NXkYhJz+7q5y33eGlsfJ88l0xcGPBP6k91zbuDsb1svuIXlATN4WSbO2ICbh?= =?us-ascii?Q?VfnXrTwr8I6HCVJny08w5kwEzkPpua9p0Dl0snpJRPUUSPuvjVXUJK4taY93?= =?us-ascii?Q?NG+gQbCU7zNbAS5U2q5fSgzD4FgIeQX6GPVff4jGetcx5u1VoBP8LUMUkYq8?= =?us-ascii?Q?dUQG0sjEcXRsPGcc7lN9E6TGsZCPYTpc9+0c3DSoTmIr4Yv5jMrE/hXyio8f?= =?us-ascii?Q?m2Mej+woX4x+06Gl5zMdyyTYb+S4tZNOV1RwFbaeIpJfqBPkIpGRgtfwTxJ6?= =?us-ascii?Q?z26aApojyTgK8yxzkHwNFFHINIzLrxX7bpHXWU1ZYvfKKpmKp1RIKo4cm3Ew?= =?us-ascii?Q?TK2G3+2dR6xx7fr2hAuZbItDJLZife10TuPVrmzDCJjuIRZSWsssjFQdri40?= =?us-ascii?Q?p8uIwFOCwL7kjaFeo35tR0EHBzXPY0RsFjO3KEAq3QeT8hmrnVBGR5QnmphG?= =?us-ascii?Q?oZwo7rRWhnv2zJ7VOjwG8YMJLPtzuuKR+QTYiC9NWBiRB+JSdqAQhWKR+Wf5?= =?us-ascii?Q?n/yjuOSK2rh9WwMHMTTYGuMMzOmAqqFYKrUmv6HfCRwe9CMN/wsPqqFM+/Ni?= =?us-ascii?Q?9OTx2MPw+CoyGFjbIFDLQ0aPSj6YgDBM0XZwTMsrUkMKiu6f9N9I/0BDQhwk?= =?us-ascii?Q?j3mb3Jmy61MDkZgoCs7k8lkmIiYolxehlNyzErpyCitdUdPp/L6uJgHrlZy5?= =?us-ascii?Q?Be5YL6VU6YQBSLPuyNesaiKRRs02wG+wD9Cf0ukVXDfRWdbUol4BMCI3Ujwg?= =?us-ascii?Q?y9Ki1c0SpZqopUoyFOokpLluZfQUb9XV1/bp51frP4hFgbjhdtyaSyITX+/m?= =?us-ascii?Q?u0o9tYa4lyaj3/YDEu6MYO5LCiBpmJo9nUL+jE3VxuE3KPFk+rRdzXbyXrSw?= =?us-ascii?Q?I9ljzMRnvcVice1gSyllq4YwRE6j4SZW9/7Pgpti1MDDg3OshjzKCaSkjXtw?= =?us-ascii?Q?0N2XIJFfInz69/MfEwVkyiVFWXgtrfuL7BzQYYwU/RyuiN16ymhEVj0TpZUE?= =?us-ascii?Q?C39biPCAOuBz/Ll4QX7Eq8EakSznxXCYJX45mthrxa5E1Xg5fs2AWy4e2I9u?= =?us-ascii?Q?QXPsR6MDF9NTuZXa5ySwMXdL6WIyzBAmX2Kp3OxIAxcAo83VL/w9YpMvNT1m?= =?us-ascii?Q?VUxslTX/VhHuN9dDC4HZa3D6F6Wjs8QIygRLew6UdNGGojEIVA=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB3366.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(7416014)(376014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?v1zwlgIKVj9ImeATNvF5ciG6Bi+/FciemLkWe+NufTxn+JQfL3OFtrUAQzL7?= =?us-ascii?Q?dPMOkOW94NIRjqJNkggy6FWAAmqX2e3bZR7HRs3YKqZ0Q5pGEgciwB1l4hSY?= =?us-ascii?Q?KjJD/Wc2H/WThUplad+2JVKU4K7NhozYLMnBYNremkJrfX/4UCtg3kL4F8A9?= =?us-ascii?Q?AJsm2EKpRLwPmwVVEVuinB1Thq23ejrb/UHStzSZygip64oFNa8FKj8D3IlW?= =?us-ascii?Q?5KxCCBRiuFdxHsJ2UD3+lncavkenbXCyArPqHVDvdvKkvQphrMiyNYBFuf7X?= =?us-ascii?Q?UtUlO5xWZhzsKF7CTQ9HKyj82kAeswhgJ8hKVMeRxjgvvri0kWj+H53GhLxU?= =?us-ascii?Q?/bCbEvXWW4EGVaRIbpDF/7b36eCTkvSLTICfye8ImRUByCKYhsXZncxr+H+V?= =?us-ascii?Q?uy7w2SGhz6S8XEbQnNEFshl0B5eQ8Gcf+5YKY+NjUvAFqJ6nUtmJ+RAXrBZl?= =?us-ascii?Q?DHG6wFw5bGMrefduIxCsWoZJL4nytvVnb3YHdj/5V4n+AsvcCBYTNWw0Wx/J?= =?us-ascii?Q?f94Rc3U+eGTi97i+84Yjw/P0Po+9lVRG/RXKHLynvTCXp9VdJODVr9tn3tKb?= =?us-ascii?Q?Epk9iEvmf0qSEc2tmHBpbZ0PsQRRD0+p3K5Mm5lDSmDW8hxnAoA4zsSBTGir?= =?us-ascii?Q?3Vnwq1iueUdgF0sDK/OI8151OumqL0BHFtxg2nlNf7C09OK8WUZiW5oLdQZv?= =?us-ascii?Q?xSwFeLcD3xMYyHydf/yWU0bBXfjMitGIH4O6D3jYFsLWihYDoRkaw2FDs8nM?= =?us-ascii?Q?EbwMloY0mClKLM7dDILqaNL5GJ423tldKEjJbn20aBU2w3be+o0o6sHo/SAF?= =?us-ascii?Q?bJo+xlrk+MKYmOREUL7GzM6kQu3lW4Vn6GQZyDq/KS0cvZ+fNAR7UmZlarNo?= =?us-ascii?Q?AxNg/z8un3XvWM4h9nnzChHf+9upePQw3dfYnzADb4LMaanPYz+7At1Ae/0U?= =?us-ascii?Q?yByjlhdWwclk+dYaro/w5+kBIlLyXup/LxiMfl/WzCV1MqknD3yBcR2WEzZL?= =?us-ascii?Q?B9psttqVYd0xFqarEEHVUsayhzDf5ioVN+XFxc3FSXrWEinOGRqejEi2NN3v?= =?us-ascii?Q?o874D8g1zbO+h7gKf5MqQ3AaJCuCxeBVvLc0zquvYxoovKwQFKFbVmNknVVQ?= =?us-ascii?Q?2Rw1BW8bWSwLsJrHkDokDWnlh/xNwFrb45mbvGrYTGpoE1RY0nVIAmC/J6f9?= =?us-ascii?Q?3iVZsgu81iQFDMogJm0SB8RsU9agyuiWZZ6wFvIsvIWdv1fUfj9C/DtD6S4W?= =?us-ascii?Q?+OPmy7BELQ/zwmALaaS5NqTwhPtExdH7DgJe1SS/SDzqTUID4eHjsjwsX0BS?= =?us-ascii?Q?4pn4xMC7/JnsGIBzGWuGb/RBj1GQb9H3/HEs7h7vzPYJ76ePgKDidKG840qx?= =?us-ascii?Q?wBBs8Xv2PC3zKtFsMl3o8j7awFD6uiZ4Te2I7sRn6wUcKi6DzHAQD5shO46x?= =?us-ascii?Q?D3u8VKiWdMXTQNeeXes899tUGXlaBOfxLCzqEIgyRZYKJtmf+TvhCB8vkAvF?= =?us-ascii?Q?2+YwAx0rYJYZ9eta+IvN42E+hMkp1KD57MB/mIu09TDtwLFrs/lVHCXruSEJ?= =?us-ascii?Q?aJ6R4dQtcFQlZrO/v3VW/cI6BUzj6NSARJeNdax+pppkGrHMsS5eFQu6XY1m?= =?us-ascii?Q?fw=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: DDdktqWD9AFUxJp5x+8ebugjjwggtAlXWglxlIiJaxMNaltYZKTlIzASDYUnEFCQfE73acaJgdqzpUMIGbYhhzKBmfgHiIVjv6JpkhyMY3f61ZQMCb0MUfc3JqfrlydZGnhog9UVI6nYvozfZ9x9aw6Z36oOGwsxVmfWkLjollxASz89W+88OvQ6o0lp0ImPyKgnxUgAc1CNnodANaGnZfJ5GPxNibkRVa3CzSt00cnugEl9OiqyJFf06qST8AQ2z0enXR8QFTpuSF73wiarDeHBHDyd4kInv1cVOxpwX/4/2e5Bm5TXoODMTN076tn0T3+OND/o99JhDjv8wdnFVAqxLRK6mEvLW68M7zzHWJKCYUD7k1ChqVM6NnfXCWTDoTi5S1tSP85CXVhDjCf0xYFLxKN7mh2MVFXj9ury2B5lm7+ZfbgLwqYNq7CSlB3er9d7kK6Nj+2jPuaoSka7mZ6NEiYB7BIbOn+moaZSUTlG8BysLTQVJL/EVaFNSgXhhhveiVV754WTlYZuoSFbDUfE2jh51IGKyKwN9tt6BmuyyMT3ZPEUmSJLHb06oAWA7REL0voHq9LTtw8MgE2Y6XU4TRE91oxecaOzhTwGCn4= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: e44ac062-98cf-4dfc-b3dc-08dd1874399a X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3366.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2024 17:09:22.1163 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: U/NtYABWRx3lVXEkjeR38YBFsIiaHpmXGgt5yIus36eoxqUD0c8HOZfDHvnaTznkYD1Y/NQTzV1T3ot3iLYWSqkKX4ynlBLYpp7d8NDMFo8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5057 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2024-12-09_14,2024-12-09_03,2024-11-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0 adultscore=0 spamscore=0 suspectscore=0 mlxlogscore=999 bulkscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2411120000 definitions=main-2412090133 X-Proofpoint-GUID: H-K0S2V1-LuZ4Sz8o95hbay7FzEb0g8K X-Proofpoint-ORIG-GUID: H-K0S2V1-LuZ4Sz8o95hbay7FzEb0g8K X-Rspamd-Queue-Id: DFAF040013 X-Rspamd-Server: rspam12 X-Stat-Signature: 66m3i3u4uqofgggaddghuq5zuosxzx4u X-Rspam-User: X-HE-Tag: 1733764152-633828 X-HE-Meta: U2FsdGVkX18IuImMyCOBykGW1Pvt+9B3hL2Pf83kXLAMYKyZ0OrbQQziw2AZBSO7a1Rs/cH2sZqhtH2S5Z7aQWqvCL6AbW8sHY+w8gDSCX70ANZqgvgQuGrTJ4CArlD477qFRVXeV40WCfxKE3lUnvgoXlcWmY3EuCVbAl+cO/tExAC+WBIHWDFqqelGb/V+MnKHidLYQIKbClp1SZUDtTz8eq9rmb7Bs0847eSk4v+6BQOXBJnfjnkmvYXQ9Ef1B0uI44NrxT56HkLG146HTm4/EfCz/2U7FRDz4N1M1ighsIf09B4bdAHJ+lQTRc1iQQraQxo5OyO/6wKbdE7e7TP8e7ex/lb60uwflr+i/sbylEc3HMyCl2Nn8N7OFYPfcZMAlCw+kjcaiHy1BBNTFcfqjvQ2a52qn1CQkbUEZvgGhtLhSTLQP2sRqt6Leio/A8fOHFqNf2luKNhY3bccpt/awNAA+049RLEPYSWK0PtXfhVzh81hZAmBlGhlJ8lCRu3no4RkRkFldjy3OTd7aswHIQ+IWxgNC0fmbHEzfYMcoiuf4m5oGCZdClXirqu6DahZ3wCwQXMojjtIMG96p9wgGiJVKJKvLb8a8NnDNbR5ogncZn+Q/JPVa+lD2Db8P60KNw3ztNjgqZKHeU3F1kIeQJ4UrMIOaLb+qbT5pBIJaI7TFJbn6oXXuMRZYFu6TeVtTVj5Me6eBRuOu8rKvlTHDKMfRufxseegUCiUYOC/RiYEhm27hG2PfatR+nsrfbIxQE/qQz9Vo4e4+pyhovyyBCBX7eE4xJu1ii4fVY4iNJfQmvCWINts2RUwfy6y6P3a1ynf0bIAK5hT3JsKO9cHJL06HxuoPjudY3unza6VFvBCdKFVZbVF6CjSixmY5MFFzQ8t4ow4mqUIVsRmaA14fyJmGhYzUjf/cNSN65BebW9cVOtZtVqL9Wr55RwvQzbCcdJYMWw4aX83cuG P7G1DyIy 8ZBecEdRQ7ty0I0Ra/iZ5dZTqDGftcNiXPWhX1hpD70DFxRV+rB/lKnmaGO6g4WkVUeuAkq13cfCXGzupdLM6JjC9HfhkD0NAj6FQA9uv84VDPSyQFfOVcsowWv1lHb3HXeAUQnCMoysraT4iwjdVninD3BH4M9A/AcffWLq6PrKTU4niSqTpB0Xjd7kl+anKovY0zPRQb4K591jILzbFxN3vK8QOTI6F6LPyyHNxbe1ZRpti2LoFeUWFcerPinGMzeZhlznj7XqQ3sOcY2zDJnm7ePMvgJYkdAsIPhOVvVYflW6lhirMzjo/9e79OxJxp83wbDns+bWKcY4WW2ZR/FqblbX5uZuueFB4MeGFTe24BKilMSaQOLUbEyzNQxIPVfmDmdXR452uiZudE7lWjaiERvHZ9cwwSGgMv4uggfEnfvh9FyEypdtvxONYEehysR/fwDIiXQR9tfR6Q79eYQRPbi+vEqifud+YLJ4esbcY87FVXK048CKSQRZ2OJftmg/MqsEqtsVnSuPQyB/k22Kp2SVEGtEsYN1XiqVUGv36FqD0nSBRbS4Md48T2q0dySjDJ1vEf/wSpPX2vzRywcWw5+tnMDwmmHWPgQqDn9uqK0sBKBgMNmuXO6jxDGXhjMe6Q8Emz9kivuMyBq0u7zYQq5Ukgkijocipvvq9NTk504lif1IJSo/USMqPNqiZuy0vhTSetiyzjANWrekbuh/zsPu9L7bA2iA/2zPBsgCIvZrI2Idwh+pexQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Dec 09, 2024 at 11:12:52AM -0500, Liam R. Howlett wrote: > +Cc maintainers listed of kernel/events/uprobe.c > > TL;DR: > dup_mmap() fails, but uprobe thinks it's fine and keeps trying to use an > incomplete mm_struct. > > We're looking for a way to signal to uprobe to abort, cleanly. > > Looking at kernel/fork.c, dup_mmap(): > > fail_uprobe_end: > uprobe_end_dup_mmap(); > return retval; > > So uprobe is aware it could fail, but releases the semaphore and then > doesn't check if the mm struct is okay to use. > > What should happen in the failed mm_struct case? > > Thanks, > Liam > (As discussed on IRC) how about moving up the dup_mmap_sem lock one level, we can put the mm before the rmap lookup in build_map_info() is able to find it, which should avoid the whole issue? Untested patch attached. ----8<---- >From 629b04fe8cfdf6b4fad0ff91a316d4643ccd737d Mon Sep 17 00:00:00 2001 From: Lorenzo Stoakes Date: Mon, 9 Dec 2024 16:58:14 +0000 Subject: [PATCH] tmp --- kernel/fork.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/kernel/fork.c b/kernel/fork.c index 1450b461d196..4d62e776c413 100644 --- a/kernel/fork.c +++ b/kernel/fork.c @@ -639,7 +639,6 @@ static __latent_entropy int dup_mmap(struct mm_struct *mm, LIST_HEAD(uf); VMA_ITERATOR(vmi, mm, 0); - uprobe_start_dup_mmap(); if (mmap_write_lock_killable(oldmm)) { retval = -EINTR; goto fail_uprobe_end; @@ -783,7 +782,6 @@ static __latent_entropy int dup_mmap(struct mm_struct *mm, else dup_userfaultfd_fail(&uf); fail_uprobe_end: - uprobe_end_dup_mmap(); return retval; fail_nomem_anon_vma_fork: @@ -1692,9 +1690,11 @@ static struct mm_struct *dup_mm(struct task_struct *tsk, if (!mm_init(mm, tsk, mm->user_ns)) goto fail_nomem; + uprobe_start_dup_mmap(); err = dup_mmap(mm, oldmm); if (err) goto free_pt; + uprobe_end_dup_mmap(); mm->hiwater_rss = get_mm_rss(mm); mm->hiwater_vm = mm->total_vm; @@ -1709,6 +1709,7 @@ static struct mm_struct *dup_mm(struct task_struct *tsk, mm->binfmt = NULL; mm_init_owner(mm, NULL); mmput(mm); + uprobe_end_dup_mmap(); fail_nomem: return NULL; -- 2.47.1