From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73227CF11E2 for ; Thu, 10 Oct 2024 12:35:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9642A6B0082; Thu, 10 Oct 2024 08:35:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8EC556B0083; Thu, 10 Oct 2024 08:35:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 78CBA6B0085; Thu, 10 Oct 2024 08:35:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 5843F6B0082 for ; Thu, 10 Oct 2024 08:35:32 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 6A6F0C0117 for ; Thu, 10 Oct 2024 12:35:28 +0000 (UTC) X-FDA: 82657638504.05.B954282 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf29.hostedemail.com (Postfix) with ESMTP id 9C7C5120013 for ; Thu, 10 Oct 2024 12:35:28 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=none; spf=pass (imf29.hostedemail.com: domain of vincenzo.frascino@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=vincenzo.frascino@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728563593; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fERPPGRKEcvi7KpEUlVYjMOlv30BfXOGAstOauB4Cao=; b=7W4/kkR3wHIpwgwkMKgfOVp6pecK2Gdk4HK/jsIXVI54QjELgBmxqPikMtobFUJr2t97bO cxlIWsKl+0G1AeK5akdijJSgNM1nvf6kDxdJp48DHMliL6e94Bi8/z5Ra3gUpVv24j7Bal QKLmypGVM6PbLQOCCMWhC2+SuKEfsu4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728563593; a=rsa-sha256; cv=none; b=BuoZ1thV9PlTYjqYuMumUnysB7Z4VXjrs1hhZy7C6jEtN9qAn3Ikf+37rFK8XX4aqJLr5K qUb1NEp2N6uDMeyTmTE7/hZasp9zN4vdM1fEXJb2L3eWY4c2/5UoRivxlh4ui6/bfeoqSd wPGwXry9yAG7tQmlL7ZXZJQvxO0TLq0= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=none; spf=pass (imf29.hostedemail.com: domain of vincenzo.frascino@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=vincenzo.frascino@arm.com; dmarc=pass (policy=none) header.from=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 777A6497; Thu, 10 Oct 2024 05:35:58 -0700 (PDT) Received: from [10.1.196.72] (e119884-lin.cambridge.arm.com [10.1.196.72]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C41903F58B; Thu, 10 Oct 2024 05:35:25 -0700 (PDT) Message-ID: Date: Thu, 10 Oct 2024 13:35:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/2] vdso: Introduce vdso/page.h To: Thomas Gleixner , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org Cc: Andy Lutomirski , "Jason A . Donenfeld" , Christophe Leroy , Michael Ellerman , Nicholas Piggin , Naveen N Rao , Ingo Molnar , Borislav Petkov , Dave Hansen , "H . Peter Anvin" , Theodore Ts'o , Arnd Bergmann , Andrew Morton , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers References: <20241003152910.3287259-1-vincenzo.frascino@arm.com> <20241003152910.3287259-3-vincenzo.frascino@arm.com> <87wmihr49g.ffs@tglx> Content-Language: en-US From: Vincenzo Frascino In-Reply-To: <87wmihr49g.ffs@tglx> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 9C7C5120013 X-Stat-Signature: rarwtu7ecxdq3x8m4q1187pcg1cr9af6 X-HE-Tag: 1728563728-485465 X-HE-Meta: U2FsdGVkX18TdGCQjiPT7lgxvsf/oX7mCn+ZQoF+bOSzZvIYVaiL/9chj7AM3+gsG5Wa465ooeun6R2OIMX/0nmt1iho+cH4T2BhKhtAIj4DQ4+Yd8Oomota3jHNwg2pFombhReL9DOgTQnqaXI83ppfkYQjMNFST/vnsnlkh+ZmZwE2tPsnLRs69iSmWVWFqhkdLX60nuYBE6t86RAtZr6WcKQ5ul5DqihqwrN4JCIhwKvVec1yDe/FIdiQBYdq9FBkm5BHZWp7XVRJSJUbq6Ex58LaYQuiiOrzej8wwMIuRxOtcO2bXQajPRPScOacRhADrX2xqzJBjiZ+zJznW1kxK1XyRs5xubLbMlP3PIPnkPUgX/uQyFoILq+vG6ulvqoJCx+OWeJNiDazBL2PhQVqWnqARkIx/KdPqTBWgxNCZccfOIvyiN+WP8PVX85/kPSUFTQ8j7jt7GohkyDr3vDRcH80uAGuf8uLu3droXsWdFszye5YqwySyyamvEmyQmBr1bfpNsNDcbJVHZrmcNV+ZxUOd2D483ZYw9MmlvwUCDpMG8jZHHJxt5Z15SGpMZ8qzH7ZIKhlHcu8XJB+pxhTRpODZeKwz8akMPTz6p2uLwGvblWvNRMoT5oaoM4DadMvEJuCLBH8Ycn+rt6i8VB3oKWkVUJuZ3jmadcfVvPt4UqzpLhvBSMAymR96n6EqyW5iUwYlu01rzKoj7pyH7RT4K2v6aauy+rwO8jpu0LJjVyP9l4NU1DEy7X8PXhLYtDJWUtnelDA3DjYzBoCc6HXos88wOBsnL0hXSJA//MID+lv96KZq7V2bXIaqCDbt8/cwLiAh9bSmlokedJdSVXsvU6D9bl8SE+cTHBGSFoNmQYM9xS+LFrP3t8IX4+c/ycUmuDUvQYOlqtA3nuMPUcTIRIu0REnp+JG+627bHkX7B+AHHdG+Hh1SDAtk52vHdCMr0JjgyQs8zgILDa YoEtbhTZ YI8IzB6BIP5q4IEkil11A9kx7sJj0qyH/1KXE1RrHmLRInk/Zqyf32Uqr7GrQnz2kOOtdAt0Tm8QmTpQ27vmoYbnV9nsNKUdCiL13mvmAwh2Yh/dIao2ajWHgH7BTL/E+5+gKc3S06PH1aLcl00HDQj1VSA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 09/10/2024 10:53, Thomas Gleixner wrote: > On Thu, Oct 03 2024 at 16:29, Vincenzo Frascino wrote: >> The VDSO implementation includes headers from outside of the >> vdso/ namespace. >> >> Introduce vdso/page.h to make sure that the generic library >> uses only the allowed namespace. >> >> Note: on a 32-bit architecture UL is an unsigned 32 bit long. Hence when >> it supports 64-bit phys_addr_t we might end up in situation in which >> the > > We end up with nothing. > >> top 32 bit are cleared. To prevent this issue this patch provides >> separate macros for PAGE_MASK. > > 'this patch' is redundant information. > > git grep 'This patch' Documentation/process/ > My bad, I thought that Documentation/process/submitting-patches.rst referred only to the proposed change which is in imperative mood. I will rephrase it accordingly. ... >> +#define PAGE_MASK (~(PAGE_SIZE-1)) > > #define PAGE_MASK (~(PAGE_SIZE - 1)) > > please. > Will change it in v4. > Thanks, > > tglx -- Regards, Vincenzo