From: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
To: Dev Jain <dev.jain@arm.com>
Cc: Aboorva Devarajan <aboorvad@linux.ibm.com>,
akpm@linux-foundation.org, Liam.Howlett@oracle.com,
shuah@kernel.org, pfalcato@suse.de, david@redhat.com,
ziy@nvidia.com, baolin.wang@linux.alibaba.com, npache@redhat.com,
ryan.roberts@arm.com, baohua@kernel.org, linux-mm@kvack.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
donettom@linux.ibm.com, ritesh.list@gmail.com
Subject: Re: [PATCH 1/6] mm/selftests: Fix virtual_address_range test issues.
Date: Wed, 18 Jun 2025 15:07:11 +0100 [thread overview]
Message-ID: <c93110a4-19e4-4a1d-b044-6b7f521eaa0d@lucifer.local> (raw)
In-Reply-To: <fc5c8193-2642-49f7-9f2a-00ad33353773@arm.com>
On Wed, Jun 18, 2025 at 07:28:16PM +0530, Dev Jain wrote:
>
> On 18/06/25 5:27 pm, Lorenzo Stoakes wrote:
> > On Wed, Jun 18, 2025 at 05:15:50PM +0530, Dev Jain wrote:
> > Are you accounting for sys.max_map_count? If not, then you'll be hitting that
> > first.
>
> run_vmtests.sh will run the test in overcommit mode so that won't be an issue.
Umm, what? You mean overcommit all mode, and that has no bearing on the max
mapping count check.
In do_mmap():
/* Too many mappings? */
if (mm->map_count > sysctl_max_map_count)
return -ENOMEM;
As well as numerous other checks in mm/vma.c.
I'm not sure why an overcommit toggle is even necessary when you could use
MAP_NORESERVE or simply map PROT_NONE to avoid the OVERCOMMIT_GUESS limits?
I'm pretty confused as to what this test is really achieving honestly. This
isn't a useful way of asserting mmap() behaviour as far as I can tell.
next prev parent reply other threads:[~2025-06-18 14:07 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-16 16:06 [PATCH 0/6] selftests/mm: Fix false positives and skip unsupported tests Aboorva Devarajan
2025-06-16 16:06 ` [PATCH 1/6] mm/selftests: Fix virtual_address_range test issues Aboorva Devarajan
2025-06-16 16:27 ` Dev Jain
2025-06-18 10:06 ` Donet Tom
2025-06-18 10:35 ` Dev Jain
2025-06-18 11:22 ` Lorenzo Stoakes
2025-06-18 11:28 ` Dev Jain
2025-06-18 11:37 ` Lorenzo Stoakes
2025-06-18 11:45 ` Dev Jain
2025-06-18 11:57 ` Lorenzo Stoakes
2025-06-18 11:59 ` Lorenzo Stoakes
2025-06-18 13:58 ` Dev Jain
2025-06-18 14:07 ` Lorenzo Stoakes [this message]
2025-06-18 14:17 ` Dev Jain
2025-06-18 14:35 ` Lorenzo Stoakes
2025-06-18 14:43 ` Dev Jain
2025-06-19 8:23 ` Donet Tom
2025-06-19 9:02 ` Dev Jain
2025-06-19 15:31 ` Donet Tom
2025-06-19 16:14 ` Dev Jain
2025-06-20 14:45 ` Dev Jain
2025-06-21 17:55 ` Donet Tom
2025-06-23 4:53 ` Dev Jain
2025-06-23 4:55 ` Dev Jain
2025-06-23 17:32 ` Donet Tom
2025-06-24 6:15 ` Dev Jain
2025-06-25 9:36 ` Donet Tom
2025-06-25 10:45 ` Dev Jain
2025-06-25 12:52 ` Dev Jain
2025-06-25 17:17 ` Donet Tom
2025-06-26 3:57 ` Dev Jain
2025-06-26 5:42 ` Donet Tom
2025-06-26 5:55 ` Dev Jain
2025-06-26 6:35 ` Dev Jain
2025-06-26 6:52 ` Donet Tom
2025-06-18 11:50 ` Lorenzo Stoakes
2025-06-16 16:06 ` [PATCH 2/6] selftest/mm: Fix ksm_funtional_test failures Aboorva Devarajan
2025-06-16 17:04 ` Liam R. Howlett
2025-06-17 15:10 ` donettom
2025-06-16 16:06 ` [PATCH 3/6] selftests/mm : fix test_prctl_fork_exec failure Aboorva Devarajan
2025-06-16 16:28 ` Dev Jain
2025-06-17 15:04 ` donettom
2025-06-16 16:06 ` [PATCH 4/6] mm/selftests: Fix split_huge_page_test failure on systems with 64KB page size Aboorva Devarajan
2025-06-16 16:06 ` [PATCH 5/6] selftests/mm: Fix child process exit codes in KSM tests Aboorva Devarajan
2025-06-16 16:06 ` [PATCH 6/6] selftests/mm: Mark thuge-gen as skipped if shmmax is too small or no 1G pages Aboorva Devarajan
2025-06-16 16:11 ` [PATCH 0/6] selftests/mm: Fix false positives and skip unsupported tests Lorenzo Stoakes
2025-06-17 7:53 ` Aboorva Devarajan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c93110a4-19e4-4a1d-b044-6b7f521eaa0d@lucifer.local \
--to=lorenzo.stoakes@oracle.com \
--cc=Liam.Howlett@oracle.com \
--cc=aboorvad@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@redhat.com \
--cc=dev.jain@arm.com \
--cc=donettom@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=npache@redhat.com \
--cc=pfalcato@suse.de \
--cc=ritesh.list@gmail.com \
--cc=ryan.roberts@arm.com \
--cc=shuah@kernel.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox