From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEC3AC05027 for ; Mon, 6 Feb 2023 14:58:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 437176B0074; Mon, 6 Feb 2023 09:58:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3E7226B0075; Mon, 6 Feb 2023 09:58:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 212B76B0078; Mon, 6 Feb 2023 09:58:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0EC366B0074 for ; Mon, 6 Feb 2023 09:58:30 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id B92DEC068D for ; Mon, 6 Feb 2023 14:58:29 +0000 (UTC) X-FDA: 80437173138.01.D7582EF Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by imf01.hostedemail.com (Postfix) with ESMTP id 01DF340008 for ; Mon, 6 Feb 2023 14:58:25 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=HiyPXYab; spf=pass (imf01.hostedemail.com: domain of fengwei.yin@intel.com designates 192.55.52.93 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com; dmarc=pass (policy=none) header.from=intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1675695506; a=rsa-sha256; cv=fail; b=OUlPiE72LuSF/X/d18XCOuQ0waQDophl9PheBM1bc5uAu/eTkV7RqokEN0FmoZUv7dX/oz MENhIpMk71RKOYGcpj3vIBVDJLuiwdNIOi8szjFu5E8b4va7jLFPHEOaYytpYrY/FwWhXs iIo2iOrtfU/GqLdO7ReKvxYErE0voJ8= ARC-Authentication-Results: i=2; imf01.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=HiyPXYab; spf=pass (imf01.hostedemail.com: domain of fengwei.yin@intel.com designates 192.55.52.93 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com; dmarc=pass (policy=none) header.from=intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675695506; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=U4dc3sicyKODXjaMykEnyRCAoATVTSLiTDvWWcvnBMg=; b=c42wNmUP099TzMh46rXmSi2CcD6UY92aPBftWI7/ZQrdFyAjADUya8Zr7KXdlTv17fO/mr U4bcpsWzPPNBPOCKqbTEGT6ovzj8CXW3IFse+PtldXeY/9tme3yx7IpsnEBOsC5udtn1N+ uus6LX75vT5kC7h/EEeyoc4LEearTzc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675695506; x=1707231506; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=MmvKooei+O5w8UbgYdabH+irv9X5mVUWkusn7/Mr8+s=; b=HiyPXYabH9gaRkV5gxPnLeqPSINlq3S1LJAlRE3kUS3HAU8dtzb5HuDp wbqceafxyV6uHGsRYf7aZfmgGdsHDLFPJOR1fHe3PbWWcTe163U23Edku Xg7LXjCSanFQ6OEjN23qAbX+cI+YdlbsImgP9Uc73SxSp3RzieITxFhDF 2Q2jRRu1Z0V339jrI/tS/kul0q7zE+PjeWSrp1eG6DQdI+F/pKPo7mBVs p9u+4DUUQcT/L+Qe3bsJflz9TSaM84yYxSmtDMyPmzdctbUu5hyD9OAf2 5UHonm6Y/zDyMUOVdwlX5HQquBfDAscrB2gCDIQDbVyAZBd0kkFjrm+Cr Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10612"; a="326909603" X-IronPort-AV: E=Sophos;i="5.97,276,1669104000"; d="scan'208";a="326909603" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Feb 2023 06:58:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10612"; a="995315398" X-IronPort-AV: E=Sophos;i="5.97,276,1669104000"; d="scan'208";a="995315398" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga005.fm.intel.com with ESMTP; 06 Feb 2023 06:58:23 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 6 Feb 2023 06:58:22 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 6 Feb 2023 06:58:22 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Mon, 6 Feb 2023 06:58:22 -0800 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.43) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Mon, 6 Feb 2023 06:58:21 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m+vpbpQYwEpJxK/TeEj7Wb+NBrHLOO9N3iknQln661jGqwnjSWn/Or1YOINPcaqAEx43lcziIfMoLWypked4anuvpcVguHpYgULY05YmgQWmO+shhpW2AUP7c3/U3B1d8GRQLE+sYRzkz5lUoI8mbpqRyB++J3BswrmiUOWs8EN1tKRXm1vniQZnlJjRRUOj8LwNmAoSfnq2kFy6JURvjZK6h5a7V+y3wiP71YdBQRwV7zwP0uEuh+w5JKJTFASDOO36BYcUUZLl+kJaRjf7qwD0hMMo0HLzHmIk+OZdpwcTh9phBljUClQJ9e3n9L4H/pDNeGPPcwVYBLNKUTq3Bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U4dc3sicyKODXjaMykEnyRCAoATVTSLiTDvWWcvnBMg=; b=dvboDIROZuTZyCkHV3bLkYrvk6amG81VOc0YTkcx8vk0kAktPJDgxnbJHKxKaM2UTDaE507lZyBKXuhtDIjAyHJmiqRFb4IAD0tk+pqI42u3V+5sjoI7eaDw3jwXYPrxHi4BdDlDpM1MQzQrX3loZGiOlvYKQ8QFD/n128Fg/AeyAEZMh8UQ6dY1IPQ9uTxGzA3gLOoCs/nrXC+Qkd2vXqpywrjNvtVyvHu6gOYLWE4bbYOMbuD3xYQtu9gonoHQec0ZUYMAT068bLZPuwafdNPicFQIpycc9SJDt8pujPtqfuDu8j0JXOg5kpSvvJvv3wDXWCH2sC4brePq2tM5JA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) by CH0PR11MB5252.namprd11.prod.outlook.com (2603:10b6:610:e3::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.35; Mon, 6 Feb 2023 14:58:19 +0000 Received: from CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::1531:707:dec4:68b4]) by CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::1531:707:dec4:68b4%3]) with mapi id 15.20.6064.032; Mon, 6 Feb 2023 14:58:19 +0000 Message-ID: Date: Mon, 6 Feb 2023 22:58:09 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.6.1 Subject: Re: [RFC PATCH v4 3/4] mm: add do_set_pte_range() To: Matthew Wilcox CC: , , , , References: <20230206140639.538867-1-fengwei.yin@intel.com> <20230206140639.538867-4-fengwei.yin@intel.com> Content-Language: en-US From: "Yin, Fengwei" In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SG2P153CA0049.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c6::18) To CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PR11MB4820:EE_|CH0PR11MB5252:EE_ X-MS-Office365-Filtering-Correlation-Id: 8109255c-eb08-4f2d-2ba8-08db08529556 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: C99TCG0ORT73JU+fuchb0cumsuyp/pZn3wwNNxsMBgLAE5dofrN4+gA51/qwc8UQA6vR5eyjgnUN9WESDXHz8KTmx2jLG13dTxjJKJYv/t/3/SLZF65wXYQRilIC8s5pvCYlBI+5wMLGEeLGZ5eX72uz0VKpbAHhSEWmyGMH26Dd4tRYyB4f3+lK2o+PPvo5RlSZykQ9ZQAMAWY/TPE6P07SeNNEeqPfel6wIDuEWqrGx8PiksPfTUVpWaIQnyP/ZLr5/+POhOdSaUWz7pdpD58mdR8kbSTwF+hnaDQ1yX8HmE2JpMGp33Abtv0L3QYx8uywhg+jnI6efMOwt1ib2n06Db7njM+lKy7A6v4AkW8CzPv9oocJaw+ukqe0la9085Si7DVErM5WQFja7Mt8taHzBVhljfzPNihjNHzaK9NaoWVpSizdFHrgij4/vh42mbLjFXDLrliLrdMmtMcwbmo3jiIZzxp8sspkkxHtkstyRpjkyYP9UEBPjXB3kggh1bZ28/2B/N/MXsRANoaa9G4udVVkfkqSFKpf5bEJd5xs9ibqltBxw+jXqThLZUcE/hL4PK7v2OdtzJeg2HVuaFa3xDoLrvnthSIEwH37T61p9PsXzn+9RC1FeT9cG4leEB11lb3iQjX4QqVXAzfIecl05Wr7uzV0vD85fZCeIdOVD+fidpN34iB8Qgb0gG0G3QmuufsOTxsK4/7r04EMBe2EvQR7Z14zWvkj/dWCTsA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4820.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(136003)(396003)(39860400002)(366004)(376002)(346002)(451199018)(36756003)(2906002)(38100700002)(83380400001)(2616005)(6916009)(8676002)(66476007)(66946007)(66556008)(4326008)(316002)(8936002)(5660300002)(41300700001)(6666004)(107886003)(86362001)(186003)(6512007)(6506007)(53546011)(478600001)(82960400001)(31696002)(6486002)(26005)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aW11cndlRVVxb2E1eTVNSjMvd29VL0lreUlEeHV3SmM1YXpUNlYzcVB4K3Z0?= =?utf-8?B?eGtTWnl6OWVWWk1renVlcHZ2Z2toY0oySjU1TUxFcHg4Z2gzTFpTMUR6ejFN?= =?utf-8?B?TVBWOTJkRU5zOUVQM01vMnlHNEtNWWk5SThLYkRValVybkNSbFZxcGlLUjIv?= =?utf-8?B?cUtMUTdqcTdiWjhmTjNQUVc1Ry91MVAzMVpKN2tXOVpNNnlCcllRSDZaVm51?= =?utf-8?B?c3NYc1RjdFR4cHRUbkNqcnpBUm9mRlVMenFERUR2bzYwWGsvR0x0K1k5eVFi?= =?utf-8?B?TGd4YXZCUzRhbHRGZWFuaTV3c2VnaDdqSTd6WXY5VzZESldxVzR3cjl4YWJU?= =?utf-8?B?WlBvM2dmVGRzZUlPUFZFTFZnOEtadWphR0hTNUVrbGF3R1JjZVI1dEZkWWdW?= =?utf-8?B?aWtmaTdxZkVrUE1nRzA3RDExZjVaaEVTRXFSY1JaY1RHcDMyRWpVSFZEMWM2?= =?utf-8?B?RXgyaEdFV25Ob1BhTjlqZExJdkkwTE9mbzN0ZUEraFJQVHNVdndDNDRKR1Vi?= =?utf-8?B?TWFuZDdYZXFtVW9uOWtkOFBvNVdmYzh1a0dySzZ2Nlk2b21JN0lKdWpiMmtD?= =?utf-8?B?VVhpQ3NJNjRIdGUwM1lTN25wOXZJMUtiOW4zaXhlcGdQbWIzUEU0V3J3clVh?= =?utf-8?B?STdRWXB4MmFYaEdRcEs5dnkyZnFhRUdOd21pZjdnUHRsRjRFZzRtd1d1K1VQ?= =?utf-8?B?MnNrZ0lVekc3WHBtOGdBZjNWclJwNFZFdzFRdEtoRUR4Y25UWGc4dXc5YjZj?= =?utf-8?B?N3F4MG1pd0IvN1QxVW9qTDc4KzU2M29vNVpXSWw2ejMvQXZYUnA3NFVLQTJm?= =?utf-8?B?RHZic3JZZ0FaTEFiak4xcThsYmU3Szc3Sy9tYnVXRUt6R092MDE4RTZTZS9V?= =?utf-8?B?bjFOc2o0Uytzd1I0VnJiSEplK2lybGFJOXFmL25aTjFxVXZzV0kzMDRhQkpF?= =?utf-8?B?VGZiVE4yZ3psTHFHVWgwZGI3aFFNbFBBQWpXb3ZicGhhOFhjQy8zejFmek5u?= =?utf-8?B?S21DVW9JUEZuWVpnWXVNY0NBZVQ2T0YvU2JIQkRlWldsS2ZCMHpBRnhnR0Mx?= =?utf-8?B?WmhQSkNJa1oyaU5zM2JidlFIT2tlR2hXeXVIZGZRaXFBc2RpS09hYm9QNDZG?= =?utf-8?B?RXVsRlFRcGUvaU1CZ05yN3IwT0NkUjZhUjBMdGMwNmdnMVJBaVUzRUczemhr?= =?utf-8?B?S1NjdUlURXp3ayswR01TRmdUY0IvcU1wWC8wVlpENUZhY05XSTZuS0RaeUJP?= =?utf-8?B?TENwNWhVUUsvZExOYjRkK0FjajZvYW43Nkgvb0Z2akxvdHptMEpTY2JNaExq?= =?utf-8?B?alJiaW92SjlFaWw4WFdlSmFJMSs1OFNnVDhITEhjSjcrVmFjRzVLVG05dmVL?= =?utf-8?B?WW04eWJZSGwzSzFpSGJaeWNKd2sxdXliM3RFRnVyREtiSCtrNGNLQnJ2NE9a?= =?utf-8?B?a0VJKzF6K2MrQUVnV3VVTVpIdktvem40bVozdVBVYnpROFNYNnVkeWdkWWxW?= =?utf-8?B?YVZBK29TNkQ2RG9EaHU1bEJlYWRDOVVOTkFFeVo0OUlTcEF3NkZ6S0lFYWNx?= =?utf-8?B?WmYvZjc0eHlWVXg3bXA4TnFWcUZqU1FTbmxIclVDWjVYcmxyNm5pb0JpSUR5?= =?utf-8?B?K3d1ekl2M25WZlpxRnlGR3hnYnh1Vk9sa3RLb1I0Y0l0MHc2STZlK3dWdmNL?= =?utf-8?B?Q1hVODdWV2ljMHZjaTFIU01JYjd0V3VwL2hVYXpiRzNYeVhlQ21hWU94ODV2?= =?utf-8?B?OFBDenpiMS9kbU9oREd0VUd1bVk1RWt5UUVJL3NQRHV1YXFoTkFyZERxVVc2?= =?utf-8?B?Wk90bkNLK1BzUjVsTVBDUWp2bFJYdlpsdnNSQkZCWmRuaEZ2VVBTdDFENjFJ?= =?utf-8?B?Ykd5T1c3b29TTHkyNXVzQ1hxVHZPVXloL0JSNU9iRzU4K0laOWNvL0FWVFVL?= =?utf-8?B?K2piR0RieC9nbmRBc21FNjkrREM2Ti80T2Y1VVhHUkJNeUtkTmh4Mk10ZStD?= =?utf-8?B?cjJrN2cxdU1sQkROQWNjYVd4dDFqNnpzZTM1RWVRUEwxMXY0MSszUjV2RmlE?= =?utf-8?B?ekJzQ0VSUEovNHhpWmpPcDRhaGFXZitDaGFuNDJLY1Z0dEtmZWFmb0hySnhn?= =?utf-8?Q?5xJLc/G+EouAylPF2tFl5YejQ?= X-MS-Exchange-CrossTenant-Network-Message-Id: 8109255c-eb08-4f2d-2ba8-08db08529556 X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2023 14:58:19.3692 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: u0mluRePcz6i2zEZLmVLL+bFWYO+CorBz93eMvGEI1pJClsPUir6/Wr8LgvmTZH5QTsdaasqrhs+dihsyFeCww== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5252 X-OriginatorOrg: intel.com X-Rspam-User: X-Rspamd-Queue-Id: 01DF340008 X-Rspamd-Server: rspam01 X-Stat-Signature: tdqoh1x4mod6g3jwimap9qwkkfa3bs8b X-HE-Tag: 1675695505-224130 X-HE-Meta: U2FsdGVkX1+zJ1rTeQSAd/DeCxQLoEZN50zciY7JUBilFiRC6ASHStEJp1d+o/bIX0TgTpzY5W3+Cod2O4KKEj1pD8IlCqS/qvPRZYQuG0GP2c8aG8aTYR4tkoSXKJZkpyk540DYB7PjI9imumNl0LFvqAiHxsiXsdMFygktQ8VDd++Lfa4rGVT++lNIc4bcFG6yAGmbJu532R9Ub9F7U3HRtEaAzHtR51EgVxlIzzFPQusV5fzlA7+InIoK+nKJw8B/IV8eTJ7Kvddb/WRR0yJdbIxEVaY3PsNeDy1LzZTfD+vc/sdq075UpDEWSUSKAp4B7UhxXwIKcFoaaeeXpiUgcCKBEF316yUfDGiu936d7hLlxo7NwmC1E882ScnkvzFJWoLMe6TKpYolTYMBhfzYNY7W9l+PgQ+1yDzqCR5914BNsRzFjLFdvNsj9sS6z0+t2xD/wSbOnUWZAz9r0/CxYW6glMgpIwNXHmotRCs96OhNMaUfyC7YSI2w9O2/XWkxN2vDAkrC/J1F9FnZkEK29b3oSl9RaPNTERUBcvR6MLiGMeQ8bTZhhf9yj2OIvlTf3iPjjgQt14vwRXuWFte42YIYRe6iKqF2KeUkoyh/RfSzwCSB7WyvSFdZsbbDRi2cmQWC1eTg7taGjXFDwQcNcuTX0DGa+ZqFu3KKNgG2JFbzu6CsrZLmwqUtKc6IthOlaVFE94u4klvp2j869HcCB6oAv0U9WuE0Ld55cCcash4SKDbCSf71bZjP9BQCMiQvLa2UHQDqJohFiKXhWM//h+L+PhPOH/lVMmoz2RSxW/W8P44AQqjEciMyfhH8pBKKf/0CliokT7IPnnsZZnHEcb55djB+TnPUvSPSarpq0geU68osXe+NK6SWveTP/8YdXoltHxDQ+ZWr4NzjCv2V/Y6noyLMUa7jKwl6hLkxNCQJpz5YFvIM8JPMHjDFxxQLX8upF+xeopfJA8c ypt4GY/l FHtsJC0vCcrXtN76bDu3sWYi6zwDgHZzyCsPJPslSN1eIVqvF2SHNzfZ8R6n0a3N4f2LA+WlFIVabIFdcty9lxPnX1t4BOP6HKjrgEbuKUB4x6/IekWUHwHb9Ht5Xt/oscvy0V4Wxe3NAERKBmcH2+HHA3AjsNgN4fSsxSv49iSH0hyQ8rhP0CwlHiDomlPBjHkjqnpeB4WQRfpPHYXq6y0XxmMGzwyvH61Apn9ntlEHwwkFFr8hfDZ7s36ui5GMswmKGbnJVmEACp7jM2rcqAFMdCrpbt/b70UUJpf18NFfn35bbBwWjXPwxCF28ZxQPsPyjjI09SYwapWI1ezJ6L2TJ2g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/6/2023 10:44 PM, Matthew Wilcox wrote: > On Mon, Feb 06, 2023 at 10:06:38PM +0800, Yin Fengwei wrote: >> diff --git a/include/linux/mm.h b/include/linux/mm.h >> index d6f8f41514cc..93192f04b276 100644 >> --- a/include/linux/mm.h >> +++ b/include/linux/mm.h >> @@ -1162,6 +1162,9 @@ static inline pte_t maybe_mkwrite(pte_t pte, struct vm_area_struct *vma) >> >> vm_fault_t do_set_pmd(struct vm_fault *vmf, struct page *page); >> void do_set_pte(struct vm_fault *vmf, struct page *page, unsigned long addr); >> +void do_set_pte_range(struct vm_fault *vmf, struct folio *folio, >> + unsigned long addr, pte_t *pte, >> + unsigned long start, unsigned int nr); > > There are only two callers of do_set_pte(), and they're both in mm. > I don't think we should retain do_set_pte() as a wrapper, but rather > change both callers to call 'set_pte_range()'. The 'do' doesn't add > any value, so let's drop that word. OK. > >> + if (!cow) { >> + folio_add_file_rmap_range(folio, start, nr, vma, false); >> + add_mm_counter(vma->vm_mm, mm_counter_file(page), nr); >> + } else { >> + /* >> + * rmap code is not ready to handle COW with anonymous >> + * large folio yet. Capture and warn if large folio >> + * is given. >> + */ >> + VM_WARN_ON_FOLIO(folio_test_large(folio), folio); >> + } > > The handling of cow pages is still very clunky. > folio_add_new_anon_rmap() handles anonymous large folios just fine. I > think David was looking at current code, not the code in mm-next. OK. Let's wait for further comment from David. > >> + set_pte_at(vma->vm_mm, addr, pte, entry); >> + >> + /* no need to invalidate: a not-present page won't be cached */ >> + update_mmu_cache(vma, addr, pte); >> + } while (pte++, page++, addr += PAGE_SIZE, --nr > 0); > > There's no need to speed-run this. Let's do it properly and get the Sorry. I don't get your point here. Do you mean the pte_next()? Or other things? Regards Yin, Fengwei > arch interface right. This code isn't going to hit linux-next for four > more weeks, which is plenty of time.