From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62A34C433F5 for ; Tue, 2 Nov 2021 14:44:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 13A17610E5 for ; Tue, 2 Nov 2021 14:44:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 13A17610E5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 9093C94000A; Tue, 2 Nov 2021 10:44:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8B8B4940009; Tue, 2 Nov 2021 10:44:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7581C94000A; Tue, 2 Nov 2021 10:44:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0102.hostedemail.com [216.40.44.102]) by kanga.kvack.org (Postfix) with ESMTP id 65999940009 for ; Tue, 2 Nov 2021 10:44:58 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 2942E5679B for ; Tue, 2 Nov 2021 14:44:58 +0000 (UTC) X-FDA: 78764262276.05.27162C8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 889F8508CC87 for ; Tue, 2 Nov 2021 14:44:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635864297; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jic1F9UNvooEC2d+xw/+5aCM+bj4ORtETpFt0PPjtmo=; b=RnizAJwXEVsalE6hxrRxp+dYFta1nMDhRkxnkle9rdW8/4/V3dE4XtoZFpUqQgm3imcwlj uSXS5W6DA9jRikBFqpdqbHAz3Xr4YgOmGUBFQAkOVsdEKlSjwGAkRqPE/+kZN+AB5bYh6v UEGNTlu3aw9cCXFkznYbEq4zcCDDy48= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-593-uCEd537FNPmWF9IF9yp0iA-1; Tue, 02 Nov 2021 10:44:55 -0400 X-MC-Unique: uCEd537FNPmWF9IF9yp0iA-1 Received: by mail-wr1-f71.google.com with SMTP id y9-20020a5d6209000000b001684625427eso7534149wru.7 for ; Tue, 02 Nov 2021 07:44:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=jic1F9UNvooEC2d+xw/+5aCM+bj4ORtETpFt0PPjtmo=; b=ITLo7ls08p/3uSM3b25K3/YfNH+5EjEZIrC28K270m0kKLw51vqTPZzN15WOdwajGj O6cQ9uvWULOeIkUPVMSIryBxdAPEynjGY8kE5ljQpOo+xbcQ4DrgdcEoLtCBv5dkYSDC EFMqNUaBzDKmNBx54c69yGIOWC9Hh6nt1YFS8Zmq0Z2iIhvHJwVTnNa+3rYaNv4/soqO N/Uq9pP5GvMiAhRZYqHh+orr89edh3DZh0ReAHbfIBsSM26qsxVALc6uoapK6os7Rax9 Oi+HUKSYomBrTlkqOlyrH4DbI8GKy7+1W44x9xrTRW23lXN6gXYsWNCZ3qp0EB9Qs3aY 0u6w== X-Gm-Message-State: AOAM531RUriI6vdnM7hDJ7XL0inTyaltc9xwPKoWuQ0MMu8AOZevbaX8 m1EyMNg7+eC+mjVasI/Cloxo6vLbhLHeLMKczU90iKRssheBpDSMuWef20hIcRhfY8965FKfsTb 52yiqzMK9Xeo= X-Received: by 2002:a05:600c:221a:: with SMTP id z26mr7823255wml.20.1635864294664; Tue, 02 Nov 2021 07:44:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwBBOUAAgvnqsjRVZ4bzRv1lCqYgkkyX3fHbS5Y5cY5MU4aoQfmzPcf1WlQqb1AxIh7YDXh9w== X-Received: by 2002:a05:600c:221a:: with SMTP id z26mr7823225wml.20.1635864294488; Tue, 02 Nov 2021 07:44:54 -0700 (PDT) Received: from [192.168.3.132] (p5b0c6810.dip0.t-ipconnect.de. [91.12.104.16]) by smtp.gmail.com with ESMTPSA id c11sm3176123wmq.27.2021.11.02.07.44.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Nov 2021 07:44:53 -0700 (PDT) Message-ID: Date: Tue, 2 Nov 2021 15:44:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH] mm: fix panic in __alloc_pages To: Michal Hocko Cc: Alexey Makhalov , "linux-mm@kvack.org" , Andrew Morton , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , Oscar Salvador References: <42abfba6-b27e-ca8b-8cdf-883a9398b506@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 889F8508CC87 X-Stat-Signature: a1emobrd11gxrygurhikoc4sd7bcmjop Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RnizAJwX; spf=none (imf05.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam02 X-HE-Tag: 1635864282-217279 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 02.11.21 15:12, Michal Hocko wrote: > On Tue 02-11-21 14:41:25, David Hildenbrand wrote: >> On 02.11.21 14:25, Michal Hocko wrote: > [...] >>> Btw. do you plan to send a patch for pcp allocator to use cpu_to_mem? >> >> You mean s/cpu_to_node/cpu_to_mem/ or also handling offline nids? > > just cpu_to_mem > >> cpu_to_mem() corresponds to cpu_to_node() unless on ia64+ppc IIUC, so it >> won't help for this very report. > > Weird, x86 allows memory less nodes as well. But you are right > there is nothing selecting HAVE_MEMORYLESS_NODES neither do I see any > arch specific implementation. I have to say that I have forgot all those > nasty details... Sigh > I assume HAVE_MEMORYLESS_NODES is just an optimization to set a preferred memory node for memoryless nodes. It doesn't imply that we cannot have memoryless nodes otherwise. I suspect just as so often, the config option name doesn't express what it really does. -- Thanks, David / dhildenb