From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C752C36008 for ; Wed, 26 Mar 2025 12:55:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C329128007F; Wed, 26 Mar 2025 08:55:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BBA92280069; Wed, 26 Mar 2025 08:55:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A5CEE28007F; Wed, 26 Mar 2025 08:55:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 834E3280069 for ; Wed, 26 Mar 2025 08:55:29 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 7276A58252 for ; Wed, 26 Mar 2025 12:55:30 +0000 (UTC) X-FDA: 83263698420.11.2BEEE1B Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf24.hostedemail.com (Postfix) with ESMTP id 4C6A4180006 for ; Wed, 26 Mar 2025 12:55:28 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=THU3o0rI; spf=pass (imf24.hostedemail.com: domain of hawk@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=hawk@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742993728; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=R+xJx58p5eU8R+vLXUnJ2BHHSCrpiOBUf7/09X+eup0=; b=JodgJIMXb9hjX8HTlVrRJd2JW01R9PvZ8mofHrofdSJxvrbtYa0L9+3Qc1tvPaLptXVKAa Rf8HPqtPx+CBLadqgwzzTyIVy6khLGrwwVy73EWdF9cu2UlQIjI40Yfnlg/mnr3B1ysEfk YqLXjmcrgu6fhdCupeGu4T+P7oAzhSk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742993728; a=rsa-sha256; cv=none; b=MzoRULAjox30zUubMM1YikV/ZI1RGjM8ed+DYZYiv0Cyer0QNJZhanc8PyQcNx3O+bJdud S8z0lRY/gvDUOBlBjiNAPVs+Vb96br8NpmZ7qU3FolhT7kXpADCtG7Pq33kW+gN4QPdULz bfoQkByukwe9KVOZtrhS+kWBuC2FXcw= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=THU3o0rI; spf=pass (imf24.hostedemail.com: domain of hawk@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=hawk@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 92A3843F32; Wed, 26 Mar 2025 12:55:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 738A1C4CEE2; Wed, 26 Mar 2025 12:55:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1742993726; bh=A0tYgISPZr3nBdVXsqT8eCy/AZW3HgsAo/r/eYIdF7k=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=THU3o0rIbjwHT9PJTSFjAw+msHz6bBCCCWbSbkZbzCpyNHz3DNnBQD3RJaYmZy4At diYGAQbunY5Z6PzvcefCNBo/l6d+Ji0PT5bdZLTGQLPCfjLHCOQoLCsnXJjwuuVho6 gJEfgcLRetMnMGFe7ylOaz7C//gvUljt2JlrwxJg0W+VXESsrm8bGvVEV3O93lNZws XMDmwzOrXpuwM/uc0QRQ6RshQzXOIcxhWzXpRE0ynrjWXkysxrPtZQWeGFtR77RDfO SQjWlEUg4s+/XITtoFn8JgwxAPNsNdTFxgpQMvqkULaySHr5d/TLSyTKe75/lY4ry8 WDvFHwE177O0w== Message-ID: Date: Wed, 26 Mar 2025 13:55:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v3 1/3] page_pool: Move pp_magic check into helper functions To: =?UTF-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= , "David S. Miller" , Jakub Kicinski , Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Andrew Lunn , Eric Dumazet , Paolo Abeni , Ilias Apalodimas , Simon Horman , Andrew Morton , Mina Almasry , Yonglong Liu , Yunsheng Lin , Pavel Begunkov , Matthew Wilcox Cc: netdev@vger.kernel.org, bpf@vger.kernel.org, linux-rdma@vger.kernel.org, linux-mm@kvack.org References: <20250326-page-pool-track-dma-v3-0-8e464016e0ac@redhat.com> <20250326-page-pool-track-dma-v3-1-8e464016e0ac@redhat.com> Content-Language: en-US From: Jesper Dangaard Brouer In-Reply-To: <20250326-page-pool-track-dma-v3-1-8e464016e0ac@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 4C6A4180006 X-Stat-Signature: wimqf1dm33tiaxseoz16jckeoq7ymonf X-HE-Tag: 1742993728-611998 X-HE-Meta: U2FsdGVkX1/6iuGV77nE9UQ8fOAnYAj0ytvca7pa/1okyUSHCmxkcO86X/uMZ/svAKjbGh6NDRr0pKxEtuikCY6uS7pNrxULjIcYgscNZGz5EUvy/laZ6IglU2n8OtjDckuF9MWBCGg5FbmC4C1SnR28isaScl72gRFOrYy+r5xkebtI2gk0UYY4EtfNlcZFAjC5yeL0CTZYd/imi5X4X5Eb44Ethc98NB+wMtWAlCvhfY4hpmGYzcjPRtA7MpTvvpsvnf0NXW5NzvR26SmUW2TsZ+O6mI1aOw7xGmUvaNOHB746XGLzkO78840DqZZiFGBrUNEJ6U4jz7FYx/hzuwqq+w3J5P5e46TS6X+XQzqoq8gD85BqsaT1KUcKNr1f98TrD7WH14EatwLUyDfYIhrhF33XDTFb3ZVC72Ji8Yp8/WzsmByC3KNlAWXyhPuoHHwsieNuIAxnf1Vuqs0k+cNnvzKvv573cjogXtQ2ciLP9Se7/VQs0iLaJl4ybQziVA2L18XMf/PznSPdhHkrApTL2xSkeVw1AIRDoWtCyqXmoHhmVLQ0GNAKFLyL5pxYwelRNQJUO1vbBxEktIHHZt0/1pqIPHinGRdNLGW2i2AL0R0ColSzFIz6VEydQmlWExDM878MfwBIPc03fBkYyJSDgChbQ93Vj8iNS/MtaTRIRtULzEXG1w9NW8wJBrQCs1SfkjSffNfzD6h6K5wZZh6NeWcOuCcK3khFYLDvy2F7jgMYc4oTwo6HuKzGlwrid0DZ+T3FFkpJiaKvgD0bt/NTt4d0oQIEunzgSa4QsIcxRYBIjpEjjzlLo0BDanN6b7thHsFIyHG/Ai4r4bcGAx67ZONXuziFLSxuVMnNBNKwzS5u4AdfmLx48vMe5JlYzAqGyhjy3EFZ4mrVcp7JIgUqAqqjJ3OrObU6DqC2xUlrkNgB4w2RlGxHj+HaAhqY9e97S315DEHJXpD+zCg RIjfLLVh GZkm0IfXvbTWur5e3FhZw0JRHTZyye+x1eVybTQux9BM+99IGdw1gc0EP4fr++fEi8Wq38+ZrQjSecZ9OsKLVvTo0p9A3wRnjFcSpaqfuOSYhULTTm1Da8xKE3doxLyW/a659g3YYiljaujNiaCWUtLw50Of5wwDLLzZjBWOJ8xSaI2HDE9o1Eyx647EshIxjQAJ4rQl0FuPnsTDNcuavP5iKkrNztHbWfABf3Qkx3mylT2GTe419QnF/JlkY869qfBL4a71i4D7nRDys5c0LgWRWh3/xVCopNKDG8vseRYPw7EheNari+Qw4jLOGTDY/050fMJGDVTvfNk5AfdZxjvK72+quI5tDQ9Dkebx1c6z3O02zZQIiWi3Pt5sWzIkPxtyhrT8lx4J7Z2nfM3K8NKkf1bZbtHlpoSTZMBp7svOuD8/JGNdu918mA0pI4lOcxGvk0UVmi2uYz5jW9VOiuoZUVPwNqFSaNL9TOoV8Hpe8bQgklyDTTtQxLFxEKlf5tNjl X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 26/03/2025 09.18, Toke Høiland-Jørgensen wrote: > Since we are about to stash some more information into the pp_magic > field, let's move the magic signature checks into a pair of helper > functions so it can be changed in one place. > > Reviewed-by: Mina Almasry > Tested-by: Yonglong Liu > Signed-off-by: Toke Høiland-Jørgensen > --- > drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c | 4 ++-- > include/net/page_pool/types.h | 18 ++++++++++++++++++ > mm/page_alloc.c | 9 +++------ > net/core/netmem_priv.h | 5 +++++ > net/core/skbuff.c | 16 ++-------------- > net/core/xdp.c | 4 ++-- > 6 files changed, 32 insertions(+), 24 deletions(-) LGTM Acked-by: Jesper Dangaard Brouer