From: Jesper Dangaard Brouer <hawk@kernel.org>
To: "Toke Høiland-Jørgensen" <toke@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
"Saeed Mahameed" <saeedm@nvidia.com>,
"Leon Romanovsky" <leon@kernel.org>,
"Tariq Toukan" <tariqt@nvidia.com>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Ilias Apalodimas" <ilias.apalodimas@linaro.org>,
"Simon Horman" <horms@kernel.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Mina Almasry" <almasrymina@google.com>,
"Yonglong Liu" <liuyonglong@huawei.com>,
"Yunsheng Lin" <linyunsheng@huawei.com>,
"Pavel Begunkov" <asml.silence@gmail.com>,
"Matthew Wilcox" <willy@infradead.org>
Cc: netdev@vger.kernel.org, bpf@vger.kernel.org,
linux-rdma@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH net-next v3 1/3] page_pool: Move pp_magic check into helper functions
Date: Wed, 26 Mar 2025 13:55:20 +0100 [thread overview]
Message-ID: <c91a9571-7893-4f9c-923b-f9d85fa4796f@kernel.org> (raw)
In-Reply-To: <20250326-page-pool-track-dma-v3-1-8e464016e0ac@redhat.com>
On 26/03/2025 09.18, Toke Høiland-Jørgensen wrote:
> Since we are about to stash some more information into the pp_magic
> field, let's move the magic signature checks into a pair of helper
> functions so it can be changed in one place.
>
> Reviewed-by: Mina Almasry<almasrymina@google.com>
> Tested-by: Yonglong Liu<liuyonglong@huawei.com>
> Signed-off-by: Toke Høiland-Jørgensen<toke@redhat.com>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c | 4 ++--
> include/net/page_pool/types.h | 18 ++++++++++++++++++
> mm/page_alloc.c | 9 +++------
> net/core/netmem_priv.h | 5 +++++
> net/core/skbuff.c | 16 ++--------------
> net/core/xdp.c | 4 ++--
> 6 files changed, 32 insertions(+), 24 deletions(-)
LGTM
Acked-by: Jesper Dangaard Brouer <hawk@kernel.org>
next prev parent reply other threads:[~2025-03-26 12:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-26 8:18 [PATCH net-next v3 0/3] Fix late DMA unmap crash for page pool Toke Høiland-Jørgensen
2025-03-26 8:18 ` [PATCH net-next v3 1/3] page_pool: Move pp_magic check into helper functions Toke Høiland-Jørgensen
2025-03-26 12:55 ` Jesper Dangaard Brouer [this message]
2025-03-26 15:29 ` Ilias Apalodimas
2025-03-26 8:18 ` [PATCH net-next v3 2/3] page_pool: Turn dma_sync into a full-width bool field Toke Høiland-Jørgensen
2025-03-26 12:56 ` Jesper Dangaard Brouer
2025-03-26 17:40 ` Alexander Lobakin
2025-03-26 8:18 ` [PATCH net-next v3 3/3] page_pool: Track DMA-mapped pages and unmap them when destroying the pool Toke Høiland-Jørgensen
2025-03-26 11:48 ` [PATCH net-next v3 0/3] Fix late DMA unmap crash for page pool Jakub Kicinski
2025-03-26 12:20 ` Toke Høiland-Jørgensen
2025-03-26 14:49 ` Jakub Kicinski
2025-03-27 10:41 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c91a9571-7893-4f9c-923b-f9d85fa4796f@kernel.org \
--to=hawk@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=almasrymina@google.com \
--cc=andrew+netdev@lunn.ch \
--cc=asml.silence@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linyunsheng@huawei.com \
--cc=liuyonglong@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
--cc=toke@redhat.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox