From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0557C83F01 for ; Wed, 30 Aug 2023 06:45:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 33ACA8E0045; Wed, 30 Aug 2023 02:45:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2EA788E0009; Wed, 30 Aug 2023 02:45:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 200F68E0045; Wed, 30 Aug 2023 02:45:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 143DD8E0009 for ; Wed, 30 Aug 2023 02:45:15 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id BFDC5401E0 for ; Wed, 30 Aug 2023 06:45:14 +0000 (UTC) X-FDA: 81179834148.19.E16FBC8 Received: from dggsgout12.his.huawei.com (dggsgout12.his.huawei.com [45.249.212.56]) by imf14.hostedemail.com (Postfix) with ESMTP id 67405100039 for ; Wed, 30 Aug 2023 06:45:10 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=none; spf=none (imf14.hostedemail.com: domain of shikemeng@huaweicloud.com has no SPF policy when checking 45.249.212.56) smtp.mailfrom=shikemeng@huaweicloud.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693377912; a=rsa-sha256; cv=none; b=ZLvjQ3BCVs1IALXs2kylhCQYXNtr4k/AS8+j40qdyDOdtZn2oKRhJHX/vW56Rss7/bLW7X qSefGhzDAF8olDejSNJmiZR/r8I2lWLK8aPe0aSeDks6In+aqE4CIszkyUYnf24GiQLgZk 6NONYYW5gMCalSk/PiGqm9Ot98XMDlg= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; spf=none (imf14.hostedemail.com: domain of shikemeng@huaweicloud.com has no SPF policy when checking 45.249.212.56) smtp.mailfrom=shikemeng@huaweicloud.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693377912; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AdggZyE7SPYyJbZMU9HBlOksaq7dSLlBdIOIi8zg/l8=; b=2fJBETDMm1I4ZDYEbA3Lw9eyVAVVL9WEpqATywQbM97OXNHbxy+SF6asqAoRDBqMojbxH6 2qHzCTHbmF42emParRewieMaWVQzswVw+1NWdVQACKBRyJSx1nU0pvhrpHhU0dEXE/kOqS rfeWoWjuKHdufYoK2ELmF2zopBzpR90= Received: from mail02.huawei.com (unknown [172.30.67.143]) by dggsgout12.his.huawei.com (SkyGuard) with ESMTP id 4RbFCd2kb9z4f3nwN for ; Wed, 30 Aug 2023 14:45:01 +0800 (CST) Received: from [10.174.178.129] (unknown [10.174.178.129]) by APP4 (Coremail) with SMTP id gCh0CgA3DqFv5e5kVmazBw--.1578S2; Wed, 30 Aug 2023 14:45:04 +0800 (CST) Subject: Re: [PATCH v2 7/7] mm/compaction: factor out code to test if we should run compaction for target order To: Matthew Wilcox Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, baolin.wang@linux.alibaba.com, mgorman@techsingularity.net, david@redhat.com References: <20230826153617.4019189-1-shikemeng@huaweicloud.com> <20230826153617.4019189-8-shikemeng@huaweicloud.com> From: Kemeng Shi Message-ID: Date: Wed, 30 Aug 2023 14:45:03 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=gbk Content-Transfer-Encoding: 7bit X-CM-TRANSID:gCh0CgA3DqFv5e5kVmazBw--.1578S2 X-Coremail-Antispam: 1UD129KBjvdXoW7Xr13AFy5Zr4fCFy5WF4fuFg_yoWDGwc_ZF 45XFsFvFWYyF4fGr42kr40yrZ5CFs8CFyDtrnxKw129a92ya9Iqw1vy347CF1aqr1UCr45 urWfZa97Jw129jkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUb7xYFVCjjxCrM7AC8VAFwI0_Gr0_Xr1l1xkIjI8I6I8E6xAIw20E Y4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l8cAvFVAK0II2c7xJM28CjxkF64kEwV A0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVWDJVCq3wA2z4x0Y4vE2Ix0cI8IcVCY1x02 67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I8E87Iv6xkF7I 0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40E x7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x 0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lc7I2V7IY0VAS07AlzVAYIcxG8wCF04k20xvY0x0E wIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E74 80Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw1lIxkGc2Ij64vIr41lIxAIcVC0 I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr1lIxAIcVCF04 k26cxKx2IYs7xG6rWUJVWrZr1UMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIE c7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x07UWE__UUUUU= X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-CFilter-Loop: Reflected X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 67405100039 X-Stat-Signature: s564egh7yqb7gbkuhznt3bdqaiuyhefo X-HE-Tag: 1693377910-863153 X-HE-Meta: U2FsdGVkX1+sf4pQQXLGttb75v+S3pkOlLoYrouFHL3qZwg/KPTJnlvHjYY8lXQTyNTBm7MmI0AhRmVBudDkLf10SR48pCV9sSzyvzQOQAaP/6hGvF8zloPxlk+Qjdhpf+qBlC5AIYA9yVuPQFWPT87xUFfEUWEW6ZKL43bq6wV5JwMOnpV3fCjv5SqKl2wQLimf5TKv7LmBi9cl9zEaPDwYqz4NrHvG/ibeSdT7bIxWGyES4H/uaATN/fRwV1HO9RrxIN01J8G4ThWi3D64giduSAKFBRJ+PEmmXa0t42U4YfvKGj0+VbCdfyVKOE7xH33rY1sgTafnvHElFT5L5VMyESz7sHXAGKKOZAkz8NXMpZ6223NRTPCuBjndG/yMSZrjdyjD5ymuEw5+K6CR5ukxqEYmgqRDI2Ap7fN7ApiZtcLQrb5OGfQZSHsJ/CG9HM05wFv23V5PoV0F/BABHs5fqQEA/jeDjTfMjwXqtzDG4s36DpBdtF35eHexTO2BcL+LNUzYWyhbnnu553IWW2F9b+OkSi/FyqD6ALyVBXUAhbdJb8n6diRTkn2au+oHYZRI7I122a8f43w769ZKC5u94uHFpKZ4U2FdGdKK5CrzXQjuTcwq/j7WJnpvKDxKyujfaoIUs9QX4Dl2NchDKI9bFFz2abwwvN4kPn/C4cnTMk+gKgmqX83fMgDCSnihUiC73044UMDOwVP9I1GJ2v6OFbeEZHwdCfQEOaW7TvU/hpRNkBjMWflpl8HpiO3JHb0tsR6VoYE/mCk21kJlreEiXaLpgW8UovzW4/bcOqDeEyya+AClQt4qF5+sRgOeHhVR4skg2NCJMTrXjnfYQBs3aD/cMkrNAaYTmXMBtkSAlJWMZRoyjWn1aEL6sbSw+oLtqOfQCKq14OgQK+utteB3YdI5zraD4w1RqM5OYNCRgYcwdF0IZPB6XlvPOY569My5L1rukd0nhTtdWvm 11z8YBV+ 3O+pKLcevR7LGmi4v+jH9tu1FiD5Q6xnR/ZYvPtsZFJBqocszgPbt97Y5xcaSOs9rw7oQubqOLnWSElCENvObbJOpyEn6crdf/a5+Em+lVZ9+/asQ58M3+Np0JDld8naGCvpjZq39S68IOhwlR2LMim8m//hfHAwJGeGPTE1vfmWBWj6BKYHvM3miz/yYRSR4ameNuI4GmZbPURk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: on 8/29/2023 11:54 AM, Matthew Wilcox wrote: > On Sat, Aug 26, 2023 at 11:36:17PM +0800, Kemeng Shi wrote: >> + if (compaction_suit_allocation_order(zone, >> + pgdat->kcompactd_max_order, >> + highest_zoneidx, ALLOC_WMARK_MIN) == >> + COMPACT_CONTINUE) > > The indentation is confusing here. It looks like COMPACT_CONTINUE is > an argument of compaction_suit_allocation_order(). How about: > > ret = compaction_suit_allocation_order(zone, > pgdat->kcompactd_max_order, > highest_zoneidx, ALLOC_WMARK_MIN); > if (ret == COMPACT_CONTINUE) > Thanks for information, I will fix it this way in next version. > (assuming there's a handy variable called ret) > > You could also distinguih it by indenting COMPACT_CONTINUE by an > extra tab, but I think it's worth an extra variable just because this is > such a long line> >> + if (compaction_suit_allocation_order(zone, >> + cc.order, zoneid, ALLOC_WMARK_MIN) != >> + COMPACT_CONTINUE) >> continue; > > Same here. >