From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DCA8D21264 for ; Thu, 17 Oct 2024 09:15:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0F12D6B007B; Thu, 17 Oct 2024 05:15:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0A1CC6B0082; Thu, 17 Oct 2024 05:15:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E83F26B0083; Thu, 17 Oct 2024 05:15:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id CA2016B007B for ; Thu, 17 Oct 2024 05:15:13 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id CF6094119D for ; Thu, 17 Oct 2024 09:15:06 +0000 (UTC) X-FDA: 82682535222.14.A3F540B Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf16.hostedemail.com (Postfix) with ESMTP id 4F913180018 for ; Thu, 17 Oct 2024 09:15:01 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="F5xSP/XO"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=otB+1goV; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="F5xSP/XO"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=otB+1goV; spf=pass (imf16.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729156365; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1dRohF8dntyW3awLl8Th7hn4ml3FhG5k4WFCLyVx5Rc=; b=1fQthr3JHGFJ8ZOXjQgc809dLtNM1TfIOoUmJZRnqjnSkGFFDpLMZGmLcHG6Hybb/mB6hy Znn2Zn2hlpUg2eLJrXxeDiV5xpQROzrc9pdK3sm9/GjVMrCR+jmIrMi9cxFC24UDz2aqjO PXmWFoxyfO4CgyvV/cyWPUYjopwRvzI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729156365; a=rsa-sha256; cv=none; b=wqwVKYCBOI+h0VrM1AXAijgbEA7zoe/XftXTN3gfXYQIxUjVbWhiXL9kFQZwWBbm8XcuCD C/CA+zcFFe7EUkbi10ostJpSwqlG1SFlwskVYYJT/OefdBHEcMxw3sznf9hj1/vBl0X78C KeIETz9eAb5y51q6sMKqnkKvfFmMjb8= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="F5xSP/XO"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=otB+1goV; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="F5xSP/XO"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=otB+1goV; spf=pass (imf16.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 045B821F26; Thu, 17 Oct 2024 09:15:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1729156509; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=1dRohF8dntyW3awLl8Th7hn4ml3FhG5k4WFCLyVx5Rc=; b=F5xSP/XOtnIBT5V+l9dIMPV8eitAN5nBbgLhXxbUJUlUrzFuXUG48ShOD14177/8j696uv DrZBM0T8g8k1hJN+qHEYHe1KCi1xpixeTy0+1LKRdqi/iJTBMhpcpUI07Etp+8O3ni8GbP +NvRpO+2r6OwbVg1YK8D+adP5bqlKEo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1729156509; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=1dRohF8dntyW3awLl8Th7hn4ml3FhG5k4WFCLyVx5Rc=; b=otB+1goVD/MGC5p3IrGUAFLn2P6MExgKegAeLOeVLYQtp7HIQZzi9URWJJfiLOfAgnscEA yt+S1p57dGVolkBg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1729156509; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=1dRohF8dntyW3awLl8Th7hn4ml3FhG5k4WFCLyVx5Rc=; b=F5xSP/XOtnIBT5V+l9dIMPV8eitAN5nBbgLhXxbUJUlUrzFuXUG48ShOD14177/8j696uv DrZBM0T8g8k1hJN+qHEYHe1KCi1xpixeTy0+1LKRdqi/iJTBMhpcpUI07Etp+8O3ni8GbP +NvRpO+2r6OwbVg1YK8D+adP5bqlKEo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1729156509; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=1dRohF8dntyW3awLl8Th7hn4ml3FhG5k4WFCLyVx5Rc=; b=otB+1goVD/MGC5p3IrGUAFLn2P6MExgKegAeLOeVLYQtp7HIQZzi9URWJJfiLOfAgnscEA yt+S1p57dGVolkBg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id E7DDC13A42; Thu, 17 Oct 2024 09:15:08 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id iIpMOJzVEGfhRQAAD6G6ig (envelope-from ); Thu, 17 Oct 2024 09:15:08 +0000 Message-ID: Date: Thu, 17 Oct 2024 11:15:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH fix 6.12] mm: mark mas allocation in vms_abort_munmap_vmas as __GFP_NOFAIL Content-Language: en-US To: Jann Horn , Andrew Morton , "Liam R. Howlett" , Lorenzo Stoakes Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20241016-fix-munmap-abort-v1-1-601c94b2240d@google.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20241016-fix-munmap-abort-v1-1-601c94b2240d@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Stat-Signature: rsftgnduinsfiog8nzatzafdbnzn97z7 X-Rspamd-Queue-Id: 4F913180018 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1729156501-213477 X-HE-Meta: U2FsdGVkX1+vo2LrIJYappBRi9WGt9AiR6Lhjr3aA1eF23f328BdZdYO2fHp5HSGeqq+d0D2ea+7FWvfpLL6AztNsUSLbBokyAiz+GbKxdpmJgFRpfvp9p54lVIItXMfD61fbYMJAiJosTWozopqPk5zDeEJ5Zt/bF30SxRG5cMZchT6scdjk1JcxmGb+u9UgeWtYLxkl0z100LY0qEzOF9rs3oZPwOhcWZqpWMK4CGeHX4t00L4uWJ9zuaUqUsQci3+MoUgARWu5e+0nxnFhWLAvIgyy3FDsVvQCq5/7R3VJ+txsFqkcma0DMqc3j9t1jNK4XIUJgLbMB/PtJnQmb/8FvZD7Y/yeG17thlsCPBDqDxdMpmNTinWmWX5XwRZ5FxYKsccD+/gwGG7cbZwyWOFIb9xDiQj320lJ3aeYe+sWh6K/oNddahqM2QmqHVA5eux+R7wxrhr/mvrwxDrCM5uGxj6ssPHfzJBKZ5q5/ILx3LcFCj3veqGC1Lc2e/CSQ5AhaUsmIPnvF7n93/n+JgyMlvm7nDoa1ydNTaVr/FEg3Sq4rMb69EvFQ7rp3PRX0FtVKwk8HFB/Dbh/CiQFb2Iyn9cADhQ3FOeWKnsvAejxB/CiY9oiF4S+8axWdi+u914ELVUYc8h6aZ4Jv92pI7PyPKJKV9BPr8Zr2CPEhvcFG72aoz0AOSIq6hY6yZfQ76yJHek9BQ6RtgYTt6+7qLdsxqwd4xfw48d64PO5xQ08dU7odHq7R3ixcQbfObc/yFRy/di2LGMxC0XZEY6YLZe7XGIj3GM6zNijltWdNw8W3ZwelLO/jylPPxn6eKpyf0UNCApmYf5odFtSipd2zirkprCQBhObkMop9arOK56ec+WfYFOKZOVU5TBLpNYG2u4swLQhLsfGF+uWQiiBCC4LKtEmi2mJBw95/S68sVYo90eJBGHs8c4Wrqdw7Xn45j4AtUY+htZoGYegPA B4fCncT2 u0XgBfzehPtEcfgCQPsdzuiSgPCvSYmVOW2LNneqP+/NVCq/boIf2TL9qEu7jwf3F5XShAV+o/wev+pB3ee4lBWc7yGynArgtObalLntT+ms3a0X8bJzrw2suqLZBg+17dMGdMQx+a+LCyXEnzcjeblFviNlY/BTZAIGIb34ggtuMkjAvxaeDYPkUsjsYeHxdkFIjhzTbm1H09ND95FjXJdbI3t4Eia8oz1gWpgij7Kb8R6GC+SRDkAfXYAg4ka+MMotft/yuFs93ZYBlDJN85tptahecQSAFhT2kwwtRcD4tx7ko+Sha6FqtQWk/+thkDkYRRdvy83V9KSe7vL8+EcXFkcBWQdNN7wcm X-Bogosity: Ham, tests=bogofilter, spamicity=0.000010, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/16/24 17:07, Jann Horn wrote: > vms_abort_munmap_vmas() is a recovery path where, on entry, some VMAs > have already been torn down halfway (in a way we can't undo) but are > still present in the maple tree. > > At this point, we *must* remove the VMAs from the VMA tree, otherwise > we get UAF. > > Because removing VMA tree nodes can require memory allocation, the > existing code has an error path which tries to handle this by > reattaching the VMAs; but that can't be done safely. > > A nicer way to fix it would probably be to preallocate enough maple > tree nodes for the removal before the point of no return, or something > like that; but for now, fix it the easy and kinda ugly way, by marking > this allocation __GFP_NOFAIL. Yes that should be acceptable. > Fixes: 4f87153e82c4 ("mm: change failure of MAP_FIXED to restoring the gap on failure") > Signed-off-by: Jann Horn Acked-by: Vlastimil Babka