From: Libo Chen <libo.chen@oracle.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: akpm@linux-foundation.org, peterz@infradead.org, mgorman@suse.de,
mingo@redhat.com, juri.lelli@redhat.com,
vincent.guittot@linaro.org, tj@kernel.org, llong@redhat.com,
sraithal@amd.com, venkat88@linux.ibm.com, kprateek.nayak@amd.com,
raghavendra.kt@amd.com, yu.c.chen@intel.com,
tim.c.chen@intel.com, vineethr@linux.ibm.com,
chris.hyser@oracle.com, daniel.m.jordan@oracle.com,
lorenzo.stoakes@oracle.com, mkoutny@suse.com, linux-mm@kvack.org,
cgroups@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/2] sched/numa: Add tracepoint that tracks the skipping of numa balancing due to cpuset memory pinning
Date: Wed, 23 Apr 2025 18:41:48 -0700 [thread overview]
Message-ID: <c90ee040-4d2c-4f52-badf-0ad9127e61c3@oracle.com> (raw)
In-Reply-To: <20250423213343.6c5dd621@gandalf.local.home>
On 4/23/25 18:33, Steven Rostedt wrote:
> On Wed, 23 Apr 2025 18:12:55 -0700
> Libo Chen <libo.chen@oracle.com> wrote:
>
>>> Hmm, I wonder then if we should add in TP_fast_assign():
>>>
>>> BUILD_BUG_ON(sizeof(nodemask_t) != BITS_TO_LONGS(MAX_NUM_NODES) * sizeof(long));
>>>
>>
>> to guard against potential changes in nodemask_t definition?
>
> Correct.
>
> Whenever there's an implicit dependency like this, where if something were
> to change it can cause a bug in the kernel, it's always better to have a
> build time check to catch it before it becomes an issue.
>
Okay that's reasonable. I will add it~
prev parent reply other threads:[~2025-04-24 1:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-24 0:01 [PATCH v4 0/2] sched/numa: Skip VMA scanning on memory pinned to one NUMA node via cpuset.mem Libo Chen
2025-04-24 0:01 ` [PATCH v4 1/2] sched/numa: Skip VMA scanning on memory pinned to one NUMA node via cpuset.mems Libo Chen
2025-04-24 0:01 ` [PATCH v4 2/2] sched/numa: Add tracepoint that tracks the skipping of numa balancing due to cpuset memory pinning Libo Chen
2025-04-24 0:18 ` Steven Rostedt
2025-04-24 0:36 ` Libo Chen
2025-04-24 1:01 ` Steven Rostedt
2025-04-24 1:12 ` Libo Chen
2025-04-24 1:33 ` Steven Rostedt
2025-04-24 1:41 ` Libo Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c90ee040-4d2c-4f52-badf-0ad9127e61c3@oracle.com \
--to=libo.chen@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=chris.hyser@oracle.com \
--cc=daniel.m.jordan@oracle.com \
--cc=juri.lelli@redhat.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=llong@redhat.com \
--cc=lorenzo.stoakes@oracle.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=mkoutny@suse.com \
--cc=peterz@infradead.org \
--cc=raghavendra.kt@amd.com \
--cc=rostedt@goodmis.org \
--cc=sraithal@amd.com \
--cc=tim.c.chen@intel.com \
--cc=tj@kernel.org \
--cc=venkat88@linux.ibm.com \
--cc=vincent.guittot@linaro.org \
--cc=vineethr@linux.ibm.com \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox