From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83BEAC6FD18 for ; Wed, 29 Mar 2023 23:31:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DFD246B0078; Wed, 29 Mar 2023 19:31:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D857C6B007B; Wed, 29 Mar 2023 19:31:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BD8EB6B007D; Wed, 29 Mar 2023 19:31:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id AC4E46B0078 for ; Wed, 29 Mar 2023 19:31:57 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 7D017A08A6 for ; Wed, 29 Mar 2023 23:31:57 +0000 (UTC) X-FDA: 80623535874.03.D1CB521 Received: from esa3.hgst.iphmx.com (esa3.hgst.iphmx.com [216.71.153.141]) by imf29.hostedemail.com (Postfix) with ESMTP id E768412000B for ; Wed, 29 Mar 2023 23:31:54 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b=EtXldivj; dkim=pass header.d=opensource.wdc.com header.s=dkim header.b="MSq/WJxn"; dmarc=pass (policy=quarantine) header.from=opensource.wdc.com; spf=pass (imf29.hostedemail.com: domain of "prvs=44543d287=damien.lemoal@opensource.wdc.com" designates 216.71.153.141 as permitted sender) smtp.mailfrom="prvs=44543d287=damien.lemoal@opensource.wdc.com" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680132715; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xGK1fR4AJk4u+9DybbTgcw+CN81GSRVKlqiyvFs5Dp8=; b=ZleNooRsPqQth3+eg2Pose8uUFtjwGHXS+KCAG/FCLC7dlJw0of39l4IJ5JB2nfLFlIha5 dRr45lpSKon0g1DaKbTmAQRwkjquRL5vFoEm7IxL15ScpNddkdCvc503nzGk6uLem0j9L2 fUqNOCrjKefqL3pScGWClkx49nKnhNg= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b=EtXldivj; dkim=pass header.d=opensource.wdc.com header.s=dkim header.b="MSq/WJxn"; dmarc=pass (policy=quarantine) header.from=opensource.wdc.com; spf=pass (imf29.hostedemail.com: domain of "prvs=44543d287=damien.lemoal@opensource.wdc.com" designates 216.71.153.141 as permitted sender) smtp.mailfrom="prvs=44543d287=damien.lemoal@opensource.wdc.com" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680132715; a=rsa-sha256; cv=none; b=Kb27QyAAC5SiFwTmUDZHPh/vA3gDXXX7txnLCanz/r9VploSdqjAgy75DS59ljiMQggAsM ntpMrDIUKRh4Y/I1cfiLKaFWaGw0OwAR4MV2Ev6kEC6DVlFzr1zjbSbh4HbNCv6id4Q5nB mKCthUgf3s35lN93IMiAzGwMGeigI7o= DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1680132715; x=1711668715; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=+kVHS+U6z9asf4h5hbfmudX0RZseimMtPqZrPjZ6sRo=; b=EtXldivjPj4t0voPlgklrEA4J5QQ35Q9PKYYdoB9uFl1yvqQsjxnTmsc yu3WDeMwskJ16PTcri3PiHJ0NAwUlTbafRBoJY8FuYsvL+j1BhGPbk9ZY 8AalbDF31yGveczZoTqbI59Z5dC1ohForoc4Q1X9sLSP22kJKKM2aPxcg z8df8ejg22fouLZgpBA3vti6BJC9WquI356+118/mdz0L9nxXkGhzIWkg eiuFlCOmrl4YB0zXqZbBR2Wtq7P4ffsu0HYAVhBPHhZw0g9GfvNQIXl3B onyabcgi3Lurcb1k0M3A0+EIi11Jo3/P9Xdre+L2MujZCfQAz4vtB1cyf A==; X-IronPort-AV: E=Sophos;i="5.98,301,1673884800"; d="scan'208";a="231808549" Received: from uls-op-cesaip01.wdc.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 30 Mar 2023 07:31:53 +0800 IronPort-SDR: kcS3SgPfDqNT1RI8LePBdHtrmdZ/t5eZyz3V0GYO185O/eoUmq22T27eNdoZZpRop+snOVwJn/ fHMpp40qs3NMyiZwbx3IimRRtUPBawD6Jf5C5Uv221XoJFLpEpIXuer4Zcf3bVu+CKXpKhH178 1Zb4Jmq7FqUIytvlu1e/bBL08dtT73U397ssaONDlM+Vtd00/bi5br6T/lG2/SFwbRo5vTr4ZR rC8oFagdw6WrZ2lOO6FjAW5mI8lendI6f83qgDJFSbXiVuUNBk8f4rxD27is5sGe5xSnfL7duk O28= Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Mar 2023 15:48:01 -0700 IronPort-SDR: EeYCICI2uiLP2glr6tRhmTFJRnC3x9DSgvLzqE3uvuTZzG0i1dap9ozZqNSwplhVDqRfFn2a5I yVr4yeU9mstiTQPjq3pWzeDfmWw2kJJBLpTurVhIR2/kHPD+W+2YMVWrM14NZRN2xAOjDBmec3 ADsO1hx8TocRiv8S5Hw5lCUbg1NFpKSmUS2gQwb9wR9lwGCRbHPsPR0fSFSiJME/EiVpQKIKcz SKmMSZtqSyB+Kpzo4FJ7PW1wF+rMMy0sZlT3itMasknxSOEl83/N5LiH5bd4NE+prtIHaKf71l Vqs= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Mar 2023 16:31:53 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4Pn2rS6HQvz1RtW5 for ; Wed, 29 Mar 2023 16:31:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1680132711; x=1682724712; bh=+kVHS+U6z9asf4h5hbfmudX0RZseimMtPqZ rPjZ6sRo=; b=MSq/WJxnLgUdzNLdphZIxQyHpRfCEW6j0Wdm4bITDd3uXIJqQ4U 6qdg8Jn+9J/5Vy15M0ezWVKJWT8F8K92ngiUMKiBHMjvNoXlsCiavKM2pCNvEVov vlK/ucLB7MVAxYZ5cHk1jabnY+TbwEwlTT9KgXLD0a9q8dyAASHunSVnEyJEYJ7P 7iw/QMpUPkVls7zoUoEY/Arks/dS+UANaSD74pMDu1fcBTeFf/On+bqerWeu/wXb w18aQHkuSirM7cbXNck9eth9dOrIym0BiZLWxzFL+lQf5z8+AxH9izE6FsdvqzY0 s4/hXeC/IEhI1jqvjLH2uTpMFvpk3PLBGwA== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id t6ORFCADbst8 for ; Wed, 29 Mar 2023 16:31:51 -0700 (PDT) Received: from [10.225.163.116] (unknown [10.225.163.116]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4Pn2rP0PPLz1RtVm; Wed, 29 Mar 2023 16:31:48 -0700 (PDT) Message-ID: Date: Thu, 30 Mar 2023 08:31:47 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 05/19] md: use __bio_add_page to add single page Content-Language: en-US To: Johannes Thumshirn , Jens Axboe Cc: Christoph Hellwig , Hannes Reinecke , Chaitanya Kulkarni , Ming Lei , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, dm-devel@redhat.com, Song Liu , linux-raid@vger.kernel.org, Mike Snitzer , Matthew Wilcox , Dave Kleikamp , jfs-discussion@lists.sourceforge.net, cluster-devel@redhat.com, Bob Peterson , Andreas Gruenbacher , David Sterba , linux-btrfs@vger.kernel.org References: <55ec6659d861fd13e8e4f46d3e5a7fbad07e3721.1680108414.git.johannes.thumshirn@wdc.com> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <55ec6659d861fd13e8e4f46d3e5a7fbad07e3721.1680108414.git.johannes.thumshirn@wdc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: E768412000B X-Stat-Signature: 88gitijehq5iiunxopan8yc869xn8ax7 X-HE-Tag: 1680132714-214406 X-HE-Meta: U2FsdGVkX18NdNPH8qtOzdbt7sAkgmGUqps25x4XabbEsTtqSSDediTy3mY4HDPF3ngjjMQnvFeFIHn2c5Cbur1TnvUDb7v+PHurLX5KljRLcU/jPVqDnMgtXInU9lVoDiCXJ6oB7O6WQ/GMoEZJu9cb1GQqaPDM/O030wG8XoVQd7k7cPwtThHPgXU5v8gpoyiT09z+UMAf4OtS7WGql9DikbNoBjLgXYzHnGkilgF58I0xDi1H0aW6Qao6bzTIRZhNsoe+tgRpPY5O6oj4r2LayFMdz8DkJO1mpCVSESGhbWqGbgrI5T7NYIuecp6VN6+pHpyOO3EBLMYzv70t9tKbOKwzDs6zzJpWHfgpqNPC+xduHfEBj0JG5Zoj5ey2Olq4hpcbUsK8/qA4TkvdTo54LBbUK8JXYnb02MdIE6FFCVJc5mYKdjRz6umwQbUfcNpduKvKbc37u/Wq+fbHiti02g4T6QvnJh/5gS29wGx67VIZSBbo+tx+T73LLlb/9cf+/vdJpdb3wR7rKfNho8wKiuEd4SXY6Dcg4lfax+x0HPDMj+iDpCM6jz0K56pJiOXOh69E8wT2pwEWq17QlqZ1Py+hesf4yoxdwf1KYRiPF2zuYqk3s/EBDKF4S26zkarFJeqPQ6BwEc9VDXaMGlNT+/tzBnVWjZT1mWDlJ0VWvmF/zuIlS5o4AfIGFNcGAoReTks6BEr02RUDc1rHTwKhd8/XS7EvPYsmMCx5TtWgogeDihXhalDPxNL9h2V+iah34m0OnDohHXvnxYlePgiZpZXs/yuzsv8Mq1u27KbpZMh1FYSkeJG5zh/mtS0T1oWXMAeSY+R7KlWKMkNnfhYgXk0eI0RmmeAVP141cUADkYttNF+egEtlDSHXMsjQKeedRbPKXoZjHCxefy0ImJJ+maIPWZkwGxpO4rtW75of8ZaYBwLehcvtMJDa973uyK8YTj8j2qZu39qkIdE FiB9m7Mc K0w1iolvifF8sIHMvnnEFHwg2GN8q1Ru+Kl/Tq8cxJCMLBoTlEDminPO8XkidCbh17Rr5x1Fgw+4Lk98SJzfzck7BFvgzhYD+8Y2P0PD/41eMtxnakfWWnQnK93XDnf+rpj6YEZcoDS06jO4UH9vLlUe9XQ96fWYgXZ1BwojlGWTIDNPOfoOKdBJDqPEA03He1iP7TtimcHMdHtrOwDe6pxvmZsi1xNps+UE34i8rf/VoAHdRvujrnm3ZpB7ZxFl/ZwKckL5dpLZ6OgkGIAnIQuTu29wX4J8L8U0CVrOc6JypIzaPWuj5iNS27nrsZCoS9y8CziC0M66L9+FojzdMlAJdZMG2heeqEc+Uvt7/kd938mSjtVLHsKS5Tis2QKfanhks08zIKHlxN//RFh0v35kJ4YSoaNB9H3OB6dO7xDINreSeyXF2sCNH85XKdo9Ne+UFn/WzA5199crfUNr6O+U6ZILXt+PPFGL8hLy1Yjpq16TLs03efNLvV4lWWOoM0wmOXBuJNJlI0bFSZcWaiSdGa4GQlaMmtvIAkMHzy9x8aWNBrJuI49k+KOHhUZSBv/yHnaYzJN/4SPQI0iZytjORtbDJnIJesOnKkE731Km2xCGWtVJiuujhHA2vfCv1aYCBUWL6gRUoiXncA3v2L9/jWD0+rLjIgoJWlnSERZzQPToeIBFTYa024A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/30/23 02:05, Johannes Thumshirn wrote: > The md-raid superblock writing code uses bio_add_page() to add a page to a > newly created bio. bio_add_page() can fail, but the return value is never > checked. > > Use __bio_add_page() as adding a single page to a newly created bio is > guaranteed to succeed. > > This brings us a step closer to marking bio_add_page() as __must_check. > > Signed-of_-by: Johannes Thumshirn Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research