From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5BA1C021A4 for ; Fri, 14 Feb 2025 21:39:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2374F280002; Fri, 14 Feb 2025 16:39:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1E88E280001; Fri, 14 Feb 2025 16:39:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 06042280002; Fri, 14 Feb 2025 16:39:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id DB925280001 for ; Fri, 14 Feb 2025 16:39:39 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 71532140518 for ; Fri, 14 Feb 2025 21:39:39 +0000 (UTC) X-FDA: 83119867278.29.45D7655 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf24.hostedemail.com (Postfix) with ESMTP id 10664180008 for ; Fri, 14 Feb 2025 21:39:36 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=av9hwt0p; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739569177; a=rsa-sha256; cv=none; b=DgMlIKDcnlsNIqQA/qilwBui9JT6QaBb6Jvikme5iG7sRJRbw1zrrMsnqu2KCd+gstQJuq 61QcidGg/1ymye+1JY3BncQrBnxGzOGS3tBnnllAe5lVnZ36ee4uCXjcCX2WPM9JLEAvUt VfzbMm1dYSItn4vj5XEzsNtqULZX+dM= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=av9hwt0p; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739569177; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iv/lNCfjwdkeR4nF0oUU9k7rRpcxsvGhnFm9RShrjfY=; b=RJT/DRIH6TKVaCD3OOuvpDk9nVsr3G46I+3OnYK6Vlg/XzdEHbnE6dRPaJpJX7Yiy0Cp4/ TdUBVdIE5nlZ5ayA7HVf5GOPoJCNMHW24eEfK8nnNLri6R/JSKtCzPpdQuWrV22ymztxkK v8Sd/IxWRgk6inDoarFr6J5OUFTPD1U= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739569176; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=iv/lNCfjwdkeR4nF0oUU9k7rRpcxsvGhnFm9RShrjfY=; b=av9hwt0pVgwv0Zk0h3R0X1PThn46HHB9+n3dlHMYtPVln3hNyn8drWhYBp6pCFbJb2ckkv 8VwAvOJhVHtcCiapuu8CwBpNVw3OwfN/RJu0/F7q4pxl8nIDmqhysTkR29VquwIWIrNZaQ rjvaq9KOyrJdw/As/8tH85p8a3rAdiA= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-446-4-VuUIGVMg-h7j2KohtU0A-1; Fri, 14 Feb 2025 16:39:35 -0500 X-MC-Unique: 4-VuUIGVMg-h7j2KohtU0A-1 X-Mimecast-MFC-AGG-ID: 4-VuUIGVMg-h7j2KohtU0A_1739569174 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-43947a0919aso20629635e9.0 for ; Fri, 14 Feb 2025 13:39:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739569174; x=1740173974; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=iv/lNCfjwdkeR4nF0oUU9k7rRpcxsvGhnFm9RShrjfY=; b=ALiel5uryi/ezhWuCVIXUjG22d9jLJWDEnOnB1AU3WkjnUktVX1G+IBRrBXBn0QKsv 46p6iSwjV8lZB6uqNORcu1rvpNtEaK7yq1gVYffOc4CwbOsThXBjGQs4+unzGjWOGKH3 mYZPa/UTxWflr4KjdlCULcss3gu0Q8Agz6TBtMKx5npaKiiyhWfFqrmsjlJYUZnIaS63 jk4PXDuYS/s7Ph3+XLZpV8q9aLwenIs57wGOdrI6EzevCqQ3d2ucCQxQlWlkG3QwSfjc 5Uyf1wSCw82yXSidYTifhHR6+MAL+kH8ljMVx1DL7MpZdsl2xaaQXDR/NFrt1ON/OQ7N o2Ew== X-Forwarded-Encrypted: i=1; AJvYcCVW7rk+e5eTGHBFtAx5OJfEJgm/67VhwM2UAUoY1HnUwwEc1kYctn984k1p4Ktu1A26vZe+g3QEXA==@kvack.org X-Gm-Message-State: AOJu0Yx68KVA+AoujcMNoCcCyL+9m0ynsa1nkGnkeURAZe8f2WMlSkdM uVmYdm5pqdcd9ZBxC6j2hpqY3TU6sGwPw0o+yW2n8rvuC+CeLSmq/X+gfZlI0i0Rsf9Cy3XRKU0 Ru/Uy8cEz8qXJ+ARoF0fHiioDz+5qlInmfRbk6VzyErkl0G4p X-Gm-Gg: ASbGncvk0oBSDfMocBbNSL2nWVHP8wpSG4bcgF1emKUwhljF8MoqXxkf32TAjiW0rEf dfJ9S/aJiLcAnFmIXh42UtsmB7v3Z2fnSKyeK/SoLKDbBlu8epF3IbFM133VhG/Ipgf1k0gcXFW DBeaF34X/SBudVsE9kAOczjaxIMkQ6pk7VE6/bFSvi/nYLec1VnUPk6yqmXJTZUrSJ6FU6FbYLx MpxdcJefTiF/AbGb6hJDPoa6oOzCrDpkRSgXoDZ1UsyxVP/lkX7dlUfTbsGuOo/xcaBjC6TPGU5 KnA+YPvi02H3Dnv+ezqymG4zKD7omY97uOtgiNd0h//Jp97Ec28qHaHmS+eDIg+JCZJJRLsxMa0 Dpddyfvv3VgXnPHHZ1pL/xqsVePKcUSdn X-Received: by 2002:a05:600c:1d1a:b0:439:5756:ad4c with SMTP id 5b1f17b1804b1-4396e6c1885mr11847575e9.14.1739569173830; Fri, 14 Feb 2025 13:39:33 -0800 (PST) X-Google-Smtp-Source: AGHT+IGBOiE8GdsHWkJu3JJujPjuarO3/1Mi20BwQfSP+o4X6JnyFijzaTOnDc+qmAg5cAL4PBux9Q== X-Received: by 2002:a05:600c:1d1a:b0:439:5756:ad4c with SMTP id 5b1f17b1804b1-4396e6c1885mr11847325e9.14.1739569173434; Fri, 14 Feb 2025 13:39:33 -0800 (PST) Received: from ?IPV6:2003:d8:2f22:1000:d72d:fd5f:4118:c70b? (p200300d82f221000d72dfd5f4118c70b.dip0.t-ipconnect.de. [2003:d8:2f22:1000:d72d:fd5f:4118:c70b]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-439617dab54sm55056285e9.6.2025.02.14.13.39.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Feb 2025 13:39:32 -0800 (PST) Message-ID: Date: Fri, 14 Feb 2025 22:39:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/5] mm: Provide page mask in struct follow_pfnmap_args To: Alex Williamson Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, peterx@redhat.com, mitchell.augustin@canonical.com, clg@redhat.com, akpm@linux-foundation.org, linux-mm@kvack.org References: <20250205231728.2527186-1-alex.williamson@redhat.com> <20250205231728.2527186-5-alex.williamson@redhat.com> <20250214101735.4b180123.alex.williamson@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250214101735.4b180123.alex.williamson@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 9hLoLhNVyChHV5ZRU1AY6Dmxs7pTyinF-tsvyu3DgdA_1739569174 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 10664180008 X-Stat-Signature: o1spmw3wjedd5hitkadqyeara93s5ucs X-Rspam-User: X-HE-Tag: 1739569176-641774 X-HE-Meta: U2FsdGVkX1+uyXmmVVM8X+t1vAwVrVtNKl6ND6kamKU5MpR58hcUOlVpImMd1a8zLlFH2IZSbUScGyS60IFQJSoyh0UY43kqXfX1rCPz2zv75QGgBTh9+erZC/c6SGSotIdio8FF5eF08ssSloYxSQasZYHcjyY45/Dyop/QxQ1qQIWL3YqAZu+SZ7Gz8/zWz7GWg3rxrkv0Td9ihXp08vbQgshd7KGRD24X3xARvDnADQnv0hYTielvrdAhZvuCF50JxXvpRsKTlNlpRT41ztKnsBjwukux4isHxytyZAGybHM3HEB6agAqdKDAjgvED5xnV0wXhSZ7421O88itMr2B1OrBs+BxU7Z2QFd7jQRJUUFt63l9mHEpy9TOWbT5tRe2cSeOWN92gryjABRbBUou7GTndV3XH1QjtUX/e8dbR3soE33Olop0oNO3kPI990PFe5r4suIxH6YjwvkwwSP45Q32EWwgeLSDpZvZTQA92aHHXE1CoE5gkZukmrsRlx3Rqa7Ky5gR1RRLLSwxbGb6IawGzfWrJcsnr7t+o5xAr/YTfqgn/9SjlzWzVLqtan1kRHw5ude8DpEqmAKWeriDi5nxAu/yzzOu/tkZJXuQ+aGhet4EBgPSqQB+XEabNlpWDgjBDqDDee8Y8M/n90/7D2RSpJUdB7j34CBB051PB0DUvP85+cGVMOvXDB3zNTeaCO1zPJjP4kvaAOdE1UUnWtpvrdmmJyFmblehEvHBHFhSgrykUda9fgQ+NF4R28XDOxMx2dcxBI9dCjJ75OvyFfUBHxOQu4bgNQ7NEkvao08eeFcfs1jH3ACb+seDypE7JBjmwptr5b7DvAnG+gL/nN81vWk4pVn8qSkPijTU1pI1eeSybI11oBgzmLaQnmbyJoI5zJA4nUm4zmshTIP3WXFbWq/VH4mE2FG+jjzlbA7HtfCYQyo2oEBiJJPoFvntAiEj5VRNXyw5d0l 3KU7/G/v +Wco4KYv7U9Gb8kWHuVv51ujpMXNt9y3m6B7cqqiZVq3NemJXy9oVw/QFuMHnxXyZbNB9NhJ+8/HSnR1bqeDsc6i0ijHFuZ8KKED/Z772Tod0PuurYVDJFSo+Ky9678m7GEl986OWstVyuhb95HGIXL5JDtlduMW7hM+v18KvTBT54t1vpPH7uPjbBmh/ormusexjO9eL+GpijxiKLWKCicVSq0vITa69hAM2un2vTdaZwwS3sl1jPF8HjflGgmraSqlLLpSVlB7LzOEcpT/XMjWmZ6W1LAb7XNSTEO7VLf+m6FWZG4B7aImDBCdRpMAUNVaGWXnjGTTNehqlnyOgP6Zu3sFlD9LXxnpZ9VhC1Hbb0NCsY3iBalnZFRjZ9pbHMe8j++yYy73M3CdGTUuiGchXaYqQ3KY+0TXk43YnCXul2/EvbtyfivICSt95/1j9Z6Iv X-Bogosity: Ham, tests=bogofilter, spamicity=0.080682, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 14.02.25 18:17, Alex Williamson wrote: > > Nudge. Peter Xu provided an R-b for the series. Would any other mm > folks like to chime in here to provide objection or approval for this > change and merging it through the vfio tree? Series[1]. Thanks! > Only skimmed over it, nothing jumped at me except ... Nitpicking: I was wondering if "page mask" really the right term here. I know that we use it in some context (gup, hugetlb, zeropage) to express "mask this off and you get the start of the aligned huge page". For something that walks PFNMAPs (page frames without any real "huge page" logical metadata etc. grouping) it was uintuitive for me at first. addr_mask or pfn_mask (shifted addr_mask) would have been clearer for me. No strong opinion, just what came to mind while reading this ... -- Cheers, David / dhildenb