From: David Hildenbrand <david@redhat.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
peterx@redhat.com, mitchell.augustin@canonical.com,
clg@redhat.com, akpm@linux-foundation.org, linux-mm@kvack.org
Subject: Re: [PATCH 4/5] mm: Provide page mask in struct follow_pfnmap_args
Date: Fri, 14 Feb 2025 22:39:30 +0100 [thread overview]
Message-ID: <c90376b4-0a8b-4db9-8b84-39325b1ac57e@redhat.com> (raw)
In-Reply-To: <20250214101735.4b180123.alex.williamson@redhat.com>
On 14.02.25 18:17, Alex Williamson wrote:
>
> Nudge. Peter Xu provided an R-b for the series. Would any other mm
> folks like to chime in here to provide objection or approval for this
> change and merging it through the vfio tree? Series[1]. Thanks!
>
Only skimmed over it, nothing jumped at me except ...
Nitpicking:
I was wondering if "page mask" really the right term here. I know that
we use it in some context (gup, hugetlb, zeropage) to express "mask this
off and you get the start of the aligned huge page".
For something that walks PFNMAPs (page frames without any real "huge
page" logical metadata etc. grouping) it was uintuitive for me at first.
addr_mask or pfn_mask (shifted addr_mask) would have been clearer for me.
No strong opinion, just what came to mind while reading this ...
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2025-02-14 21:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-05 23:17 [PATCH 0/5] vfio: Improve DMA mapping performance for huge pfnmaps Alex Williamson
2025-02-05 23:17 ` [PATCH 4/5] mm: Provide page mask in struct follow_pfnmap_args Alex Williamson
2025-02-07 1:38 ` Mitchell Augustin
2025-02-14 17:17 ` Alex Williamson
2025-02-14 21:39 ` David Hildenbrand [this message]
2025-02-17 21:56 ` Alex Williamson
2025-02-14 19:14 ` Jason Gunthorpe
2025-02-05 23:17 ` [PATCH 5/5] vfio/type1: Use mapping page mask for pfnmaps Alex Williamson
2025-02-07 1:39 ` Mitchell Augustin
2025-02-14 19:27 ` Jason Gunthorpe
2025-02-17 21:52 ` Alex Williamson
2025-02-14 19:46 ` Matthew Wilcox
2025-02-17 19:33 ` Alex Williamson
2025-02-06 19:14 ` [PATCH 0/5] vfio: Improve DMA mapping performance for huge pfnmaps Peter Xu
2025-02-07 1:39 ` Mitchell Augustin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c90376b4-0a8b-4db9-8b84-39325b1ac57e@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alex.williamson@redhat.com \
--cc=clg@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mitchell.augustin@canonical.com \
--cc=peterx@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox