From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AAE5C3ABB6 for ; Mon, 5 May 2025 10:09:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BA2B36B008A; Mon, 5 May 2025 06:09:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B52936B008C; Mon, 5 May 2025 06:09:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9CA4D6B0092; Mon, 5 May 2025 06:09:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 783576B008A for ; Mon, 5 May 2025 06:09:01 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 6C43BBDA73 for ; Mon, 5 May 2025 10:09:02 +0000 (UTC) X-FDA: 83408430924.14.932D839 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf12.hostedemail.com (Postfix) with ESMTP id D5B3340002 for ; Mon, 5 May 2025 10:08:59 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ijC8Cqhb; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746439740; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BmTwP3C/5RRHNa0cESV330FAgf6OjrxM/JkWPUJkdr4=; b=MVfq5VORVH/01yC8yDPtg5D9v5aGFjTJMjgbFDUw30s6OX1mCgF+7Ycr3Wxzu0Qrg2LF4Y hJ5J0EXM66qD8MylVhn8R+dLQCfCdfc1yV8jgWgu7HdleqaLkDDzr0Rf/+mch2eMs8v+7w l7+W/PSdQPZLiWJ5DeL8blfy1GmxtuM= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ijC8Cqhb; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746439740; a=rsa-sha256; cv=none; b=xjkOrCw43xmHDq3N+YmENDn2JK7Au9c8/OuUXxsZ+PHvRER4gvgV2fyrxMQLn2yh9/7ir0 i78HyHk0hPmDwcp2BoiAgiygV7qm3Btcb6NdxglxiXxUstQooGH3s1nz/BJJUqdTFiK5FT ymvwzWzZFcjYXsRtDdDEaMo0PtpnSe0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1746439739; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=BmTwP3C/5RRHNa0cESV330FAgf6OjrxM/JkWPUJkdr4=; b=ijC8Cqhb9owexcj8Ls/ioT2HGqT5u3EyYh1DokUuROFfWzzuAVi39BWv8BM4rOOiGPmUl+ tQOL/Wp2aLlm24iRdUD3ds2ar4PIXlW7423JsZrehAV+5ElJmHmCaQfKbYuekQpjpgsHOc 1vcHAJt6fjySPfW7xXl09Z9ox7UaGTA= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-411-t94FbpSqN2aAt_U6OVWnAQ-1; Mon, 05 May 2025 06:08:58 -0400 X-MC-Unique: t94FbpSqN2aAt_U6OVWnAQ-1 X-Mimecast-MFC-AGG-ID: t94FbpSqN2aAt_U6OVWnAQ_1746439737 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-43d0830c3f7so30571115e9.2 for ; Mon, 05 May 2025 03:08:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746439737; x=1747044537; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=BmTwP3C/5RRHNa0cESV330FAgf6OjrxM/JkWPUJkdr4=; b=ZlWWAmaEk7WVGbx9E2+DT0GBbHbRZPQZJMLqfrT+Z8xgK53YuzcUpwjmKQWcrH6/WG k+xvrEMtIE8nTf/H+MDODAyDTZ++Tq0l3XQxq6b65wqblKs9+NRv/86DEx6TJRVZXKRB RDyyqRAD3M26LAt08dgqUf2Dx7mPKWk7KilVZ1P0dohucRFg5xBCAfhX/yHSyM5rVMYk AAxcUZqmo2ZvlNCkwIP01rakh0jtMTgYCVgw4ueul9K/cBf2u2z4j+LIgz4UrL9bTkXM qPc1Y5XRvsDRCN/mo3jUFn+mNTHGLI1ev+6Q3xPXCO1327pI2YCABnqGh9bVqHH67xdo Rvlg== X-Forwarded-Encrypted: i=1; AJvYcCWyXQrHMf47HGyPh7ykeTGT9ATYHffPoUR4vI02BuD7Is7JY7uvvLzGKvxlmdMHv/ofgt9lwGyHpw==@kvack.org X-Gm-Message-State: AOJu0Yzoxwo6to0N+ugzP9m6m1FBRvVRE88+eDW+BJ5bgEnfvCHPD/+b 2l4jJxODy/jMN0BZQaumhkJZjVC4V2dM90hATyO7LY7nm3VEyZWxDzWIbsydQpBloOQzzGJq9Yr xM1jsoFDJ/RaYhAW5vdnoyINXv/SSE4smER0zSzq2UtyuweWN X-Gm-Gg: ASbGncvJaKkQgsk6jdJmZqD3lZQHZ0HXkTWlLZpPce0yHQz65CskPjL6EUdvF6T3n6B s1mIg6PQf9EFi06crnBfWeOKps39LDHvJG63Cbd7kjojSS7LOElBNXHGFXkPQXAUVgRHOgnXi0j RtVBEl/mgqCSMdfycjDkUJvWP8z5m9i6r4pNNO5psagXhp8pH9lzLrfKnkHUVkoNr+Jt/ojQx+S iWWtmQw/690c5V9GnFVwW8WtasCn+eutyFNy+Ki91CK/0bW87O5Vdyx/IW6dHYcQAmmYf/V97FQ c1yUrZuL0Kl6Dv8hoPXPspmSVyoNX6ebMxF7x/xYyiw1R9Lf+SVv0hpfAX/DmBecnxr9u/wl6Ux bI+CMb8zKGSf7xGl5p8x5ig/MNxic2r4XzL7ElwU= X-Received: by 2002:a05:600c:a13:b0:43c:f81d:f with SMTP id 5b1f17b1804b1-441c48bca3bmr57375895e9.8.1746439736748; Mon, 05 May 2025 03:08:56 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGPx432VgCohrDR6C5RgxgqMkrU5XckKpboeqJ5naVLmUoTk99ORY1qD6XhEz6hLJ5dyJF7Ng== X-Received: by 2002:a05:600c:a13:b0:43c:f81d:f with SMTP id 5b1f17b1804b1-441c48bca3bmr57375515e9.8.1746439736336; Mon, 05 May 2025 03:08:56 -0700 (PDT) Received: from ?IPV6:2003:cb:c73d:2400:3be1:a856:724c:fd29? (p200300cbc73d24003be1a856724cfd29.dip0.t-ipconnect.de. [2003:cb:c73d:2400:3be1:a856:724c:fd29]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-441c0dfc537sm82386455e9.16.2025.05.05.03.08.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 May 2025 03:08:55 -0700 (PDT) Message-ID: Date: Mon, 5 May 2025 12:08:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v4 4/5] mm/readahead: Store folio order in struct file_ra_state To: Ryan Roberts , Andrew Morton , "Matthew Wilcox (Oracle)" , Alexander Viro , Christian Brauner , Jan Kara , Dave Chinner , Catalin Marinas , Will Deacon , Kalesh Singh , Zi Yan Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org References: <20250430145920.3748738-1-ryan.roberts@arm.com> <20250430145920.3748738-5-ryan.roberts@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250430145920.3748738-5-ryan.roberts@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: UWK00lv6guPv-hTN7IouaEXjw8BN0Rrnq5TOwCGI1qY_1746439737 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: d8qbsrwyqecz1tcfhc813mqu1789gmsf X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: D5B3340002 X-Rspam-User: X-HE-Tag: 1746439739-455336 X-HE-Meta: U2FsdGVkX1/h9Jg27SUwbNTAb3Zjh7sU96DbJ/KRPcqgSw5k73nH4TMt5WffbR1Ydh/A2yly8wATNfv7G14GCh2Q74Omd/VAPqebjiDzImoaP3dyypqhxaX81iKXmRWCML54yxMmF1oAuVNz/IFz46vlihopmKDWfNYRhlvBnXI4LIVmP1BQJDbPQ93QF/VpJDtUy4fyCo8Rx6bnKCGmMzuAsKm6MEVGF9R9fYJXYMyM8V3B30anQTsVK+PKny0oRSvS4OvCwMRshfKOmWqApvBhFYENtWgZy0FAdKPKd/aq4zUISq2xwei+IBllMJe6d/0QhJKp3X7c9WIeT59JQ9HhjFKr9beuqKWZxWqzkY3YC140vk9EzCPYlq+dNhubY3z0oF4jw1uvdwRDgWuKW4cxkm+ib2qaYHCVj8rOLd3tEGM11NMLpmh7neQRTTxRpqtPDyz6pqrl3HWvu3jLOhdL5Dzni/czsuVznBp0WMfNeLr4FWvT/yffO20g1uVuJuUbtRSIPLn7wb8weYKR2z2JQ/WqIHiEaq5/nzD5ljeiac6GrcN3mzRqeYLUAh+p/kWrOuOfrFvna4+1dS1OEZVWSE/ylkeNIlwuGSPsxYWqHnL/RuhLC9PbU6dPosPxwgJtkqdxyxXFq65aLgEdvf/GNFNGMCMD2zONAyiZf+9W8H5wY6I4+oHgJhdaXnOKdmXjbss0zLrGLl3bEaSpzdt89iwXeGbRDXx24xtHvHGxo18rBjApTy2Aoty7xG4hVVBlskJc3VY7tJ4adsLilRc0TAUj8oCQIkEI4AVCxWQWZtZt2WdWW+Yu+KOpKh9o+BbUQTZjuIj8ZMnbRjqUFym+Bvp19iAmffhiFY9W4V90xMdJjliEL12OaozmMI6oDPTaOvpdL89dGs3Cppy6W8oTAuNRE3Skc3aROKy677JmFgm0pdhDoiE5FbDjxLCgnvA8ZsyIkm2aWjm1X/F cCNiRTsG Yc1NPCWPhTDroEzpJQ5wNl+oSr1bmkzrvjcDl1ailWH0zoT6SAo5J6aeSquG0Vr4ZuBNgEJvs3gw5x0SnnuuTt+c+zeJy0okKh3OawoB0VywyYHXJrqYmiYoLrTAl4sskp6AE64H+85q5CnAKbuAGhVrvzLB/G7gfRU5Kd7kT50C206yOopkTCFwZdFhCmDo9STATe2DPTsDU4H6i9nbIEQhvUupxPm+Rlkh2Nl4EuensHKAw8+i0socRH2T1sxl7r9EUVVW52ahbv4ggfoT209iPdgeiayxbnaBPtiMyFKNjJf35LXWfsr1F2i87zafNOPJG8ItQZc2VCgjGCSEnci7c0+Ub+cIOjE5QME0rGVjXzCsSszQNpsdkU00GswLviFMiuDzHC8mww1XkPDJ7B9qnJnXoFfQIiJexoVu/VoPQC8PoEuKs3BW0Q0TwERGIzPMrCyU8Qm6/0Oj3DMWWkAaXiETeeagtF4GtKCbxy28E+DV7KTraX9G0wrkeuRqu3tNO X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 30.04.25 16:59, Ryan Roberts wrote: > Previously the folio order of the previous readahead request was > inferred from the folio who's readahead marker was hit. But due to the > way we have to round to non-natural boundaries sometimes, this first > folio in the readahead block is often smaller than the preferred order > for that request. This means that for cases where the initial sync > readahead is poorly aligned, the folio order will ramp up much more > slowly. > > So instead, let's store the order in struct file_ra_state so we are not > affected by any required alignment. We previously made enough room in > the struct for a 16 order field. This should be plenty big enough since > we are limited to MAX_PAGECACHE_ORDER anyway, which is certainly never > larger than ~20. > > Since we now pass order in struct file_ra_state, page_cache_ra_order() > no longer needs it's new_order parameter, so let's remove that. > > Worked example: > > Here we are touching pages 17-256 sequentially just as we did in the > previous commit, but now that we are remembering the preferred order > explicitly, we no longer have the slow ramp up problem. Note > specifically that we no longer have 2 rounds (2x ~128K) of order-2 > folios: > > TYPE STARTOFFS ENDOFFS SIZE STARTPG ENDPG NRPG ORDER RA > ----- ---------- ---------- ---------- ------- ------- ----- ----- -- > HOLE 0x00000000 0x00001000 4096 0 1 1 > FOLIO 0x00001000 0x00002000 4096 1 2 1 0 > FOLIO 0x00002000 0x00003000 4096 2 3 1 0 > FOLIO 0x00003000 0x00004000 4096 3 4 1 0 > FOLIO 0x00004000 0x00005000 4096 4 5 1 0 > FOLIO 0x00005000 0x00006000 4096 5 6 1 0 > FOLIO 0x00006000 0x00007000 4096 6 7 1 0 > FOLIO 0x00007000 0x00008000 4096 7 8 1 0 > FOLIO 0x00008000 0x00009000 4096 8 9 1 0 > FOLIO 0x00009000 0x0000a000 4096 9 10 1 0 > FOLIO 0x0000a000 0x0000b000 4096 10 11 1 0 > FOLIO 0x0000b000 0x0000c000 4096 11 12 1 0 > FOLIO 0x0000c000 0x0000d000 4096 12 13 1 0 > FOLIO 0x0000d000 0x0000e000 4096 13 14 1 0 > FOLIO 0x0000e000 0x0000f000 4096 14 15 1 0 > FOLIO 0x0000f000 0x00010000 4096 15 16 1 0 > FOLIO 0x00010000 0x00011000 4096 16 17 1 0 > FOLIO 0x00011000 0x00012000 4096 17 18 1 0 > FOLIO 0x00012000 0x00013000 4096 18 19 1 0 > FOLIO 0x00013000 0x00014000 4096 19 20 1 0 > FOLIO 0x00014000 0x00015000 4096 20 21 1 0 > FOLIO 0x00015000 0x00016000 4096 21 22 1 0 > FOLIO 0x00016000 0x00017000 4096 22 23 1 0 > FOLIO 0x00017000 0x00018000 4096 23 24 1 0 > FOLIO 0x00018000 0x00019000 4096 24 25 1 0 > FOLIO 0x00019000 0x0001a000 4096 25 26 1 0 > FOLIO 0x0001a000 0x0001b000 4096 26 27 1 0 > FOLIO 0x0001b000 0x0001c000 4096 27 28 1 0 > FOLIO 0x0001c000 0x0001d000 4096 28 29 1 0 > FOLIO 0x0001d000 0x0001e000 4096 29 30 1 0 > FOLIO 0x0001e000 0x0001f000 4096 30 31 1 0 > FOLIO 0x0001f000 0x00020000 4096 31 32 1 0 > FOLIO 0x00020000 0x00021000 4096 32 33 1 0 > FOLIO 0x00021000 0x00022000 4096 33 34 1 0 > FOLIO 0x00022000 0x00024000 8192 34 36 2 1 > FOLIO 0x00024000 0x00028000 16384 36 40 4 2 > FOLIO 0x00028000 0x0002c000 16384 40 44 4 2 > FOLIO 0x0002c000 0x00030000 16384 44 48 4 2 > FOLIO 0x00030000 0x00034000 16384 48 52 4 2 > FOLIO 0x00034000 0x00038000 16384 52 56 4 2 > FOLIO 0x00038000 0x0003c000 16384 56 60 4 2 > FOLIO 0x0003c000 0x00040000 16384 60 64 4 2 > FOLIO 0x00040000 0x00050000 65536 64 80 16 4 > FOLIO 0x00050000 0x00060000 65536 80 96 16 4 > FOLIO 0x00060000 0x00080000 131072 96 128 32 5 > FOLIO 0x00080000 0x000a0000 131072 128 160 32 5 > FOLIO 0x000a0000 0x000c0000 131072 160 192 32 5 > FOLIO 0x000c0000 0x000e0000 131072 192 224 32 5 > FOLIO 0x000e0000 0x00100000 131072 224 256 32 5 > FOLIO 0x00100000 0x00120000 131072 256 288 32 5 > FOLIO 0x00120000 0x00140000 131072 288 320 32 5 Y > HOLE 0x00140000 0x00800000 7077888 320 2048 1728 > > Signed-off-by: Ryan Roberts > --- > include/linux/fs.h | 2 ++ > mm/filemap.c | 6 ++++-- > mm/internal.h | 3 +-- > mm/readahead.c | 18 +++++++++++------- > 4 files changed, 18 insertions(+), 11 deletions(-) > > diff --git a/include/linux/fs.h b/include/linux/fs.h > index 44362bef0010..cde482a7270a 100644 > --- a/include/linux/fs.h > +++ b/include/linux/fs.h > @@ -1031,6 +1031,7 @@ struct fown_struct { > * and so were/are genuinely "ahead". Start next readahead when > * the first of these pages is accessed. > * @ra_pages: Maximum size of a readahead request, copied from the bdi. > + * @order: Preferred folio order used for most recent readahead. Looking at other members, and how it relates to the other members, should we call this something like "ra_prev_order" / "prev_ra_order" to distinguish it from !ra members and indicate the "most recent" semantics similar to "prev_pos"? Just a thought while digging through this patch ... ... > --- a/mm/filemap.c > +++ b/mm/filemap.c > @@ -3222,7 +3222,8 @@ static struct file *do_sync_mmap_readahead(struct vm_fault *vmf) > if (!(vm_flags & VM_RAND_READ)) > ra->size *= 2; > ra->async_size = HPAGE_PMD_NR; > - page_cache_ra_order(&ractl, ra, HPAGE_PMD_ORDER); > + ra->order = HPAGE_PMD_ORDER; > + page_cache_ra_order(&ractl, ra); > return fpin; > } > #endif > @@ -3258,8 +3259,9 @@ static struct file *do_sync_mmap_readahead(struct vm_fault *vmf) > ra->start = max_t(long, 0, vmf->pgoff - ra->ra_pages / 2); > ra->size = ra->ra_pages; > ra->async_size = ra->ra_pages / 4; > + ra->order = 0; > ractl._index = ra->start; > - page_cache_ra_order(&ractl, ra, 0); > + page_cache_ra_order(&ractl, ra); > return fpin; > } Why not let page_cache_ra_order() consume the order and update ra->order (or however it will be called :) ) internally? That might make at least the "most recent readahead" semantics of the variable clearer. Again, just a thought ... -- Cheers, David / dhildenb