From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 365A5C4332F for ; Fri, 23 Dec 2022 09:40:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 74DEC900003; Fri, 23 Dec 2022 04:40:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6FE1A900002; Fri, 23 Dec 2022 04:40:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5EDEF900003; Fri, 23 Dec 2022 04:40:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 520DF900002 for ; Fri, 23 Dec 2022 04:40:24 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 26BBC1A0969 for ; Fri, 23 Dec 2022 09:40:24 +0000 (UTC) X-FDA: 80273075568.22.4EE1BDE Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf10.hostedemail.com (Postfix) with ESMTP id C44BCC0005 for ; Fri, 23 Dec 2022 09:40:21 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Ygo1U0Eu; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671788422; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dYdCTqml4c7ljbUVU4kZcoEb18gRQ5azwzQzokRe0Yk=; b=plmL2gNV1pbXn/T1NYwtGW0NIuT+7XR2iGhYNfrteXwRvyUrpcckTv6xOkKdfqmoFkmnER nKwnAKqRxArw5MW/lm5sRdzmI1AjXbV25fltZ2d/kGGFABr0tE55tdsh51NB/ohC3/s3Z1 s3v9Xrfxqf2sUjW/0t1LmU0tZwcJlGY= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Ygo1U0Eu; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671788422; a=rsa-sha256; cv=none; b=NP8I7ZUH9vSk3JBur5rc1YHpaM9HqkJgxGruZeXtNdMHG8lDbXpxbKmd8+Y+LFA1inn/6T 28bjNJ5Xbi4C0wRKER2rOMiZaSj0G2qDjG/3UwYAHVg1Ao7MEVFFI63kuYnwVN5qx20qht t/W0kUsMZPOIYu8ywWLj+7yfa3oeGAg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1671788421; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dYdCTqml4c7ljbUVU4kZcoEb18gRQ5azwzQzokRe0Yk=; b=Ygo1U0EuA50agyZTLi2oC0eSDAeSC9IeKdpr6hgEaMHA3SCnXg+/Sxb/bEcKWEVgINJuzR xg2poEFjTbGKxD+Xzjy765+GvC0fQ1dtFHf1F6UqBWmlndXatNxGVN50zKxkrHPVY4P7Kr urvNzG3PBl574Gh/F9nt0jczuAh1S9U= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-230-2rdzdPw9NN-7jO0ltqNYVQ-1; Fri, 23 Dec 2022 04:40:19 -0500 X-MC-Unique: 2rdzdPw9NN-7jO0ltqNYVQ-1 Received: by mail-wm1-f71.google.com with SMTP id j2-20020a05600c1c0200b003cf7397fc9bso1992376wms.5 for ; Fri, 23 Dec 2022 01:40:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dYdCTqml4c7ljbUVU4kZcoEb18gRQ5azwzQzokRe0Yk=; b=L4frdg1AWuF3xbJuNCJmEKlD2jRWNaKJI/Fu/92fbzBYafgx6NQBlGaSbLXu2muXiz ELcJBJ1+JUyrJ98PIeMyVOKKoF3qeic/qjThI4ttYlKRI3mDoifltc9jYo6eWZhPP6P3 yKgQ5kRNx7Ap1JlzhRuhXZR/6khRBfSQnWh05uP4rEIau0yNRjNn7SyDTfnjAsoEw8JU EF37IDV0YAUDFOcVdhr0xNvZmc00Hn4iqlgYzmLkHnig4rGeHsQOfUq4QhosHV0XEanp l4YaXWeGPYteJ7/Bhvp/NAGmKM7kqThAIz+WCdzFjUegYyMUYEu7cPHwDGUo5EbVYVIR fkpQ== X-Gm-Message-State: AFqh2ko5rW0U6d4YY03p4a7Fb8qFIa4GkcGzpumOP0aayBkaF7SFsZtl 6svGMdbx0+9K57a5TNCPD0B25/BOGgsciYbIZkAZogaTMf9ZlDcqsgXa2yw6HdZjoNnEJcJlYyI HU3+nHwGdo44= X-Received: by 2002:a05:600c:3b22:b0:3c6:e63e:814b with SMTP id m34-20020a05600c3b2200b003c6e63e814bmr6654803wms.2.1671788418725; Fri, 23 Dec 2022 01:40:18 -0800 (PST) X-Google-Smtp-Source: AMrXdXtPQ3uPs0KjP5mtjfcVVsKM5D3DKI+aZQLipe0tFV+bETDeJScFVeATD1YLHh9iingWOI6IKw== X-Received: by 2002:a05:600c:3b22:b0:3c6:e63e:814b with SMTP id m34-20020a05600c3b2200b003c6e63e814bmr6654789wms.2.1671788418429; Fri, 23 Dec 2022 01:40:18 -0800 (PST) Received: from ?IPV6:2003:cb:c707:ab00:3d8e:16c4:a38d:2827? (p200300cbc707ab003d8e16c4a38d2827.dip0.t-ipconnect.de. [2003:cb:c707:ab00:3d8e:16c4:a38d:2827]) by smtp.gmail.com with ESMTPSA id o27-20020a05600c511b00b003c6f8d30e40sm9565434wms.31.2022.12.23.01.40.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Dec 2022 01:40:18 -0800 (PST) Message-ID: Date: Fri, 23 Dec 2022 10:40:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH] virtio_balloon: high order allocation To: Soichiro Ueda , mst@redhat.com, jasowang@redhat.com, akpm@linux-foundation.org Cc: virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kalutes@google.com, mhiramat@kernel.org, cwd@google.com References: <20221223093527.12424-1-the.latticeheart@gmail.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20221223093527.12424-1-the.latticeheart@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: C44BCC0005 X-Stat-Signature: ksbezcstttchk1r45jd54ih5r56ioiwf X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1671788421-942467 X-HE-Meta: U2FsdGVkX1+B9Uo4ZCmWr+pQvzH+83M10JuoqPeilnEBiP94DrfA2kW1UbUloImic9bkPMZBIDVUE9xeSuVVjRlJaxdZI2nk4eMClpj+F640VSgK653KvNei1dQ56Xb3mSRcDUYoAf7eTAmz6M1Z4oqoqPBrXDG6kGwJl+ihXLnAPcHsRafLtszzKTd7uA7iUyK36P7HnQArMCA9zaf0rgy3RrFHnV3m979MYxqQg+h+N1wGLSuo560nDzWJwCSE9nHaKZuGYeFQKsbVMu+FG3v6L/xN+tZMreUGYuWmK6oN6Vb1PMPIq977Wy0rT15HMANpMAhFH/FmF/M8bwQbAVjBSuu/sf6IrShyTQuIBDMojQNXavJ7tcGe4vyyBXH51ondZEttmm0Ee5oXaIyjX0Ta/OPZ4ciECCfxW0dM8nwnB+cDVO0JhU0UHDv4RQdxsbbDSkZRKUrIkIN90bXAcJV8f47VOYdvyMqP8xtuB1wTWy6XUtukwyHT5HePezP9B9FOb3RlYw7eprdtt0JjmbDP7YoZ2yVl8k4IO+LMvK0ykvZRBSPzKhQjSekbB/YRE1S3Hbd3Zoi4XpVazbMtgZSIm5Fd+RRZyVfVGUXUCAQQC2RxUUlMF+EjgTTayr9Mkm8gWosgHtl2IdGFtyo1JZD7XzlsDrBMe0AXSc0CVtMd45yk5i9kC8AAJ8UIrnyz2chpFbAewFuFNPiLLvgv6aTpWlX79EejSy99CYjD+5XjPBK/CbJ/8UJo+YjVEtEmtl8vlWvauRYuaIlXQb3B1M+JkfLDfOgcptCBvVeUJ9/2wEKRmb5MOAK4G6lFcEQNZNmn5Zy25I1bguUEHFBQbBYiWBtFyGG3LUiXoJSSEspmmvoMjReHWmQhvxfYPUxDIxx1aVkDcNO3wvlIY0S+FOq7k25yKeHRqoQUjsdczjUTmRVZ4yNW6RbzJvRQDts6VwnUjN3dgsE8WubujFp 6i8ogiZo 3OTVxW8qqMUgUb2PaELWLQsImCzUKT7FitbvYNVCKsREhgdP84GSy5wf79TmGq9diEAUzCDrbvzenjeJVfKjuqFXQApVKoke3F9e0tZUW6OTjn2erRrOXJPvh2f34cAXXsgJ1cjSYAjIF+VkmF2dv8VwbUSnl4yiVrjM0ErjBun2pVFnDhjN/usn+hgemlA30sy3sww60Wa6OntTPrVBjs4jV/r3IgcU9AsyFXI5HT7jG/Rz1Alnzfoitfc/kzPb02OyvXpI3UPerJm8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 23.12.22 10:35, Soichiro Ueda wrote: > At present, the VirtIO balloon device driver allocates pages > one by one using alloc_page(), and frees them using put_page(). > > This changes it so that the driver allocates high order pages > by using alloc_pages(), and frees them using __free_pages() if possible. > By doing so, the CPU performance of inflation and deflation > should be improved. > > The effect of this change has been confirmed by benchmarks that measure > the elapsed time of inflation and deflation. > > The results are here: > > 16 pages inflation: > before: 119,779 ns > after : 115,655 ns (-3.4%) > 64 pages inflation: > before: 156,977 ns > after : 150,961 ns (-3.8%) > 256 pages inflation: > before: 218,649 ns > after : 208,490 ns (-4.6%) > 16 pages deflation: > before: 78,112 ns > after : 68,288 ns (-12.6%) > 64 pages deflation: > before: 97,205 ns > after : 80,491 ns (-17.194%) > 256 pages deflation: > before: 122,742 ns > after : 107,526 ns (-12.4%) How does this affect page migration / balloon compaction etc? -- Thanks, David / dhildenb