From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A87EFC3DA49 for ; Tue, 23 Jul 2024 18:52:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 08F9A6B009B; Tue, 23 Jul 2024 14:52:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 03F946B009D; Tue, 23 Jul 2024 14:52:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E49386B009F; Tue, 23 Jul 2024 14:52:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C80406B009B for ; Tue, 23 Jul 2024 14:52:54 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 2C71A1C0B5A for ; Tue, 23 Jul 2024 18:52:54 +0000 (UTC) X-FDA: 82371914268.25.F0023A4 Received: from mail-ot1-f44.google.com (mail-ot1-f44.google.com [209.85.210.44]) by imf07.hostedemail.com (Postfix) with ESMTP id 4168040008 for ; Tue, 23 Jul 2024 18:52:51 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=IsQdIFgf; spf=pass (imf07.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.210.44 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721760724; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=W+1U6RJ2NItPVIrD/Ztovzd5skJgdRj4cfCS6MVn2qs=; b=L9HvvnhRcRmkFk0dnoI+/0nOupzLQuRp2G+7P8R9KLqF7JNENZF00lBG95Y5uFQg2iFrCo 2q8Qk55uhGUMGfKKKU6FozZ28i3oOXAu7VNivNnijLNWXs4AJzTbNZc4Tf8S+DMD7JgFAF v0T6XhCM4GT5wAhf+UaxY2JvYnlUk54= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721760724; a=rsa-sha256; cv=none; b=6c8DIKNmpPvIuK1ASOMDiAdkhQ2//tYfwE0MzpSfmfvI3Pha8zA67c/t2/3b/59oWm+U/c we51XqqGgDqKT7VJKjB6CSMobc7QykIjSOigjXwwkQP/GicB4bDwGU13MYm/WTRCCd9q2a 4/taRToS2X7PFaF/b2OJpbK2iA6QW3o= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=IsQdIFgf; spf=pass (imf07.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.210.44 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org Received: by mail-ot1-f44.google.com with SMTP id 46e09a7af769-704494efa7cso2991879a34.3 for ; Tue, 23 Jul 2024 11:52:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1721760770; x=1722365570; darn=kvack.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=W+1U6RJ2NItPVIrD/Ztovzd5skJgdRj4cfCS6MVn2qs=; b=IsQdIFgfrLcB+yKd5TYRqSRWVJqWtYu2eU+nBhchqjNYflxR56WV/iqkLax0ERiSPj UbOx6lzLUu+JHclN009wyfmx0m44jvKFPARrH4/f7d4cx/vxBt9r/9LYtyC9w2VGEPjg 3DhDpIBB0zpe06U8jNxubFE212z/j1JEMvjR13UxlxiShyKgtG/oZXyGWUNl+ZBVCPtY D49H+39BAnge5ypJLPzrW9opsrSe3ERQ9uqom+2Tc1OEI5yWydi4uhT1Ffn2fXDwEd6c yG5J7qGNGrZi0GBctATJnBR/1qeC1G4LM/jXOSOQsop1VMRJLORPfd0x+zQouCwiNeYi lTRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721760770; x=1722365570; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=W+1U6RJ2NItPVIrD/Ztovzd5skJgdRj4cfCS6MVn2qs=; b=c4ESgAdL3/H40TVjd6qrPIBp1T9/2ierU+Gc8cKTrpENVW+RpmdX7ipD96VaIiqMGF ajXub7JP28moWgLjgE13YpZUTDSHH9rGEmAeLYGkeYRakgTktneoxFd5nGIZuFindWYF LkqwgMH6m0vUWzBTzw/4xTyPcFbPoAQAjvAcawt7xbqtYVocakCp7FPjr4hCTw3w/x9V M+/2zfIV0tjquQjNVCf0RBoAZoyeUcEne+6Bz+lIg2ITDa8d2c3/C6Y1sS99svw3t3sn GmwgQ8Or5auLz2Q5v9U2s/TWgOJTfT/AkBVJRXPbWF+AvCuNKjJFtydKIb3dpUZsrN0w Md6g== X-Forwarded-Encrypted: i=1; AJvYcCW3WXOVjafpWjPz8CRXH7asHTBxBV+KhJU+jcsM8JvJsIWQ3YDR6mudYzlYwDti0f2Bguraq7IdTv+JKe8MOl5tSPs= X-Gm-Message-State: AOJu0Yzrq3gzhKz2Ci2gtdPnAhoVaKc+KMcgLfSLLM0NawVNwG2iRS5L IYedUuo/PIpy8nQ12lh57cpUqXKx7+cSkPde2ObOa6ZTn0e11gZb/fTfSfT6QU4= X-Google-Smtp-Source: AGHT+IGNMEVlXB+5zF7wMl4AQKl28uLYFF74Cz7JAMAkx3CgLRP/W1EKqF1VK3V37/dX1OppY8KC/A== X-Received: by 2002:a05:6870:891f:b0:261:e19:4587 with SMTP id 586e51a60fabf-264876023demr605282fac.6.1721760769894; Tue, 23 Jul 2024 11:52:49 -0700 (PDT) Received: from localhost ([2603:8080:b800:f700:eca3:bb93:d28d:1005]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2642ca952d0sm1730446fac.37.2024.07.23.11.52.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jul 2024 11:52:48 -0700 (PDT) Date: Tue, 23 Jul 2024 13:52:46 -0500 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Matthew Brost Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Nirmoy Das Subject: [linux-next:master 13298/13495] drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c:183 send_tlb_invalidation() warn: variable dereferenced before check 'fence' (see line 178) Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Stat-Signature: 89sfe6tddstz7fg3t51cxc8d6chxq6a3 X-Rspamd-Queue-Id: 4168040008 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1721760771-504987 X-HE-Meta: U2FsdGVkX19jCYm+2lz4/rNYWQAZqWx/wTDscLXtfZGixOcdSlOQVNY7HLNyvvWsZAR10SDvs+0Wvfb8xfNSDduOiuG9ezdvaB43MdUgbHL+GmW6cfIu8k9dts/o6okONtEfo1S1cpU7uLFOoI9mYbamZCwBhSARhK/jtv8dzgW3Qb74XQkZo4fOcbyute2Qvase+i9D1oNTN54DfID1+CSYT3IGhs+t8ipyzG3ORAmO13OTJnKEZwQzR+LyMhWBCxFzGbv3q+fq3OF3QcicA/MFuMPCKWmL8C1wgNXXx9DbhivFIGDaItO57po8v2ws9weRqjouFMs1wG7r6UeJu0UL+DLAfu0jPXmZ//d/WPb4oSTAn04oGbibxrkUfCgiOOWqQPzD/1zsUzxpmpfpkMZI1j+Zf/OWCBiVyUtHHYbE8s5sOPk4/xGzyZu5gAnx3guFtG2JeQefQxr9WgJHGGVwDrLTpL6SaJfwVdlZ2cY/kY+pZfEQ4wD9otCbqM6eJD8C35i7Uk3o7b0nSnvo96igueKTVvAT4S1ya92AMag8jMTyfL8m5dof4w2MuE3pVnWsG8RMp7htxVKp44oiFtMU896h/i3OYWyMCE57fVajkHxeELuyHlZ+Sf9LsGd1SkZM9gvWR84sbKIg5nez4bKNbTMaoinWm5deZ4AdoFXSxVBB8QtxGLmD6ElIlZDdxkgEKJuVMZhQPAeo7DE7SDOGzB6k/FAjOPzyLhMnSY8AxN6ESQIio4UqwYqg+jaAVcLczI5Ap0+RxsH2+kU7k3T7jqP7L4M2X1UY8/zVrVy84SXhZhwGxXpam8Qh/x4dVkiOuR/2WNpX7tFUwyjePXOxhvLAs5ASYAN/osFiDaMsx641e6xlrCh8dEOaq5jAcWav36+jdW6PlnxaODgFpOCury4WG5z+QH51AB9a7UOf0UZP0vAyJCH2usLeDi/hoNG+pWutcgZVUSN0Ny8 BgMCFwxy gCSAVsheQJl4r/KBZpukx0gNBkBzTDRxh3MKCx8fKIkVmjBBZGZz/iyC7oAvRXJar+qRtlxwLrDWvJkfQPQ2AIKQNCqCa2YR10Z2sRYFBUT+DBdmdUWLugKE4uRleLm2hdpzxPmVssIsF5Q7YgsxsY282uKdydoNlJ+0FHXFNTxb4e4zgojhyHqGYjuoZ3W24Luow4m6vNBdB6+k8EniySo2VJ7PulWyg1+DeTOkpGHmMHzjFcf0nuiOm5MkEYLhrx3DaSuBIwFnKTQfd+8Nbk4IzU+hx9vgtsdLqHJoqmoVBRSxNrQzzaB4BCi13ZEt9FRIrfNzcPPdIuZ9xRkpEnJ0JaX0GHxbvV5J5pMjVtm065ouQxUk1Mg93sequKQa72ZiO489g8XSBaT0WNLGO+8sQdVPft5jc5xZl3fYPRsNoZyEFkpJ57oQRHSvSX8ajAUOv13ZjUS2fugyJHrCKmRWAY95QAvpFIe+fKDMqSKC37+UbDej6iCVZrnExdHS0lE9/4/jc5PLaDGk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: dee7f101b64219f512bb2f842227bd04c14efe30 commit: 61ac035361ae555ee5a17a7667fe96afdde3d59a [13298/13495] drm/xe: Drop xe_gt_tlb_invalidation_wait config: i386-randconfig-141-20240722 (https://download.01.org/0day-ci/archive/20240723/202407231049.esig0Fkb-lkp@intel.com/config) compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202407231049.esig0Fkb-lkp@intel.com/ New smatch warnings: drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c:183 send_tlb_invalidation() warn: variable dereferenced before check 'fence' (see line 178) vim +/fence +183 drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c fc108a8b759f52 Matthew Brost 2023-01-17 159 static int send_tlb_invalidation(struct xe_guc *guc, 332dd0116c82a7 Matthew Brost 2023-01-24 160 struct xe_gt_tlb_invalidation_fence *fence, 332dd0116c82a7 Matthew Brost 2023-01-24 161 u32 *action, int len) a9351846d94568 Matthew Brost 2023-01-17 162 { a9351846d94568 Matthew Brost 2023-01-17 163 struct xe_gt *gt = guc_to_gt(guc); 501c4255c40935 Radhakrishna Sripada 2024-06-07 164 struct xe_device *xe = gt_to_xe(gt); a9351846d94568 Matthew Brost 2023-01-17 165 int seqno; a9351846d94568 Matthew Brost 2023-01-17 166 int ret; a9351846d94568 Matthew Brost 2023-01-17 167 61ac035361ae55 Matthew Brost 2024-07-19 168 xe_gt_assert(gt, fence); 61ac035361ae55 Matthew Brost 2024-07-19 169 a9351846d94568 Matthew Brost 2023-01-17 170 /* a9351846d94568 Matthew Brost 2023-01-17 171 * XXX: The seqno algorithm relies on TLB invalidation being processed a9351846d94568 Matthew Brost 2023-01-17 172 * in order which they currently are, if that changes the algorithm will a9351846d94568 Matthew Brost 2023-01-17 173 * need to be updated. a9351846d94568 Matthew Brost 2023-01-17 174 */ 565ce72e1c2d54 Matthew Auld 2023-05-24 175 a9351846d94568 Matthew Brost 2023-01-17 176 mutex_lock(&guc->ct.lock); 62ad062150c2ab Matthew Brost 2023-01-17 177 seqno = gt->tlb_invalidation.seqno; fc108a8b759f52 Matthew Brost 2023-01-17 @178 fence->seqno = seqno; ^^^^^^^^^^^^^^^^^^^^ Dereference 501c4255c40935 Radhakrishna Sripada 2024-06-07 179 trace_xe_gt_tlb_invalidation_fence_send(xe, fence); a9351846d94568 Matthew Brost 2023-01-17 180 action[1] = seqno; 332dd0116c82a7 Matthew Brost 2023-01-24 181 ret = xe_guc_ct_send_locked(&guc->ct, action, len, a9351846d94568 Matthew Brost 2023-01-17 182 G2H_LEN_DW_TLB_INVALIDATE, 1); 38224c00d9c284 Matthew Brost 2023-01-24 @183 if (!ret && fence) { ^^^^^ Checked too late 35c8a964398e1c Matthew Auld 2023-07-10 184 spin_lock_irq(>->tlb_invalidation.pending_lock); 35c8a964398e1c Matthew Auld 2023-07-10 185 /* 35c8a964398e1c Matthew Auld 2023-07-10 186 * We haven't actually published the TLB fence as per 35c8a964398e1c Matthew Auld 2023-07-10 187 * pending_fences, but in theory our seqno could have already 35c8a964398e1c Matthew Auld 2023-07-10 188 * been written as we acquired the pending_lock. In such a case 35c8a964398e1c Matthew Auld 2023-07-10 189 * we can just go ahead and signal the fence here. 35c8a964398e1c Matthew Auld 2023-07-10 190 */ 35c8a964398e1c Matthew Auld 2023-07-10 191 if (tlb_invalidation_seqno_past(gt, seqno)) { -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki