From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 796F9C636CA for ; Fri, 16 Jul 2021 10:05:50 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 22A09613F2 for ; Fri, 16 Jul 2021 10:05:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 22A09613F2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6942F8D00F5; Fri, 16 Jul 2021 06:05:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 643C58D00EC; Fri, 16 Jul 2021 06:05:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4E4F58D00F5; Fri, 16 Jul 2021 06:05:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0213.hostedemail.com [216.40.44.213]) by kanga.kvack.org (Postfix) with ESMTP id 2CCEC8D00EC for ; Fri, 16 Jul 2021 06:05:50 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id F0BFF8248047 for ; Fri, 16 Jul 2021 10:05:48 +0000 (UTC) X-FDA: 78368019576.20.25BF447 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf04.hostedemail.com (Postfix) with ESMTP id 882AD50000A3 for ; Fri, 16 Jul 2021 10:05:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626429947; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=d+47a2m62uOqKTxHt/Ok6yZAAE0QOF2ZStyoz2+5Ezo=; b=L1WMxsF+XS40Ueb2bmZ7uzuW1J0t7QeQ8YhwUD06SPnoviuSibSO9Z0xFRZ6zjFxIomwX0 jvbGCvvZ2xmjoBcvyF+jnUDZxhhRqY2TA/Um7WyCo41cA0le9vYZzBiOlsFyvDvyeyE1D3 cWE4bZy6D7/Bg8e+0Nz4sKBlc2VTQho= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-557-g3c3Kg3tN-CG1e_n4ONiOw-1; Fri, 16 Jul 2021 06:05:46 -0400 X-MC-Unique: g3c3Kg3tN-CG1e_n4ONiOw-1 Received: by mail-wm1-f70.google.com with SMTP id v25-20020a1cf7190000b0290197a4be97b7so2973764wmh.9 for ; Fri, 16 Jul 2021 03:05:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=d+47a2m62uOqKTxHt/Ok6yZAAE0QOF2ZStyoz2+5Ezo=; b=fws0KpIdCnt09V2CIYIXxhfbjIJ1BtmQ0rnB7I/KdWEfbGqjmTevLr0Kvs+gBQoUZs mRkpOoBMgjus21UzgN392GCtDqO5/jgqwfO+ivQdEIf3Qnk4LUPKr73Pyi09b7l1qA+9 NsUOiQSw2lQF3rtMPHcCzSvB5Pu25MM2qCDzRsfGEdQxM4E3WMOQy6LzNza3hHB0Wi02 62/9iUCWj2THsyscBfpXwCOsES5634HqTtl5xiw/KWPnNXBfP7mvMbwMzk5Xd1AqrkLT l/REF4LMLyOfYuvIs3Tn+2oCTslFLn+JE0PB+12yrYHDpu9kSDnn/Jw7jsfUryNMzRFM SSwA== X-Gm-Message-State: AOAM530V94EsaieyJ/dhmSg09OpwDXxWgAelmkz64NZ0WRaJYRQstshJ S1ovkrorl//jxvpeFeJGCRAlY3c6moADUyyUFtrBpZ0iea7J++X5MqSh1GBnACbztOs7Ex5pV19 xGMX6oDtAvbg= X-Received: by 2002:adf:9d88:: with SMTP id p8mr11718863wre.409.1626429945366; Fri, 16 Jul 2021 03:05:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzbCXasxdeDcHr9sKxyFrSXAWSG40s1WMX8Y45RxCT00l50KFWUWt0ncWOiKWOqa8XfRu5ADw== X-Received: by 2002:adf:9d88:: with SMTP id p8mr11718842wre.409.1626429945183; Fri, 16 Jul 2021 03:05:45 -0700 (PDT) Received: from [192.168.3.132] (p5b0c621f.dip0.t-ipconnect.de. [91.12.98.31]) by smtp.gmail.com with ESMTPSA id f13sm10196399wrt.86.2021.07.16.03.05.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Jul 2021 03:05:44 -0700 (PDT) Subject: Re: [PATCH] mm/secretmem: wire up ->set_page_dirty To: Mike Rapoport , Andrew Morton Cc: Mike Rapoport , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20210716063933.31633-1-rppt@kernel.org> From: David Hildenbrand Organization: Red Hat Message-ID: Date: Fri, 16 Jul 2021 12:05:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210716063933.31633-1-rppt@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 882AD50000A3 X-Stat-Signature: jh9tnmnchcjxqdngrngn4fp53ja8f6xm Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=L1WMxsF+; spf=none (imf04.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-HE-Tag: 1626429948-719923 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 16.07.21 08:39, Mike Rapoport wrote: > From: Mike Rapoport > > Make secretmem up to date with the changes done in commit 0af573780b0b > ("mm: require ->set_page_dirty to be explicitly wired up") so that > unconditional call to this method won't cause crashes. > > Fixes: 0af573780b0b ("mm: require ->set_page_dirty to be explicitly wired up") > Signed-off-by: Mike Rapoport > --- > mm/secretmem.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/mm/secretmem.c b/mm/secretmem.c > index f77d25467a14..030f02ddc7c1 100644 > --- a/mm/secretmem.c > +++ b/mm/secretmem.c > @@ -152,6 +152,7 @@ static void secretmem_freepage(struct page *page) > } > > const struct address_space_operations secretmem_aops = { > + .set_page_dirty = __set_page_dirty_no_writeback, > .freepage = secretmem_freepage, > .migratepage = secretmem_migratepage, > .isolate_page = secretmem_isolate_page, > > base-commit: e73f0f0ee7541171d89f2e2491130c7771ba58d3 > Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb