linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: Mike Rapoport <rppt@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: Mike Rapoport <rppt@linux.ibm.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/secretmem: wire up ->set_page_dirty
Date: Fri, 16 Jul 2021 12:05:43 +0200	[thread overview]
Message-ID: <c8977f73-d7eb-9a81-4667-ad9302130200@redhat.com> (raw)
In-Reply-To: <20210716063933.31633-1-rppt@kernel.org>

On 16.07.21 08:39, Mike Rapoport wrote:
> From: Mike Rapoport <rppt@linux.ibm.com>
> 
> Make secretmem up to date with the changes done in commit 0af573780b0b
> ("mm: require ->set_page_dirty to be explicitly wired up") so that
> unconditional call to this method won't cause crashes.
> 
> Fixes: 0af573780b0b ("mm: require ->set_page_dirty to be explicitly wired up")
> Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>
> ---
>   mm/secretmem.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/mm/secretmem.c b/mm/secretmem.c
> index f77d25467a14..030f02ddc7c1 100644
> --- a/mm/secretmem.c
> +++ b/mm/secretmem.c
> @@ -152,6 +152,7 @@ static void secretmem_freepage(struct page *page)
>   }
>   
>   const struct address_space_operations secretmem_aops = {
> +	.set_page_dirty	= __set_page_dirty_no_writeback,
>   	.freepage	= secretmem_freepage,
>   	.migratepage	= secretmem_migratepage,
>   	.isolate_page	= secretmem_isolate_page,
> 
> base-commit: e73f0f0ee7541171d89f2e2491130c7771ba58d3
> 

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Thanks,

David / dhildenb



      reply	other threads:[~2021-07-16 10:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-16  6:39 Mike Rapoport
2021-07-16 10:05 ` David Hildenbrand [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c8977f73-d7eb-9a81-4667-ad9302130200@redhat.com \
    --to=david@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=rppt@kernel.org \
    --cc=rppt@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox