From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1FC0E77188 for ; Fri, 3 Jan 2025 15:49:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3D8496B0082; Fri, 3 Jan 2025 10:49:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3882D6B0083; Fri, 3 Jan 2025 10:49:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 24F426B0088; Fri, 3 Jan 2025 10:49:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0669F6B0082 for ; Fri, 3 Jan 2025 10:49:52 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 711D8140870 for ; Fri, 3 Jan 2025 15:49:52 +0000 (UTC) X-FDA: 82966573620.03.780FD33 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) by imf23.hostedemail.com (Postfix) with ESMTP id 35D7314000A for ; Fri, 3 Jan 2025 15:49:14 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=M7Vz58WT; spf=pass (imf23.hostedemail.com: domain of dave.jiang@intel.com designates 192.198.163.12 as permitted sender) smtp.mailfrom=dave.jiang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1735919366; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jEF2lE+t+6xHP96g3v6xQjb10CXSHIJ/9MMztT9ExQc=; b=RHMvvruZjxSK6EfUXqN4koXZodVhjZ4kgCnfA9yPYYoxi8naQGWud5Jzfr8txwKe2PFiOT Fu56cM0TLfSxARBBCRJ0Gvj3HQ4fdyclX6uz8zu+Vb5pyEySiOWdjWBqa2EHahuHU2MShm kzUoy5hQprZUFF0vmv1KXuExsZ47szc= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=M7Vz58WT; spf=pass (imf23.hostedemail.com: domain of dave.jiang@intel.com designates 192.198.163.12 as permitted sender) smtp.mailfrom=dave.jiang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1735919366; a=rsa-sha256; cv=none; b=Oxe0oxLtEj10OACtLoKYs9zKQkaHxn65vs09jBjLT353t1ERXpvKegxKiu/xvVKIZIm+YJ 82qprB3/lBpAzYQfAtipsJMmd9a+DfWq1w8UvBtHgpAjPZUDK/U6oJB6Oa8zkpYuWSlloO 5FhTjS4Ivmbon0FK9xhwcovds06nf3c= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1735919390; x=1767455390; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=1M6cKi7PT9clm8YB/qYa2Ju4pXO80UrAsUJC1DPmJBg=; b=M7Vz58WTzNRB9x73BaINnGzE9pZIbuL8NDnM9HgDYmMSjFVc5XT1k9Cl 08WeMp3y2oBBLettNs1XhdqCPLn2TDciZfJJhy67pphS6czLgD6J5Rzi7 n4Q+Edeb4bCL0O7mwIj3xYHXoemveYrQYv5qDrQ0YAkWmI3R4b9Kircck Pyi3oUQTFxiQhITU8pMe+qn2CvoJU1l3RxIPGkBnZkvhgHTGaMe5bM0dV 07hBejY3ME3L2gX2ENFMSTlgnQWGH2QkM5LVbR0zNdv46HCSATEhvaN5y J26IivtCI/K5Nvh4mP/9ti0J1arMt55imbh0yhmdPsGfGAI2KMbGJ7hG+ Q==; X-CSE-ConnectionGUID: BJ/NZY3KT9q2Xa8F+RoI1A== X-CSE-MsgGUID: hr9hpdBjT42Fy7pwzCq02Q== X-IronPort-AV: E=McAfee;i="6700,10204,11304"; a="40095152" X-IronPort-AV: E=Sophos;i="6.12,286,1728975600"; d="scan'208";a="40095152" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jan 2025 07:49:48 -0800 X-CSE-ConnectionGUID: cqjjp0lqTluA/TIGnYXdcg== X-CSE-MsgGUID: ve/dGZInQMmW3/WppMVc+w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="132739840" Received: from dnelso2-mobl.amr.corp.intel.com (HELO [10.125.110.13]) ([10.125.110.13]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jan 2025 07:49:45 -0800 Message-ID: Date: Fri, 3 Jan 2025 08:49:44 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v17 00/18] EDAC: Scrub: introduce generic EDAC RAS control feature driver + CXL/ACPI-RAS2 drivers To: Jonathan Cameron , Borislav Petkov Cc: shiju.jose@huawei.com, linux-edac@vger.kernel.org, linux-cxl@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, tony.luck@intel.com, rafael@kernel.org, lenb@kernel.org, mchehab@kernel.org, dan.j.williams@intel.com, dave@stgolabs.net, alison.schofield@intel.com, vishal.l.verma@intel.com, ira.weiny@intel.com, david@redhat.com, Vilas.Sridharan@amd.com, leo.duran@amd.com, Yazen.Ghannam@amd.com, rientjes@google.com, jiaqiyan@google.com, Jon.Grimm@amd.com, dave.hansen@linux.intel.com, naoya.horiguchi@nec.com, james.morse@arm.com, jthoughton@google.com, somasundaram.a@hpe.com, erdemaktas@google.com, pgonda@google.com, duenwen@google.com, gthelen@google.com, wschwartz@amperecomputing.com, dferguson@amperecomputing.com, wbs@os.amperecomputing.com, nifan.cxl@gmail.com, tanxiaofei@huawei.com, prime.zeng@hisilicon.com, roberto.sassu@huawei.com, kangkang.shen@futurewei.com, wanghuiqiang@huawei.com, linuxarm@huawei.com References: <20241122180416.1932-1-shiju.jose@huawei.com> <20250103114109.GAZ3fM1dEsyBSn9lWA@fat_crate.local> <20250103130213.00006abd@huawei.com> Content-Language: en-US From: Dave Jiang In-Reply-To: <20250103130213.00006abd@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 35D7314000A X-Stat-Signature: qtruop176hzfkabgiy9febz54giq7ui8 X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1735919354-161967 X-HE-Meta: U2FsdGVkX18GFOTwTlMxYi0SSYZC4zhEsrP0ClkyAXkAL6BHd9xaWJNhrP4C14g0BC3ezdkzA9UPBjXwFRdGA0Cyj/8M9emqcKbo+KzhNK1CdrtyImmLxbFT8kcVw+HBYMqpz0He5whnzRE1tFUJf3vzltVGlMPFRpz3hY57Jem60AZ9it8JTpkQQQVB0lLmOfhtybgZ5TKIfU4NlXNfkIEXUbNF78v05G6mDVWKGmoBRdxDfdmVUdIslTNffP5toM1gJnli/BGrsHo9XIakLo9tbMerXyH0N1dvu8hv2JHVkHX0iNX8KFBfn0vFhR/qSVNgahoRLfPLwvB8NZ6R9rQ7m/8S/QQoF7tE9Cjjv66QXaZe4ZyX5fF7ehocmClJs0WLvepoUn483rTZw8DJQb915Dv7Xgzp1nOxFuIZhJaU0H+GQhvlKK/htGA/Cu4/C8xV/6Fwhv2sBkFzyc9PsPwA9tY8ilCFyRJ5a7UwNt7ZGVCGSZaAYB+2AX6oyWIT4t81AandiMbEhpY/+8lKXceBj0LfbunhBGuyu4tDuDCYfo1CNmaaz05Q4KCGcn8/VE4/011MEa/L7sOigxtrPmEURQygXjrT4XHXundNBldX1hIByaFXD0Jq7wAlu/1WLoYsoTelRJBVlJfkyHfXiz7tBazZ0RqqbCgHEYDJn1Ujf6oratQCHRDCAGuROQ75KA5Ya5osc13sVNf1hRlLi3nUYLyeyG8qFHAQS/Rg2lujLdc/AirUIBteE9l8yfGioLSHU4F2LzEfqX5E3vFERcH0InYcH8tQWRbjePnwUWoBzaUiz7iY14TRr/FFCk11TjBqL6DfmANjd3waKlcCggKth1fYmM9txvDkD8EEtQ/v4ntXRZXX79j2VJArtN9zn75IwIrxXRD0N1dyNW+DwHYLn0kYZQnoCj8y7Onjrmt/moTiOQUDigSl6fYTDbLaUq1mV0mb0D5vY/eRkwa orh9sdq6 /on9tA5ibCpGQ8qwz4f/Y5gKyFwM/X5x71sFAY/0DclzFWDsSfaUQyP3bEwHOaXyrPVlhY2FWwYDTqh68O/4uQF7SoLtTcCkYaOy+8dwn3Cq0+Xh42LukKT9YGcLKoiV72levDw85vtgvNb6zDMJo4TZ30v3rxpp1v0Df4Tnz/enul3e9M4prhX0FEX5VajCQQ6UNQEXdc2APG2wQL1xq4a4soEhhLASDBlevVC5iV8vRd+LX4qkVfAxTlDRwlyi3yUZUtFKmt9KAJzfs2xst6v+XQGFoOfPXutOAXqDbhCMwm3Q= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 1/3/25 6:02 AM, Jonathan Cameron wrote: > On Fri, 3 Jan 2025 12:41:45 +0100 > Borislav Petkov wrote: > >> On Fri, Nov 22, 2024 at 06:03:57PM +0000, shiju.jose@huawei.com wrote: >>> drivers/edac/Makefile | 1 + >>> drivers/edac/ecs.c | 207 +++ >>> drivers/edac/edac_device.c | 183 ++ >>> drivers/edac/mem_repair.c | 492 +++++ >>> drivers/edac/scrub.c | 209 +++ >>> drivers/ras/Kconfig | 10 + >>> drivers/ras/Makefile | 1 + >>> drivers/ras/acpi_ras2.c | 385 ++++ >>> include/acpi/ras2_acpi.h | 45 + >>> include/cxl/features.h | 48 + >>> include/cxl/mailbox.h | 45 +- >>> include/linux/edac.h | 238 +++ >>> include/uapi/linux/cxl_mem.h | 3 + >> >> So what's the plan here? Am I supposed to merge the EDAC/RAS bits through the >> RAS tree and then give folks an immutable branch or how do we want to proceed >> here? >> > > Dave Jiang / Rafael, what would work best for the two of you? > > To me Boris' suggestion makes sense, particularly as that > avoids the complexity of CXL get/set features being in multiple series. > > I think the split that would make sense is: > > EDAC immutable branch for: > 1: EDAC: Add support for EDAC device features control > 2: Add scrub control feature > 3: EDAC: Add ECS control feature > 15: EDAC: Add memory repair control feature > > ACPI merges EDAC immutable + > 13: ACPI:RAS2: Add ACPI RAS2 driver > 14: ras: mem: Add memory ACPI RAS2 driver > > CXL merges EDAC immutable + > 4: cxl: Refactor user ioctl command path from mds to mailbox > 5: cxl: Add Get Supported Features command for kernel usage > 6: cxl/mbox: Add GET_FEATURE mailbox command > 7: cxl: Add Get Feature command support for user submission > 8: cxl/mbox: Add SET_FEATURE mailbox command > 9: cxl: Add Set Feature command support for user submission > 10: cxl: Add UUIDs for the CXL RAS features > 11: cxl/memfeature: Add CXL memory device patrol scrub control feature > 12: cxl/memfeature: Add CXL memory device ECS control feature > 16: cxl/mbox: Add support for PERFORM_MAINTENANCE mailbox command > 17: cxl/memfeature: Add CXL memory device soft PPR control feature > 18: cxl/memfeature: Add CXL memory device memory sparing control feature That works for me. DJ > > That does mean that the actual drivers/edac/ specific drivers land > via the ACPI and CXL trees only, but without another layer of immutable branches > we can't avoid that. Might cause merge conflicts in Kconfig/Makefiles but otherwise > shouldn't be too bad. > > There is going to be some noise in documentation as examples are added > to the docs with the actual drivers (whereas generic docs are introduced > with the infrastructure). I think that will work out though. > Shiju, could you spin this ordering up and check it all works > (incorporating Dave's updates to the GET / SET feature)? > > Thanks, > > Jonathan