From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD540C4345F for ; Tue, 16 Apr 2024 03:20:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 403AF6B008C; Mon, 15 Apr 2024 23:20:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3B3FF6B0092; Mon, 15 Apr 2024 23:20:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 254A46B0093; Mon, 15 Apr 2024 23:20:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 05AD06B008C for ; Mon, 15 Apr 2024 23:20:28 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 985501608A6 for ; Tue, 16 Apr 2024 03:20:28 +0000 (UTC) X-FDA: 82013942136.25.BDC9E7A Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by imf14.hostedemail.com (Postfix) with ESMTP id CA259100003 for ; Tue, 16 Apr 2024 03:20:25 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=WThOdZJX; spf=pass (imf14.hostedemail.com: domain of pizhenwei@bytedance.com designates 209.85.214.178 as permitted sender) smtp.mailfrom=pizhenwei@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713237626; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+lHv0WjSUS0/ZTvnK4A3g1boJSBNj3lLffVIsFdrOUs=; b=t/kl+H4RLNkZtsp8gRFfhAcoiN8BIW+oGgvCjD6PoE2CwLf9uiuwdBrkXZS1F79OHtA4Ep 9yW2830Ep/LH8ASSlDe3h5hXRQDEx59Xih3sBRxE5SXyaOyuuB3Fr5eWSTkz6vj55XpgiG gqp3KC0d1xQb1XClgtLtAWY4irqwlYg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713237626; a=rsa-sha256; cv=none; b=jQltUt+mSl/Ij8itXGZb2CG8VAUazG9D1nLM79/Sw46NI5XjDIhXy7rD45gz7gmkGNpovV kVyb36KWQX0dVD19gRPO5/xO1MQOQyMt5I3/fIRjqBkBwEI7FvIPU+qt5l02G4ZZnGgHnn +izvha9WCD+GO41NXTi/LAT2D1Konrk= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=WThOdZJX; spf=pass (imf14.hostedemail.com: domain of pizhenwei@bytedance.com designates 209.85.214.178 as permitted sender) smtp.mailfrom=pizhenwei@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-1e3ff14f249so30171485ad.1 for ; Mon, 15 Apr 2024 20:20:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1713237624; x=1713842424; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+lHv0WjSUS0/ZTvnK4A3g1boJSBNj3lLffVIsFdrOUs=; b=WThOdZJXwtbJfPT+PADofLb9T//6aLiNAqraiIY3EewzClQSwalmGuW2x8vZsTL89c JTCZm2nxV07z4K8rfWLR1RrkaxTfn6H5R3qY2q1aCwEf8Gg0BTsiEMtyBdxpvt+OeHyb VXb3kik7y5JDlDJXx7ibmRAmPLS303KGdeS7IP0J6tplup75hFT44EJ+/f32+4qVb2XS fSkdLznRVhJ5PF3W8Fpd6jaKQ7N2vvfsKZaAWQQdTeysyDUN9GndbY5TYHFi98PyMCEo mhj46Va6m9vjNT5rq3GShw51e3Wx57X0vTikqU8Bl9NJdC+JHeWN+tS9EmHgvc38SbXp ltQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713237624; x=1713842424; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+lHv0WjSUS0/ZTvnK4A3g1boJSBNj3lLffVIsFdrOUs=; b=BqICXb7aCyru3tFnbNTrAE2BYFsx+KmWSWjOG0QRuoe8iUWZRvSlH/qw9rCgIR9me6 ENFucbnCxiiuPyrFC3XWNS5PzJV54DE/wmhOD8tvO4wjmFafDmJEovM94DfQRCHPqcCE S08+RGY24Lnkrc/93SWnlf4DzbXTSnNAoZeflqICFXxxS7KQTrTFWqvWKtW+MAZZY717 Ed3411/QLROWx05pZhWBk3s03ukkots+oGwmZkKLVXQK8TYTc7N6x7k/lWgk5asCs/MW Xtt+aHh6rlcSvUsrOvYJJDSB01R9d0MRPjNbGeVOFC3iQ9HVPqG6oED+Dz7WWFc67XLt pBwg== X-Forwarded-Encrypted: i=1; AJvYcCX2WZjpZi5Xrr5xi1WG0YSHhuAuTWC5MGhWxv7A0qBw43Rk4tOS2YPDJiUZLtuJrWRzWbgXR6hF9Q1BVlcf3U9rZRM= X-Gm-Message-State: AOJu0YwV/fteK0kS80xtvv/G3/L4MCdMGx9dBAbD1xheA1LkR7Cx0mSs U/IbQRgo9GYxmZsDYbxhZR6xMwbTI/fuS2Ioyb5tbkz+FbDOtH/iiJzBUFG1qkY= X-Google-Smtp-Source: AGHT+IGkkCHrVas2WX9GNLxY+hWNmIALkljn0FUFyXThYhisWj9SErZLdlVT0OL3IKHgguvcHYHNDQ== X-Received: by 2002:a17:903:41d0:b0:1e4:53b6:6be with SMTP id u16-20020a17090341d000b001e453b606bemr2302239ple.1.1713237624396; Mon, 15 Apr 2024 20:20:24 -0700 (PDT) Received: from [10.3.43.196] ([61.213.176.14]) by smtp.gmail.com with ESMTPSA id l5-20020a170903120500b001e4458831afsm8674525plh.227.2024.04.15.20.20.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Apr 2024 20:20:24 -0700 (PDT) Message-ID: Date: Tue, 16 Apr 2024 11:20:19 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Re: [RFC 0/3] Improve memory statistics for virtio balloon To: David Hildenbrand , linux-kernel@vger.kernel.org, linux-mm@kvack.org, virtualization@lists.linux.dev Cc: mst@redhat.com, jasowang@redhat.com, xuanzhuo@linux.alibaba.com, akpm@linux-foundation.org References: <20240415084113.1203428-1-pizhenwei@bytedance.com> Content-Language: en-US From: zhenwei pi In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: CA259100003 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: oy4so4qxfsqjes8xuzwtwigx4swtxnag X-HE-Tag: 1713237625-7563 X-HE-Meta: U2FsdGVkX19J5Hc4ux87JbzmHExO1gGhVr4rYSuh2kkSiPAsUmg32NfzgMGo+kSNoyvpodmvz7lSfsBBVKBtch75vMb/54MVyDnBqQOC7xV5HtSNDr8+JnAJmeKmooR5YCof71J09+3Agd/iLWV0F/caff1C3hnrCyvu+IAVPWroD+4g8+kc3qj4zseAu4OWlgF4xMXWqWTIgoOZTN6CgfPCaGDwVUtMfF9dcggzKpBdpOi9w8kM0bQvrxBG/FqjFbqmzrSp+wBx/kgTapE6sPkCCwCuLsVmgzLVOuqBnapphQ7+ia7BZIhXL2610GfDgpf1/kVNxMMeUWgdyCxS52sjfvRU+0c8jdSZUYi0vTzcD9hHYX2YdC2qHxLe8OkZQdRf7ZpzUId3qg+vV5WKQR4kEVr0Elvo0hur9ecHxw3/2r2X8dDH1tRgLJB6hAG6D4SUPjuJjOmS35L6yc8dsz9ZHX9R+wk8RBCmjuxx7AohfqcKknjOecRizxji5cFtLd71B+tDEpYDmVzMMDy0Itbz2i8ltUnJqvfSKXDN+hTLQNLsNF7scuJVRVCrmivSmPYec1rUCztIKq1afwgvU20syyKQYaEEldt6LVx8vjIuhShyy1I2GFQ51G4MeO5CQquleUoM1VIfoAZWDcbcUSApM11i4RGpv7hc0foZgRXjx9v58LC3ryxarT6I+Mj2rF/gwR8o+jk9X0yckmJxx6bq84ARpXUQnahEYV3Ne84yVoeGRAWNfIM/E89UWpJtyQVUZUSmEWj+sLPZrzZU4RhvVJWp1Zy3l7Y2ziLA8QVL2egygZADXqexCcbBDFMOuZSV2ci6ccKo8l02fjEj4RVucPwlr7AuZhbLt+eXNWXRvVVe4fiKWCfS77RadutDTTzodfmBKGjDeJgnQvBKy0OFuMucUiALv0syAb9H3ww//vE1QSM9HwDF220XVXzYmfWFoN6463y9gv6Cv0w 3dZ1lU23 I46AjlVwnV8ZvTrBCfSQkVYni3zP7bQSIQ1JxqPfatlO1LkjASuzsj+kcidky3qUPQQagGJNcvrFt3/ROV2zVQ/OPF2McyvxcrRNkzA9VCD9JKmrIaki7rZnTUSxWjfaZPq3/hTTAcOIivCttQISTGzZYCfg0/lK/85XLpQm4SS7gqYA8HiIwhesN5HcXHvk6nVLy1yWe6GesZSBKdeR8jn8fmFYbOhI7dom+tgQ+qk66T/T77kuz91WH/PZsajxNk5ba2DCwNuvrGqD9W7E0mI6gLflmJO8TGSawezjVLiTnk4ioRS3SEHx6aeuM6JgeHdvm0OUqt64hDnLACUbmPH9stzqRMPC7HIals0nM4B1Sz27ILxNxS2sMx+TDGOfdxa0pwtYbTVrMFuIC4T4Dqm6Ssh/xl5svLbfwY0urZWwIU0FFkLIJuR0E/X0s/oMUnCbH8cTnCaRVgSJ/Wsyf6yHq5Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/15/24 23:01, David Hildenbrand wrote: > On 15.04.24 10:41, zhenwei pi wrote: >> Hi, >> >> When the guest runs under critial memory pressure, the guest becomss >> too slow, even sshd turns D state(uninterruptible) on memory >> allocation. We can't login this VM to do any work on trouble shooting. >> >> Guest kernel log via virtual TTY(on host side) only provides a few >> necessary log after OOM. More detail memory statistics are required, >> then we can know explicit memory events and estimate the pressure. >> >> I'm going to introduce several VM counters for virtio balloon: >> - oom-kill >> - alloc-stall >> - scan-async >> - scan-direct >> - reclaim-async >> - reclaim-direct > > IIUC, we're only exposing events that are already getting provided via > all_vm_events(), correct? > Yes, all of these counters come from all_vm_events(). The 'alloc-stall' is summary of several classes of alloc-stall. please see '[RFC 2/3] virtio_balloon: introduce memory allocation stall counter'. > In that case, I don't really see a major issue. Some considerations: > > (1) These new events are fairly Linux specific. > > PSWPIN and friends are fairly generic, but HGTLB is also already fairly > Linux specific already. OOM-kills don't really exist on Windows, for > example. We'll have to be careful of properly describing what the > semantics are. > I also notice FreeBSD supports virtio balloon for a long time, 'OOM kill' is used on FreeBSD too.(LINK: https://klarasystems.com/articles/exploring-swap-on-freebsd/) > (2) How should we handle if Linux ever stops supporting a certain event > (e.g., major reclaim rework). I assume, simply return nothing like we > currently would for VIRTIO_BALLOON_S_HTLB_PGALLOC without > CONFIG_HUGETLB_PAGE. > Luckily, virtio balloon stats schema is tag-value style. This way would be safe enough. Suggestions in patch [1-3] are good, I'll fix them in the next version if this series is acceptable. -- zhenwei pi