From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81DA4C282EC for ; Fri, 14 Mar 2025 10:27:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D76EF280002; Fri, 14 Mar 2025 06:27:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CFEAD280001; Fri, 14 Mar 2025 06:27:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B784A280002; Fri, 14 Mar 2025 06:27:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 96FE0280001 for ; Fri, 14 Mar 2025 06:27:44 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 5C5AB56253 for ; Fri, 14 Mar 2025 10:27:45 +0000 (UTC) X-FDA: 83219780490.28.CB33077 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf08.hostedemail.com (Postfix) with ESMTP id E13D716000A for ; Fri, 14 Mar 2025 10:27:42 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=m+jmdcM7; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=2Da2GVXQ; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=m+jmdcM7; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=2Da2GVXQ; spf=pass (imf08.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741948063; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cgnd6h/8+X/DkEnqQwYn262MXQhZFGwUf0NqimX6ZLs=; b=TKIfySnwssgH5CkrvFXJXlOp37ZP7DPVrWKIHZ7JhXP7zFWpdgaG1uAxWGJAFZKeksrqgC sS6gsPRy28hSP/8+LPNTj9sIEkbZEX2Yj/nUGS5L3NygBHm90TnTflvFIay3EZ3+nu9Uod esZ3cdXQbsQ9Uvbc72bTGV1T0GeJFfQ= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=m+jmdcM7; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=2Da2GVXQ; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=m+jmdcM7; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=2Da2GVXQ; spf=pass (imf08.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741948063; a=rsa-sha256; cv=none; b=vGa4hsddnWztn0PQ0UCFpO4lFpmXqKl9dJyd3ubQjPCryQTLzFi7yn4JUagVdP9UThdFjx 1+Fq9bOprffRRzy4GtQYi1M0iwWF+zaJwWDGlm9dvRDeljHZMR0NmilD+pl6EMCjunTAP+ zPhTc+ZM5dqWvbSYicmPYkjI01uPJUY= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 288B01F38E; Fri, 14 Mar 2025 10:27:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1741948061; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cgnd6h/8+X/DkEnqQwYn262MXQhZFGwUf0NqimX6ZLs=; b=m+jmdcM7naaaJYDjiLUoxBoxJ1CUuX2Lg4vABxBJHyTXYB5MR9GuIes3/qRccuoKZF4HDU 3KeFroriA7gVH/riqYktnDgM1V4ZgY4otUSaZE9PNYqCuWikLFrAlwzSmMrvGPwgZ9YbHG dCK2cYFsreK6SZ2EDzsLBlKDEL9qxuM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1741948061; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cgnd6h/8+X/DkEnqQwYn262MXQhZFGwUf0NqimX6ZLs=; b=2Da2GVXQOSiDIHTxiRa89PZSJ4zgmkGZnKDEmxXRDLU6yAL5/8ePn1raLqhnLE6MJ5Yijm e1ZU+M9xehJbbsCw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1741948061; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cgnd6h/8+X/DkEnqQwYn262MXQhZFGwUf0NqimX6ZLs=; b=m+jmdcM7naaaJYDjiLUoxBoxJ1CUuX2Lg4vABxBJHyTXYB5MR9GuIes3/qRccuoKZF4HDU 3KeFroriA7gVH/riqYktnDgM1V4ZgY4otUSaZE9PNYqCuWikLFrAlwzSmMrvGPwgZ9YbHG dCK2cYFsreK6SZ2EDzsLBlKDEL9qxuM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1741948061; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cgnd6h/8+X/DkEnqQwYn262MXQhZFGwUf0NqimX6ZLs=; b=2Da2GVXQOSiDIHTxiRa89PZSJ4zgmkGZnKDEmxXRDLU6yAL5/8ePn1raLqhnLE6MJ5Yijm e1ZU+M9xehJbbsCw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 11CDD13A31; Fri, 14 Mar 2025 10:27:41 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id mxH5A50E1GeiZQAAD6G6ig (envelope-from ); Fri, 14 Mar 2025 10:27:41 +0000 Message-ID: Date: Fri, 14 Mar 2025 11:27:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 07/10] memcg: use __mod_memcg_state in drain_obj_stock Content-Language: en-US To: Shakeel Butt , Andrew Morton Cc: Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Sebastian Andrzej Siewior , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Meta kernel team References: <20250314061511.1308152-1-shakeel.butt@linux.dev> <20250314061511.1308152-8-shakeel.butt@linux.dev> From: Vlastimil Babka In-Reply-To: <20250314061511.1308152-8-shakeel.butt@linux.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspam-User: X-Rspamd-Queue-Id: E13D716000A X-Rspamd-Server: rspam03 X-Stat-Signature: stbgz6deoicu8crhukxo3uo1rg88szq1 X-HE-Tag: 1741948062-318059 X-HE-Meta: U2FsdGVkX1/We1NWLVIuzCn9ejxF+BgbR6fljBG0jq7M4/fO4EDT775eVmlqOYOkoM4bfEay0Xp20kjGwBAejAkKjpFVJ7x/TRQ01m182CuI9zTzUrUM5Tfim8kmBWOcuQsgWYhLMV/trfM+jwCpr0QxVrSjjKtpn8bjYxslTZT0cwlM+8v3MCVez1IYK2hIHi/vkX2sSYQOUAy1NGQKkVsicA9Fl4zPMkW0L+/+VvAOZs1HsuMTGt2qJhnkujPisTsNxvcApbtLPHSc5lM+vM47pJEtQ5P6XyyURmzi4TNYjE9me2rYjk3ZL0Gz1tBzKAJ1OtC93Vr9yV1KSM6G9Td/v04d1IrfdmUzbwC4C6Zyp2M6BVJrvgWUp2IY8TDgDoxeRGrmnHmbIvGfVGeYvIFiTx2poMcSppk5KHvP04tUn+bLqza6r/xFOeAuVaEYD19Ecm3rzR0jnAqWaF2PzKfF6VyxbnmRbedJVtF1eimZ2S57f2CpFNF0YoRXJczPFuGrKc3iVArMQMLw0ehg69jn+FY8878ZrZhcURK3YXzlBHTTSWOt+o1sxK6HV4XmuPr4zyzxOfgEb2NQ91pTiZXZdgUOp8shWcS8Gqol+MLaPVh8cQvWjWjpZx3ARiV19b/57xYcI7ILA5zh4VkIJbxyZ6LJaTzOhWGNEjRDM865d4/lU4CEJ0Nm1meOewGfu0Qa8od8BKRuwHai7uv/T3Hwc1nOb1ilwdoSdxHlIIwOXWGJ2jUYTaajo/9ZxJ1HwQe8x/uOkoDXTwkL2LTDovJyL/+vvOD2Sd+/Iczk7ph0pYSJhnmC8dmyIZKWj1fUlQC+ZQ/JNZhWfK08zFbomATodkvN5yhQTwNWV8lZWdHTd65W+dygfsrrsJ+BC27MBWRlFez+NT25rVwIx1nN+Jh6ef+QZZ5LXMkLx/a7TpYxVYoPyTqwGHs/h7ZejEqBZ/g96Ty+zboFmHwKWfi bon2TBN3 P2HJpVLjTLN5qL11Y4SL+pWgbMNK+OSke/gOF22N3rmCLnK/4v9tyZo3n+YySI+28Lxg87FK+pwCb1C2k58qoRsYEqwfupj5mv3dXH3H5gPpJ7mEKzmvc/bA6Wo8lx6V/DwxWH3I5RYDw+HvWn3Q8OUo+fvkwzi5+Gb21kpnpGa277+2q00wDS3GV7X/xVgXkT2hpePCX6zSFwn9+fhyE+Gad736ZKOvpkwXA4CMGqWh+rrrEQjJWuqjiuziRTyi7G6wWbLNCrFP9PqK7Cr5kk6nfz7qYSxJ1C6Id55k5b9G/rIZtP/qFBUgIXTEoj8p4QoHOxPEvrkctwgE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/14/25 07:15, Shakeel Butt wrote: > For non-PREEMPT_RT kernels, drain_obj_stock() is always called with irq > disabled, so we can use __mod_memcg_state() instead of > mod_memcg_state(). For PREEMPT_RT, we need to add memcg_stats_[un]lock > in __mod_memcg_state(). > > Signed-off-by: Shakeel Butt Maybe it'll make sense later but as of this patch itself it begs a question why put memcg_stats_lock()/unlock() in __mod_memcg_state itself and not just around the call in drain_obj_stock()? > --- > mm/memcontrol.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 3c4de384b5a0..dfe9c2eb7816 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -707,10 +707,12 @@ void __mod_memcg_state(struct mem_cgroup *memcg, enum memcg_stat_item idx, > if (WARN_ONCE(BAD_STAT_IDX(i), "%s: missing stat item %d\n", __func__, idx)) > return; > > + memcg_stats_lock(); > __this_cpu_add(memcg->vmstats_percpu->state[i], val); > val = memcg_state_val_in_pages(idx, val); > memcg_rstat_updated(memcg, val); > trace_mod_memcg_state(memcg, idx, val); > + memcg_stats_unlock(); > } > > #ifdef CONFIG_MEMCG_V1 > @@ -2845,7 +2847,7 @@ static void drain_obj_stock(struct memcg_stock_pcp *stock) > > memcg = get_mem_cgroup_from_objcg(old); > > - mod_memcg_state(memcg, MEMCG_KMEM, -nr_pages); > + __mod_memcg_state(memcg, MEMCG_KMEM, -nr_pages); > memcg1_account_kmem(memcg, -nr_pages); > if (!mem_cgroup_is_root(memcg)) > memcg_uncharge(memcg, nr_pages);