From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E1A1C71136 for ; Fri, 13 Jun 2025 13:38:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 900E76B008A; Fri, 13 Jun 2025 09:38:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8B1866B008C; Fri, 13 Jun 2025 09:38:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 778A96B0092; Fri, 13 Jun 2025 09:38:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 52C706B008A for ; Fri, 13 Jun 2025 09:38:52 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id D8C565B5B1 for ; Fri, 13 Jun 2025 13:38:51 +0000 (UTC) X-FDA: 83550482862.14.6E02C0D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf18.hostedemail.com (Postfix) with ESMTP id 40F8E1C000C for ; Fri, 13 Jun 2025 13:38:49 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YHv68eu+; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749821929; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gA+fyTDhlNNImNCJ4jABZvRjAPCgbHPkzMh2Vk4M9w4=; b=3j3BmJLbOjCJjX6f7v/xAsgAy6mWTCjjYcmpO66p/Wp7laARonUDspXHoEtJ5gns+Ttt9r SHA7olwDnO9THbaOMlDTn6e6nXua1hyUUkrt/eCotn/gB6AU38Fr7mSOmjDoVvxi/thaa8 RYkmgfgudMV8CLE9AmOcGGfi1Fv7IT8= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YHv68eu+; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749821929; a=rsa-sha256; cv=none; b=DlIldP0gpbyv/1qR68qHViJew3icshWqy7Eay0zBRCqzBBVOs3T8UDnC+IuvBtxMakttRw eNEoa6cM9jHM4IOm64iSF+D5bJx3uheccemQCE+649yEHSsZCykqv1+liLApFoyTlyvcIG 9jpRgtaF1jthAoACKvo5HN88rylDKtI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749821928; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=gA+fyTDhlNNImNCJ4jABZvRjAPCgbHPkzMh2Vk4M9w4=; b=YHv68eu+/ts3km52WqYKONMQPsfJUoMtECnHKMw2020awcbhLQwudwcnJYuikFwp9PqiE0 RMSNbc0ryigaXT6MCdZnyinUYQaH9AIboWzuLjuS4JsMBB+PXBWJWr97fl+Y7tilmoVbWP X0V2NKjH9l4aCy/Hm0te0N2IU0cfPD8= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-93-QFc-evW2NICJZCHNToUHKw-1; Fri, 13 Jun 2025 09:38:47 -0400 X-MC-Unique: QFc-evW2NICJZCHNToUHKw-1 X-Mimecast-MFC-AGG-ID: QFc-evW2NICJZCHNToUHKw_1749821926 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-43eed325461so12706225e9.3 for ; Fri, 13 Jun 2025 06:38:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749821926; x=1750426726; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=gA+fyTDhlNNImNCJ4jABZvRjAPCgbHPkzMh2Vk4M9w4=; b=D5tA1iaMKVvftVW6D5DwxI+iUx+iOWw7z0kRvu0UxvHdQPICr6p8yTywXuHa/86g2/ 5U2kStU0afhNE3pmXKlu91IMihofE4q95uM73iTYYiy8yC/mRL9dvDL3C7ZwrUoKqa5K xp9TRoXgOHb99oIMwLB17U+a2KschnZSqek/5OJ1fG7oQZgQtb/noeM41DN1z897JtgL k5QMYGZNMppdiakQiiL0YDWyg5HlqkpNUKsrknxC/K5hZs8pa2OAIOnlJKyD2St6YrbN bxkOlytKj1RRl1ArIl/bXJTubQeSTTgWaOQrQQaqhtlV4SDdAA/JA+47UGz5V4qyrjCC X+QQ== X-Forwarded-Encrypted: i=1; AJvYcCV1au910uhqC1S3KhTVGFlBEP5CLLW3Gv7urNx/1NbwoElFiSZabg4U8rPhRD2KHo0bXOYXkEcm5g==@kvack.org X-Gm-Message-State: AOJu0YzlSA+k4fO84Oh7FqvQNa7o99czNd8FoI9c7IA1jiTvisk6Dzes eeaDZcl6KRMoQL9uizdV1OBdooNhWSR8QFYS+LmrMgM4robDfhQ6gcjSaFpXhTDulw2UxraNyAw s1MVFYIJ7tziLn265HVcwqQStB8Xs84eGZo5J7c/ZNBeGOQjC9Rwd X-Gm-Gg: ASbGncu0Rq2G0w4/7rXh9qdUj7Swsw+0W0X3+oakd+r6S0pLhDWCxEqh6CQc/FxEEb0 Y3U5juumcfiN8j5x1+DO+E67KMCgqfzZ4ZmKwAOO+Z2BN8jkJG+/X3wzgIpr25hQBWo3BoY45qh 50QtqISC+habCKJjU0EYstXHyLilx51eZiz56NnDe/af1/DoWi4sEq00xBYE9mA2tqghGKJ/KZM 40fIQu3UKUj8vXR9AoUwu9ZrXojEIUdSGkvlPuIq5FaDZu9C0FCtyzFGWMoceFuNJfWtJ5QIE/b 4uvuti4mOZZjkuY205phvX8kFS61FZatV4Jrk5QLU1m0CbSpjYBw X-Received: by 2002:a05:600c:821a:b0:440:6a79:6df0 with SMTP id 5b1f17b1804b1-45334b63134mr26911745e9.22.1749821926094; Fri, 13 Jun 2025 06:38:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGPc0rAqrtm8Mfy8P9qTOpKk4v0Ra18xaU23rpSwVHpxhe/VL2TcmbeQhBrzEnWo85AfNh6Yg== X-Received: by 2002:a05:600c:821a:b0:440:6a79:6df0 with SMTP id 5b1f17b1804b1-45334b63134mr26911485e9.22.1749821925755; Fri, 13 Jun 2025 06:38:45 -0700 (PDT) Received: from [192.168.3.141] (p57a1a50c.dip0.t-ipconnect.de. [87.161.165.12]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-453305a0d9dsm46813075e9.21.2025.06.13.06.38.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Jun 2025 06:38:45 -0700 (PDT) Message-ID: Date: Fri, 13 Jun 2025 15:38:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: huge_memory: fix the check for allowed huge orders in shmem To: Baolin Wang , akpm@linux-foundation.org Cc: ziy@nvidia.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <529affb3220153d0d5a542960b535cdfc33f51d7.1749804835.git.baolin.wang@linux.alibaba.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <529affb3220153d0d5a542960b535cdfc33f51d7.1749804835.git.baolin.wang@linux.alibaba.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: bRA-sGyH6V2uKTjg63_RIJIWVxIrNR1XLd8GxfPUdtg_1749821926 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 40F8E1C000C X-Stat-Signature: rzwt975jjguh5fggw7a1fzyt4j3jjem7 X-Rspam-User: X-HE-Tag: 1749821929-3192 X-HE-Meta: U2FsdGVkX1+OB+63JMVL5IRCTZ7fiDF3+MSRPqZFyMWuzDmRQl+Hf8RzgZDU2PVBgek+OipqD8kmsSTzvkCQorIm7jJ1uEX9rnfSv0e1TesWxU1Cja1odYweeSk0iofUP7ShDqiAqEo6KOzvPLUPr/fE5k3HTc+GCd5CQV8rawxqQKVR+CKmzT48AHEdW/zSY6YoDR4LEgaOPOmocjiGcEq0n3naAZRLs12wZwCkZ9W5J8C6sDbJBwvGlUcj/cuBPCkZI9KjdBZIs0EBaAWv5TnRPoIa3GwLnKOIlMRE36yWRuimZQTcM/OvR++C8TalQ65GE0vtz/a17OAk+GmvHyiOWimXWUL/rTRCYa0BcHacPYgsqRxV2xACUNVVqKGB7OpaayhDljWxcDvMc0joTqBuSnPsNZIhJBgucxNSXAVfA5nfLGBPruBb7xf0KLQiw2suwfbggPeruxyKe9f1mbcn+gNQiuBEn9T5CITlT7JWQY9/pCE+IaiHw4PZjfFRYipfEDMc7Lt3Ngo//vduGD1TLILsyDkob2ORuKx0jswy2bVDaX3sE5OyBsGSxl/+K/7H9ama6fqlOnEHdh8dDJOUAAaZwfWCXQKta6Jd5mnbktcQbfCC8oox8q1HUqp5ZmzuQdhXpkYVH28u5k+ba61Dsz+fkxFeKp1VtyFwBa7x5GRHrpyra38hOAB6kqaIytA/tM0hCPFe8fWpEWUnfhs0iIvnS2l8CLdLHV2COBNqRK8XyzXIPAFrmX1La9q6qWTrgK8puobz2Xi+su9/qRhqK+1yGbVipChSGx1hg3beVCOHNwkeiOEVwKksFeBpUeN9mYQUsTrlUHNr9+XQ7fHAUlOelNhO5DzIXF+eOq8qYKnlu0lU3yKp/xnYs6PNZs2DtJoqu6YpB8nlIZcVHP4JOi6hDV7BP8lVu48sCMBtjUNTfduDRA7iIOx9h1xOYRvpvuFFhkudYoS1B5b KE524A67 Zs2Ntjd+uP/e9rC//mH8/43m7s8FQOZZMBZdEfiWuySli3yLon51y6l3CtgMrhiS1/+TU8lZL05YHaHClzqs9YNSCr4YkMju3mug+kKyT0u9jdaDb7Gqg1KcmUNy1N3MYk1yo63looMg0s5D9/y3j6W/voee3mCGi1HEnlMvUpg1oNNPst2jmZe6jUtUnF6y5OxO92heVVhJIcNLxLcTK81OarWFK0b22lOL9X0/WwyYpUZYlKmmZ4R45W5L6WpUk35OYKKfupU9GnGlIxnyPMK72CDsPLsr0iMuhrozCH3KxL5jo82I+l2sJPuEXtFqv4OtwV4YBovqqaPLQtxl4gZ/jntS24CJLneRB7VUVtS9E6afGTlJVFvElcXCQIWkbCIVCgZs73maYy9MplOKIdK8QuHBVrkshQxPVQago38twABtSZsOhEvQUdi9G9rja8HHiZXGwMg9r6IdBF5CkyEyrlTfNaWHZ0ysO2/ezmhtWj5uirKKrYO73EiTbY97O/PB4K+U5lo94fgUl9PLood+BfykLqtA7cNb+7H4Gnq95xg9lGuvOlzlhfNT/Bk+VF97a X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 13.06.25 11:12, Baolin Wang wrote: > Shmem already supports mTHP, and shmem_allowable_huge_orders() will return > the huge orders allowed by shmem. However, there is no check against the > 'orders' parameter passed by __thp_vma_allowable_orders(), which can lead > to incorrect check results for __thp_vma_allowable_orders(). > > For example, when a user wants to check if shmem supports PMD-sized THP > by thp_vma_allowable_order(), if shmem only enables 64K mTHP, the current > logic would cause thp_vma_allowable_order() to return true, implying that > shmem allows PMD-sized THP allocation, which it actually does not. > > I don't think this will cause a significant impact on users, and this will > only have some impact on the shmem THP collapse. That is to say, even though > the shmem sysfs setting does not enable the PMD-sized THP, the > thp_vma_allowable_order() still indicates that shmem allows PMD-sized collapse, > meaning it might successfully collapse into THP, or it might not (for example, > thp_vma_suitable_order() check failed in the collapse process). However, this > still does not align with the shmem sysfs configuration, fix it. > > Fixes: 26c7d8413aaf ("mm: thp: support "THPeligible" semantics for mTHP with anonymous shmem") > Signed-off-by: Baolin Wang > --- > Note: this general change is suitable to be split out as a bugfix patch > based on the discussions in the previous thread[1]. > > [1] https://lore.kernel.org/all/86bf2dcd-4be9-4fd9-98cc-da55aea52be0@lucifer.local/ > --- > mm/huge_memory.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index d3e66136e41a..a8cfa37cae72 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -166,7 +166,7 @@ unsigned long __thp_vma_allowable_orders(struct vm_area_struct *vma, > * own flags. > */ > if (!in_pf && shmem_file(vma->vm_file)) > - return shmem_allowable_huge_orders(file_inode(vma->vm_file), > + return orders & shmem_allowable_huge_orders(file_inode(vma->vm_file), > vma, vma->vm_pgoff, 0, > !enforce_sysfs); > Acked-by: David Hildenbrand -- Cheers, David / dhildenb