From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB539C4167B for ; Tue, 5 Dec 2023 12:26:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3920B6B0075; Tue, 5 Dec 2023 07:26:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 341FF6B0078; Tue, 5 Dec 2023 07:26:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1E3F56B0080; Tue, 5 Dec 2023 07:26:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 0B8BF6B0075 for ; Tue, 5 Dec 2023 07:26:01 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id DD61016011E for ; Tue, 5 Dec 2023 12:26:00 +0000 (UTC) X-FDA: 81532686480.16.5EC915C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 871FE100018 for ; Tue, 5 Dec 2023 12:25:58 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HJRqV9Cc; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701779158; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ETXmoryrBgHKIsSSGX8IoKw3azWp+g8uDvWiDYs9lkk=; b=BaCTfohyWZDkkTlnBKdjxw9nZ4tHdPsqYwm/Gc+KsDsxxTZlJ3FBjyjwlss3SJ95UIN0Fc NkKEMbJBzIYq/AhHuENbmx3rD3p5AkrzaDi3N+GYVU05JgR883ydU6IxYiNr1E8kfmcXnU tKerNPG0FhBmT7vuy4/mv/q/q9xSQVg= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HJRqV9Cc; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701779158; a=rsa-sha256; cv=none; b=31wJryn+V4VUR89Vd2DWbd9c8l1LRaGg6KQDc4amcAL6we55jOlAC60RHvQIMN3zYL61Vl DDKisuNu154BFPaN4Dcp3DfXO7RoIMprLP+BjcEak633d/ZMZx0SmrTcMRn3CG1uqxfLoB GFC1UflVxF+RB5+HmmRkn2D1Pty43MQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701779157; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ETXmoryrBgHKIsSSGX8IoKw3azWp+g8uDvWiDYs9lkk=; b=HJRqV9CcCadfhFJYT0nMf+pN0692j7IP3C0+HjekzDER3tTAsDcPpI64k//mSNu3CDSz/O Nbmdz2/PF0baX/q2C7i/VpA6q8l3rssDurvQLq/Ywg9IB0Gm0gi8EdxwOnatvose5MM5Lv 2BJDhXgmyGTzS/pHmfGmHz95hJsrzK8= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-696-pvw-fYpoNq-MNnHfeApsYg-1; Tue, 05 Dec 2023 07:25:56 -0500 X-MC-Unique: pvw-fYpoNq-MNnHfeApsYg-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-40b3519a03aso48259885e9.3 for ; Tue, 05 Dec 2023 04:25:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701779155; x=1702383955; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ETXmoryrBgHKIsSSGX8IoKw3azWp+g8uDvWiDYs9lkk=; b=DDJNMKdKtM0Nq5J65AuG5xE44jtEYCL3Mzhu5mIHxv11++Db6QZXSYDcQIKKZlDnJX QD7R8vdmnTged4lGbRivCql4GXyoYXoxSYxxSlRGbYX+mEkzVoL5pgtpAOV+V3OP9ilT HRqJ3GUj7c5HmYwFmGlYBaSkumMsD349kCv7hFpFaT7zLpHeEnfln1u4e39CpQ4pddan bwAGiC0cpSHI2ff4eHVqEuLDJ+/p67EtUlqaJB6M6bE9cA3zSP/YMb99dW4mTnemw7fk Sg6NZdqsOQ4faMAKTS7rhYyB8jtFyQGaV1P1OVTo6J032so/fLXzf14p6y78vG634J8G anMA== X-Gm-Message-State: AOJu0YxM5cXC8TGgqyQQAw4KzNf9bu9GK12q0YCc8zXX8RtfsJOpcq42 94x4BuQAix2wGQR4MrbPGCxIRAxslrTERedYESRE1BbmrzSQfEQq664T7neBWnfAIFsLW1dr+Vy qcq3ggyoOaPw= X-Received: by 2002:a05:600c:1508:b0:40b:5e59:cc9d with SMTP id b8-20020a05600c150800b0040b5e59cc9dmr473866wmg.126.1701779155530; Tue, 05 Dec 2023 04:25:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IEpBBmzrQ2OLh+b6PaLOLKXclFjQkPBqzBmCdPKmDXrgPQNI6bI9uP1/eNijm3QbDMZq07qQg== X-Received: by 2002:a05:600c:1508:b0:40b:5e59:cc9d with SMTP id b8-20020a05600c150800b0040b5e59cc9dmr473856wmg.126.1701779155106; Tue, 05 Dec 2023 04:25:55 -0800 (PST) Received: from ?IPV6:2003:cb:c72f:300:1ec7:2962:8889:ef6? (p200300cbc72f03001ec7296288890ef6.dip0.t-ipconnect.de. [2003:cb:c72f:300:1ec7:2962:8889:ef6]) by smtp.gmail.com with ESMTPSA id a10-20020a5d53ca000000b0033330ace23asm12044230wrw.73.2023.12.05.04.25.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Dec 2023 04:25:54 -0800 (PST) Message-ID: Date: Tue, 5 Dec 2023 13:25:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 07/39] mm/rmap: convert folio_add_file_rmap_range() into folio_add_file_rmap_[pte|ptes|pmd]() To: Ryan Roberts , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, Andrew Morton , "Matthew Wilcox (Oracle)" , Hugh Dickins , Yin Fengwei , Mike Kravetz , Muchun Song , Peter Xu References: <20231204142146.91437-1-david@redhat.com> <20231204142146.91437-8-david@redhat.com> <3e748c18-f489-4ec4-ae71-5a5b18a4b161@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <3e748c18-f489-4ec4-ae71-5a5b18a4b161@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 871FE100018 X-Stat-Signature: efaz86d6efiurmsz1zn8539dtf59jweg X-Rspam-User: X-HE-Tag: 1701779158-228079 X-HE-Meta: U2FsdGVkX18eZcMijTarLf0LEEdVfkd7mMCGoYik5CnCqKZBXXSCU0JubOqK3rEN0+HhtikkQomojD/C1g+gHPupM3H+1CM9XEfRB8xnd5eD7gWSXrj3VwY91wNwttHpg75ncLz1IhbCdGcmMDP3/UwOdqVI24GVEM7YcuF2NhfmGk/6sUFRDnn+HrDRpLvoq5Tu4qN1N/6S+VR/TEjFFY/8oF5h8J/oeEDgHil1aL6Jwp6gHqaDSm/tSQRTVsIgfMC7/ttmtsdgenXXoRiYEmB86Z8SFZ+xfJxQHuC3zEoj1YB2/ALVD2s/sVZm38ZDIZaH+VAmb53jjQGgo43I98d4trRiSqkseYAzdQql2JiusnL45Sst5vy7b8i84Gq9+7DHGlqU2vvhZIUrscuDl1r3yvwj1/F4FViujpkjURArigxE7YRr88jBrjBEUy1dGveAt+R96Mr2ibH9WP5AG9yLm72M+3aCjByBS8Zix8rF0Q/Hy9kM2rvVJN8Vo7iHalTePGs3wU0LSHyUgSu4TNdTTO8AdbZXiU2trDIHep+9J+ibmV/i/8XFRL51crl+5WnJM5zX7K92iRWAVTUKwpcjNwkF7fINNo/O5qBU/pxP5BvZ8558Wx6zNC/V21u9eomB5tmdKpuI6nA64Nd2ExRX0Uh1TUqurhWJFsjK+pLwK1Ka0PbR9QOzlG6O0JZ86nlKmV3TezgamFX0yqm+MclmDgrpUZjCbwBSnPf225Yk7aDz4ES46K0k+OOltoxeQfRq691Ex4oTR8rYxI91MaqbOBundvGigNYFrLL8wfbIgwgj5yHR0hFG6FVA5Oz+u1Pex7YZ/T4XvTf5mDqS+rmDr3th1Y+nrlXpUkUOInmskKkfY+UeCniurVAAt7EryCFIUccQwEk/+mjva6FWMjU5lEITZHTQEcjpnwAvX8kj/weugVeuA/8VUBOQ6qjYMcPYtqvN0uqEEC8DFL3 UXtp3XS1 iEErvcZ7r3wOyTp3v86Yxs3udOhjAktgFICkdo0TTm2cgc01JP5cfwFczEVMKEKoA+6aj0x0C01tbMsFrcaH9GvbfAF4JDP47B4BVDZ4YK7QRJqQkh0uI6n+Qnbhc3G75+mRJ7WUHgvuz656IKMvU0UUKkViuX3vMr0bIJD3O5GFCvzx+ApIx2XNkdChB/5PJKD2zJxskou9Qgwy2OlOrDriOWfalhzbs2AAYLaoK2GGIiv1jvU1RWhIifV7+4FpF+PFOp5+m9LrCSRFYShe9olKVFwd8HAVxQ6E8O1uCy5W8MA2+BEq5UftBUFrikZ72WeS1gzqlgFQTD52aCtxk9bA5jiIvZDRtt8yIbX4NAk+NnDQtxgDlhYekEkhGe+p07ByH/kPBd7lsZzNB96/C9muDC46uWt6v9ADRB619meUpADXBTWFkkK6EW08rJIgYVVtmrA0cOy2jj/1O46VXYxJXBQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 05.12.23 13:04, Ryan Roberts wrote: > On 04/12/2023 14:21, David Hildenbrand wrote: >> Let's get rid of the compound parameter and instead define implicitly >> which mappings we're adding. That is more future proof, easier to read >> and harder to mess up. >> >> Use an enum to express the granularity internally. Make the compiler >> always special-case on the granularity by using __always_inline. >> >> Add plenty of sanity checks with CONFIG_DEBUG_VM. Replace the >> folio_test_pmd_mappable() check by a config check in the caller and >> sanity checks. Convert the single user of folio_add_file_rmap_range(). >> >> This function design can later easily be extended to PUDs and to batch >> PMDs. Note that for now we don't support anything bigger than >> PMD-sized folios (as we cleanly separated hugetlb handling). Sanity checks > > Is that definitely true? Don't we support PUD-mapping file-backed DAX memory? They are not handled via the rmap. Otherwise, all the PMD accounting (e.g., FilePmdMapped) in RMAP code would already be wrong for them. And it's easy to verify by looking at zap_huge_pud() that doesn't call any rmap code. [...] >> + >> +static inline void __folio_rmap_sanity_checks(struct folio *folio, >> + struct page *page, unsigned int nr_pages, enum rmap_mode mode) >> +{ >> + /* hugetlb folios are handled separately. */ >> + VM_WARN_ON_FOLIO(folio_test_hugetlb(folio), folio); >> + VM_WARN_ON_FOLIO(folio_test_large(folio) && >> + !folio_test_large_rmappable(folio), folio); >> + >> + VM_WARN_ON_ONCE(!nr_pages || nr_pages > folio_nr_pages(folio)); > > nit: I don't think you technically need the second half of this - its covered by > the test below... My thinking was that if nr_pages would be "-1", one could end up with weird wraparounds. But yeah, I thought about this as well and might just remove it. > >> + VM_WARN_ON_FOLIO(page_folio(page) != folio, folio); >> + VM_WARN_ON_FOLIO(page_folio(page + nr_pages - 1) != folio, folio); > > ...this one. > Thanks! -- Cheers, David / dhildenb