From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0759C25B78 for ; Tue, 28 May 2024 13:45:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4085C6B0089; Tue, 28 May 2024 09:45:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3B88D6B008A; Tue, 28 May 2024 09:45:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2803D6B008C; Tue, 28 May 2024 09:45:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 089A26B0089 for ; Tue, 28 May 2024 09:45:04 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 298BB1C14F8 for ; Tue, 28 May 2024 13:45:03 +0000 (UTC) X-FDA: 82167925686.29.630AE21 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf17.hostedemail.com (Postfix) with ESMTP id C8FA940007 for ; Tue, 28 May 2024 13:45:00 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Lrd4nMk0; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf17.hostedemail.com: domain of vbabka@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=vbabka@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716903901; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LIn1Dlg4/wF1l7HRy7IuKXIbdm4ObOMNz7nwnC2Syuw=; b=KRI3jY+gUlOLuDVtbmPBm4cxUPPfl8NesMYhyg6QFs1VmDAu0c6Z8noY+itCiuxFIFLPtj uWI+kt4kc5jrzsqcVT8MDKFtW8WBsm036G7PH7ev9/qAvyOZ4mKB2BrQKZV8vV2vKBVcsn bU/XUkH7zslVuK4z3lU9kti8wibtfhw= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Lrd4nMk0; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf17.hostedemail.com: domain of vbabka@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=vbabka@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716903901; a=rsa-sha256; cv=none; b=H8oq0qqz39WRF2vAwvLsiaIQYAsJv/EFH315hHCgaxGJUYBK1s9jaDzhDtV3actWx3oTcl 8GJCt4IbEEcINe0Wgd5WRvbBl+KWU9yUMleOFJXMqP2CAQPMbHmBX6Xv3i0tutAqNOzx1O hLjVYJ3ok98reG1KEBbTAEeukz1drDs= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id A988BCE12E8; Tue, 28 May 2024 13:44:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5539AC3277B; Tue, 28 May 2024 13:44:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1716903895; bh=9EqkoHYcuTnYOItA/g9YcyP8U6j3EYnq+T+pjK+6TR0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Lrd4nMk0sOgxul8v1Wq8ot+mopcU135atLvoBZLPdoY0QyJoRv3I9nK5Ghm9NMPZF Y4nLBLlFe7ZKNzFTy7iyh7Qu0im5K6U/UsGHhkaZwVPVP4LNDACZszrFEA2tWZu+6G U04QCPmaglotlnB5eby69bI2Dbrzbl9w/+8fmCvOOsTqGFleMGFq/xpd0E4O/7QtWm 13FHqFC0CpVofcYjt+aXqHMujeCx+URtEIfARZw7ZFugolZUo89C9OeSKSrGCR2+Wu 25+GIyCYQTbiEwtjQu5fpispaumM0Sar2GVpxafXKEuutDFZjpvWmGOjfE7Qlq2rwq dRjE/7S+h3SLQ== Message-ID: Date: Tue, 28 May 2024 15:44:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] memcg: Remove the lockdep assert from __mod_objcg_mlstate(). Content-Language: en-US To: Sebastian Andrzej Siewior Cc: Shakeel Butt , Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Thomas Gleixner References: <20240528121928.i-Gu7Jvg@linutronix.de> <09e085bb-f09e-4901-a2dd-a0b789bb8a4d@kernel.org> <20240528134027.OxDASsS3@linutronix.de> From: "Vlastimil Babka (SUSE)" In-Reply-To: <20240528134027.OxDASsS3@linutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: C8FA940007 X-Stat-Signature: 7dpb3tsccubgt8yoaau8jo6odepogqjo X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1716903900-894914 X-HE-Meta: U2FsdGVkX185sl5+uV76Ye1bgfzTp8qhEs0tkFwYKg4EHfx3RcxBZrZ0PUwRYSCIZdFSD+CNpj4q4c/t5nhH08iCmNA1P6wJQbbb30Q6SMEs9q1RUPZ6DW2wtqV330EI1KU6F9kG63YMx2tqkocgcWwXKMDnqgpvPRuTD3Ear6gccD5dTSfCx+l4OWT31vJdGmSnUyft2dbKoSejdhLe+FKWLgy+qm8RJ2k5LZEFfcRs5fSQYcrE4PtJuF1Ddr5hb2RXyN9EOD9b9wDJOJiOcksT3nu+KPpR2XpjAkXk3Lk/aoAQqahKxvKnRn3yddJH4P3iZ6Jrm9FhI5ITEwyfQaq5w5g9822FphBrZWESeTWsKol4pLnQkDcdCongtKeazw9BObw/JPTigvA0WVbUhFav1KCt8cHCbpG9hVYv625lcF+PrDPQNhm4qjkMyhfKk08NLBOU+2NW9Sy8vsY6JBmGWL2SivVueHzcb3aMcB5DfnO+9egieAWdPQ8Q1FfiZEFqcwuQZ4KmZ+sdJD9+ukZJPo+hPStZ2WEUwE3fzB+ZAqaWGXsyUBNNM4VWVknnGm6c8xOvS7ZPbODcGiP/E2UePqzsCS0uzOF4/IDFBVSz3gp+lTe/D4TyROTgvfnVle/jg64LP2hOw8GZ99NYMQHhUg6sHXdAl6r5HusZvzucL39A7pMdvaVa+0FfS+tfl2+K7n1F/OaZFyeZd3DmIMeImUESvdvvIBd+PM5JSsvB8ClPMkJ8uqI3ytIAwaujzfGXfT7WIUlWMyrEv3JzfQ2XDpcCmeGqKAtdVtpxm2JjWZwnYCRNdt/uaxQNcx4nC6lLVeIaRU4aHSEKo6oHF9l/WaUnWFJ0MoqX54wH3VjelMNv7Ity6P02YY8oUMVCm8OsyZZHRCwTVgj9i0aGwHen5CJPBfZdcTQUXUeTu2jG/rJuvzvC0xuC8nXTH8b2HFaakuXxvXysknibsbt LZxUUhzj DA5HP1cxhkwzrkuSSB79OtjOrQhI4llRh8aeSrTBwcxbhx1abYQW4ABfc07opPuf6a9hb75Lgn4xLlrgm84h/kn61HfrQM/Y3k57lGs/5sVpR+TmVdgc2N9UfWrDtM8hPaXqvfJKbTGjHFBeky5ZbSoP0v+T3ovyz+BIe0XDaGJDG69YeYe2WLybA+B3nzi+eBvwQp+8aAhoBbxPpH9SHL6D/756t4Ki/9eQA2AfkTrtVEJL/ZsxI/Rl/NcjaWa9vEuHZi9Ge6ipjUa6z5ywSu4Sy+w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000134, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/28/24 3:40 PM, Sebastian Andrzej Siewior wrote: > On 2024-05-28 14:34:55 [+0200], Vlastimil Babka (SUSE) wrote: >> > The safety of the counter update is already ensured by >> > VM_WARN_ON_IRQS_ENABLED() which is part of memcg_stats_lock() and does >> > not require yet another check. >> >> I think here it's __mod_memcg_lruvec_state() doing the VM_WARN_ON_ as we >> don't go through memcg_stats_lock()? > > It is either VM_WARN_ON_IRQS_ENABLED() directly as in > __mod_memcg_lruvec_state() (which is special) or memcg_stats_lock(). > > Do you want me to rephrase this part? I think just s/memcg_stats_lock()/__mod_memcg_lruvec_state()/ in your phrasing, since we are removing the lockdep assert from path that calls __mod_memcg_lruvec_state() and not memcg_stats_lock()? Or am I missing something? > Sebastian