From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E554EE7717D for ; Fri, 13 Dec 2024 14:06:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 790AC6B0093; Fri, 13 Dec 2024 09:06:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 740336B0095; Fri, 13 Dec 2024 09:06:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5B9DC6B0096; Fri, 13 Dec 2024 09:06:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 3E2B36B0093 for ; Fri, 13 Dec 2024 09:06:43 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id DA47F1A0F90 for ; Fri, 13 Dec 2024 14:06:42 +0000 (UTC) X-FDA: 82890110898.18.1A02B4D Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf13.hostedemail.com (Postfix) with ESMTP id 2BF4E2000B for ; Fri, 13 Dec 2024 14:06:14 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=b0sfmrtd; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=3004Wz7M; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=b0sfmrtd; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=3004Wz7M; spf=pass (imf13.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734098781; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LDSa2olsfTBIt7ipj8DGwL39NNeIxDdt5QJrbM8lt34=; b=LRDrJmzyPxpRnvQCGJoiPiYAXD9nYX7TjeqPhFDqqNypKD2/y7LSHQttuT2RNO2oTffNFm cuEi7yevcWsylFinL0dzUoaMO63OQNXgLv9TpYv1MejnwJEY9mkebFzGUld29XOMR/bfd4 a8rFTXjnSwa5YHSYyJhYbdA6Az8Obf0= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=b0sfmrtd; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=3004Wz7M; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=b0sfmrtd; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=3004Wz7M; spf=pass (imf13.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734098781; a=rsa-sha256; cv=none; b=fxdffvFY3VnAP+/+LznkxwNt37Bc7eEmE3PZVUJnAT50eCTNfbvpq9UokXodKwX2vS00L9 LhuWLm1pJStcDsZeButKP4PJefyyWMe1FgmU0rG88XOrJNk5rdJh44GlY/TUHJNDER4wAb hCxay0VYnd2rZc2sKA+09R5jfdNAvWQ= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id B96461F450; Fri, 13 Dec 2024 14:06:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1734098798; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=LDSa2olsfTBIt7ipj8DGwL39NNeIxDdt5QJrbM8lt34=; b=b0sfmrtdDTZ3moXhQwT8486sttYL/QKB0tOwk+9bQC7rBqPIym4NzNuyu+Gi1Y/MbZaY5F xl9FRBWhMNZzpgATZwQ9Cgh4/H+sQruOi43AglgpEqB7LrrYSce6W+tUQpDZEIxGtBSQrK 3Rl8dmHVK+KklcFOmwZ1yIsKVDuSlB8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1734098798; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=LDSa2olsfTBIt7ipj8DGwL39NNeIxDdt5QJrbM8lt34=; b=3004Wz7Mtil6y3DHc6Q1r0O6rc/QGmqLIhnAG5Z+j8Bkti1pWZRh/XjWqNB+N6h8pMgq8A Gxn6mzUphHKklfBg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1734098798; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=LDSa2olsfTBIt7ipj8DGwL39NNeIxDdt5QJrbM8lt34=; b=b0sfmrtdDTZ3moXhQwT8486sttYL/QKB0tOwk+9bQC7rBqPIym4NzNuyu+Gi1Y/MbZaY5F xl9FRBWhMNZzpgATZwQ9Cgh4/H+sQruOi43AglgpEqB7LrrYSce6W+tUQpDZEIxGtBSQrK 3Rl8dmHVK+KklcFOmwZ1yIsKVDuSlB8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1734098798; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=LDSa2olsfTBIt7ipj8DGwL39NNeIxDdt5QJrbM8lt34=; b=3004Wz7Mtil6y3DHc6Q1r0O6rc/QGmqLIhnAG5Z+j8Bkti1pWZRh/XjWqNB+N6h8pMgq8A Gxn6mzUphHKklfBg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id A3087137CF; Fri, 13 Dec 2024 14:06:38 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id Pb3+Jm4/XGcOFwAAD6G6ig (envelope-from ); Fri, 13 Dec 2024 14:06:38 +0000 Message-ID: Date: Fri, 13 Dec 2024 15:06:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: assert mmap write lock held on do_mmap(), mmap_region() Content-Language: en-US To: Lorenzo Stoakes , Andrew Morton , "Liam R . Howlett" Cc: Jann Horn , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20241212114841.55185-1-lorenzo.stoakes@oracle.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20241212114841.55185-1-lorenzo.stoakes@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Queue-Id: 2BF4E2000B X-Rspamd-Server: rspam12 X-Stat-Signature: 113ji955oy8oobf9mggznxoj6husj9bz X-Rspam-User: X-HE-Tag: 1734098774-799327 X-HE-Meta: U2FsdGVkX1/eEsT4v8WV/qHYY98R+6YxFAJOafjL+YI++w0cHdmIebhbJ5UA7rQHOyjuw3BBRo1PLoGRXJ4fvMKnGlgXu8sYVNy0QwcXxItTtixID3nUNmlw0lYbCOsYAAQqd2pN7PgoVmGWP1nnSx6L93XB7x9KMED0x2NBHgFy+qQhuZmuCxHAltyIXV+7l2zDvVSPHLrSZO/bMlsydt7+T22Af930+42ig8legbG0jX/5FTmhTRgbq5GoX18iveyJTlXXIebHzYTifYUwTzAGI7WTt/GOs1RW/4CvBZDT+2/sAD2CfNCQzj+ieFc1ROLOo93YCBIB+T5AlCyshTncmKtqQ2wPF3y6uT5t9XsyWE/8TK7EWvsdMPgphi4zGIyGl0jaoWpmT+Zr13y2YemsX3Js7+r7hj/8tpEdKvTs2Y/6J986RZe5XWL/f7ygaqPtmy3U2+qTZ2td6BvFm4swpc5xb/JxWJOgSh36rZiptx3Ur+8FAyG1seT9FLY1J6insEC3xq1owFezyTi3htTkKY0IcREMrfbO8kRjJ3dPdUzq2mcp/cHG6aA8GddPpsx+KiX9DVNoIZY4fyUCghHuHeTdF+2C5J9ScSLfZHyoFT7TP/KAOLdpdC44sKsAOaxa147QzE/XiM9vzRNZJbj2XT9W1DCvCCL9yrXzQ5NEMqru0kT2lGk7kbCeE/19q2OaD41j3Ttkm8TWR5puh1biUObVl0h3IdZItH36AbMXWBUFIZsOtp9P7LFErZ9l45I5ha7Qm+qbdlu90IjHwToy7JybcvEeBtdc4q9dkpnWGdWzPkc7ARaVrmGPKKtcoMtPPqxLTMoNN9btmZtdDFiD2mEg1ES+ZL3FQ1VcYl5gwoMAKMNZZ8KuX5j4zN/1IMSfrqESs0GHImU+DZIqI2HJ3nbnLVXVH/q8hZ77s8bxvWtyBRdtpitogAbyYUVaTNoyFEQZASAM0d8v+1o sxsOvtxe xap8T/a4clx6hdRz0k+1w2JdOtMm8vzbN4g8prfPvGDxvbCYpHw6f3ZT/bmEvKQn+T/m0EEYzwfqtEATRzsbMOZLZoE81qb+HOU2TnubS/k1WuB9D6m4JHKGeiEk+JzeGFHf4WzenvTPhPKi7LBo/CeGSngYiyqe6bnX+Yis4PfVwEq6gFE3HLKYp9lMW4lQzW381yuDooR/IuATebMV0UJhq2ds5/8/Ndsa7xA9cDKuXXf4PoMvDSMXkpBfNfOsKkVsr6SiEXvTy494TdC2GgHHD3kmklOUImk+bND5QpyfokuNsfe0YS1sZY0MZ0WRHjomEJdAj7I/IN9UL1jw7xpxDVUaALqmE02oH X-Bogosity: Ham, tests=bogofilter, spamicity=0.003225, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/12/24 12:48, Lorenzo Stoakes wrote: > Both of these functions can be invoked outside of mm, so it is probably a > good idea to assert that the required lock is held. > > Will only have an impact if CONFIG_DEBUG_VM is set, otherwise this amounts > to no change at all. > > Signed-off-by: Lorenzo Stoakes Acked-by: Vlastimil Babka > --- > mm/mmap.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/mm/mmap.c b/mm/mmap.c > index df9154b15ef9..43ef85028921 100644 > --- a/mm/mmap.c > +++ b/mm/mmap.c > @@ -291,6 +291,8 @@ unsigned long do_mmap(struct file *file, unsigned long addr, > > *populate = 0; > > + mmap_assert_write_locked(mm); > + > if (!len) > return -EINVAL; > > @@ -1023,6 +1025,8 @@ unsigned long mmap_region(struct file *file, unsigned long addr, > unsigned long ret; > bool writable_file_mapping = false; > > + mmap_assert_write_locked(current->mm); > + > /* Check to see if MDWE is applicable. */ > if (map_deny_write_exec(vm_flags, vm_flags)) > return -EACCES; > -- > 2.47.1