From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0E21C04A94 for ; Wed, 9 Aug 2023 13:44:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 478346B0071; Wed, 9 Aug 2023 09:44:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 428BE8E0001; Wed, 9 Aug 2023 09:44:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2C9AD6B0075; Wed, 9 Aug 2023 09:44:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1D1276B0071 for ; Wed, 9 Aug 2023 09:44:58 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id EA465C0F11 for ; Wed, 9 Aug 2023 13:44:57 +0000 (UTC) X-FDA: 81104687034.06.CE96ADA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf02.hostedemail.com (Postfix) with ESMTP id 8C3BC8002C for ; Wed, 9 Aug 2023 13:44:55 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=a0FRRlZl; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691588695; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fqyuetX9IJT3wFdf5PzPuqgqYvLR1G43I+5Kt2esilQ=; b=gY/AIBmzmlL6iVS7LpFA8HSp0S09tNkGeutZ2cNlDo8kMbFZ36vxCxhjOf0hPDHBAxuid7 kGX3OHd1oakmtLVIMnC2TJM356Uv7s6BQedlOSK/rIIYMacqV1EANRYCl7jeU2zsIFSnND UAsZqZEccmQTaMcd0dYYhQkwbh5rhYs= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=a0FRRlZl; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691588695; a=rsa-sha256; cv=none; b=fYROIUwax4qOLqBKpLA/S0TwYg90ifc9B0/Eqt8t9grNRLbhDejUAx6bafRFo6q2L7xpu1 O821zV2BHzI4Ilwy/BJ0V7w3o6EMwJUZbFh03L5EJqc8I1Ogyl1X7/4dX211FcEGJT+Axr M6zcz/DNvQqFc48EnTUYGIK+ZekQcVk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1691588694; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fqyuetX9IJT3wFdf5PzPuqgqYvLR1G43I+5Kt2esilQ=; b=a0FRRlZlN9HNC7SBswQxHU6Dw/u/FKVWD+IGJDL/nbwAE6Dwo9BGOGvi3HyU4m/aBsVhLV 2n8hmILEMUKeuyEe8thUo9SYjuZSm8AoVXoQvFkHxLHl954g2v2mL/SxrCbnUAmRh4nvDf 7dG/Al1zd2FFXKMHNN41zSGbnpmFyu4= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-88-sLvlcu1pN9adf6oDZjkmFQ-1; Wed, 09 Aug 2023 09:44:53 -0400 X-MC-Unique: sLvlcu1pN9adf6oDZjkmFQ-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3175bf07953so3484899f8f.2 for ; Wed, 09 Aug 2023 06:44:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691588692; x=1692193492; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=fqyuetX9IJT3wFdf5PzPuqgqYvLR1G43I+5Kt2esilQ=; b=JhfL/8UUGDMGfmWoaqmjT/LcuKtLH3/FuwXyN+XGZ42i6mEVKJBHXAy6Alic6P5m2J PFj0zTd1aqyRwbw11im/zhQy/TgXHvdvm5nP36n/VPRvNrhzPRWg0lCR4s55khW2W4F5 53T5NrUGDGKa9lYfXh8Vmkf4DafCbbRnRVHHimHPo+tCU00Lpr/eYOGEBOaw9mMG7NYp xa/W6FeySqozW9mQd56cETkzZuhxC5jx2Fhl8oSvLX0znR2uJdRGwz5pKsTMxOTrjGPa uq8YmHNf6Tk0aDLkMHB8nKZQ5/g3QjFSnrejcwWqXodpqC/JvwpoSVfbuHylNJdNSCiI XTcg== X-Gm-Message-State: AOJu0Yw85j8AJWuS5/CI6J5ogWs8tGWqwOttuY45XauWvuf8XwcIXaxi 32Uay/oX6pUGZjg/zKvlYwOIEqkogc7k4rXxkfP8+GeCLJSpU6uQfDyxqixYLHkIlOjPWT4xBfS 3evxpsL3kUSk= X-Received: by 2002:adf:e981:0:b0:317:e1fb:d56a with SMTP id h1-20020adfe981000000b00317e1fbd56amr1743163wrm.40.1691588692314; Wed, 09 Aug 2023 06:44:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEjeSdz5eNPntoLhhuXJEctdu7hjG/fuc9nh53OsgkyCdsSOcm8Bhd2knlASGCJP7RkRKkrNw== X-Received: by 2002:adf:e981:0:b0:317:e1fb:d56a with SMTP id h1-20020adfe981000000b00317e1fbd56amr1743151wrm.40.1691588691933; Wed, 09 Aug 2023 06:44:51 -0700 (PDT) Received: from ?IPV6:2003:cb:c70e:6800:9933:28db:f83a:ef5? (p200300cbc70e6800993328dbf83a0ef5.dip0.t-ipconnect.de. [2003:cb:c70e:6800:9933:28db:f83a:ef5]) by smtp.gmail.com with ESMTPSA id j6-20020a5d6186000000b0031455482d1fsm16810387wru.47.2023.08.09.06.44.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Aug 2023 06:44:51 -0700 (PDT) Message-ID: Date: Wed, 9 Aug 2023 15:44:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: Replacing walk_page_range To: Matthew Wilcox Cc: Sidhartha Kumar , linux-mm@kvack.org References: <531ae10b-6911-8520-893f-8b87d55a9d9c@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 8C3BC8002C X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 5grtx1nwcircjq384x5qmyz7p7utu8t3 X-HE-Tag: 1691588695-345506 X-HE-Meta: U2FsdGVkX19JYXsbQzfLp2KH7svUq33UZpFlD+HHgTwKY21LdLTtxZBDZbLF4nRi4xsg57hxc1NzhXpJejFQJdHJyJE1baj9IIhgYMXS+OP/1tp2ertMgKB5lhkaDmViFTitlB6jpyxwkhGKuJBdcZwHVrswSBdzwACeDgd7s0eHEyaN5CYugrgBeY86f7qOR9YTH7V6GlWzfORCDywWCPHW97hO3gC4x+Vy/nRoil/HDDndaqCcqIW7lEnMdtEFb6tX/zwU+lwwrRdbU1OGuNlB3ePYtd/oNTWZPreXIGTC/lzix91fnOkvDmfHl4cZIO98uFBvNuNu1UHrHFka2HjiU8uUKFCVhmrUGBI1dJUR7IUQXWcWEuNFCwZREx5+eliImx4XkDB29ezbh1sQlkrMnAH5vdU1mBhGp3LnKH/19RPSu5sFsr2ytlCj95cCAY08KJXaWZJvW2iHGDsCOjgnGftOe+AiRT5aNJK1YUHb6JfY85qvjuMvpPZLGrQGUVzrPfONt3AUTRUEBRPmlAMNyFd46JSYcHKlRFCtxU+9jt5YZOC/ZLAHZLRiaMQ/AHORGWBVWlswD6xZ/XBJVAy15rs91z42p0ETUK16N9wj4spB63KDM6FHMv2mRJX9DK34gJJM0OYj4kG1uCyDFtWAX5qEwOB5GXcsfuJudEXKuoql4YCCFss9qM+UHjgNDipFfnW45rFktz4A6lu/OHME/ymXAKEMag7tZOymK6b8JccwIuF5W7Qd1tyM2gQSLybRVKubgfSMoZMwPNMn7lbQZvZip4HzVXV87VPuCoSSe8Qo8qA7POgabVHuD9JnmwjQt1xTQ+1myQSSxeo2ipj6dR39HuqjsqhdaifwwuxMm9wH6fMyUpmmCjW/lzDPaAZLa5FQCa4Rio1BJ/LHDkGOe90Ruwo7D0cNTu/cj5JLNSBAEHHneZ6ksAxcs43+3V5pf3Qn490HAcJK2Fc naS9LuD8 AfZkytY7+XTHh0hT0/i1juKr45DW9nQETyh7J3nr36wKMqKmBhlHUqijI5kF+gLf/32qsc/VOGkhnD/XiG0JSaAQp3SDqScmoozVWMoj+tg+eI1JoY8yNoAByoTAMpeyWZ8XHY39TbP0lNMWrxoJjICxKI0hBx+CscotxhWgDvEVgo8UB/J0JhdqTTEqGguH2l2Ix9Tz6Udupzd1QC7ayj03cnnF37bGuuoyOZAe1vgxQvsr9n2NFHa64yMZdnls+/RS3/EV/pf1lazllK7yQk0uZMQWcOsHH8fvbRkySDdkCiZwicjyMmsuRgQreTUySN2lNQMrNMrIOhuk9NCm5ydH1W+pWLq/j9yCelFbpihBQapV+W3lsaDRzPVAxE80NZNGFYJzcKEZmomFfNjut5lsADV+fEBZEN9uUD1F9QXkO56g= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 09.08.23 15:09, Matthew Wilcox wrote: > On Wed, Aug 09, 2023 at 09:35:01AM +0200, David Hildenbrand wrote: >> On 08.08.23 19:09, Matthew Wilcox wrote: >>> Sid was incautious enough to say he'd like to take on fixing >>> walk_page_range() so that hugetlb isn't treated specially. This is >>> going to subject him to one of my rants, so I thought I'd share with >>> everyone before we meet to talk about it later today. >> >> Are we only talking about walk_page_range() or also walk_page_range_vma() / >> walk_page_vma() ? >> >> I tend to like the VMA variants ... > > We're talking about getting rid of mm_walk_ops. There aren't exactly a > lot of callers of either of those functions -- 4 of walk_page_vma() > and 1 of walk_page_range_vma(). Okay, I see. For some use cases, it's probably sufficient to walk folios. But we do have some advanced users like fs/proc/task_mmu.c. [I do have two more follow_page() -> walk_page_range_vma() conversions lying around here; they want to also know if a page is mapped writable] -- Cheers, David / dhildenb