From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47A99D3ABCE for ; Mon, 11 Nov 2024 17:01:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A8D176B008C; Mon, 11 Nov 2024 12:01:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A3D2E6B0092; Mon, 11 Nov 2024 12:01:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8DDA76B0096; Mon, 11 Nov 2024 12:01:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 703646B008C for ; Mon, 11 Nov 2024 12:01:20 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 21AE81C7A13 for ; Mon, 11 Nov 2024 17:01:20 +0000 (UTC) X-FDA: 82774428744.12.B174E75 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf12.hostedemail.com (Postfix) with ESMTP id 2778540027 for ; Mon, 11 Nov 2024 17:00:58 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=none; spf=pass (imf12.hostedemail.com: domain of shiju.jose@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=shiju.jose@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731344246; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5fANvS7K2Jm1cYVi3OWIvZAyHRHxDroqDPJfIS5Xlx0=; b=xAts8nOxxD70vxO5A5OsuvcCixsdS0nlYEwugVdfSdQyLU/ym5dH4+EasEF7VX/VZ0qK3f B8vZHVoHAcp2L1+ctQ0o5K0aN9WxgxQRVXAQzfjxi5NTzhpJrvluLCs751GStCgEdn7cAc Qc8DXJZOcZJ7dxmcpv3M4WN9TTAkIyk= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; spf=pass (imf12.hostedemail.com: domain of shiju.jose@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=shiju.jose@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731344246; a=rsa-sha256; cv=none; b=ptbq+ZlJdsxsGiJTAbhJjhY7fklM+mPXV9k9zuOb4cvGUXAPDvx4o3IE3pjXBhzo61VlpV xWF1PQzTigcfMJBu03LGAFJqyCpkaXyb9UZONMSxi6F55PGjBdIpsIaBv1ti7RqnMXtGJy /foXozVyxUIAbsyZVjSKfZKQFV3RJgU= Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4XnG5r6N5vz6L72m; Tue, 12 Nov 2024 01:01:04 +0800 (CST) Received: from frapeml500006.china.huawei.com (unknown [7.182.85.219]) by mail.maildlp.com (Postfix) with ESMTPS id 12AB6140B3C; Tue, 12 Nov 2024 01:01:15 +0800 (CST) Received: from frapeml500007.china.huawei.com (7.182.85.172) by frapeml500006.china.huawei.com (7.182.85.219) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 11 Nov 2024 18:01:14 +0100 Received: from frapeml500007.china.huawei.com ([7.182.85.172]) by frapeml500007.china.huawei.com ([7.182.85.172]) with mapi id 15.01.2507.039; Mon, 11 Nov 2024 18:01:14 +0100 From: Shiju Jose To: Fan Ni CC: "linux-edac@vger.kernel.org" , "linux-cxl@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "bp@alien8.de" , "tony.luck@intel.com" , "rafael@kernel.org" , "lenb@kernel.org" , "mchehab@kernel.org" , "dan.j.williams@intel.com" , "dave@stgolabs.net" , "Jonathan Cameron" , "gregkh@linuxfoundation.org" , "sudeep.holla@arm.com" , "jassisinghbrar@gmail.com" , "dave.jiang@intel.com" , "alison.schofield@intel.com" , "vishal.l.verma@intel.com" , "ira.weiny@intel.com" , "david@redhat.com" , "Vilas.Sridharan@amd.com" , "leo.duran@amd.com" , "Yazen.Ghannam@amd.com" , "rientjes@google.com" , "jiaqiyan@google.com" , "Jon.Grimm@amd.com" , "dave.hansen@linux.intel.com" , "naoya.horiguchi@nec.com" , "james.morse@arm.com" , "jthoughton@google.com" , "somasundaram.a@hpe.com" , "erdemaktas@google.com" , "pgonda@google.com" , "duenwen@google.com" , "gthelen@google.com" , "wschwartz@amperecomputing.com" , "dferguson@amperecomputing.com" , "wbs@os.amperecomputing.com" , tanxiaofei , "Zengtao (B)" , "Roberto Sassu" , "kangkang.shen@futurewei.com" , wanghuiqiang , Linuxarm Subject: RE: [PATCH v15 11/15] EDAC: Add memory repair control feature Thread-Topic: [PATCH v15 11/15] EDAC: Add memory repair control feature Thread-Index: AQHbLD8AfemaRx1ca0GejEwzrXB007Ktlc0AgATHjxA= Date: Mon, 11 Nov 2024 17:01:14 +0000 Message-ID: References: <20241101091735.1465-1-shiju.jose@huawei.com> <20241101091735.1465-12-shiju.jose@huawei.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.195.246.235] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 2778540027 X-Stat-Signature: 7hf8yd9g69mttxw1qf5686mm9b1jztn3 X-Rspam-User: X-HE-Tag: 1731344458-17811 X-HE-Meta: U2FsdGVkX1+WLz25q8/9ASzXkcVkX7GgQK9QSjSOCfPbw68sW46QjPGcRlIzXw3VcHeqOEwxyblN2KJHM8eBidknsafARrZV+reBo2wnOOOI2r7siTbDrF7R2Azq/T2AMW1AxZnZ0VzrfxL0glWHu2hv4gA4sOSp6USdCaQgT08wXgerqk3DJ1rk9q83o0QpijRdy9L6xdSK+5Fq2vHRdL09Be+03813UHAY4beyfJotRPtbiJt6maYpxeGB6M1SLG+dn/uZHc4Y6yeTvnwjISUN6q1usiasO+H3lziqGUwBOCEhJtNUNej+yZa42dojJ6xOseRaKOoRfYS0JdV3eWsYyRzDPg1asKpK0OMxPmX+ZFoREOiHBtBng9lwCmWPxuFoh7ETcy9j/4f3X1hQ9Rkncgk/Ube0G4WR0iJhRnfO0IaltIe3HzTLhA5P5akn8gfqU67nIkUpWl+Tb0kG8AQ6NAEuYrkQRXnj7E88dkCwEcMRSkxX/DMe+zVX7xXgi5GfS7bc5le8Xqu/5/lc5w4F3V8JlJFXABwWDZ5llzcHiI1fCSDnkFz3O//q/vkgEYxyg0yDlM/a9xwOncvpxjIPuwf9D9QArVGBy1TtFTAYM07ylTVHhO1fy5smRiAXcIYc0oaf31TctxU18u0HeeDt+N4NuaQtdN9QXk5cNLQwuNLnqgZjQrNJCQpAjsMFWrrjICp5Jne4yojnQ9jh/QOdvPejO75QNUcoHs/7IRMf4Co9HF8NYuv8QLWPXDU8mCvHKP09WeWSZ2iGQ6rXYiE2+jNoB5b4RVovJVx7vv1AqhUyW1IvUkhUySIXSHH7SuTmk2vT8+jF09CqN5Da08ljQ+YRn2hUzZXpjx2s7NXu/nMuUXMd49LLNyOPUjkcqOK4LRqum7V0a6lbZIA01nqOBFG9cYBmQWWMJ3+Ish0racYPLLgYLSyrRqMPoyEjPNPi62uuSIwQnCfTpk9 D4O2T1SH jeIymwIBJRzoqhf0c7o43iNhCS5KbJUmx+3gQMq8171B5WNeIAZkOKi3YQOZVIzevwPJg6hgozMtagXcS/VN+TEddlZ+LIH/6hwahevgz2xR3wLRXlo4gPcdLHjd+LtFXFilgc97CcZ5gas7mzWF444h6H9cgdrgp0OyMLn4UUa8tm/fw51h5RLEIEhYwmfhjtF131pFbUpHHQDz+OPPirly1bZj70hFSl6C6WnrQBRc1FrgK0Wt+ETk3hROL6PHB6Lgul5LknhIkelUxQ8bk3vMkQSiL6YeOp5ZUpCsOwGLjYr4gcIqjM6OArMskceQFf696b2Vyy9A4sdqQ5kCEiqUFPSoqdcDMjBwc/LtoQt7HPC6csZFaHGtm0u62PoLdMnWJvj68VX1XScpBHrBkyT1odpQ+AYNs+frBbRWjoxZQaNEYpXAk9xd8JwhAWwF2MRuR0DnxOJBgzqIiU1XX8jb7CFYM9HXgvcIzenDnuP5smoTx67rsXdxhs8rgW3/+LPYAU96a3wsegFWoYPCnynhmaQOrWRGtfXDmPRiFfi5AVB39IkgnTomaUcVpBDOC9EWrXO8OEiLhJurBfvshT0LW6fPPAKHdjbuQ7zpJtgiVGjHv8xGzRWrtBA+zks1+8xHdDkNbInpoyyAkrXldGxmtK0B95tTMos2cVzeA56ItYtah45Hz3rEASeBn2tiy5s3KEPlSuMBveO+oXyq9pYZYkp+Dafb7GadnnakxQtSUzdJ0MJwI3dHWQwhuKgkZ/fhrKbmtF4td/drHAggmfv2ft+DFv5oSKn+B5hcjCMotYyJ5vcmkKjDdG0h2ipKSkQFArSjbJ4DVUoJqu1p8QRghT3eF1qcVGbtxUR68Ce9wqLaLAs9MNdevy6wzFfZR26h3D5XGD+JKYy4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >-----Original Message----- >From: Fan Ni >Sent: 08 November 2024 16:59 >To: Shiju Jose >Cc: linux-edac@vger.kernel.org; linux-cxl@vger.kernel.org; linux- >acpi@vger.kernel.org; linux-mm@kvack.org; linux-kernel@vger.kernel.org; >bp@alien8.de; tony.luck@intel.com; rafael@kernel.org; lenb@kernel.org; >mchehab@kernel.org; dan.j.williams@intel.com; dave@stgolabs.net; Jonathan >Cameron ; gregkh@linuxfoundation.org; >sudeep.holla@arm.com; jassisinghbrar@gmail.com; dave.jiang@intel.com; >alison.schofield@intel.com; vishal.l.verma@intel.com; ira.weiny@intel.com; >david@redhat.com; Vilas.Sridharan@amd.com; leo.duran@amd.com; >Yazen.Ghannam@amd.com; rientjes@google.com; jiaqiyan@google.com; >Jon.Grimm@amd.com; dave.hansen@linux.intel.com; >naoya.horiguchi@nec.com; james.morse@arm.com; jthoughton@google.com; >somasundaram.a@hpe.com; erdemaktas@google.com; pgonda@google.com; >duenwen@google.com; gthelen@google.com; >wschwartz@amperecomputing.com; dferguson@amperecomputing.com; >wbs@os.amperecomputing.com; nifan.cxl@gmail.com; tanxiaofei >; Zengtao (B) ; Roberto >Sassu ; kangkang.shen@futurewei.com; >wanghuiqiang ; Linuxarm > >Subject: Re: [PATCH v15 11/15] EDAC: Add memory repair control feature > >On Fri, Nov 01, 2024 at 09:17:29AM +0000, shiju.jose@huawei.com wrote: >> From: Shiju Jose >> >> Add generic EDAC memory repair control, eg. PPR(Post Package Repair), >> memory sparing etc, control driver in order to control memory repairs >> in the system. Supports sPPR(soft PPR), hPPR(hard PPR), soft/hard >> memory sparing, memory sparing at cacheline/row/bank/rank granularity et= c. >> Device with memory repair features registers with EDAC device driver, >> which retrieves memory repair descriptor from EDAC memory repair >> driver and exposes the sysfs repair control attributes to userspace in >> /sys/bus/edac/devices//mem_repairX/. >> >> The common memory repair control interface abstracts the control of >> arbitrary memory repair functionality into a standardized set of functio= ns. >> The sysfs memory repair attribute nodes are only available if the >> client driver has implemented the corresponding attribute callback >> function and provided operations to the EDAC device driver during >registration. >> >> Signed-off-by: Shiju Jose >> --- >> .../ABI/testing/sysfs-edac-memory-repair | 168 ++++++++ >> drivers/edac/Makefile | 2 +- >> drivers/edac/edac_device.c | 32 ++ >> drivers/edac/mem_repair.c | 367 ++++++++++++++++++ >> include/linux/edac.h | 87 +++++ >> 5 files changed, 655 insertions(+), 1 deletion(-) create mode 100644 >> Documentation/ABI/testing/sysfs-edac-memory-repair >> create mode 100755 drivers/edac/mem_repair.c >> >> diff --git a/Documentation/ABI/testing/sysfs-edac-memory-repair >> b/Documentation/ABI/testing/sysfs-edac-memory-repair >> new file mode 100644 >> index 000000000000..393206b8d418 [...] >> >> + if (mem_repair_cnt) { >> + ctx->mem_repair =3D kcalloc(mem_repair_cnt, sizeof(*ctx- >>mem_repair), GFP_KERNEL); >> + if (!ctx->mem_repair) { >> + ret =3D -ENOMEM; >> + goto groups_free; > >If the function returns here, we will have a leak from memory pointed by c= tx- >>scrub. Thanks Fan for reporting.=20 Fixed. > >Fan >> + } >> + } >> + [...] >-- >Fan Ni Thanks, Shiju