From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 849FEE8FDB3 for ; Tue, 3 Oct 2023 21:08:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 019468D0092; Tue, 3 Oct 2023 17:08:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F0C648D0003; Tue, 3 Oct 2023 17:08:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DACC58D0092; Tue, 3 Oct 2023 17:08:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C8FFC8D0003 for ; Tue, 3 Oct 2023 17:08:32 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 9B654B3FDD for ; Tue, 3 Oct 2023 21:08:32 +0000 (UTC) X-FDA: 81305388864.10.B6A8B93 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf14.hostedemail.com (Postfix) with ESMTP id 5BDB010001B for ; Tue, 3 Oct 2023 21:08:30 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=c9UaHypH; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696367310; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iZqudPdFmsqAX0i25tQhq4N6QuLZbaMC0GnCxXAloB4=; b=jni8n9qMPkotQqWI2V4ZIL41jeG6gBBUCoRElN4jFarFpw42clLRplrPS8vGZVKNuoInAs fpxyv4w8buqpSwoIroe1MVukOWBCN9sQRQjbt/TQRS/MfOup0jxonk/y+oBXPmSZ9Och4F sr/VilMzom3ZgJ/tAofYyOCl/sJOkWY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696367310; a=rsa-sha256; cv=none; b=4yMygnnUy9l+zbBD9o/0Wzx9SCgoyPNExX6vT+UUXDfJx+bM4BDUn3aiCwPZTSr7dRjSGY If1bGe8aMLPffnhLSLcEEg/U4os9TzgRVr0+66hls7mUbk9K0v5DumqrUgFfQFxr0mvDYD IXYnkYHfFM47ivZInAnAU2fgkgeqLX8= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=c9UaHypH; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696367309; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iZqudPdFmsqAX0i25tQhq4N6QuLZbaMC0GnCxXAloB4=; b=c9UaHypHg+Ox5IW82cqS2rl2voJV/9EYq/TddKRyYx07i9kGqdNMdMGKtNqeXPpWHvCoCO ck5F24qJ8AqBYvWhE/jjiv6A3JWF3AxgNICg4A+PLVbrk+PKHL8LOnWGh7d5geDVnEFrsl brdwVepy6GY4fPkedELjAFMFc9kkDgM= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-435-wXYjlvhPN_2ANjES8LhgbA-1; Tue, 03 Oct 2023 17:08:11 -0400 X-MC-Unique: wXYjlvhPN_2ANjES8LhgbA-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-402cd372b8bso11030015e9.2 for ; Tue, 03 Oct 2023 14:08:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696367290; x=1696972090; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=iZqudPdFmsqAX0i25tQhq4N6QuLZbaMC0GnCxXAloB4=; b=pHUBvjSCxmVW52hAamMRBKQ9K2M5wW1tWEK3EeQytaHV+riE29/eWdax3URwLOdA42 psbacrCoh5InxCgbXfVoqqpgq4ZkWV5lB6MZiqK7NmaTqBd91/Do6AjNvwJSJ48LNk3c /FLvwTKpytzeNcQQrHkkVb8J/ohFa+/X2Bk7xyClxwZs3iTx3NCCW7P2SfKErb9lfBhM DNJvmrub+3HQcVqmghVAqsFdZWFF31hSq9jjMKPBdM5pVrwPZm2z0iCzbFZLlT+OtoM8 3oNQzwqFc+/uj3rz/RwHlBiwA54fRTFqbzO9XsKUB82YZUdTOcqdZ0KCV5cGV7PQLIhI oA/A== X-Gm-Message-State: AOJu0YxGBTjSP3xMLaDxWpLRg2E4eCdElTDnPxNWvA+QqlvEk5uKxT2+ QpdoHH13XOE3vZqAKHctRGkFRBUIMpdIDHPsJ+m1g1yPX0sESZn8zRlH5IZ8K2oRTxrlegi++Rw FGpNiHdtOHDU= X-Received: by 2002:a7b:c451:0:b0:401:aa8f:7562 with SMTP id l17-20020a7bc451000000b00401aa8f7562mr649102wmi.11.1696367290211; Tue, 03 Oct 2023 14:08:10 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF3Eewd0OYhzLMEft9jgHfzauv7z/0zio9oUhdJ+EuXuDZ6P60kvlN4IwqdpM02c5om1hVGew== X-Received: by 2002:a7b:c451:0:b0:401:aa8f:7562 with SMTP id l17-20020a7bc451000000b00401aa8f7562mr649063wmi.11.1696367289788; Tue, 03 Oct 2023 14:08:09 -0700 (PDT) Received: from ?IPV6:2003:cb:c736:1b00:e1fc:b01b:70f5:1985? (p200300cbc7361b00e1fcb01b70f51985.dip0.t-ipconnect.de. [2003:cb:c736:1b00:e1fc:b01b:70f5:1985]) by smtp.gmail.com with ESMTPSA id z15-20020a1c4c0f000000b003fee6e170f9sm31441wmf.45.2023.10.03.14.08.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Oct 2023 14:08:09 -0700 (PDT) Message-ID: Date: Tue, 3 Oct 2023 23:08:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v2 2/3] userfaultfd: UFFDIO_REMAP uABI To: Peter Xu , Suren Baghdasaryan Cc: Lokesh Gidra , Jann Horn , akpm@linux-foundation.org, viro@zeniv.linux.org.uk, brauner@kernel.org, shuah@kernel.org, aarcange@redhat.com, hughd@google.com, mhocko@suse.com, axelrasmussen@google.com, rppt@kernel.org, willy@infradead.org, Liam.Howlett@oracle.com, zhangpeng362@huawei.com, bgeffon@google.com, kaleshsingh@google.com, ngeoffray@google.com, jdduke@google.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com References: <85e5390c-660c-ef9e-b415-00ee71bc5cbf@redhat.com> <9434ef94-15e8-889c-0c31-3e875060a2f7@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 5BDB010001B X-Rspam-User: X-Stat-Signature: rk89o8yuaaguxcjs165dry79szycfg9u X-Rspamd-Server: rspam03 X-HE-Tag: 1696367310-350072 X-HE-Meta: U2FsdGVkX1+k9tI+CRly0fOj1CyDsbGSpZ30C0CSeYraM6DC4CM3jBMGm5pAOazCX+sMaQywlGhbnXteLpCxde/9wU3cpcgbSEOTrDXNsqL2oQzY77KAEnq8cD9Wx0peuzeaEz6hjvojPWk/u/mioRVbI17HOTUkkfUZKwnflYsPpwh0R9gSlHcReSN81poW9aShmjXHTUT9FBo/NmaYQ/YWgmg4qoToHPfjVMDG5p2ZIWn0HPqAoz69rLLiV3K5I188DEq8zAT+33mNRgOmLBVgpiiIvl3YnVLxB8ozBa9DvzIFePfPVmnT4EzTfxjaorFeqXUf4l/8XwEEEfwojlzstFS2h+2GmP8MzzwryBBHRIceYF61lAL9IM8wUENkbs+snRlGQGpQLH+y7XvNElQMHeIHrCWh+Mbx9VVNZf5p/ZsZYpgLAETSXRvDUTLt0nFNurp53yKftH/onQUub6CpfyVT0ZhG1RmhxheP9J4NfVPGBNFbgjVV7uFu2delFK77B7zyKHCWKLMF0sukk17rn5o8XZ5wHadXPM2N+psy8W3wyue3iC2gTbxy9D7NYR/4AMIHAq9t7XGpDiCkkEtGw/yIWYYNNMVeGAliRdXrWcc/C/e69jts87Te3yUrwpu+bZlXnZDbCxiheBEaagbULy3BP698xRkq3ZP8/B1TkqvMxIbf0r3R090naG1jXprojDRQ99rvvoZBh24LvOlA7w1CvVCmQGwAW9h6oezBuCpanh5W9ylu4Anz8rd/DSspBpO87OaDJXu+4y3+3yGvSKdba+eMFJPtxbSGwmmjztwJ1zppC6M9ZSiI5cNNPGVSljD0UKsv9bp2xa5hB14O/aoVZCWs6zdb45+SGCt+Pr/0SQejI14YlioNOQHLexGjl91aw1cIkAAnVQ/u8CpuNWYBFkbVCGBllKTJPetLgUpinqGtgLugnsv16yB8usK34rZPD8WtYfhzN/R pDrvGbOl aXfREHxCwCUTq9oYgijsdKmpLKTARaQ1H3D3DDQwL9VhODiVBHYeXC71q+WN7LVfoP0nwXKn9Fx2y7y+z4/6m9pvksycKNqATlbdcDLNyAb029G327LcTYNBpkL/WL7BeTNWLRs2jzw7+4uy2YwQmbAVHilN+2214d7yTw9JzIEqle8TPrb0GlA6wdWoRGlyqQvo/86JwIS8C7k6Y+cZJ4NOYF0vnUETG5aNF1ae2Laq+kJgGW6Y5WOK3uZiOmMfLFb59DSqpbiwepG0RhGdJLeLYeziDRmHPMK2QiYAaPU2xSIjCCSNIEQ+YJDpwRk1lfFyESVdh9RaymjJuRueWEpKrFqFluj4K0LVUd+f1S1TrXeD+UYL/L6v/hTX3CVY6xPEK9Ux15OpMlk86LgsE85DvhyPnzRzqOrsOzpYSpkQeYQE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 03.10.23 22:21, Peter Xu wrote: > On Tue, Oct 03, 2023 at 01:04:44PM -0700, Suren Baghdasaryan wrote: >> Ok, I think it makes sense to implement the strict remap logic but in >> a way that we can easily add copy fallback if that's needed in the >> future. So, I'll change UFFDIO_REMAP to UFFDIO_MOVE and will return >> some unique error, like EBUSY when the page is not PAE. If we need to >> add a copy fallback in the future, we will add a >> UFFDIO_MOVE_MODE_ALLOW_COPY flag and will implement the copy >> mechanism. Does that sound good? > > For the clear failing approach, sounds all good here. > > For the name, no strong opinion, but is there any strong one over MOVE? See my reply regarding MOVE (+zero-copy optimization) vs. REMAP. Just my thoughts. REMAP reminds me of mremap, which would never perform any copies, because it can just do more expensive page remappings (modifying VMAs etc.). > MOVE is a fine name, however considering UFFDIO_REMAP's long history.. I > tend to prefer keeping it called as REMAP - it still sounds sane, and > anyone who knows REMAP will know this is exactly that. Sorry I have to ask: has this ever been discussed on the list? I don't see any pointers. If not, then probably the number of people that know about the history can be counted with my two hands and that shouldn't be the basis for making decisions. But again, remap vs. move is for me a semantical difference; and as I am not a native speaker others might disagree and I might be just wrong. -- Cheers, David / dhildenb