From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49650C02188 for ; Mon, 27 Jan 2025 17:38:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C81BF28016F; Mon, 27 Jan 2025 12:38:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C3072280163; Mon, 27 Jan 2025 12:38:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A5BF828016F; Mon, 27 Jan 2025 12:38:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 7CED5280163 for ; Mon, 27 Jan 2025 12:38:24 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 31B8AC04B6 for ; Mon, 27 Jan 2025 17:38:24 +0000 (UTC) X-FDA: 83053940928.27.B29EDF0 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf13.hostedemail.com (Postfix) with ESMTP id CB90B20005 for ; Mon, 27 Jan 2025 17:38:20 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=JcY+bZS4; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=h63Vztft; spf=pass (imf13.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737999501; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=F8UA356wel7UbUwIjcqOkFZGUFdCb8XePuDVVYBmRrg=; b=ZsR42Qq0VvyXsIFfqpUhu3DvStZWMiM+uMZy2/SLM0EPc6ZAS0+sK472EdludeBv/Go0PA XauPKBWnkhtHXFjaYwi9Up+ELUBcLrfeHC1GDKqYPpU9s+YDWY5F8u2H6zTCwN1YgVJVqT TxvZ4IMIWqI3IBBgn5GNC0XfSoKCQ4o= ARC-Authentication-Results: i=2; imf13.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=JcY+bZS4; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=h63Vztft; spf=pass (imf13.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1737999501; a=rsa-sha256; cv=pass; b=6qvLPjItoI0ap1ZauVC3eR7EmXXiqq5ekrlZwVhPcavW7TqP1SGNf4FDN0H/3LzbONwl08 sQO8TdjbBYmMtDGY/uOtwF6CgxzLWHI8cnZvWzq+Ez5EznE6SAU/J8pQBci7kmDgYM1YlX GGfD1gXGjZcnBYvHzrIiNQbXKgMW1JE= Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 50RHbNaB021769; Mon, 27 Jan 2025 17:38:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2023-11-20; bh=F8UA356wel7UbUwIjc qOkFZGUFdCb8XePuDVVYBmRrg=; b=JcY+bZS45482+/jVyRjAATnJSRSteaiAvP H7z4U4XpTXh6srBNFXrfF2cHU8RprgSoE1ehZM71rSoHf5qZEQHK2UtrSlk9xCF4 IOmwGDwQ+f2xJME6Pvy4dKjDM2HhgaKdfEJysChiN6RF5EcV7jKCtP9Ucm0jAwIL qLBFt2aO6hp1tz1Gl67MqHUEUNoLDsfUZHgdkycjK0jWNQNq763TZKIlGF0PW9TN SnHnwguex4OvW9fTTwgBcZowbpworpxKGES/wEASLqMaL4t5O6XKcYyRObuO3u1i jTvAGVyQCrPfifZ43nzzjOmaU59BdoUzvnL0PuLqfZjNtRsKksKQ== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 44eeps000v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 27 Jan 2025 17:37:59 +0000 (GMT) Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 50RGr1E7023908; Mon, 27 Jan 2025 17:37:58 GMT Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2177.outbound.protection.outlook.com [104.47.56.177]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 44cpd79a0r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 27 Jan 2025 17:37:58 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=fgk3qeaq01IKsfUclbIM/9J19HQhNE+aNlzN8/P+XVovIQF7wg2ueIT2V8tnUuXYfy3Zb0x61y5NVQTe3vU7iiu2ckFYzX2nGFZ0IzzLl3gitEaIGNbml+fsO7i9/t9ZLXoJrNdExnhvWywj9LCR4n9YLqpL3SdqBIygXKUi1h4cGkFfuzLEJYR4f5boivBF4DCDcH0yS99B7ScClADXCZZQnJ6KcRDN6VntwqUqWPykKM+a2LAgbjMNQfb2RRruSXDwRoNPO7jquanoksvqqaSPDNhNDFveCO4IbO++09PPdWgP2rdQMJFVdSIAs6iMQrsjvbV1UtqsEmb9NnSW8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F8UA356wel7UbUwIjcqOkFZGUFdCb8XePuDVVYBmRrg=; b=favcWLyI/8/IMrnzMd2azxymp2jo4DO/90Q4wvf8M+A46GTo2tw4RrkqjCEhfDHnT5FWk8jf0sqbFQOozdJlNB2L36JWkMdWn8X8DLtBVlDg2WmcDIGOvMgJwqdpGr2yvx+O0Pu912KiaZpPuJhf7Um6KmH+0iiwVx/II5FDfJtSF23qttPBkTCbSMIACKhMEFoo5PiSVTsxNBd2GeYJVqVCgL204wHEDn1XPcQWm7//xSXruzHgladr9v//8BozltVArzNrAmlynAhJlWYXOebIiuHt6/cMI310+FiErgbc1uP9r18SxKkTH3wVZTvRGQc3Q/NRZCGziTKX90chmQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F8UA356wel7UbUwIjcqOkFZGUFdCb8XePuDVVYBmRrg=; b=h63VztftDaJqzR0KqB665MVd5YvqH8g1Uppo4kYAFnspB0s3L3ZArzvHIujhMTZlC395FrlOBCdaD5FBl/uC9JHjnwk8nfKgKqN4Zhvj1aZfyKed4E/gLvL9o8ddYzsaA51ntJGi5481HGKWaKotWKhSf0ISUcvOkRxHehU5xhY= Received: from MN2PR10MB3374.namprd10.prod.outlook.com (2603:10b6:208:12b::29) by PH7PR10MB6988.namprd10.prod.outlook.com (2603:10b6:510:27d::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8377.22; Mon, 27 Jan 2025 17:37:55 +0000 Received: from MN2PR10MB3374.namprd10.prod.outlook.com ([fe80::eab5:3c8c:1b35:4348]) by MN2PR10MB3374.namprd10.prod.outlook.com ([fe80::eab5:3c8c:1b35:4348%3]) with mapi id 15.20.8377.021; Mon, 27 Jan 2025 17:37:55 +0000 Date: Mon, 27 Jan 2025 17:37:52 +0000 From: Lorenzo Stoakes To: "Liam R. Howlett" Cc: Andrew Morton , maple-tree@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Oleg Nesterov , Masami Hiramatsu , Jann Horn , Peter Zijlstra , Michal Hocko , Peng Zhang Subject: Re: [PATCH v2] kernel: Be more careful about dup_mmap() failures and uprobe registering Message-ID: References: <20250127170221.1761366-1-Liam.Howlett@oracle.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250127170221.1761366-1-Liam.Howlett@oracle.com> X-ClientProxiedBy: LNXP265CA0066.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5d::30) To MN2PR10MB3374.namprd10.prod.outlook.com (2603:10b6:208:12b::29) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN2PR10MB3374:EE_|PH7PR10MB6988:EE_ X-MS-Office365-Filtering-Correlation-Id: 7732f2f7-e00a-4956-b930-08dd3ef95510 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|7416014|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?iQVK70UDd9P3dNC/LEMC25+z3PvRCakJxxD84FlOkcL4aEgitGPbXYsrldK7?= =?us-ascii?Q?Z40XVj9QQFqR03f7EH3/NJgyK3w63NZmzeruXaDVoU+0rpDwkxqgsxCtjuLB?= =?us-ascii?Q?bV1fFsZrdP01BH5qcYUirrCpxM+biaWQtzPHhFz0ATHRkSkTDIn9ROJSMbtx?= =?us-ascii?Q?n2H3rfANBpk74hlOlxhMSaeVEP8adGxuyquXvWShM8IYpUXkYflF/EsgZzFJ?= =?us-ascii?Q?vDSzZcTn5w3NsTDLs49NgL6KlqmA3TN481pvTd+3p8MTkviId25w2lLG0KD6?= =?us-ascii?Q?IOQ4c6/VTXe98634vH4xQPtKRkzPxo96yUmp7eREVYrJEAMglyqzGkN/4FhY?= =?us-ascii?Q?IKz4UcrMR9nNPFtZe9igFahWE8lfizi/hpJMhLP/mh9KBr47bqaRQfzTZ0cb?= =?us-ascii?Q?JYgARKSYYHYCqBuutkoRfALzMr4VlL73fxwrdXXk1/xQUPLudts/LUkRnBHc?= =?us-ascii?Q?tkikz1r70iCOKrc4e4JbX6cubX+kuGzI7gasgd7S+AyiqY0dnNQ8DktDKXSn?= =?us-ascii?Q?9bSiyzbleixJQAlNQTZtBO8SX3S3GCXWzjgvbbqnFa/3Y/w6Ii2lrH+svRv1?= =?us-ascii?Q?6dETEt57jeKCVHh1GcqkeJVMTm3yR8bhwt1u0PyuzO8m3hbSXOMlkgaEZg50?= =?us-ascii?Q?6JqUgehJiKJ/TAklcokerIoFfSCrl6kvbpfUo4cZNFCxKCfNeEI3I6nZCczR?= =?us-ascii?Q?bv9b20PQ2A+PeBYfYXqIjbnWfm8TRiglg+DatQYzZjLU67gXHSAjBPeTF4AA?= =?us-ascii?Q?rEi3XcSsqkadUn2q9aLXkKz+9A7JKTGV2rqOnNaN8d3rdp/EyCPQRy3zwPje?= =?us-ascii?Q?4fnASdl81bFnv0Wet/7uFj8DSIjQgUQ2pB4jT3atlU7HitDRaklO7RNwoMaa?= =?us-ascii?Q?OHAv2S60k2GixwO3bzzcS8xi+ykldcswDCUkLH0kstg/v2lhRw8gD+nZH9yG?= =?us-ascii?Q?+MnKaHdzcwrjlKFBYb4uFeF3HnW4J4LMf4C+LLeOGHgYYvdSiDbswGdp3xEU?= =?us-ascii?Q?gzz3jLzOcGJSEAFjo2hSifzM8ryqFQAfkX3u9tAsPxb13V3G1u8vWEPYaFnt?= =?us-ascii?Q?T69e/OTWoyXplNExO4WIhcvklHbRYC/maE+MjwM7O35R8B82uiWtU2hbk3Z1?= =?us-ascii?Q?1ilfC4ToNa4Llr2ug5EnpsxAEJ2933UadssU1/e0PwHjErcTd+3FxyVrKpxF?= =?us-ascii?Q?f8pEX7X9VEM9P5g1Zemerr13Iq/0XMOvlhNlVwKXi6LTN75sEYNbDgcBmL9+?= =?us-ascii?Q?BD1f/FIPjpDj0CKNoT5C2QDEYg6V3PQDpgPxA/F07qO04GKmEm3oFuYHqbjG?= =?us-ascii?Q?0kJn1w4aHJjacki+61H40dZGmwYv88B9jpkDpUrv85JEXg=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR10MB3374.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(7416014)(376014)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?pVPGBMoQru2SSaOHKLMjZxAhxfkKHmXC6Y/csyNva7RiXT3WdGvBuw6k0iWY?= =?us-ascii?Q?P7YOEGEk5+jKCHwuw/pr4Ac33JYZ2069VlqFzL+1KHxpMaIDr/NvMbue/WWv?= =?us-ascii?Q?6yeMFwLEjCggmCQKrzlpbjXMyGSiPPESezZcoca4NigU8wOXf7pV+xmDKwea?= =?us-ascii?Q?ssOuyg5l+cBXW0WT2/vehLs6usg6B6o9yg9mN7tTtgqrI4XdCtaQjQQZA0od?= =?us-ascii?Q?daT15SMiYdPK13f7niq079TTrPSoejgS0wNf/tAr5L9CI0hhTneuezJTd8OX?= =?us-ascii?Q?WobJxOyg2LGgpRhj6VZD1NO/aU0DQRJHAoASEvIZCCKcyV1p9c5+ZbQSNk1u?= =?us-ascii?Q?e/5nMRlmGRgo6nSM1yAPy84Gndx2fufHSrSlticY8REZv2p1EV1xTaY45XC5?= =?us-ascii?Q?klXDtwMFoE1cwQf9A+0ruZakayUt1sh7scCCBB0ZNBQf1ZWXBgfePdLR+i/e?= =?us-ascii?Q?3TDczB7+xij+vSuiwvIQsnjBtATOd7QYKTj6kSM44Bb87F2ma4/HnL+vLc5O?= =?us-ascii?Q?8v6uhCavDeTE223NXEQ2v/sawyUd7L9FQ3jQnjwlWs4T3N6xiblvZ3VjEg7k?= =?us-ascii?Q?3Tre9mEVD1++F+VgS355xRdkRXBy3BmWjOZHe7xNZSjYUxTkhrqSIJecWoiM?= =?us-ascii?Q?impk2jCCFUfQcfjg6NpbY970DEnmCeT8Rz2KOkST3WuYuwkbUxyXzIjwHS8S?= =?us-ascii?Q?JcXsi1bTLasacfbcVaFHkcMBese+6IIMv0WJrOuHpOUWl9aMCr5FpXBETl2T?= =?us-ascii?Q?s4xLyFCp8wdNjYCxpjW17vTxI0JLYhyxweeyT5bR1VR2y+draBPytyWcINku?= =?us-ascii?Q?DJq/hJghxK8DHEYYC6CHLcmIGOS6eokVwYP7Csgi0Uw1GupTwaetvNSuRa+o?= =?us-ascii?Q?KaRlRSXbMAOKtXu0HdaNqcf7SPYYg/yytdSPOlvPV3YUz11ZurjLdLus3wNV?= =?us-ascii?Q?+m1OhrCBE2/hRdD3BNBZ7t33sx2ZinBFbkIHAl7OZd0tSV0KBMCAVH+F3A7k?= =?us-ascii?Q?olLnFZr8+3pZ9YMXWXNiXXGxYvlWYnDzI63xe33KC4pgy9oaPp2X975WrBUG?= =?us-ascii?Q?nZ/R8E5Nkpya5swD4sYSj+PpJ8N+lDU6eW3ngoSXTCGSxfJYKcHyyWCqTc7N?= =?us-ascii?Q?MtXpp4zOeWqv3mz9DOfUPaJfIb9vHuiFBOvSJTIlzlHS+ggmh98aw3vlTAmb?= =?us-ascii?Q?ht+MrOJ7lUm05PNgThNfOd23cWFQfMw9lPy47CjIIdLBAt6G6RJZD4pH2THu?= =?us-ascii?Q?IBWZlttP9BhftniLD7xeRIxnbbXvflF431YTrsaoyp2hH9PMnn406/nvqjKs?= =?us-ascii?Q?/Hk1Iw/+XPojemw16ZiKFX4WB5izv9TEBk/rETtgJ8PVfIK47mLXBt5m4100?= =?us-ascii?Q?sjZL6N6lN1UUnMxywfIwx7jOMW3M4dN4W+UM6Jec0WyxB9X8OOe8fTuswWC5?= =?us-ascii?Q?HVt3X/PSGOJc3uyJm80AtAaAvum5VnUWj6PJeZ1Docham6De6Y541qhVk2oF?= =?us-ascii?Q?+7HsI0dVpt9GYYhJLoXjjtaB6A29EhYYhtWJLT55IpY3qAD2BDZbkYBzpSZu?= =?us-ascii?Q?PaL9xGtMFq+sB0mqV54JJfnez52U2tizR5SNIKt4I5RkcVnRS8t/KilMJ3HJ?= =?us-ascii?Q?Kg=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: SunMROCXdXUs6YL9Dw9k1lrRZY04TrctXCGDMfEwejRXHway4CXhwHSxekntnS1HpACjFqwcDuO7bOXS4GrT9Uv4K3STmi2xufjKcBCqU/x6Y6fgY2MlykB/0iMHkH/1z4Qh9oTY9vEeOEEIajkAcXnzAUPjIDmjHjn2hKDW0kW/JXbnt8xCr3L3KRe3BZh3jjMYcemCIL8unJxgOP5Nf9qAHpGtlW0t7pqvi+WcSN6wDrrSvs/awCTgCK645G9ejcccYkwatU6xmPMiwRR7fsfb1uLgKMpQ5AzT7tHQSRYABo2yngjj2P5+fX1XQB1W61KzIm0hJ6yPyJBSS+VAQmmbgOj35RwNK7d0sZ6iSdIzKlzP5uCi6pjRZTNvILz1Wr051jG/oPvtdFXA/jlR7UFInDXshKlcKfFbQUz6F5IGjf/eR5wT3be4Il1NdlQ1TLB4ShVnIFAzNWWVNLJQOlpO1H+UduZy3ZSCRs0GmPGQqP430HW9HAqBi2lmI1WGy630ApndFbVdqtzxiwew3f89rNu+t5/diTHOONhmqwg9W5zHq+UZt7wOz50QmD1g+A0kJ9mot7wS0h5IJ8SOEQSjYOkvMVmFa56ALiu5XW0= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7732f2f7-e00a-4956-b930-08dd3ef95510 X-MS-Exchange-CrossTenant-AuthSource: MN2PR10MB3374.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jan 2025 17:37:55.2984 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YaYdX5zLx3eJTub5W9l+gKH7RTduympa/TF/FkJM7Gqm1nOUxeaGbyluzJcKssM8nh54jdyFbVALzbUlxyQZppnD1tch+APOklXG0ddtGjs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB6988 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-01-27_08,2025-01-27_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 suspectscore=0 mlxlogscore=999 bulkscore=0 phishscore=0 mlxscore=0 spamscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2411120000 definitions=main-2501270139 X-Proofpoint-ORIG-GUID: VQX1VtKOqoRnF-mYDu1RvOkR1wn2tvZU X-Proofpoint-GUID: VQX1VtKOqoRnF-mYDu1RvOkR1wn2tvZU X-Rspamd-Queue-Id: CB90B20005 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 5jxcsj4da45y71ze8b4nusf91rssionu X-HE-Tag: 1737999500-566678 X-HE-Meta: U2FsdGVkX19TupROEE8khLeYbyKQ04Lb8HczQc9W3PjpYTYc3r0v53NFphMgLcl5gjepywHCq+bl/SXO4eDGDu1ShyKgQ/LHgO6Ozu/jYfv6StetC009eOPm8ICpo0Lfr+nZJRNJY8UxpZNabw8QIjOYbkqvRzSCV33O7SmFa7iE4Dxf2rT+MB/sLJ2pSnDsnXAIy107pR0YZTv/dYgVWGa2bbhKRWD2Z0M/rAuwRre0Ot38j0JSkRrWLIgsppYHFFc9wevE1EE4VC+vz/uamW+igQ3mACIZKSbiUJLeVXhvQAzWk97I758bNAGl3YhSZIoq50uuH4FyvYRsCN4WsCoOAGoDR7ftKYYZjSp6r9CchA5GrJA0oUUxkfJE6pA2bEYFVQ7EVUs9Eeq5jZflO4yjEbo9jw1+s2dleYI/9B3/OOA/7O6GQJAEVz5AND9C7N1l2gmUGJOeD2BWDFlBnnR7+UxK3SwctwXvxUCWYrc8ba+RE1zggZjg6KzDcsEgbf2YJyhDO4azkOq5TKG4vpu1auovfpXMlZLUu3dEKhh1P0k9AkEuJg5lOrzjPJHp3K2b19uiZYZhaLot3JehgBi1QFE/V87SYdECI/6BhNEc0bkONi6WDWsf2Y478Lt17HxADcpHkY0jaalpNLFIerKcDK9h2HxlXBvOJtP6P49oCHHC57092sgpNMLuJ1XEduJWqpXf5sZVmeBuiqfThrSTy6w0KZn64ins5LRs5u7CJBaOy3G0PVfNjcttJroG6kjYjzptyyLuFEyJ/+R/EhHEUv6rNOf/VMTPncEtgdH22YUNq5nWzXmWCx4Edyh6RPwefMFYDTNYOyYT9/ob3VwoI1HuLw6eeNwHw5Jl7ZkURUPCiQrBeTCI1zCpGh/XSe7+ig+sYwRaWsaF3DaGNcMMBhZKUN3Fi9IOKRSPuI6xI6zYn4mUWI8qjrPE+O7dbax4+/vNJwQ6fnOC/sx lqqOMJov 2kiA8m9e1ecp73UjBCeD5zaP1B+18AvWEW0FqS1GQ3sL3RBwUl35el+IjpH+9Ktua+3Omtu4z7VWf0yl2qQYiyBv8NMqjC2urCHItfwHyE23JsmOSF1j6qqwgKsUIN1Cq1Ssxd9pwX7/n+F8Hyndh6WmEkrr22HTq+eNf4dtXm7eSZwd1RodW3VyEL7zK0yOd9Qj6cJQOzXboPKSmAQRblOha9Lq2MqyJPDlG9NTEiSPNYit0RWIOEuqU3TVtTfjAdi5Wz6U82V8pqUDecG6Sb35xNZmJddYymfnRqKzcoWupxo8rSI5lEyLy3i3HEYphNXrv3LjBjYgZ5mt07ELAcMgg5COlqXVwscVJItKQY2bhv2f9NDsZbd9kS3Zq0yrfuxUiHvT0Boxom7WOdTtk/R4A5q8ZjVQT1/9rzE1VhJYVUW2Bad1S54823AAxO3qeovs/B8GoITmDitarqgk3JS9JTgstT3z9FaK2syZKjI6RfQaCko7AAfnwnf/WbW20Sls7dSE3aujVIus4M3fqrDpZIkmCdxaddp+qLaebD0kRormGOxOV0u+xzSPoHksP5ZMMFFqZ2tuc61ocA6DrNXIo9zyZDofCdFJGn8bbZbCEXOFADKASwL8h2jzai+uOug9TEsAf+Kxxaqtr2sBzz/yNiLakdkniDzH/KQygD+3CZSL2AN7VYoWhqTFhonZKHuuaBOIxqbskRWA21o8JvT8NMoSzYSJWMbQDVXNVad0xvfQxiuqj7fO+6p/LzowUAkEUxYiC4DB7J0bs6egPjCI5t6EpSyQnQLS1ye0jD5yD3eavVjPnwHrC+8KmV0ZwrI4yr+1EScpUZJo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jan 27, 2025 at 12:02:21PM -0500, Liam R. Howlett wrote: > From: "Liam R. Howlett" > > In the even that there is a failure during dup_mmap(), the maple tree > can be left in an unsafe state for other iterators besides the exit > path. All the locks are dropped before the exit_mmap() call (in > mm/mmap.c), but the incomplete mm_struct can be reached through (at > least) the rmap finding the vmas which have a pointer back to the > mm_struct. > > Up to this point, there have been no issues with being able to find an > mm_struct that was only partially initialised. Syzbot was able to make > the incomplete mm_struct fail with recent forking changes, so it has > been proven unsafe to use the mm_struct that hasn't been initialised, as > referenced in the link below. > > Although 8ac662f5da19f ("fork: avoid inappropriate uprobe access to > invalid mm") fixed the uprobe access, it does not completely remove the > race. > > This patch sets the MMF_OOM_SKIP to avoid the iteration of the vmas on > the oom side (even though this is extremely unlikely to be selected as > an oom victim in the race window), and sets MMF_UNSTABLE to avoid other > potential users from using a partially initialised mm_struct. > > When registering vmas for uprobe, skip the vmas in an mm that is marked > unstable. Modifying a vma in an unstable mm may cause issues if the mm > isn't fully initialised. > > Link: https://lore.kernel.org/all/6756d273.050a0220.2477f.003d.GAE@google.com/ > Fixes: d240629148377 ("fork: use __mt_dup() to duplicate maple tree in dup_mmap()") > Cc: Oleg Nesterov > Cc: Masami Hiramatsu > Cc: Jann Horn > Cc: Lorenzo Stoakes > Cc: Peter Zijlstra > Cc: Michal Hocko > Cc: Peng Zhang > Signed-off-by: Liam R. Howlett Looks good to me! Reviewed-by: Lorenzo Stoakes > --- > > v1: https://lore.kernel.org/all/20250123205849.793810-1-Liam.Howlett@oracle.com/ > > Changes since: > v1 > - Added check_stable_address_space() to uprobe code - Thanks Lorenzo > - Added Oleg & Masami to Cc list. > > kernel/events/uprobes.c | 4 ++++ > kernel/fork.c | 17 ++++++++++++++--- > 2 files changed, 18 insertions(+), 3 deletions(-) > > diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c > index fa04b14a7d723..90ebcdbad05ca 100644 > --- a/kernel/events/uprobes.c > +++ b/kernel/events/uprobes.c > @@ -28,6 +28,7 @@ > #include > #include > #include > +#include /* check_stable_address_space */ > > #include > > @@ -1260,6 +1261,9 @@ register_for_each_vma(struct uprobe *uprobe, struct uprobe_consumer *new) > * returns NULL in find_active_uprobe_rcu(). > */ > mmap_write_lock(mm); > + if (check_stable_address_space(mm)) > + goto unlock; > + Great thanks! > vma = find_vma(mm, info->vaddr); > if (!vma || !valid_vma(vma, is_register) || > file_inode(vma->vm_file) != uprobe->inode) > diff --git a/kernel/fork.c b/kernel/fork.c > index ded49f18cd95c..20b2120f019ca 100644 > --- a/kernel/fork.c > +++ b/kernel/fork.c > @@ -760,7 +760,8 @@ static __latent_entropy int dup_mmap(struct mm_struct *mm, > mt_set_in_rcu(vmi.mas.tree); > ksm_fork(mm, oldmm); > khugepaged_fork(mm, oldmm); > - } else if (mpnt) { > + } else { > + > /* > * The entire maple tree has already been duplicated. If the > * mmap duplication fails, mark the failure point with > @@ -768,8 +769,18 @@ static __latent_entropy int dup_mmap(struct mm_struct *mm, > * stop releasing VMAs that have not been duplicated after this > * point. > */ > - mas_set_range(&vmi.mas, mpnt->vm_start, mpnt->vm_end - 1); > - mas_store(&vmi.mas, XA_ZERO_ENTRY); > + if (mpnt) { > + mas_set_range(&vmi.mas, mpnt->vm_start, mpnt->vm_end - 1); > + mas_store(&vmi.mas, XA_ZERO_ENTRY); > + /* Avoid OOM iterating a broken tree */ > + set_bit(MMF_OOM_SKIP, &mm->flags); > + } > + /* > + * The mm_struct is going to exit, but the locks will be dropped > + * first. Set the mm_struct as unstable is advisable as it is > + * not fully initialised. > + */ > + set_bit(MMF_UNSTABLE, &mm->flags); > } > out: > mmap_write_unlock(mm); > -- > 2.43.0 >