From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CCA8C04FF6 for ; Tue, 16 Apr 2024 13:51:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 84C3D6B0089; Tue, 16 Apr 2024 09:51:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7D4A86B008A; Tue, 16 Apr 2024 09:51:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 675A16B008C; Tue, 16 Apr 2024 09:51:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4CAAE6B0089 for ; Tue, 16 Apr 2024 09:51:40 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 0804B120A58 for ; Tue, 16 Apr 2024 13:51:40 +0000 (UTC) X-FDA: 82015532760.04.47EA663 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf01.hostedemail.com (Postfix) with ESMTP id B378540006 for ; Tue, 16 Apr 2024 13:51:37 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QkxhvIFf; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713275497; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KzEshGm05jYMH47Ft2QC8UnffG1g9JyMRcoOm48fEmc=; b=ocwgOtN8dCo3f2nvcPylzLjRgJ8DYrY5N5t8/I7WwQfmjwNf9kAI8GOKAkLmNkcs/DL0Ka QGYYCY6UffsZvIE80gorbsV5JFf4dUDURqNOxarxsbhwVpCI3LysSzqoBzWmOYHsq8tesL ZUZI4MxYQSrVtOEDYAl3xN/Pckpc/Sw= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QkxhvIFf; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713275497; a=rsa-sha256; cv=none; b=Snj8+Lv0q5aBNfeu6Ht59GTXn3vHijNpT1f3NwDd+xffYwFmvwUmiuAwedHX6cdIAcuf4h bNa+E2dlssDxEeZCkA3dbpIobopbnqGvZL+RYxRtwjZs2cqxhf1iRKeSz5Lvy+B0FPSZCm AuoLhttcmEkpmb3k0OcCwNuVysqVVWI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713275497; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=KzEshGm05jYMH47Ft2QC8UnffG1g9JyMRcoOm48fEmc=; b=QkxhvIFfVoZ8MfpU0mtJWF0/U9wL7SBIrD/JjfRtntfa6wwR/q/brQbhH61Nq7fIbc2f9/ Xnqn0qOUaNJS0SMVFoElhBLU8FDOrqsPQ5EE2od2cfcPfkVqZryKNNcIOwMNlSUSqA8KCn CL6ro8QP0Ta3NEu6IB1ysal142GpzLQ= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-154-3FX1KDLrPXuv9C1t5EHKxw-1; Tue, 16 Apr 2024 09:51:33 -0400 X-MC-Unique: 3FX1KDLrPXuv9C1t5EHKxw-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3479b511725so1788142f8f.3 for ; Tue, 16 Apr 2024 06:51:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713275492; x=1713880292; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KzEshGm05jYMH47Ft2QC8UnffG1g9JyMRcoOm48fEmc=; b=LkAwowYdrChw5dG8fh8cXmwJvxNUyrgg1Wjab4h27ZbvUp/k0uh2inhJl0EbyUM2Ox 1hI1FIGgxcaX87iE4DglbJFVEdczC+fyOzWUJw4XUyjzr8ijgr5hdV72qlgBVudO0Uhz Wpa2s7sf7qotdj1nUORbrRLrEBTu9xGnQ3ludCe7n7knHNEt5lCYHKw4YoSREoXDRl3Q U23jB1nraWuLDn+kXLUOX3AB9ePCYU8Sl9InWb+m/q9Mi/eRiS0ceXlAJMG6uumLJ0xP u/UWeBEUYbUdye9IqDkT024J6HeYWLZawWa90v8gp5ETZbGuLCCDcwIftG/yXq0+57m+ Pa1w== X-Forwarded-Encrypted: i=1; AJvYcCUpDTqmCQNaVHdT8jyXqY26wRJ206JfkPIw9fF614ZbqpcqF+TCQnBC+9LcuQjxhPa+JF3dgYjMVizACc19nsZGEM8= X-Gm-Message-State: AOJu0YwpILJm6No0qd/XCnAmJDkmPmU25mUWK0iY9uLwjsQs7kY7PDiN KZfj7xWChRz42tPl5mT3KtmFIhcLGjj+6FrSsxu0+oJgcCqeyBJrAVYuLVPWIv2arVq/otV8LWj /z4XksnUP6IV13n/p58c9SS1/K2RiXecOPMR4k3BhmQ+WqwsfMS6HUh2N X-Received: by 2002:a5d:4589:0:b0:33e:c316:2a51 with SMTP id p9-20020a5d4589000000b0033ec3162a51mr7672085wrq.27.1713275492288; Tue, 16 Apr 2024 06:51:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHCjzlADbwFv44JQkrB/ikEE61jxFMn3dfaESPXQ+nqH0EMS1bqqdCY2S0qlAv8mMtQKQ6YEg== X-Received: by 2002:a5d:4589:0:b0:33e:c316:2a51 with SMTP id p9-20020a5d4589000000b0033ec3162a51mr7672063wrq.27.1713275491857; Tue, 16 Apr 2024 06:51:31 -0700 (PDT) Received: from ?IPV6:2003:cb:c718:6400:7621:b88a:e99e:2fa8? (p200300cbc71864007621b88ae99e2fa8.dip0.t-ipconnect.de. [2003:cb:c718:6400:7621:b88a:e99e:2fa8]) by smtp.gmail.com with ESMTPSA id s4-20020a5d5104000000b00346f9071405sm12624395wrt.21.2024.04.16.06.51.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Apr 2024 06:51:31 -0700 (PDT) Message-ID: Date: Tue, 16 Apr 2024 15:51:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: ./include/asm-generic/tlb.h:629:10: error: parameter 'ptep' set but not used To: Miguel Ojeda , Arnd Bergmann , Huacai Chen , WANG Xuerui Cc: Andrew Morton , Ryan Roberts , linux-arch , Linux-MM , linux-kernel , loongarch@lists.linux.dev, clang-built-linux References: From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: 734fiheso65bmke914xg7rm5epr1z7hq X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: B378540006 X-HE-Tag: 1713275497-804589 X-HE-Meta: U2FsdGVkX18cD8oOZPJjuUj6UfGH1lKkzMJCdM2vVs2h190QHXZj0YzZ96sCAZRHCbULmAcCsCBF4i2I29Ts00SsOWB3Gft0VWF7kO/QRR7GhOUTeyzIqqG13gNilq2bo0O0HWkrN8Z2h+pCTYjQ4/5lFvUeXm5KLI98+B4xt49Q7HqUXc+Ar+xBMR/rGwbtRtkEEysCil2/JEO8ClWLQ/1qcKWhrX3d02lto1gNm+iep2c+rPpB3wlf4DUkhbidYdXzyACXgG2fNO5sJCrXR3GghQU4rLXU1oKxpDIKHeX4JePkWIfQv97Yy0+DNTMPsYXdJhruPTJdHYKo0ul9sZpErO/CIz6D7RkKhMq6N2h9/Gv14+M1YIWDgWY7RtNoTtU8K94fbBJgmpMHmmMG9ZneAQsWPZ9LIjNiNyjwtwDgPMEMGmInPzW2OkaFwQJ+i5ctyOn7D5EN6dOXC/wHyjiacKptj2sMaWWIVC/3JyZvSkm51EITrhXJp/IJY0haLtLBuD1J9Looo0hBLdmOqb6tRoVOJgFqMwSunkqlKZCX4mGrx/efvUEBAQbBg/t8+LnYLNopCpbsNcf7vs1vzJ1BP7qMb8dlAzN3V4RMxE6nNStLwY6Xwt5EAelYSC+uxfsTIYrEj0Nh8W0gmq7Psp6aCKmaDttnKzGDuCG88scGA8SEIMRQ0zUZ4wXssb6K6+iUWSGbNATewLRgroFnry7O3DgB59Hk2YInWgiKqKBmzaOQaUYQiZTfopkdhcWryBV64+u55dD3VyyeKv2wqFzimneJZZcbdKJHyvzU9CaYE622Hkqr0hZUOZ+uPvGEq8vqAPvck2qPxH2X+uxsGZEjUmzuT27YoZSP1w77PpKQKLKJwCh4dWY6zxECsWpmccPEukgUTd4+0rXArmBmIvw6FptdP3SPej+KwrR29pKjTU+cpTXEszmIsVfffJxQrlPJskkiUhPoO1aysc2 fS3RTMQD wZhCTnE8u7ymnECLafYb+4oFJyQIJstVOlp3mWzDNDk8O9rsMIwxfOmakmt2VUyto13RSqijuGjtjbqBSr6nXJRDcab1ZJCZU3Zfs5eScpESgEAFof5fSQZtFZATQXzFgo3tTd5Z0smcV/StCpSr9OGmsBbnUn/DbT0x6lk2BnyMP5rZ7byepPbWoNWviBR72hey2Aqu7haB3/amHPBFD2kwRf5uBR+SSfOp2hKj2JOaaywdVUeXS0qmh5K3YzU0e6JdQtSnLYGtkEZWKHV9b6S7d3k+zHNgUaQEKOzTjjnlUPoJm1g/xrMhjdds8qE/fkVuSc5m/Ti2eD0sDHaBaBGzjJSUP1U2Kec2uQPdnuVq0+nnNGE/+/fCUmzyNFMkK7tp4YaF89/8pgvfr4iKc1HhZ43RvPufqqncY+ntq1V0F58oxtnzjwgBsfOukeSk5ZSMX1nqMSt+Zq+q5Fbz6i1uIRZol6VFskJUSQrfND39+yuPdq7RUIbVYXpmiX86OExn0n4Y6YwcfwYx14Dor/NvZ7QHlVcKGEYf3o5BuNaqJ7D48GTK7wLXeaPXVXaXmwwsXrGrNyatpcliYsYdvIANpzMTrteSwawIU X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 16.04.24 12:26, Miguel Ojeda wrote: > Hi David, Arnd, LoongArch, > > In a linux-next defconfig LLVM=1 build today I got: > > ./include/asm-generic/tlb.h:629:10: error: parameter 'ptep' set > but not used [-Werror,-Wunused-but-set-parameter] > 629 | pte_t *ptep, unsigned int nr, unsigned long address) > | ^ > > Indeed, in loongarch, `__tlb_remove_tlb_entry` does not do anything. > This seems the same that Arnd reported for arm64: > > https://lore.kernel.org/all/20240221154549.2026073-1-arnd@kernel.org/ > > So perhaps the loongarch's one should also be changed into an static inline? 4d5bf0b6183f79ea361dd506365d2a471270735c is already part of v6.9-rc1. How come we see that only now on linux-next? I assume we should see the same on upstream Linux with LLVM=1, correct? If so, we should likely just drop that completely and rely on the asm-generic one: diff --git a/arch/loongarch/include/asm/tlb.h b/arch/loongarch/include/asm/tlb.h index da7a3b5b9374a..e071f5e9e8580 100644 --- a/arch/loongarch/include/asm/tlb.h +++ b/arch/loongarch/include/asm/tlb.h @@ -132,8 +132,6 @@ static __always_inline void invtlb_all(u32 op, u32 info, u64 addr) ); } -#define __tlb_remove_tlb_entry(tlb, ptep, address) do { } while (0) - static void tlb_flush(struct mmu_gather *tlb); #define tlb_flush tlb_flush Thanks! -- Cheers, David / dhildenb