From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99FE9C3DA49 for ; Wed, 17 Jul 2024 02:23:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 129786B0092; Tue, 16 Jul 2024 22:23:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0D9D06B0095; Tue, 16 Jul 2024 22:23:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F0A356B0098; Tue, 16 Jul 2024 22:23:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D36986B0092 for ; Tue, 16 Jul 2024 22:23:17 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 3ED97160866 for ; Wed, 17 Jul 2024 02:23:17 +0000 (UTC) X-FDA: 82347647634.25.A3C07CA Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by imf07.hostedemail.com (Postfix) with ESMTP id CA4C64000C for ; Wed, 17 Jul 2024 02:23:13 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=none; spf=pass (imf07.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.191 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721182975; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9vxXJZRi7hBD5RntgfW1O9vGfVn6kkJ8MzePK5HQ6JU=; b=COIoGqrO8q6BMCb2XibT6hZOFTl1kdo2GMcf8u5jjailZIRxlpICMpdkLPmzrQKoMcxuGV mAFQkNZQydM/ykLlY2rR6A76MSreU40eM9beDifRRhpopMXsTK0WJNDVIG9NdEreyYQdGY aRQ2u6t/3CqH8VGXqzOiqHp47xpqgQI= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=none; spf=pass (imf07.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.191 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721182975; a=rsa-sha256; cv=none; b=3cmur99AkNslxP1ECPFgM40LkMzeQvLbSUdlMaU9TVKAqJQNUrFTK73jrEQ9gkVvhAQTKe HIzPi7/4N9vxq6DCxjiqTGw0N/AwrI4nJkaP0fy8cm4WOozIx+jr/FpGqVk67ykK1SBqGu NA/3ZxUUDSAPoXI8KhcQ/g/zMy+KaXI= Received: from mail.maildlp.com (unknown [172.19.88.163]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4WP05t4b8Yz1HFLL; Wed, 17 Jul 2024 10:20:34 +0800 (CST) Received: from kwepemd200019.china.huawei.com (unknown [7.221.188.193]) by mail.maildlp.com (Postfix) with ESMTPS id B4E7918002B; Wed, 17 Jul 2024 10:23:07 +0800 (CST) Received: from [10.173.127.72] (10.173.127.72) by kwepemd200019.china.huawei.com (7.221.188.193) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Wed, 17 Jul 2024 10:23:07 +0800 Subject: Re: [PATCH v2] mm/hwpoison: reset hwpoison filter parameters in pfn_inject_exit() To: Michal Hocko CC: , , , References: <20240716033516.606582-1-linmiaohe@huawei.com> From: Miaohe Lin Message-ID: Date: Wed, 17 Jul 2024 10:23:06 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.173.127.72] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemd200019.china.huawei.com (7.221.188.193) X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: CA4C64000C X-Stat-Signature: i6999k38wakrcn1ss7195ckk7u4mads5 X-HE-Tag: 1721182993-583232 X-HE-Meta: U2FsdGVkX1+p7gF4aAjMHNxI+k3H+jp0lCBuoRJERfsjZNBm891JtROv4IiSPJ2HFQSaxe4+V6dfpdO0YXO2QgERyxJeJXAy1rVWFMhfP89mHWiKn9Kixty4O5SyJjK/v7MCtKYwBq8SvA1Daa0YN+xTcKZ3czUv3T5hdTN4rZ0CNvovbiladLiVEUhkYFeD63/y8het2hsHhBxpzWodw2nTnK3CCc4HZCgj+AA9r+5sIxsjwE5uhq0mGglS+gZ1CpX/Q5ByazRNAJMvFXjng8o0M26urHNMljLwQEgwwhHwypcOAs028vbfZTBmttjQ9Yr3Q9/fU0uCLq6BFJAPYvZljzGCg5LLkVTy7SNBlYy36tJsx2YkcKjudR0+Th9xPryvScffV70scJe2k3iJM16+u2PDcShloSSWzOvOt3+bpLXGemo5lvyhkUT3vdBF/KawDxeSHVoXTF1coiuj3M8xijhmghfaoLfndb4yiDnmM9B3XJRSD7CgdkVlaIY3nJCdNJ+j4I8TA6xuxmaTXPqcscDdYieH2ydV3MT6cPYlQVjMny8HPNRs0rjqz9S79jLc+D0JXE+UfUNJmE/Khgf39R/B/QGhoqLtgYfDkKBfpsRDcodaFJFHLsU8C6nAMxMTxggkiQhn0elilJq24sCVGzjX3IETNadBHXMzvpL0J3SJ8AnUaAbwLSh4rHw91BMyICSSJf6nPKEQuwt6xq7SW8XgoHqP8Ev7cYuPzt8PxifqcuSmxGP7KxzGesotG0vkf+4LDWxqoAA6L6bVAf/XHp3ICY1hkVoYjUc36KpIuDU5+E2maC7k6neSo7RkS4aaSQjct4LNWlJlY0X98Xl+5xqh6lqT5d7G5FYGr3LofpUg5eCqY1iQeN92REgON8Mrom11iLJhQpDuGnGRGQjJQWLy0j9Sh8POhdmk5BimFYkowpb57B9Vm8szlupCMrtwQU8Xujj74L/gcih dsgIXAEJ r/GQWKiT0hcuDryqETsaJn4mDGvPDkW2IGsS9G8lgzDp0N0jNXy7L5BdW6YNc34PZk7qEjkSr1pJRLN6TtUxO47C3a/8UNZikyuY76O5ittPzq6pB3NXMfaubsyIR4tTLfZaOFprLYIReW4Cm+c1KwCPUKWv8BLBlZcE0kmE7iD2+Cxos+rj6OikxHoxlDNIKOTUwPPNOmbjhuNabGu40FFQ4W8trK69FaPckIjbvTM4U+XsRMNHcdQwuvw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/7/16 16:38, Michal Hocko wrote: > On Tue 16-07-24 11:35:16, Miaohe Lin wrote: >> When hwpoison_inject module is removed, hwpoison_filter_* parameters >> should be reset. Otherwise these parameters will have non-default values >> at next insmod time. > > There is a clear layering broken here. We have mm/memory-failure.c using > values and mm/hwpoison-inject.c defining the values. Both with a > potentially different life time. Shouldn't that be fix instead? In fact, we have mm/memory-failure.c defining and using these values while they can only be modified through mm/hwpoison-inject.c from userspace. The common usecase should be: 1. User set hwpoison filter parameters first through mm/hwpoison-inject.c. 2. Then doing memory hwpoison test through mm/hwpoison-inject.c. hwpoison_filter_* parameters are only used for test from userspace. From this perspective, this potentially different life time doesn't break anything. Or am I miss something? Thanks. .