From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67597D65C58 for ; Thu, 14 Nov 2024 08:05:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C83D56B0083; Thu, 14 Nov 2024 03:05:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C34366B0085; Thu, 14 Nov 2024 03:05:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AD4ED6B0088; Thu, 14 Nov 2024 03:05:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8F4EF6B0083 for ; Thu, 14 Nov 2024 03:05:06 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 11E1E160FC7 for ; Thu, 14 Nov 2024 08:05:06 +0000 (UTC) X-FDA: 82783963584.21.3D19FCF Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 3EFF5C04F3 for ; Thu, 14 Nov 2024 08:04:02 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UzjcvLZQ; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731571410; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YFn1B25xOIEJVLI0NlbbrKG4fTitKkPbUGmnBKaC+Qc=; b=CxMjpZAg55hbJI3ens2RTiJ4rDY4YNxWO5CsDmrb4NInWIw2f4K/YdUewSOEEc249W/7bk qHByTQ+YHf8NOb5v1MqGrPIqh+VrCH5+z06LGQt+ooQNghorSLut6P2v5Eb2zliivRXhk0 aOER42N3Th0U9gV0wB8oWNOYGf7c2ao= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UzjcvLZQ; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731571410; a=rsa-sha256; cv=none; b=FudA3XCdJvZhKiikXTnWMzkOoM2ll+YERmJR9b/812jXvXmWWF/+nvI+d3PmLD4mO54rIX 3MOu7x+I2LkubhZkIfUbTfJUq/0QpGp/go6K880ZYIDY1PTLFL+eSF/oK6n1jGotpjTDh3 xwr4yMAy0WJqpaCLZFoiqMJ+vF4Y+h4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1731571496; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=YFn1B25xOIEJVLI0NlbbrKG4fTitKkPbUGmnBKaC+Qc=; b=UzjcvLZQYk7fb2GPe1LSxL7lVB4RI9R8dW8lxUWTWT57sFF7/G8+UmFabluQlRYoLxeSGA HI99DwKfjW+Ti40OYUgpjR8PkaSoBHR8pLNMP4lC+J5bjfBNauMXnTePob0xzOU1rvaHE0 JWVxLCLSkrt4Sbbdb006pisI7B2ku/E= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-576-ThqmnqxcM0ymwbeBm-Ju7A-1; Thu, 14 Nov 2024 03:04:53 -0500 X-MC-Unique: ThqmnqxcM0ymwbeBm-Ju7A-1 X-Mimecast-MFC-AGG-ID: ThqmnqxcM0ymwbeBm-Ju7A Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-38218576e86so172435f8f.0 for ; Thu, 14 Nov 2024 00:04:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731571492; x=1732176292; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=YFn1B25xOIEJVLI0NlbbrKG4fTitKkPbUGmnBKaC+Qc=; b=qY6jR6LAcv/PH6oT06zXYl/h6upgSu7IyW/Uu0FdlzaqF9t7zjxEDZeIuvf6N8Cfdk Fcjqcaxn1FcateAcom/h8DDsFxyjup1H3B041OCY9E2hM0EG6X+VsKnTJI3sf7BG8bjY bQZ+AmimrXIfxETiSWmfakLWxlYSOQzt4GvClJVfx/ImtAVcA7x7topjY40VjD18QjKj SRxAL+KrtdcIO7fPDK4244Xhb4yLUPFmQcJLOFrSKhR7sEEyh2XY6azNRQ9BLuIj3vue rblOme5wzZ6oFCl+sGeyq8ntOlSBjwNmlZ6cinF586LSbP5eH9AQOrJaEW2daehxu7Xf utdQ== X-Forwarded-Encrypted: i=1; AJvYcCWoqjItVxSElhJl+gPVtXcQSwc/DkuKlKqws+pNYuW88lF195BNMUzAbB+h50k1DP3F+W5a4Ruivw==@kvack.org X-Gm-Message-State: AOJu0Yz2QIEkab5Tchi1pbIeirVRaEPVDDogC8+s5a4zgg/5OWsq+afd 3gsqeZvIN4vVhSfQeGvd8DllkwCTKoSLim58uzi1hkJdQ0J1jamqkJ4A3IMYnttiCFZPa6Lv4rh xCe8gSN0Oh/k7Wb3Y1UeOscY5PuXAHI8Ejk0/RB89K+rxknwF X-Received: by 2002:a05:6000:2aa:b0:37c:c9bc:1be6 with SMTP id ffacd0b85a97d-3821402219fmr1933096f8f.16.1731571492629; Thu, 14 Nov 2024 00:04:52 -0800 (PST) X-Google-Smtp-Source: AGHT+IH0bIURVv764qy3SJRXm7S+CYzynemUaMTOSUdVgTWGY9/Cuf/kNHKIbJ4cX8wrDs8zoL1i/g== X-Received: by 2002:a05:6000:2aa:b0:37c:c9bc:1be6 with SMTP id ffacd0b85a97d-3821402219fmr1933056f8f.16.1731571492180; Thu, 14 Nov 2024 00:04:52 -0800 (PST) Received: from ?IPV6:2003:cb:c715:6600:a077:c7da:3362:6896? (p200300cbc7156600a077c7da33626896.dip0.t-ipconnect.de. [2003:cb:c715:6600:a077:c7da:3362:6896]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-432da244915sm14393875e9.3.2024.11.14.00.04.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Nov 2024 00:04:50 -0800 (PST) Message-ID: Date: Thu, 14 Nov 2024 09:04:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 4/9] mm: introduce skip_none_ptes() To: Qi Zheng , jannh@google.com, hughd@google.com, willy@infradead.org, muchun.song@linux.dev, vbabka@kernel.org, akpm@linux-foundation.org, peterx@redhat.com Cc: mgorman@suse.de, catalin.marinas@arm.com, will@kernel.org, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, x86@kernel.org, lorenzo.stoakes@oracle.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, zokeefe@google.com, rientjes@google.com References: <574bc9b646c87d878a5048edb63698a1f8483e10.1731566457.git.zhengqi.arch@bytedance.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <574bc9b646c87d878a5048edb63698a1f8483e10.1731566457.git.zhengqi.arch@bytedance.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Ze4cDr_C-grLQ7lX5snrnWI8EGFf8kpAYnIPDcqKAFg_1731571493 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 3EFF5C04F3 X-Stat-Signature: 4wtgs6temmez31nq4ckq6b4mobrx7ag5 X-HE-Tag: 1731571442-261237 X-HE-Meta: U2FsdGVkX1+M1tZeW1S+GKGh+elakp+E5nyQzdBJLTFp7kH+USA+TKQO/JGKYB8vu3MOLKoio4v926T/0+cswnhKoU5tKea9MJqZ6OvnGol5ULt1IJGfWoCVEiEJ+teWY5D/PpphcuInVErxbJw82SOyvrbPuXtlDtzk6xzq5w6OtcltH8kwaRw47YLRwVt/qsGnlBz4r4fcb7aPJzKjBGCcHmcSkafwitrLE2M0wHsNLQqbUBywaWpbrf/Ef+w9RCG34gpxaxvEDzQjDWjRrCNVqSthSKxPL2QRpvdvjqfsxDidvHOZshdigIb6R9ouuKAOvNE2F5SeN9xPdwO63Bjlp809CTgCBbMKVFZfxvhs2+WJ3a4Ojmc2XAGDdzjl+YVQGasuclyVEUJETfk3QdajTnKglIDrQI5ngvOBnH1Gxta1vZSZLn2f2CYIZ3peeax9Ng95Ae4OPY/U8lo68fgmLOKGklY4zHAgtjDOJcKH4yiW7DON5ZVo6X2jy4rV1/MUCP2qDDnV4zx/QpzS4thZ26JdSStZhsIXrKtBT5k80c4FdISOHNRn9vtijMkPRijKzEJTVHCT2w8b4cYtlZzy+OMvY9t4QZHFab0rvtqddow+xtUAI+uk2CJwnD7ktLW/9fkCOK47/rGRweex9z6ZS7ZD2TTPNZfZQeXKsnhJeRpdrPaI771Dtc7CIJok+8961AgIuqUmSTJaLT8QOkfuvL20yY+N9Zp5vugzBoNge2sBJweCBX+uYvrUbeXBmK+nGZQpgFPQLQ7ag2mTtSjtDp5tAN6DxmMwENtfchz2C+sHi0dwv7DicAbKNCrMYZreoPQg78jFLIMUDLDBrGfQCrbaTrYZinfPGHgd0pa9arSn75bbf8eVA9FrA4+kWxedZYrwxwOKmmdNCBjy/PUf42Z2+I2BYqxwyGnIVN7ExeHhwW0iwj7nugLdT2gHwo9L2bfw1lw84WNfGcB OG7+Rqlh T1IWi8GzxK8mKa6KdVFSCtBwpMa9fP7pYrEoyA/RxWwFvTJgjyr4J6Xe1lbSaf1g9xxFk509lXw3pnky9rHTqaldqt3EN7O2hUYILKTx5LiXfooTCN0xOVryfr+mdCdch9SewoIFE7ObBZZRg/82FX291mat14PVKWRRP26jRCHoXg9L0T7GjzldF1YUFxBThZ/bJQ/U69Nbh6n+5ziOjHQp6ElIiqf+WhHaXgauQFLqsnCNzgNYuKOWKVmwFXjkbkTrJHUWjpGNpwK3zckd5UmHXbWYjcgOcilnvdh9p1qfaEu7idH/vLSMuuiJ5xAEE0CZ35Ueo8SYrgJhW8LQ1Bi+smDNWseJFE2FDQ8p6WWJXUOSdjS8fxsF7GY2SewtHeaUsl48Oy3WAl+W0aHBcorTYYiiKdIZ2XyT8Re+yfp1+VNWPXfhNDcdNSg/62Rw0Fikusx3nvBGlRpO5obcUDTfUDg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > static unsigned long zap_pte_range(struct mmu_gather *tlb, > struct vm_area_struct *vma, pmd_t *pmd, > unsigned long addr, unsigned long end, > @@ -1682,13 +1704,17 @@ static unsigned long zap_pte_range(struct mmu_gather *tlb, > pte_t ptent = ptep_get(pte); > int max_nr; > > - nr = 1; > - if (pte_none(ptent)) > - continue; > - > if (need_resched()) > break; > > + nr = skip_none_ptes(pte, addr, end); > + if (nr) { > + addr += PAGE_SIZE * nr; > + if (addr == end) > + break; > + pte += nr; > + } > + > max_nr = (end - addr) / PAGE_SIZE; I dislike calculating max_nr twice, once here and once in skip_non_ptes. Further, you're missing to update ptent here. If you inline it you can avoid another ptep_get(). > if (pte_present(ptent)) { > nr = zap_present_ptes(tlb, vma, pte, ptent, max_nr, -- Cheers, David / dhildenb