From: David Hildenbrand <david@redhat.com>
To: Jinjiang Tu <tujinjiang@huawei.com>,
linmiaohe@huawei.com, nao.horiguchi@gmail.com,
akpm@linux-foundation.org, xueshuai@linux.alibaba.com,
ziy@nvidia.com, osalvador@suse.de, linux-mm@kvack.org
Cc: wangkefeng.wang@huawei.com
Subject: Re: [PATCH] mm/memory-failure: fix infinite UCE for VM_PFNMAP pfn
Date: Fri, 8 Aug 2025 10:08:30 +0200 [thread overview]
Message-ID: <c7ebdbcc-aba9-4860-af7e-add209a32879@redhat.com> (raw)
In-Reply-To: <14abf20d-d3d0-46fe-8184-6dbc97a4e5ab@huawei.com>
On 07.08.25 13:06, Jinjiang Tu wrote:
>
> 在 2025/8/6 20:39, David Hildenbrand 写道:
>> On 06.08.25 04:05, Jinjiang Tu wrote:
>>> When memory_failure() is called for a already hwpoisoned pfn,
>>> kill_accessing_process() will be called to kill current task.
>>> However, if
>>> the vma of the accessing vaddr is VM_PFNMAP, walk_page_range() will skip
>>> the vma in walk_page_test() and return 0.
>>
>> That check is dubious and it's on my todo list to revisit that,
>> because it doesn't make sense for COW VM_PFNMAP mappings.
>>
>> But I am curious, is this about having an anon page in a COW
>> VM_PFNMAP, or on "what kidn of page" do you get the fault?
> The pfn is RAM pfn, which is mapped with remap_pfn_range(). There is no
> COW.
>
Ah, and that works because in check_hwpoisoned_entry() we are only using
pte_pfn().
--
Cheers,
David / dhildenb
prev parent reply other threads:[~2025-08-08 8:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-06 2:05 Jinjiang Tu
2025-08-06 3:05 ` Miaohe Lin
2025-08-06 3:24 ` Jinjiang Tu
2025-08-06 12:41 ` David Hildenbrand
2025-08-07 11:13 ` Jinjiang Tu
2025-08-08 8:21 ` David Hildenbrand
2025-08-09 1:23 ` Jinjiang Tu
2025-08-06 12:39 ` David Hildenbrand
2025-08-07 11:06 ` Jinjiang Tu
2025-08-08 8:08 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7ebdbcc-aba9-4860-af7e-add209a32879@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linmiaohe@huawei.com \
--cc=linux-mm@kvack.org \
--cc=nao.horiguchi@gmail.com \
--cc=osalvador@suse.de \
--cc=tujinjiang@huawei.com \
--cc=wangkefeng.wang@huawei.com \
--cc=xueshuai@linux.alibaba.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox