From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17595C0015E for ; Thu, 27 Jul 2023 14:03:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2F9416B0071; Thu, 27 Jul 2023 10:03:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2A93F6B0074; Thu, 27 Jul 2023 10:03:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 197BD6B0075; Thu, 27 Jul 2023 10:03:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0AED06B0071 for ; Thu, 27 Jul 2023 10:03:18 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A457D1A10F8 for ; Thu, 27 Jul 2023 14:03:17 +0000 (UTC) X-FDA: 81057558834.19.F9C1220 Received: from eu-smtp-delivery-151.mimecast.com (eu-smtp-delivery-151.mimecast.com [185.58.85.151]) by imf28.hostedemail.com (Postfix) with ESMTP id 7582DC0360 for ; Thu, 27 Jul 2023 14:01:55 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=none; spf=pass (imf28.hostedemail.com: domain of david.laight@aculab.com designates 185.58.85.151 as permitted sender) smtp.mailfrom=david.laight@aculab.com; dmarc=pass (policy=none) header.from=aculab.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690466518; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+FMdjlxfYAQLQ/syU7JB9rh01InVTMgJkyEtHQA9N8I=; b=K+AxmIoWmQcT7qSltZBLXFMurDfivoxOz4VRGPIQirIYN3na9naR18nja4UkTv7GOODfj7 AQjQYq+/NXcA3pZ+TuxybKbzSZ0VqNTOO0LBTPbfH0cF6UcP8zBHfpf3I1t/KHo0vt4/Ne zevmYmoRthEq7QR4+xZVNg40oaBVht4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690466518; a=rsa-sha256; cv=none; b=APB3Oi4wFquBf723IoIWcTyWTS9TxCSWqPSHOc9EyY/xfdX5PobUD2S0k5eR7qmYtbcrCs eCKfwicnshSgBWdFNCmlHbMDKE5tn3kTXu/OxRcgPStF6dHyO5o6H41IA3qFGEg2UiiBVn dHaMwNsSfPiNn/qWiQ23OgyvuOu9vtI= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=none; spf=pass (imf28.hostedemail.com: domain of david.laight@aculab.com designates 185.58.85.151 as permitted sender) smtp.mailfrom=david.laight@aculab.com; dmarc=pass (policy=none) header.from=aculab.com Received: from AcuMS.aculab.com (156.67.243.121 [156.67.243.121]) by relay.mimecast.com with ESMTP with both STARTTLS and AUTH (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id uk-mta-228-MA1g0RDwNJKsqFhPGNhzQA-1; Thu, 27 Jul 2023 15:01:49 +0100 X-MC-Unique: MA1g0RDwNJKsqFhPGNhzQA-1 Received: from AcuMS.Aculab.com (10.202.163.6) by AcuMS.aculab.com (10.202.163.6) with Microsoft SMTP Server (TLS) id 15.0.1497.48; Thu, 27 Jul 2023 15:01:48 +0100 Received: from AcuMS.Aculab.com ([::1]) by AcuMS.aculab.com ([::1]) with mapi id 15.00.1497.048; Thu, 27 Jul 2023 15:01:48 +0100 From: David Laight To: 'Andy Shevchenko' CC: 'kernel test robot' , "linux-kernel@vger.kernel.org" , 'Andrew Morton' , "Matthew Wilcox (Oracle)" , Christoph Hellwig , "Jason A. Donenfeld" , "llvm@lists.linux.dev" , "oe-kbuild-all@lists.linux.dev" , "Linux Memory Management List" Subject: RE: [PATCH next 2/5] minmax: Allow min()/max()/clamp() if the arguments have the same signedness. Thread-Topic: [PATCH next 2/5] minmax: Allow min()/max()/clamp() if the arguments have the same signedness. Thread-Index: Adm+2wKUQ5yQ6t/FR+W/hRy2DuErJQALXH0AACSnwSAADmS3gAAu/pPA Date: Thu, 27 Jul 2023 14:01:48 +0000 Message-ID: References: <454f967d452548a9acfa7c0a0872507e@AcuMS.aculab.com> <202307252359.Is4T2MXC-lkp@intel.com> <350c7fe495424138afd15d797830c417@AcuMS.aculab.com> In-Reply-To: Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 7582DC0360 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: a4zeufag3acprhef4pzdyqaxw6ya37by X-HE-Tag: 1690466515-978806 X-HE-Meta: U2FsdGVkX184KCTJ3KqJREbJ9phlPKCqi/6b3bPXw6yJDkZ30wGwUbVN2rV52irQjSNKxMZUjP5WOctssTWA584W0n242ACOdfbJCuDiJ8+oYnFQyzvkhVcz0f7qs7AGWz0L1WtFjy5M1+pleU7GhB+f/lCLe/DajM7H7O2b7+17ylP50nCWiXlTHcxeM5Qvi9/tKz7CM7Pyu0gR5di0F4brQGb2tL8iAw3FHadTlsWcjqPZqQQhZT8FBnOka+lKd9HDyLuDOh3U6o3Fn9c5DdkspURcx5/OH0w3IiLEWCIB6gyYjMgjkV+dHwME6aOdfm8XaoX+2jxB7+N+cGD0b16DFCWvzvLKQqaYPwL5VxIlVIglODSZxZZtaYokx9BVDM/ZFVsruh3lCPemsNQGnPrERJ3ov7XBWJzcPZWv08fEHNhdN8HULi7whCb7Akkf8dEs9y6yYSdZEgbWwn3KkCRB2FW1ihd3W2wCHSKBxw67xmEPGOUocC6M08vnDTibxP6/xgLu1kKGsBAKkexMecz2iwddVRNfdwzqtXsVUgkIKYKDUNWtIC9VDiSIVJW76pR+2ANcPgMg/a/rJPUy0HGN3Wh2r7X9JFZ1kl5ZV+2yhA6P+xHnuffoA2WFtiuA1ix2I30O1SUj6PFYWLQOjh05LCrD0LuJwYQ2kDx/2n2EN4hgTTPSNFZxB8QrBBFSoyeGg5zmzJ5yA6xOpugK9SvRg0Be9r7aCZ4xWiaAGsapdJcmAWBm6raXQBguvaL0g3sjhpdgXxScJ2JZUg4b16E4xqfYVfM2DOMfDKebcflNuj//Z5O1oeqYjRr8kj0QPsQNurtQK9/DMSq//n8bhzaOs0t9v3TijpwibSkpVrHqhBUbSNVcDqAWmyaKgEm8QZ2g+63r9ChhTa6w1CThl0+3VGVSvQExDoWHgda/DjvL44Pz6zyBXuep6DT1HpG5GWGg/FMSp89jVGymK2/ GWf1/Aya up+zZGmKFELUcDxlkfh1vycoV5OyJvhY02fMWW15lEqj60qsfnn91A8Nx9D8LlwX87LsJDHYwy6UAy/akef+02NsJ+95JPis14cLV+8bvp/GF8gO3uCsZnzy9kEF458R2+BlLpuy8Q2t5yUVCeP9ObnAdR0vEo0NuU2VBPLbAa19IMkvoC3299eJQLoigTBJn99oOR5TLMvpauv7261SF3Br2+oXq7B2Kf4bKTkHQHiDV+Po= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: 'Andy Shevchenko' > Sent: 26 July 2023 17:20 >=20 > On Wed, Jul 26, 2023 at 08:30:59AM +0000, David Laight wrote: > > From: kernel test robot > > > Sent: 25 July 2023 16:58 > > > > > > kernel test robot noticed the following build errors: >=20 > ... >=20 > > > In file included from init/calibrate.c:8: > > > >> include/linux/jiffies.h:427:28: error: call to undeclared function= 'static_assert'; ISO C99 and > > > later do not support implicit function declarations [-Wimplicit-funct= ion-declaration] > > > 427 | return jiffies_to_clock_t(max(0L, delta)); > > > | ^ > > ... > > > include/linux/minmax.h:29:3: note: expanded from macro '__cmp_once= ' > > > 29 | static_assert(__types_ok(x, y), \ > > > > This is fixed by the earlier patch: > > [PATCH v1 1/1] minmax: Fix header inclusions > > > > which adds #include and thus defines static_assert(= ). > > > > Can I just assume that will be applied? >=20 > You can test that and reply there with your Tested-by there, it will help= it > to be applied. I can check it doesn't break my x86-64 build. I think the build error was on a 'um' build - not really obvious in the report. I suspect everything else gets build_bug.h included from a very common header file. On x86-64 (5.10.xxx) by forcing an error I get: CC init/calibrate.o In file included from linux/include/linux/bits.h:22, from linux/include/linux/bitops.h:5, from linux/include/linux/kernel.h:12, from linux/arch/x86/include/asm/percpu.h:27, from linux/arch/x86/include/asm/current.h:6, from linux/arch/x86/include/asm/processor.h:17, from linux/arch/x86/include/asm/timex.h:5, from linux/include/linux/timex.h:67, from linux/include/linux/time32.h:13, from linux/include/linux/time.h:73, from linux/include/linux/jiffies.h:10, from linux/init/calibrate.c:9: linux/include/linux/build_bug.h: ... I can't help feeling some of that chain isn't needed :-) =09David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1= PT, UK Registration No: 1397386 (Wales)