From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72832C43460 for ; Thu, 29 Apr 2021 14:48:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DDD7361449 for ; Thu, 29 Apr 2021 14:48:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DDD7361449 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1BB226B006C; Thu, 29 Apr 2021 10:48:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 192B46B006E; Thu, 29 Apr 2021 10:48:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 032666B0070; Thu, 29 Apr 2021 10:48:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0140.hostedemail.com [216.40.44.140]) by kanga.kvack.org (Postfix) with ESMTP id DCA476B006C for ; Thu, 29 Apr 2021 10:48:47 -0400 (EDT) Received: from smtpin36.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 9544F8249980 for ; Thu, 29 Apr 2021 14:48:47 +0000 (UTC) X-FDA: 78085686294.36.57A3BCA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf16.hostedemail.com (Postfix) with ESMTP id 22A7280192C7 for ; Thu, 29 Apr 2021 14:48:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1619707726; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Tkl/J7KdySQSxmwL4nToe0M/Xh0jvxPcUzrvauVfBCc=; b=ahzF16XmOz8/pdcNp6cbm1IRZlEeGIuCmpjcrOiv8MA2iLlRhUhuL5/W7jxuxWT2C/I653 dimK+NaW9RGFCGqy0tzFQ18MlXKoGWYSByV1ZvQOrapGmSssW27hBtZy3p+V2udPXaNHQ0 SLgUwDm/fwIaubJNw3ued/cUkUhFWRw= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-39-L_IPsdcCMQeMCz_Z-zwX0g-1; Thu, 29 Apr 2021 10:48:42 -0400 X-MC-Unique: L_IPsdcCMQeMCz_Z-zwX0g-1 Received: by mail-wr1-f70.google.com with SMTP id j72-20020adf914e0000b02901073cdd9d65so14614842wrj.0 for ; Thu, 29 Apr 2021 07:48:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=Tkl/J7KdySQSxmwL4nToe0M/Xh0jvxPcUzrvauVfBCc=; b=s0+hcWOlVH3PrpJv05cqhlu4qS+EbC3bCnmi8soUcTUHm+y1W9uxcvsI7D5lXlY5Ak BMbZTOjg5l2b54jtKtvxYlHfGTK54vW4a4hKmhDjPfGQniIlvNjlBqj8SnmxT7X0z/Fn pGcZjyGR/Ae1auOx3Y0PEH+8DMRrkR1vjdKwD/BfIlGqqqfZTx+TLvQ0DnEmnkcBcrbF XH6o8mvtBFhCSIU2GVwAOdR3WjxEpUNic2OOqTV3UJVzJFM2QK/G56v5uJtWaaqf0ck5 BS5LwVG3tQBMXpmlJxpI+rlbQm0qjy/x52DYt5+dNo062JVTXN/Hm0tXU6ocOV/2RPP2 lBEw== X-Gm-Message-State: AOAM533mtHy4qgJJB/F767RgMt7q0jkPIPFTuyLtas+aUOHVSdQ4UiY2 xwb5HZuR5LQQQzk2rqk2Qi3TGdWklsJRE43CALNRtH5ZRfSyFB2ZxPCZ6hhl2c3MdWZkLwQ+NHq KPuW1On6g7Ad0cAy7+TBHmgS5vXg/glCHowlrw8rED1I/nC55Btqdq6N9WSM= X-Received: by 2002:a05:600c:2d4b:: with SMTP id a11mr375469wmg.185.1619707721395; Thu, 29 Apr 2021 07:48:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyK5tOEhSkHKJM0+mEkeUgviEzMNg++fZFr8Lr9yMtdQOF0i9GqBldz4nWleT5OKc6yM0IfdQ== X-Received: by 2002:a05:600c:2d4b:: with SMTP id a11mr375426wmg.185.1619707721051; Thu, 29 Apr 2021 07:48:41 -0700 (PDT) Received: from [192.168.3.132] (p5b0c6158.dip0.t-ipconnect.de. [91.12.97.88]) by smtp.gmail.com with ESMTPSA id p17sm5000217wru.1.2021.04.29.07.48.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Apr 2021 07:48:40 -0700 (PDT) Subject: Re: [PATCH v2 1/5] mm/huge_memory.c: remove dedicated macro HPAGE_CACHE_INDEX_MASK To: Miaohe Lin , akpm@linux-foundation.org Cc: ziy@nvidia.com, william.kucharski@oracle.com, willy@infradead.org, yang.shi@linux.alibaba.com, aneesh.kumar@linux.ibm.com, rcampbell@nvidia.com, songliubraving@fb.com, kirill.shutemov@linux.intel.com, riel@surriel.com, hannes@cmpxchg.org, minchan@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20210429132648.305447-1-linmiaohe@huawei.com> <20210429132648.305447-2-linmiaohe@huawei.com> From: David Hildenbrand Organization: Red Hat Message-ID: Date: Thu, 29 Apr 2021 16:48:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210429132648.305447-2-linmiaohe@huawei.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 22A7280192C7 X-Stat-Signature: fet7s6gux148sf6kk8n1sksyfwayh4aw Received-SPF: none (redhat.com>: No applicable sender policy available) receiver=imf16; identity=mailfrom; envelope-from=""; helo=us-smtp-delivery-124.mimecast.com; client-ip=216.205.24.124 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1619707721-805878 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 29.04.21 15:26, Miaohe Lin wrote: > Rewrite the pgoff checking logic to remove macro HPAGE_CACHE_INDEX_MASK > which is only used here to simplify the code. > > Reviewed-by: Yang Shi > Reviewed-by: Anshuman Khandual > Signed-off-by: Miaohe Lin > --- > include/linux/huge_mm.h | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h > index 9626fda5efce..0a526f211fec 100644 > --- a/include/linux/huge_mm.h > +++ b/include/linux/huge_mm.h > @@ -152,15 +152,13 @@ static inline bool __transparent_hugepage_enabled(struct vm_area_struct *vma) > > bool transparent_hugepage_enabled(struct vm_area_struct *vma); > > -#define HPAGE_CACHE_INDEX_MASK (HPAGE_PMD_NR - 1) > - > static inline bool transhuge_vma_suitable(struct vm_area_struct *vma, > unsigned long haddr) > { > /* Don't have to check pgoff for anonymous vma */ > if (!vma_is_anonymous(vma)) { > - if (((vma->vm_start >> PAGE_SHIFT) & HPAGE_CACHE_INDEX_MASK) != > - (vma->vm_pgoff & HPAGE_CACHE_INDEX_MASK)) > + if (!IS_ALIGNED((vma->vm_start >> PAGE_SHIFT) - vma->vm_pgoff, > + HPAGE_PMD_NR)) > return false; I'd have used if (!IS_ALIGNED(PHYS_PFN(vma->vm_start) - vma->vm_pgoff, Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb