From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17723CF3189 for ; Wed, 2 Oct 2024 19:04:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8D21B6B04FB; Wed, 2 Oct 2024 15:04:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 881CC6B04FC; Wed, 2 Oct 2024 15:04:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7222D6B04FD; Wed, 2 Oct 2024 15:04:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4D2AF6B04FB for ; Wed, 2 Oct 2024 15:04:54 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id E98D7140EB5 for ; Wed, 2 Oct 2024 19:04:53 +0000 (UTC) X-FDA: 82629589266.24.7796E82 Received: from mail-4316.protonmail.ch (mail-4316.protonmail.ch [185.70.43.16]) by imf06.hostedemail.com (Postfix) with ESMTP id 2F932180014 for ; Wed, 2 Oct 2024 19:04:51 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=proton.me header.s=protonmail header.b=Yx3mYK4t; spf=pass (imf06.hostedemail.com: domain of benno.lossin@proton.me designates 185.70.43.16 as permitted sender) smtp.mailfrom=benno.lossin@proton.me; dmarc=pass (policy=quarantine) header.from=proton.me ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727895852; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9akIb4qnOADzLJh2oi1jZDxi/cwQ564uVPZn/qtrwfk=; b=sjLe7iNirndAEleKngICb44f4J39wJJAmZ3/IEjBXuL7KDn87TExCCyJhTrn6KJZz/eIqJ 2VVA26n33h5ZeNEBRHNKYIAv90IWzo+XYaTXKr+UslC4fr5eTyW133dOeXvbM2bQ/WQV+B 8iSwyEoBVSu7NJbJKe0pezvEiU+np5E= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=proton.me header.s=protonmail header.b=Yx3mYK4t; spf=pass (imf06.hostedemail.com: domain of benno.lossin@proton.me designates 185.70.43.16 as permitted sender) smtp.mailfrom=benno.lossin@proton.me; dmarc=pass (policy=quarantine) header.from=proton.me ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727895852; a=rsa-sha256; cv=none; b=weQ/y/oyaoJiD+nm/lqkY5CqAk8HYJyB5wro0WFMUTElUWPG4lExvpB8qMye1dZn5AQzD9 YGrdhqkW9V+lta7QnyCw+a4eH4y5Q1G1lIxcdHAqUdGPgw8E08HrNXGCEnCrhdmJntaPW6 KITp6b4EUdkZ7QKDGIo5oflbCxIUDZM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=protonmail; t=1727895889; x=1728155089; bh=9akIb4qnOADzLJh2oi1jZDxi/cwQ564uVPZn/qtrwfk=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=Yx3mYK4t7DSc4JRjFsOCtvopyfL9b56ZuDSYue7b2uOOFfEGwM9w2PSeIzxZ9i+0T WQHoNPirjdlnZqb9q2pYlTVrd0mQqtYs9SqfUsZosZsFT9eXFVo/6/v/1Uf57rx1Xr V9nmd5mI3FP3/ymbyF1LeO4r5O5GVc6ITj65XPRJso4udIwKaMn3rRdOD2CbjaYdID eXoefn8hKDviJhJVDoDHl6dinS8Kg334ApC4GAWFjZcRwHLRby8fzv21/oTOns4WZ9 TvB8M0bMdjL5bPFnKuRcNLCBGtXkz9kAK7x3gHUpSFy3IbjIuNQ+Ddb/9pkryo2cOv vTXspNFZXSxRw== Date: Wed, 02 Oct 2024 19:04:42 +0000 To: Danilo Krummrich From: Benno Lossin Cc: ojeda@kernel.org, alex.gaynor@gmail.com, wedsonaf@gmail.com, boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, a.hindborg@samsung.com, aliceryhl@google.com, akpm@linux-foundation.org, daniel.almeida@collabora.com, faith.ekstrand@collabora.com, boris.brezillon@collabora.com, lina@asahilina.net, mcanal@igalia.com, zhiw@nvidia.com, cjia@nvidia.com, jhubbard@nvidia.com, airlied@redhat.com, ajanulgu@redhat.com, lyude@redhat.com, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v8 16/29] rust: alloc: implement kernel `Vec` type Message-ID: In-Reply-To: References: <20241001150008.183102-1-dakr@kernel.org> <20241001150008.183102-17-dakr@kernel.org> <977af809-71f5-4a5a-8006-a283f8a6fc25@proton.me> Feedback-ID: 71780778:user:proton X-Pm-Message-ID: 528b097b375c393c59da8090d105ccdbc39165f4 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: xgris4jtf9zjbw8zoiukigaohu59np45 X-Rspamd-Queue-Id: 2F932180014 X-Rspamd-Server: rspam11 X-HE-Tag: 1727895891-564272 X-HE-Meta: U2FsdGVkX1/M2DHU6OIM+EWWKAZJNy4dw7UFsuoW/KdzaNmTem66vwvpcBYvqhQYzzmRXVb+6Fp9VoLf3N18q68GIHnYtT+ZeL9nUeA3p4/vDaRE/cTxNPeKcwjnid8Apau8UG9MTqicahwtugsyZzY0MFo05i6rRJhBcpUj+4ZxyhIDowqlpi8gUSLPwyWx1Secaz/V0epxFaFmzYSWvE9RIMf7efKgxioMQW+n6n4dz1qjD/zuD99LS2fc0Bk7XYW2A0am7ghNG5DDxJ5EqVd8MjPqMNgdkaK6zeqjTYqZBP7Q6TcK0mM5gF76WYcxuZy2D6xftB2Z7d33ohFvsEDZlULcnKciWRVWLZrKFEgx57AX8b3IHx42CfvZfcsQMRt7Ev9x4d5S43M97Ir7W+uD+dGFq9EVTtptJrUt24Wb/LheQhC0WwdMqSni3QLuWhKTYv+JaXDljPqqCvdkGO3lcqRNxHhpHjbQ5QxXVvzChAzJAI6cx/gyB+wHlNbCJMy6NWJlkMJghnVyEvRtS5ENrOAT2hFe18RCKypvcD8CHrnKU+z895OBiYNz5oo/5vqemgZCFqRE0/89PK5UmFT2oSwH0O4GSiOJpZtFI1P1BB5ItuGsvJHi9E8XGB5RDkrXhjszRwhK98xGmVCu30FrF2TnzsTSWmFkOjtsyErTSjzB2A5gQG4KOcboo6zzcGz66VB4zo/u/YIZqNx6U/1Om0q4hsnP58J2MVTP2lluNpvZvcgDrr/xfWTZuCwaI+uWjEza0nsfkpo/R8MsWS340ePFwmre23+yxu15P3HNpDnd1z1KTajfk0plCHJbrXBklZYa/xcT9qunV5UXHeyYYrTeYloYk0zZL9RZpv7y7vVwpgk01Kbg2rjE9D9S+Ij35I1vv9j5q6qdK26JZ6XTvrEgfXJM+j2FwAz6pi76mleTx/bOqm0iK/HxjWlswY/WqBCwIBE3dd5s/No b7k9zE7+ L7nCEaNMQvkMxkU76hCU0rLSRIK8MvvdkgBlzkyZqqEyv3WkVYeST+LN86/sv+JfmS9boRTXasaZet2elto2x5N0CoDAlhevWjAX2/FbS0PRBjKIQf9AIBoS8nQV32IvL+CISKCvy1lqZbu/0nfqhbVY9YQ6/vyCOL2yaHzW+dyMG7ost8w+kJExZ2gn4OgMjNi/wq5FjA6fE+rzlMhGMx8BU/J+CWFRYELGQk/vMocTpbB7ZAiDrAW35iwnXLzexPLR3DTobSujQWUhqmUGkTjnw+X1CZ+Vy9xSAnQp1k769UCmBeB6t+YXnOKINLkgN3ziDTcGtLpFgYxOqPlQVVNMdw6e2YJk5DvuPPhJELxBT3oFlbzQ3RQigmgUDIiq8YAb3PrD1How5RZaV+OAZJ8ZEsA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000006, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02.10.24 17:20, Danilo Krummrich wrote: > On Wed, Oct 02, 2024 at 03:02:18PM +0000, Benno Lossin wrote: >> On 01.10.24 16:59, Danilo Krummrich wrote: >>> `Vec` provides a contiguous growable array type with contents allocated >>> with the kernel's allocators (e.g. `Kmalloc`, `Vmalloc` or `KVmalloc`). >>> >>> In contrast to Rust's stdlib `Vec` type, the kernel `Vec` type consider= s >>> the kernel's GFP flags for all appropriate functions, always reports >>> allocation failures through `Result<_, AllocError>` and remains >>> independent from unstable features. >>> >>> Signed-off-by: Danilo Krummrich >>> --- >>> rust/kernel/alloc.rs | 6 + >>> rust/kernel/alloc/kvec.rs | 637 ++++++++++++++++++++++++++++++++++++++ >> >> Any reason against naming this `vec.rs`? >=20 > I think I didn't rename kvec.rs and kbox.rs because we'd need to escape "= box" in > various places, e.g. in rust/kernel/alloc.rs: >=20 > ``` > pub mod r#box; >=20 > pub use self::r#box::Box; > pub use self::r#box::KBox; > pub use self::r#box::VBox; > pub use self::r#box::KVBox; > ``` Yeah, that's why `std` uses `boxed.rs`. > And it's a kernel specific implementation, so kbox.rs and kvec.rs still m= akes > sense. :) Fair. --- Cheers, Benno