From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B829C47074 for ; Tue, 2 Jan 2024 11:10:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BED118D0001; Tue, 2 Jan 2024 06:10:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B9ED06B0121; Tue, 2 Jan 2024 06:10:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A654F8D0001; Tue, 2 Jan 2024 06:10:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 98D2B6B011B for ; Tue, 2 Jan 2024 06:10:09 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 711E5A14DB for ; Tue, 2 Jan 2024 11:10:09 +0000 (UTC) X-FDA: 81634101738.17.EAF01DC Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf27.hostedemail.com (Postfix) with ESMTP id F21364000E for ; Tue, 2 Jan 2024 11:10:06 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="UmcT1/r5"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=E1nsOvAv; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=dATbVlgS; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=YXBgv7TK; dmarc=none; spf=pass (imf27.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704193807; a=rsa-sha256; cv=none; b=jOx6gye3Blo6BzmDlevoQVdIouGwGAwZTHhAPU1R5ssc0xFkmvlm+fGIh2ogBCUDeU2W8n DZVcqA7sxodgTsS642JcGp64rjNaQ1XnTBVR3kuPMRE1epILsh9bm2J/zrmW6nalEOHHRw a0K25lTCMkpXsZKw4RFVy4fvSjWuw0s= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="UmcT1/r5"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=E1nsOvAv; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=dATbVlgS; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=YXBgv7TK; dmarc=none; spf=pass (imf27.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704193807; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/tzG57lKdo0jwQEqX3DhWZxIgxDE4YMWxyLpQirohZI=; b=KeEhN2RUgVyyNpzGsvcENkkcVzuZAp48PCSChBnqC0ITHkGx9dyfoRGHwtx8lbyvHd8M9u +fHl7mJY+erFZrWx3BmVAGBUz5Q41mDOeVm/GjKVuKM87fmH1ADWtHPGrRZ0nZ2hEW4Ki9 7WhFiGt72dKQWBUt4U+Gx9RBY2Gc0RI= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E5B371FCF5; Tue, 2 Jan 2024 11:10:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1704193805; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/tzG57lKdo0jwQEqX3DhWZxIgxDE4YMWxyLpQirohZI=; b=UmcT1/r5nVZ0BLR+O8ao/J6Z1j8Sl/3m9wSz+bc0F89MJWSQoJxdqVOfw9zikbGAhf4/te ErmJv4Co5MTm5TnEH0Pm/85dicaYw3IOtHAfUCpoAFc1G7U5t0de8V94CZ40/qe7nuugJ/ jGXwe95e/dzqqHuy6AOZVs4EyTuqTA8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1704193805; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/tzG57lKdo0jwQEqX3DhWZxIgxDE4YMWxyLpQirohZI=; b=E1nsOvAvOXFnFAhIPXnWPxoEDyOmQoeR2878i/3ggba6gFHyZgxO023OkcG0cIuNLnvfS1 CiGxZZqkwvhiQFAw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1704193804; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/tzG57lKdo0jwQEqX3DhWZxIgxDE4YMWxyLpQirohZI=; b=dATbVlgScUpFYzimVO14loPcDj2w69YDJscmJuUrwwxf7kpVaizyfaTRu4HHUM8i8Ji8UN 883narh0TJtTssEu41kHwUrVIcnrB3tgs1BMILv12Awp4Cx8JHE5hJz7qZvWfSU0/wrRFG KjthAsD0p3s/T2AMMST+Z9sEyrUuv8s= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1704193804; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/tzG57lKdo0jwQEqX3DhWZxIgxDE4YMWxyLpQirohZI=; b=YXBgv7TKtMok3XzrRYgNBjNrkToYLdxoct1EslHRCAVKxhiLI+E+PWi9ZTxLC1kRiv86uV k3RPG5dQV9h0j+AQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C888213AC6; Tue, 2 Jan 2024 11:10:04 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id nCtmMAzvk2UCKQAAD6G6ig (envelope-from ); Tue, 02 Jan 2024 11:10:04 +0000 Message-ID: Date: Tue, 2 Jan 2024 12:10:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/6] slub: Use folio APIs in free_large_kmalloc() Content-Language: en-US To: "Matthew Wilcox (Oracle)" , Andrew Morton Cc: linux-mm@kvack.org, Johannes Weiner , Hyeonggon Yoo <42.hyeyoo@gmail.com> References: <20231228085748.1083901-1-willy@infradead.org> <20231228085748.1083901-4-willy@infradead.org> From: Vlastimil Babka In-Reply-To: <20231228085748.1083901-4-willy@infradead.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spamd-Bar: + X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: F21364000E X-Stat-Signature: x1bxcn4cezsdo349rinnpp8r5aas8e5r X-HE-Tag: 1704193806-69160 X-HE-Meta: U2FsdGVkX19ub+al4giMzwkAmSZb4FuR9XnDMn+sNAPrO2MgIG1DJuUpLIkfdjhOC+G3V1nm0Xj+dt5YT5htvRKd57EpgI6uoFfvtf2cgiwtjBotnBrMypLlC84V3/PF0/t3Ydnze1MN08iJ7eVXhMWdTW7WibSAuNe8ZcojSV6RAbvh/CiXIcXXgIWHwX/S5oXWnwiiey5zSUedcxk4j0ofIRenSG23LLzlKhzRd6IlpwzbJkNYfGGjoilHwR3Jh7d7aOrqiD0CEWaGAc1kRITi2MFLkdNxX2ty9NERMJW+LjDSAJZbu2DEmglWvYLf7rSo+kbcwlmiyN8U5sOYOwiTB0R+gpBjfGDUdk7ngdGMlbjqwqa6RQyIq11cr6zkMmPCAq2cU4JUFrBHYbTqlLQlpEcmOqQnyzPaqVHTckUtDw2CMx4BeeJMYwr8skIEEfMPMG6e2BZJulqx5qMANpyoBVWX1eHBAJX2CSj/AcnCc14DtlZJ5kiIRqzydYi5Ye4h3cnenaCgZAtyTIIp7wRtE3JFxvL6Xe7RR2h9fdelzWC6xA5qREhMt7Yy2o8a8jxYPWRy6Xo0eD0vnEZ2y1eveVKMS/+gidKPkfcw3TRh91+WERQ8zD6Y49eK6AbbLbQ/KfzXTLFiWhUltQNtWL+ovP9SF3puCFtDXYIzB8AjQHDGwuIdrvXPaeNjLpAG6XF9JP0q4cIy8dqlM7JGskIfQvAeBfdpH8l4XDseHA5MbpBMKkg1kPdAZ02kfAJ7bZmw+XdQlW5ZyX1DV+fUDOFYCpszHbv6A/nrBjAjXUO2CvgwCRDpwtDc6/xChlIYqt6A3vGeR/UbqRy+SeRmbh6omjhMghr7YLnRMdqWyJcuyso13uBipv/PesFpI0i+JmxOgmPOEK+PXZKkxmCZFiJDqjAcxoJtXjq1PnA3Pi7V5raQ97m/9X/yq7ti4M3dlprxRSPEOpXnFabgkag V/6fP7gB ZgQR9Yv2Dq6QjWgSp4XA+pjxCensD4pacy/0xt6s3lENztzgF3Ilr2zPTHS8OyDGK8/79QCFLLqJhwTG9E3/sM9qqewfDA1MmcCE7bTRpZC6hl4QMcC63imaodSUC9nuHk2YtGY6lZpsKJfYh2z5qsH6L3cDQxfCsiJTKwZx4wG2NX6bf3gMFn1bNDqomyStbJmKzNTE8enHRWURamJdjJl2RB8xx4JeTOzU+OBUl2pPEMY8yHTNv2C5oD5CktGGKQzXAdlY/EfOsB5ee0MXl6iUv/mYGdSUODZTg16yxdTlPiCCmyeYZl0XsfdwaFR529f3OE5DRi3RSuwJuEGfagh8Ip0kXGoE9xzqFQvNry8oW4jFNa/BkwBr6qvAvt07ArN598Y08JwUFKZ3Kst7iDUgZk45JaYEfJvoK2cGfRwl1JfFNt2b1n7WVJw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/28/23 09:57, Matthew Wilcox (Oracle) wrote: > Save a few calls to compound_head() by using the folio APIs > directly. > > Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Vlastimil Babka > --- > mm/slub.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/slub.c b/mm/slub.c > index 342545775df6..58b4936f2a29 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -4375,9 +4375,9 @@ static void free_large_kmalloc(struct folio *folio, void *object) > kasan_kfree_large(object); > kmsan_kfree_large(object); > > - mod_lruvec_page_state(folio_page(folio, 0), NR_SLAB_UNRECLAIMABLE_B, > + lruvec_stat_mod_folio(folio, NR_SLAB_UNRECLAIMABLE_B, > -(PAGE_SIZE << order)); > - __free_pages(folio_page(folio, 0), order); > + folio_put(folio); > } > > /**