From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFD77C61D85 for ; Thu, 23 Nov 2023 09:32:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6BFA48D0018; Thu, 23 Nov 2023 04:32:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 66FA48D0002; Thu, 23 Nov 2023 04:32:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 537728D0018; Thu, 23 Nov 2023 04:32:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 427DA8D0002 for ; Thu, 23 Nov 2023 04:32:31 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 1C2D0A0EDC for ; Thu, 23 Nov 2023 09:32:31 +0000 (UTC) X-FDA: 81488703702.20.3EF776B Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) by imf23.hostedemail.com (Postfix) with ESMTP id 367FC140018 for ; Thu, 23 Nov 2023 09:32:28 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Gk947g5o; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf23.hostedemail.com: domain of fancer.lancer@gmail.com designates 209.85.167.52 as permitted sender) smtp.mailfrom=fancer.lancer@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700731949; a=rsa-sha256; cv=none; b=ClXPXlh4P9Ixz/3f97OnnY+AEz2IQeH+A4DUdxf34khXlHPIa+fYWLrENkYelupn3j4hO1 L6+1Uf3ES//xkTw35Aa/9fYlGnMnYzJoPwXE/djp0SdLsLvREfNTyF7xN7VeHK4JwJusNO zEqGt2jj/1+TX7AFjC8JkdjOIFe7tfU= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Gk947g5o; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf23.hostedemail.com: domain of fancer.lancer@gmail.com designates 209.85.167.52 as permitted sender) smtp.mailfrom=fancer.lancer@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700731949; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tqEJ9Wsu9O4u7Ifl6pZ1YDAaPyCTLMsbbJ4KpzLqR9M=; b=a7p2ftCKyNPDkz8fPuBRo9HcOBMKMCd/dTeXMJWnhG+g0roQ5KkTGfKWg+m9LF0UYN7sfU 21Rg4uel3yqJQIsIe8GttN/yDcrziWX8fkT0XRklfrHySK86yLRlrwX7EUhgdtDtWcS5Wq r7bnBodq3CaXDrMQeG+cv0vTcqhbcDo= Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-5094727fa67so852166e87.3 for ; Thu, 23 Nov 2023 01:32:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700731947; x=1701336747; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=tqEJ9Wsu9O4u7Ifl6pZ1YDAaPyCTLMsbbJ4KpzLqR9M=; b=Gk947g5oGO5fTvW9zOlTSTcqjtom4WF1iTvJ4ICT4DXYntZcVYbR0Rfqj9hfesWoqH 79BN/57g1n2AoriJYx0CXOD1KA2oiWTR4WV5vg+Os/J1ZJhoMolH1h+oNxszwqsk3Tes Xif59/x7GcHKyGQwR2a2CZ/UqJybzOSA3T69Lyeu4UZz4B/ymfv/MOqmtf9RQhx1wtg9 ISiwLeIP8a0ykukyYrhCIg0pBRhSkE2PpdKo+no1+pMHbOY/XYbOtB6KWenGwHW0WdWe 4AVyHV8Gn3kPTPtTMV58MWw0gfOv4kQvLgdjOYBGTcqkx7AZ4oC9lRcZEGwdTQRAthyn RJgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700731947; x=1701336747; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=tqEJ9Wsu9O4u7Ifl6pZ1YDAaPyCTLMsbbJ4KpzLqR9M=; b=Ox7tUAZ8sLeR2fHuq/EjlVbfyjm2ciwVuBTDMg/4Y/QnrllepYqmRBtx8cLR0O9CQi 7hq+GSD1EgG9aXRMMHTLRuPT43YDZZvdWFR7JgQnQG8J423TdhdOx+M4AQeN5pyrKWyh Rb/aGQQ133l24G8mMRcNYSBCout2bVQ+qNj9fKG9MkST6RVd0vDRajOBvdcHowRZSoAp uxYF4pZBULjzIyge+4RQ9snmr+p/OUnN++B0eM87z9H0rChF4I1q+5fHoYEmFYUfwXyW lGJm8PBRphLTVoA7MUqTwujsvjXsaY3RUlt5oKhilXUL3bMc7viSMJmbhbrsEuMfezZt +rWQ== X-Gm-Message-State: AOJu0YzjpbEdB5Buvvfd7mVliJfGYJXac3B5n2eiStNAcn7+QgBl3SC3 i7UammorIGkuf0EMPAXpjNM= X-Google-Smtp-Source: AGHT+IEEH3l1v05pUmE2AaeJ8W/B4nA+a7iA1maBjDbATrhvBv1FofrOnDthOQ+pWUtvH83CSBIElw== X-Received: by 2002:ac2:4911:0:b0:507:9d70:b297 with SMTP id n17-20020ac24911000000b005079d70b297mr2872785lfi.60.1700731947096; Thu, 23 Nov 2023 01:32:27 -0800 (PST) Received: from mobilestation ([178.176.56.174]) by smtp.gmail.com with ESMTPSA id p15-20020a19f00f000000b0050a7052409fsm135201lfc.121.2023.11.23.01.32.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 01:32:26 -0800 (PST) Date: Thu, 23 Nov 2023 12:32:24 +0300 From: Serge Semin To: Arnd Bergmann Cc: Thomas Bogendoerfer , Andrew Morton , Mike Rapoport , Matthew Wilcox , Tiezhu Yang , Huacai Chen , Yinglu Yang , Jiaxun Yang , Alexey Malahov , Aleksandar Rikalo , Aleksandar Rikalo , Dragan Mladjenovic , Chao-ying Fu , Marc Zyngier , linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/7] mips: dmi: Fix early remap on MIPS32 Message-ID: References: <20231122182419.30633-1-fancer.lancer@gmail.com> <20231122182419.30633-2-fancer.lancer@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 367FC140018 X-Stat-Signature: 3jnnztw9of9cysaauzfjj5pemfeohb1x X-HE-Tag: 1700731948-906289 X-HE-Meta: U2FsdGVkX18f0f1nirZnEUZhIzN9poThfSsPsOAVJa1Du+/+u2XTLk9VNJuhjtGRWm4bH5HLNXAs1psgBKt/VJtRZi8GPey3yN12OhDyPAche+L6WUGbmKswaW8Y3uPkeVjK0O53EuMbVyS524kdRHxUo5BuZTIvsNy5SW0eyVh0XYzsisZo/khJ3oEvbo+jsvKxaStZSVjPYRe2isR+VkWSqfcwRAP9X0GApcA3wfC3BnjeG7o5gvTwYksrdBBIzGvW6bPGsYEsm0rETC0PU/HDRn/Ho9JQfvU1SYKxSYWZfq3x5zYIk2wR2Yk0E1+hLXel5If2T1CmpA8zD9iHSs81MzaLYI/gRKEPLhFpTsGTqwwVs4z4SqO7E+S8dfBg1ClyZMbGbOGvcea2niLJWpfegxpdCaNVRFzXOysX9i4Ivyile3Rax8BgBCUdXmdRSUb47cI6v6NVXv4rre0c5z0mNIuau/HwgX4DQ6mT7e4GgcV1ZG6Q2KepY/Rowe4+h/QdM4jSqhe7F49ZJl3igGgeQLFBnr4pES7NytRjGxhHV+OS2v9kPBfro3Ohr2jqxT3vdjDX1Im/cAyuyKRZwgJB9TmWWwJN1AQ4d/SheaBVvir8K2k30+mBkeAgLTiIWWg0fZqOM8II09OjxTVQ3wXSlfmHjWqNsIwcOm8BkTE8XG3U70lMa+3/EunXy9EHhtkBHq9dnsioTDbigkWsU0bYVRVDZ808NRCx/UTW8IqVQdu1T8qsb/ilYHk3ip/ZA897WJa3W83rDFyKuiJi9D8sYxTuqsmcPxLCJ1Misn7Z2aRFWPr6ZML5R8jYHpvel0Sl1SdmIY50/tHR+yRnWaIyWocXlt2ZhJ7fn++1AB9D50pg0cVuhfcXUzMpXem9LK1kemuC9fSN9RWcCF29ROUo337jKKSjJWGFTt5NxxlbGExbOWHLkhN9XQb8UWtK0utKIz56k7dllqsfHac DPTVDZMi f6TpSMchbt/NXpWS2o6Op9rq80WMBfBL+sB/14vBf7fZPV42GeNQxJ2QlET7wltaIoMZ98exHXBt9Ed1+TQ0avobvUO/+8/aK0VEs3QuOygyjv9AhVCrLueMtpTypoRSl74XTI93rrLGJTOLteFru1SIYjXRvH+0EyBWq8zX+vrjo00z13oDbbgtmHhrMgR4GAQk1Dps3DKDbjOa26YrfokJf5jpuKO2a7DxL2cx1E3uvMkzcpzRtSaxuKKT5rikJv3dlsDwGSHoXsljDSv6AKoUTeOPj4yXQMNZozjd9ys55EFm0l6HSa/OJoJFWzaPdXnsCx71f54znM5hKfKjYykEKgbsxcyJL/VAB6Bfl3dY3lcTuqaH3Jhlt2vDnDqcxK+J4FHkpTEZnjfupUxxWAIbgugiVj+qVZE8H5SYL3dPD8UZMm3xbJRX9k/6DeN1PYK4jJJi3nIWamasRKRQl6GuXwehvobFf18Jt6iYSYvGHwrA3vImCvebrexpUnq+ZscwmaXsjcrx6GaTYie4Agd1HGSnqnnTIvWMjpapZzwGi110= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Arnd On Wed, Nov 22, 2023 at 08:35:01PM +0100, Arnd Bergmann wrote: > On Wed, Nov 22, 2023, at 19:23, Serge Semin wrote: > > dmi_early_remap() has been defined as ioremap_cache() which on MIPS32 gets > > to be converted to the VM-based mapping. DMI early remapping is performed > > at the setup_arch() stage with no VM available. So calling the > > dmi_early_remap() for MIPS32 causes the system to crash at the early boot > > time. Fix that by converting dmi_early_remap() to the uncached remapping > > which is always available on both 32 and 64-bits MIPS systems. > > > > Fixes: be8fa1cb444c ("MIPS: Add support for Desktop Management Interface (DMI)") > > Signed-off-by: Serge Semin > > --- > > arch/mips/include/asm/dmi.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/mips/include/asm/dmi.h b/arch/mips/include/asm/dmi.h > > index 27415a288adf..525aad1572d1 100644 > > --- a/arch/mips/include/asm/dmi.h > > +++ b/arch/mips/include/asm/dmi.h > > @@ -5,7 +5,7 @@ > > #include > > #include > > > > -#define dmi_early_remap(x, l) ioremap_cache(x, l) > > +#define dmi_early_remap(x, l) ioremap_uc(x, l) > > Please don't use ioremap_uc() in new code, we are in the (long) > process of removing it from the kernel for everything except > x86-32, and it already returns NULL on most of them. > > Would the normal ioremap() work for you here? It seems to > do the same thing as ioremap_uc() on mips and a couple of > other architectures that have not yet killed it off. Ok. Thanks for the heads up. I'll fix the patch to be using ioremap() in v2. ioremap_uc() is just an macro-alias of ioremap() on MIPS. -Serge(y) > > Arnd