From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4405DC3ABBF for ; Tue, 6 May 2025 10:22:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 43C7B6B0085; Tue, 6 May 2025 06:22:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3C6436B0088; Tue, 6 May 2025 06:22:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 265896B0089; Tue, 6 May 2025 06:22:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 070006B0085 for ; Tue, 6 May 2025 06:22:49 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 25D3656B75 for ; Tue, 6 May 2025 10:22:50 +0000 (UTC) X-FDA: 83412094500.03.3F29B76 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf19.hostedemail.com (Postfix) with ESMTP id 6AC5C1A0005 for ; Tue, 6 May 2025 10:22:48 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=none; spf=pass (imf19.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746526968; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=g+TDHydmiIFPRZl/4SglpErhqC9MfKzZ0ENT4CvCO0c=; b=hxE/JFQVX+R/WdkuJGIE3SCpXM/JbCLW/pA2s6anvunrUHjuQk3L0dFfXK24Fz/OINIhbB zzKfFfn3rTrmisIYrwpec+FyaKThZTeJ9xvdD+c5SKE70VSTJ3VfkC5vKKCMCBKA2rb8Ag UtrypOiYfqjG9amoaQbuAdUTvLAtX3c= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; spf=pass (imf19.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746526968; a=rsa-sha256; cv=none; b=GO3Nv0kGD1g6rSq5xF7IOtVsLHcgxM1k+nAoXghVFkoWu4peF7DQ3YPMyb/WwJD8P+LeGz hVXooe1E+YIlOAblViAVOCApd6DKemNSMmfOhVEkef5wtd0b0ayOC28w3N5A4iTtMdtUP+ wBgZ5wojWPmbWhF4T0mXXG+9n2rD3go= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 046AE113E; Tue, 6 May 2025 03:22:38 -0700 (PDT) Received: from [10.162.43.13] (K4MQJ0H1H2.blr.arm.com [10.162.43.13]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1F2883F5A1; Tue, 6 May 2025 03:22:41 -0700 (PDT) Message-ID: Date: Tue, 6 May 2025 15:52:39 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/3] Optimize mremap() by PTE-batching To: Anshuman Khandual , akpm@linux-foundation.org Cc: Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, vbabka@suse.cz, jannh@google.com, pfalcato@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org, david@redhat.com, peterx@redhat.com, ryan.roberts@arm.com, mingo@kernel.org, libang.li@antgroup.com, maobibo@loongson.cn, zhengqi.arch@bytedance.com, baohua@kernel.org, willy@infradead.org, ioworker0@gmail.com, yang@os.amperecomputing.com References: <20250506050056.59250-1-dev.jain@arm.com> Content-Language: en-US From: Dev Jain In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: 4ad5njzudmrnjqsppffek3kjabzms199 X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 6AC5C1A0005 X-Rspam-User: X-HE-Tag: 1746526968-701696 X-HE-Meta: U2FsdGVkX1+vTwiRB2Gtqf+PC+HeZIajw2Rq34xN4qGDnrnPZnRbQ80EB5rFtAWVVH8ctGfCiW7xBiDuSZ8IHHFisLtzZ4kQ5waXXRN/f/ft6WA5GH6XB6WvwhtcZbQEcJoEFLtoXAr+ZvIsVksRdrZTBm5SWDns1EM0T+WqnPCKmal6AVFMRkueYi0U4qhlXG2lv+oMxsbNK4RukyIT4EC1F3qLLLf6iL9Ty6v8qfhDVg24fg7TdYNQvt0dHVcWlOt93bIb2jGwSyfnaiA/ZD0aRHWIpjSsumhUbHLrHnx2sztJvojMEKSR4fADEGODjUXGYK6/vMMxSeFdhTA2EMYZ2FwWIn6XbEVcYLZUg2pNl0EB9nHFGLX1AvOboCqTRpk0vS18di7HIaKsGhV7cbZccX7sHlB3PzRrswKvAJCbCY8mYeg+EKXXwDtb2I3knvuHYeSVP88oc8Md/MHkTt3ILKMsK7aj0Psx011ByxVOFfSeglv0xSvJt0UTwFkDqWmwc1qspAigZtfopU46Vy2IQ16DZh1PCzaGXSWH1BuTRWd5qo0YFEFEbePeQLMsnSMomaoOLDhm17iBuYyhlJPfTBbKe3SPTFFAVD7fB/7TeyML9GzvWi6bSVvTOnxRchOBRBKm03OGxCMz+fnKcDrbeIsZQY9mxjjpu03cvXjlT54P2qyhx9Udwctl0hkc93DaJyygeAukFi5xTm2d85xOklEePj6KP06/4ILycfWI4yE6RMJOvLa7NT2OMk9NdRw/H0LA3EdHuQJWbRAPAeiLhAlyX5STzHE0QmWxBk6lb+frCc+IyFH2xbgkr6CNerqXyzjPlcvMOfd9lOAl8iKTjJ0l5uUojIL1hN6Z2lr1ZxbbN961zRvtqEuJ7DnGENyJIwjx21MzBKKdXJCk/2sjDfxJYv/OmUx+PLw56kCsfgknbwMngxcLXjml7rIdAZMOAQ6wbI+t0CXIgJ9 rV5mGVc+ SuSrKGXKoYkGLzj0JIlu5iGI+GU4fPHu9HSMcQjl5puWkDY9TIs/uQayLM+hEm7FdA1RjteJ+MRI3KH1vQfooGJq0PQUAOGN43J9ZlOs85vVCdRqGsmXHTaSH54lRvFwcB+j3PIq7dQCOaWC9mlyR+HRwGQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 06/05/25 2:46 pm, Anshuman Khandual wrote: > On 5/6/25 10:30, Dev Jain wrote: >> Use PTE batching to optimize mremap(). >> >> Mapping 512K of memory, memsetting it, remapping it to src + 512K, and >> munmapping it 10,000 times, the average execution time reduces from 1.9 to >> 1.2 seconds, giving a 37% performance optimization. (Apple M3) > > That's impressive improvement. But could you please re-organize the test > description into a pseudo code format or better provide the test program > itself (which should be compact anyways) just to be more clear about the > scenario where this helps. Sure. > >> >> Dev Jain (3): >> mm: Call pointers to ptes as ptep >> mm: Add generic helper to hint a large folio >> mm: Optimize mremap() by PTE batching >> >> include/linux/pgtable.h | 16 +++++++++++++++ >> mm/mremap.c | 44 +++++++++++++++++++++++++++-------------- >> 2 files changed, 45 insertions(+), 15 deletions(-) >>