From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE118C48BC3 for ; Mon, 19 Feb 2024 09:30:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 17DE78D0003; Mon, 19 Feb 2024 04:30:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 109108D0001; Mon, 19 Feb 2024 04:30:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E767D8D0003; Mon, 19 Feb 2024 04:30:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D018C8D0001 for ; Mon, 19 Feb 2024 04:30:26 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 78E7FC02DC for ; Mon, 19 Feb 2024 09:30:26 +0000 (UTC) X-FDA: 81808032852.19.27A3B9A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf08.hostedemail.com (Postfix) with ESMTP id 1485716000B for ; Mon, 19 Feb 2024 09:30:23 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=W6piOGVA; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708335024; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KPNtQLX/ASuH8CsNpvSg+A86gihyZbCbVxAryd4BHq4=; b=wwdkaA05CbTOAYNgXKsQntzZTYpXonInfBmjc9bIO/6ZhKRV9nESXu3fuYWeplPgC9hDez c3e5o+dYOCAqsIKcDcKE+YM0jvQqymv3CXTp1SHmZ2PTlEpA2kYMrEpQD7tO3MW3n/IHNZ ecK1IsqgZQyfJ4HKpDqEBo1bspOmkHI= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=W6piOGVA; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708335024; a=rsa-sha256; cv=none; b=XHBnYA8Ku2san7ekfcYXmYcAZQcCgO1Dk5jrZ2mm4TUjMCrbmOBYtEAt8PCjcrjjcexMfF ZqHPF/iw0lczhf0MT6WjOYUx3W5qSGPVkQmGf04fXUCY9GWga/iiN9pNu/w8qpNSFXc0j0 /KdEUAXOE5PBXyFi6Aj10SwLdhA3CWU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708335023; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=KPNtQLX/ASuH8CsNpvSg+A86gihyZbCbVxAryd4BHq4=; b=W6piOGVArrqzhX6rdhkwX3JJ7cS7EqeKIsuNkzdLie4oPecPDOKs6yJyanoQnLBXS+yBkI Ow7z1gVuo0OU7zmjrwlMJsqubnxZOnv0ey7IkDqYgIweiBtVrRbjX6DtvWG6RscaaZ/A2e 3BWffEZzqH4Jps7/D9jUU7d5IYyT+cQ= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-411-xueaULHMPCOVpKIXpyPbiA-1; Mon, 19 Feb 2024 04:30:21 -0500 X-MC-Unique: xueaULHMPCOVpKIXpyPbiA-1 Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2d0a329e86cso37887381fa.3 for ; Mon, 19 Feb 2024 01:30:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708335020; x=1708939820; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KPNtQLX/ASuH8CsNpvSg+A86gihyZbCbVxAryd4BHq4=; b=p5qKARNUvyefH19XMVFqx3Na1tXqyds/iGdnFKXlSOANlTfidIarV9A0KwUpzJtq0B 2tJcEDsj1do5FrSeR9/d4UaNo20M3W1oLSe4YQD+lZXvwHO03scwN/d8OkJry8Gk7amw IhTheOAugiphX3JJX7XGi9psFM8duAgtn1BETU9A0BuZbWCzNzu53iyt443ng3Wz2NU1 VJ6b8+Z/UFXcRfzpVb6kVX8m610C3uhlbnIo0AWWcAFnEhCsr67jueswxtxVgzakQWR0 lafrWQiSXYt7KIVBbx2HUONHLrSiSdu3PQfbuwZ1E/egmkHIopp6x9nuh/xUMYoto0lP Br4A== X-Forwarded-Encrypted: i=1; AJvYcCXGK+N5jCgontoW8jDbUL8sRIt6mqWyX5Kwlm3tMsJaytZdio8yOqIOT0CyVLxjKAe393ZchSWg0mX0PcyMHdhqGa0= X-Gm-Message-State: AOJu0YzheEbUqBif7EPKKJnsYyMEjehssyAIbVR7A2Drigf4cCu3T2kd 5WtlT1b+pZWOVOBXVPziWsFucvpKTmW6lCfKMJdlV5t2NumksKlVa251Iw+sbezt+/dNswnS9j8 PlGRZFI2oMWd4xURWZQbvZz5xEaGB7rZeM8HzHhJ2CIfGR6xi X-Received: by 2002:a05:651c:2127:b0:2d2:31af:a5a8 with SMTP id a39-20020a05651c212700b002d231afa5a8mr4102840ljq.35.1708335020197; Mon, 19 Feb 2024 01:30:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IGg7Yq5EamispIHV/asAqBi3ILJCiny9xfb8yYl2FcitR66BULSiWjebv3iSA/d8jWc463PSg== X-Received: by 2002:a05:651c:2127:b0:2d2:31af:a5a8 with SMTP id a39-20020a05651c212700b002d231afa5a8mr4102816ljq.35.1708335019794; Mon, 19 Feb 2024 01:30:19 -0800 (PST) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id o19-20020a05600c379300b0041237b54811sm2293904wmr.0.2024.02.19.01.30.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Feb 2024 01:30:19 -0800 (PST) Message-ID: Date: Mon, 19 Feb 2024 10:30:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] sched/numa, mm: do not promote folios to nodes not set N_MEMORY To: Byungchul Park , mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, akpm@linux-foundation.org References: <20240216114045.24828-1-byungchul@sk.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240216114045.24828-1-byungchul@sk.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 1485716000B X-Rspam-User: X-Stat-Signature: me6jqa7bsh7nk1ru8wwrmbi7wmoktqb9 X-Rspamd-Server: rspam01 X-HE-Tag: 1708335023-467135 X-HE-Meta: U2FsdGVkX19Hh630cB6J3n3YtPjLocCO57kldHNlNLRkav3om1i1y+eMipAlM6IXGu/YeffXUwuDuqkV5SYx74BY3sIZxfMXO3tjcBRh2lCuHkPNzCDiJOqkFi0t0vfLfRKKPwNFy2p+3YIqfA+32RW7M4y7x8+mjIhs9wVrnecQcfRrXoud6k4ElN3AY06Bnb8IKM3JXhc4qaFjxNh9TXTjhjjKd7Y3HIFzQcoGENhtzFzNwKuFwNF/tw5iiqVCbCq2TpDDvNyt1l0W1ixxV5L4SMrwAgVttjKYLj9NCOYkROic5jfI2QWYoqshZNRbVEzDFGaf+I64VesYSTBHuLkqhp1qX/5zRKXGsp+2T01vjA4hXK0g0itAC8880CaeWoKVPpFyxsFkEZ8BzvO+Ltx4iJ9YK0dpvujSFBXoK79NG4jWU1FzMt28I3xaCcUBsUJDE8yV3klSdqaWhua/VzV13/NsdycMBuwwwZlfKBsd6WBzW2cQQoNOt5M7czXB6+CLJgfITnA8o3k5eO2zYG/1ngBsQ9Y+pqckgdW6vwbuGYnmnOsPyB2XfMTpOFzzoR3dkZtHkwRSLHFCgQSAZQL6mEBMLgtnkcQMg12QmOpOhCNl7aQf62yeEPOQtmgkUsdDAwm/TB1Zk9s50CQeJSnZVRmS6Hgp1D65h9u31Pefsn3NNbxYtOGsVebWBRv3Xx4SdI/YpWUifBZ19wn91cLS/3HzGEo1JsEjnzDc0dp3OrJr6ykZaL6Ndl8r+Rtglz3PD/0re+iFuiFq54I0JQIPYTGWnFMH2/2qLh2kkueCbOV8FfntlUw0QDeWCoOxS+NF1maZmvEEm5Q/GxT2LN2VX69gw1TdyvgMz0KJ2kuECGw5ftlQmztzdDKB385NEtidBp4vIeF8gA1hOxpQkrgRIR5K1Ypei6oBRL1Z+V1U9QvNwaytTCU8IiDP4Jtk+3NfKPWFNcK29qqXf1L f6+ma3Oo WmNXp1t3XR217g9Eszcc3rNYm0xq7fyPWTH6qnuAr+FhGGOEjkcvrc2BK3CusJEce7Kr3VWOCw9UqjIbwjR89j4ZZoowSH3blbuVUrus5m8+bl+Kh7ZXto9tVaOWaFMIuMLnrlt+doY5Q21S4h2d5dmmZShh+TAhrRIZjU6ek2VoIkFQQwIRu3IWgpXP0BapP7WHHLogrtY30qZz2P/R0J6Pb1zbygSsDzvXLJ4M3cCCTpgsSKUwR0AGn8bmCKqfiep+nwHFlY8962NQC1APvxtLBW10TnGnXMEThtpwA27e7H53NTcuAs9++DoqgxDuiYWRNambQx3IKXNJRkfO9gmr2sX7Z+1/Xhj4vMj44nw0cUSnftDzvfBU2zp1xmKRnbdbfokps8ZSYN81+vbQVB4yBLW6dhgRg5qiUey9XDGwAyirPtN0V32NDjqqJjay9beyjyh78cYSD/ClDT3EjBXHlA3UUJMZtxcgvgbyPp/fPUxGbysAHC1uEm4Hza/9Ome5dkrDTb+Esmxse8zxIRk4mjRlhtfxyicIGvqN2O+is/PXzfBxxxBDMCWMxQuhjWUgFUOExlUe++Ih+XttG/vDdrvyFbiRIlZn/M+p2287wFUkdi+NFVpnxkd7YsDody7/W X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 16.02.24 12:40, Byungchul Park wrote: > Changes from v2: > 1. Rewrite the comment in code and the commit message becasue it > turns out that this patch is not the real fix for the oops > descriped. The real fix goes in another patch below: > > https://lore.kernel.org/lkml/20240216111502.79759-1-byungchul@sk.com/ > > Changes from v1: > 1. Trim the verbose oops in the commit message. (feedbacked by > Phil Auld) > 2. Rewrite a comment in code. (feedbacked by Phil Auld) > > --->8--- > From 150af2f78e19217a1d03e47e3ee5279684590fb4 Mon Sep 17 00:00:00 2001 > From: Byungchul Park > Date: Fri, 16 Feb 2024 20:18:10 +0900 > Subject: [PATCH v3] sched/numa, mm: do not promote folios to nodes not set N_MEMORY > > A numa node might not have its local memory but CPUs. Promoting a folio > to the node's local memory is nonsense. So avoid nodes not set N_MEMORY > from getting promoted. So there is no bug/panic that can be triggered and this is not a "fix" but an optimization? > > Signed-off-by: Byungchul Park > --- > kernel/sched/fair.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index d7a3c63a2171..7ed9ef3c0134 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -1828,6 +1828,13 @@ bool should_numa_migrate_memory(struct task_struct *p, struct folio *folio, > int dst_nid = cpu_to_node(dst_cpu); > int last_cpupid, this_cpupid; > > + /* > + * A node of dst_nid might not have its local memory. Promoting > + * a folio to the node is meaningless. > + */ > + if (!node_state(dst_nid, N_MEMORY)) > + return false; > + > /* > * The pages in slow memory node should be migrated according > * to hot/cold instead of private/shared. Acked-by: David Hildenbrand -- Cheers, David / dhildenb