From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8716EE77184 for ; Tue, 17 Dec 2024 22:31:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 076326B0089; Tue, 17 Dec 2024 17:31:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 025B26B008A; Tue, 17 Dec 2024 17:31:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E07EC6B008C; Tue, 17 Dec 2024 17:31:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C3D5F6B0089 for ; Tue, 17 Dec 2024 17:31:35 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 4A3D51A0A25 for ; Tue, 17 Dec 2024 22:31:35 +0000 (UTC) X-FDA: 82905898572.28.B418EF3 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf24.hostedemail.com (Postfix) with ESMTP id B1878180010 for ; Tue, 17 Dec 2024 22:31:28 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hu42nRc2; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734474663; a=rsa-sha256; cv=none; b=OyjlwVpM1tJh0plrw3EeUjr4ol66R/PhSREPbb9pUx36AeCLaOkW0cWv0jFB1vOYPmTNaj JnRgPl36kfTw2XZ6MdKmPmMdyuxwfwGNI7ivu3h19hoZBIgF8Ro9DaYxLGFT+8mZFeZEBx zMmk/fl6c0ZzG+MqiTkMbCAsHrd+1cI= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hu42nRc2; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734474663; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XiLljyALg1fM2VreFU+kaDTSYWKU4UrG1GGEjFwMl+I=; b=M990gZHyLGoTKSf6nu8VHaFZZUbu3QgRXwhgQX2DAdGpF1q9xHnlnBStJbfZZWsMXNKW0s x1XMJLtXs47blO5KpKS/52++L9Hf6qUYE0zC59/qUDlB9F0Cb8fqd5H162IePKe4itxGap P81yGj6rcegmNsfojhqy07HQBiZv100= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1734474692; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=XiLljyALg1fM2VreFU+kaDTSYWKU4UrG1GGEjFwMl+I=; b=hu42nRc207yqOU6Yjl/1GFFlOpE7G86MkQdQ5XZfQTxPZZFNMo6xxFVsq1iUpPbLZTADpq lT5716lMSrp5HVNjEg0hVoc8yPGTNb/sGuLbvoCiexa3gRCtwwwHgmO0yt1is3dhuIu8Yp abeDuuAzz1ysSd57S84UZRer+17abd8= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-266-IJTX0_W4NWyMV3WiO9eQCg-1; Tue, 17 Dec 2024 17:31:30 -0500 X-MC-Unique: IJTX0_W4NWyMV3WiO9eQCg-1 X-Mimecast-MFC-AGG-ID: IJTX0_W4NWyMV3WiO9eQCg Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4361c040ba8so27044845e9.1 for ; Tue, 17 Dec 2024 14:31:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734474689; x=1735079489; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=XiLljyALg1fM2VreFU+kaDTSYWKU4UrG1GGEjFwMl+I=; b=OaB3zUmF004pZy2AwK4Q3IOkcSwCPSMM5XoZ5YfboilejLxsZFhdHkBC2FlaKdhfAI Bs1WleBbeTHIr9Qw4dGHDbAxjiFuKAoHQJ3+1GfOf5jVTeWToFrejqf+T5yjFZ8yBb0W NdJxbZE2BCmmUjdNcHV0H4JfQzNjDXs0YnT2xfsTLc8uCxqTRW9eDyOznGWMuhFRAnZj Cn2ZFQS/U1lTJykllmw0lVax8PXOYk1zch89iDb8cfdZ2fO3+5eXYrLAys0wIGXcA2A4 aivDRptyezlA3Df58NCI1oRxANKsBF/vioefRI9sj+YdMZh7R8tnN+88+PGEtQsZJ1o3 t6Nw== X-Forwarded-Encrypted: i=1; AJvYcCU/p7k84A+CuTZlvWqX0rSzTCvkBHFi7p2kl/0A7opdHYvtfpQvDx6OYcXrfiat56VFsUOX4/o7hQ==@kvack.org X-Gm-Message-State: AOJu0YxafOzIFrmGw5PmbRURNtY5PPYpOixS96HXF1Y1XSUJICSggauj v6ooyjO0Iy9cZxe2C/UoJaFGHScOAHeGvNXTTg45ptkJGZG1d5fgMxB+ShK/a0PPDPW/8gsy+RR 6VdklqtdoyAGS7teKCBs8SQD4QaXqYqDQleVAQrSyQvCqziO5 X-Gm-Gg: ASbGnctI8V5Sm4yfQk0FnkVxCP/IDc60yz3ON9M9J87b/cJCJ1NfWFXI86yEbO7z10P PYpEwtaKnObXmLxbQDk/kXRt5za9lbJT21iTA9TBLsoqd6n1uejSEz2I54G4BtUcQwFzo42DoZo R3msoUyi+oJ2mh75xQ+z9SPMIopsDn/gojiI6lNCSnwr4/LgUybo+eHJOnrIrEh2VGgAoaW8JZl wxGaYQf6HCKwZE2gfDFVj6jsnASdLk4ZCyC7aTzfrDCLVewvuIhUlR1jrYInHYLlR0TD4o6087R 0Rc69uCj4ERhIUeASLbjJQ0WIP4KuCBU8BXPJ3HdWFVd3ArgkPTcKci9EZ8jWkeMl11SOVTbzE8 jeGwIQH5O X-Received: by 2002:a05:600c:5103:b0:434:ff9d:a3a1 with SMTP id 5b1f17b1804b1-436553445f5mr3532775e9.2.1734474689195; Tue, 17 Dec 2024 14:31:29 -0800 (PST) X-Google-Smtp-Source: AGHT+IGMpkNWSDjSv+iIYkeduZssHVTB6HwkoYhZzex1R7it6KzpFTUsFNkIA9cgdJx8YijN/SwZMQ== X-Received: by 2002:a05:600c:5103:b0:434:ff9d:a3a1 with SMTP id 5b1f17b1804b1-436553445f5mr3532555e9.2.1734474688806; Tue, 17 Dec 2024 14:31:28 -0800 (PST) Received: from ?IPV6:2003:cb:c73b:5600:c716:d8e0:609d:ae92? (p200300cbc73b5600c716d8e0609dae92.dip0.t-ipconnect.de. [2003:cb:c73b:5600:c716:d8e0:609d:ae92]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-388c801208csm12474132f8f.1.2024.12.17.14.31.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Dec 2024 14:31:27 -0800 (PST) Message-ID: Date: Tue, 17 Dec 2024 23:31:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 19/25] proc/task_mmu: Ignore ZONE_DEVICE pages To: Alistair Popple , akpm@linux-foundation.org, dan.j.williams@intel.com, linux-mm@kvack.org Cc: lina@asahilina.net, zhang.lyra@gmail.com, gerald.schaefer@linux.ibm.com, vishal.l.verma@intel.com, dave.jiang@intel.com, logang@deltatee.com, bhelgaas@google.com, jack@suse.cz, jgg@ziepe.ca, catalin.marinas@arm.com, will@kernel.org, mpe@ellerman.id.au, npiggin@gmail.com, dave.hansen@linux.intel.com, ira.weiny@intel.com, willy@infradead.org, djwong@kernel.org, tytso@mit.edu, linmiaohe@huawei.com, peterx@redhat.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, jhubbard@nvidia.com, hch@lst.de, david@fromorbit.com References: From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: XP95uK4D4afVqB_5wReCr6sQNipeAyt2GT67WHPQVt8_1734474689 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: B1878180010 X-Stat-Signature: eschzumypc61kmnz5tg6w1t8ykcnm6bu X-Rspam-User: X-HE-Tag: 1734474688-445384 X-HE-Meta: U2FsdGVkX1+Kq5vLY3MdRXAmcuMjn3GIXxtWp4spNPWTjNNG57to0Zq+d29xH8yuJMdIiAtOBepcYk0aX1gmnFvaYtTTWA1QNcjO89fLq7jAOc+JjuzctUy2tg1tG52qBRzCpKz9SucU/nbSBB1409vRWxysyENVL3he+ONHgOqMKcpvVmd5i8E7wRpURz7rmY/vYZu/1FKFLcfDF/1/vFgu9jInEUhJXRp9cpPYkDWT/frpEXirHb+5KFfigIomfTmFVp6oz7r4uX6EgP8iU4YYsXNb0R1Ah+bzTmGV47MOBPVp+ci3lgaYPiF2ludYJCMJ1muiJcszWd80lO5+92R9K8BMpMLiNRTwkuTIJD+CdT+MENMCbmE+gYZ/DRuX12ay0IkeC8vGlMIhQaCQnfekE9gmvcTDxZCrunnpzpdF0A+P3WjIX4JMDHvzpMHQ0EuvkOTeGf1oc8fyUDcvtZEVzLiiVjKZazhxplWCPrBTwK1LiY+FgURdY3ERmuFqC+lMVfOReieZ+9yWHq1yoCtwF8H0oeJ3Y/D2ICaAKnQDyKw02r/nsQud0wq2BJISruaXUk47nMt/v+r/u+YcuZbBzPiYcGdo8PoMgKcHXnCRvJoQSDU82kXxjwglmaN4a5xoV/9OJbk67n5ohYtH3qKlqcfUkiRDf3zYqRlNZqcgAwge3qgMu2fA4yFg5j7Sg51gJfwWsQpIfbmfTZpTL9IrjRbVsuXeJltO1RI0p0lmcjbSKrd0xXsVMBlAK0DyfyLNfC/l7fIia0A+S5ggHIZL5yOg5Iq2GkktUH/ayZarUxlfjUmCXF2AfRAUHx86N2g5M03Iq4CmhNewbHcEbN5kVFBNZbKXm835Q8j2ZctQUY90ATaU/hW4ax2L070gFAyOAqQnKSw+RYRIHXJ85R5lWdD06CpqE8FoY+K84k/hQkzz7U820zduNjsSQ+zXhLnoD/ZoOguhut4n9bk 4e69phI7 LXz0pPzQPFi39n8M26UlzMHPe4nw086LFwh8HvXstjM3VaH6abVlEAaMRVtqQf79jjV7xD5AIMaSugMc9v+n3mzmfWHjAGrD0iQ/MTQhpS/NvvoBHPQQRyLtAyOM8zi8D63/BO6lZKkVjtDDliqQ4ZWxKm7t0ijEAhkJSd1ibmYpGTn2TQEuUyiUxy3AHp1FOPNsL3+e+m37BnvjyD/q3e7UVhNqvUoToOIHVFbRonkhdlZIx6vgOgmR0OpuTfJ1By1l5P5f0h+dpMgTLFY7JIGm9dDk2b6yzx/y6Nh/YSLOK8EkWbOyNraMj3VKWkuPYtx7Dg+j3uOvNY/4jK7uy9NDy6iL1FLx9R3giCSwZvT+y9APmP+WrxgSahZZrt/mxruD/VhSKSQW/dIu7cXzlNN48a1wBOg1Ox8JVUGlwzGnNFtKnsTF+GxtIKbyL91eOgxRAMThCMrutiq8TzRHre94sk/meiT9y9ysQh37eG9tfVIaL+TMOLKC9OrfAp7y6g+Bjl3Vz9jvYpkklahPxbBFi2xFKFenuxIKm X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 17.12.24 06:13, Alistair Popple wrote: > The procfs mmu files such as smaps currently ignore device dax and fs > dax pages because these pages are considered special. To maintain > existing behaviour once these pages are treated as normal pages and > returned from vm_normal_page() add tests to explicitly skip them. > > Signed-off-by: Alistair Popple > --- > fs/proc/task_mmu.c | 18 ++++++++++++++---- > 1 file changed, 14 insertions(+), 4 deletions(-) > > diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c > index 38a5a3e..c9b227a 100644 > --- a/fs/proc/task_mmu.c > +++ b/fs/proc/task_mmu.c > @@ -801,6 +801,8 @@ static void smaps_pte_entry(pte_t *pte, unsigned long addr, > > if (pte_present(ptent)) { > page = vm_normal_page(vma, addr, ptent); > + if (page && (is_device_dax_page(page) || is_fsdax_page(page))) This "is_device_dax_page(page) || is_fsdax_page(page)" is a common theme here, likely we should have a special helper? But, don't we actually want to include them in the smaps output now? I think we want. The rmap code will indicate these pages in /proc/meminfo, per-node info, in the memcg ... as "Mapped:" etc. So likely we just want to also indicate them here, or is there any downsides we know of? -- Cheers, David / dhildenb