From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95F39C2BBCA for ; Tue, 25 Jun 2024 13:44:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 05F286B0089; Tue, 25 Jun 2024 09:44:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F2D8F6B02DF; Tue, 25 Jun 2024 09:44:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E1BF86B02E1; Tue, 25 Jun 2024 09:44:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C4F3F6B02DE for ; Tue, 25 Jun 2024 09:44:24 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 4B1171219EF for ; Tue, 25 Jun 2024 13:44:24 +0000 (UTC) X-FDA: 82269530448.01.4E86885 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) by imf15.hostedemail.com (Postfix) with ESMTP id 585BBA000F for ; Tue, 25 Jun 2024 13:44:22 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Jer4t+T4; spf=pass (imf15.hostedemail.com: domain of seakeel@gmail.com designates 209.85.210.170 as permitted sender) smtp.mailfrom=seakeel@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719323055; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JAl8J4MqP+4c3Z5hB3+MKmFrhSggCFQ2IlAm7f5yZiU=; b=WZKkaOQvSd772mUq3Qs7AxH6TjQdcxCpWT8SkMyqTwSFkJhPAp0dxg7kxxjJ87HBFp0qum aJpytF2cA9QYXkyxo8Hb4Z62TKsKLgO2LLZGj9an+M+MnYGot69huoDh1wEOtExNV/f9Na 5y4JIRG5P/4AucC9nVS9bZ/Egze2zew= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Jer4t+T4; spf=pass (imf15.hostedemail.com: domain of seakeel@gmail.com designates 209.85.210.170 as permitted sender) smtp.mailfrom=seakeel@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719323055; a=rsa-sha256; cv=none; b=pUPj0NguvsSr8/i3w1Xl+/IXZni1mEL85uJj+8pN8gb5lhHKG6Mr26oZVMWuek+P4pSmpS SSr02eEtYKLAF76XtCSsINOo3cE4SFjwhJADH3w8Kvd1P5YX0pEwPzZ1UkWDRTH8+qTDi5 XBe1QKmRfj1FAQsS0UrXwVf582dusXI= Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-70675977d0eso2347633b3a.0 for ; Tue, 25 Jun 2024 06:44:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719323061; x=1719927861; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=JAl8J4MqP+4c3Z5hB3+MKmFrhSggCFQ2IlAm7f5yZiU=; b=Jer4t+T42e0wK1u78eLCk5X5O7eW4DFNfZjiXVcAf5TE+ac0OOjQ4+y7NXhSmCiRYT NkpDcSf560EoA3DSNLI1bfQFG8/+LxhcFz4NtsGTbPnLuaemEC2JE/j5/FayYIjfF/fm UmAfbmkKHi6qifv0mOMA/uzm59luXeSC9/pL3X1zDi/KDfQlxlHUBztO2okB0U5rre2K Ul2bn0n+tyOKRdkthTgAAIpX69kq/xW1GrsiqS8Kdey0tj/BkXHpGEjCpqrjr3CISshX u0Y+MbTtuJta7/ap6wwRnrK5DHukif1w2kG5vxUucskTmwQlbkkYUhCgcpuHiOykCMyU ysIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719323061; x=1719927861; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JAl8J4MqP+4c3Z5hB3+MKmFrhSggCFQ2IlAm7f5yZiU=; b=ZtJyFfTPV8fP6qvExiXrsRNAT3vASGtPwBuzw41Bqgf4ytlrIdNejkP14Vro6FPxag 4FZZHYlalup4zU/cTP/cf1mQNbPjz9a0MUTxNNyi2DjjcbQJzCdYNqdygBpR+B21q5Qb sdtJ9vSgFHg5lhTP5ePfeDQCl72oDRnp+G8Vwk0dQ8MyIm5s0BJub4+d6A4oZdbzYa+c wNatgpMX6ipgkH+Ssrf7aUziLVe+MF7yYkgqixI+9O3PWEiUxT3vkLLNgRuL9W8mYvbv Y3Al8z+FV/bgV11ibi7EbGk5nF5UEiNYxdetHPEVK3L2icIbRX034xTcbD7D7DiaFe4i +Mbg== X-Forwarded-Encrypted: i=1; AJvYcCX6pFGzXl0BJbCK84XdKxXcS2jJNzKbb5Y3XvY6k9RoEwTmXxxN3w/61Pom1l+W6Hhd0TfDQYJrh+TcD8PICO7B6K4= X-Gm-Message-State: AOJu0Yz3AE6KU1aqte6a3FaP/oZhGByZm7kbFvklWIUR97AN5kmO477S yIs0LFjqmiWr4HyDEM3YjdJFrZ3asQMDrM4XzJd5F/T+imVPxlea X-Google-Smtp-Source: AGHT+IGIn3SURX/Iou535swnaQy0A2CsGueDkYGx96tHZzoERA4ZhGtMlE1BiwXsPPB0yNnw2rfcGw== X-Received: by 2002:a05:6a20:dd97:b0:1b6:db6c:11dd with SMTP id adf61e73a8af0-1bcf7e6a5d8mr6325808637.9.1719323061188; Tue, 25 Jun 2024 06:44:21 -0700 (PDT) Received: from [192.168.255.10] ([101.87.0.0]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f9ebbbc1cbsm81095205ad.282.2024.06.25.06.44.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Jun 2024 06:44:20 -0700 (PDT) Message-ID: Date: Tue, 25 Jun 2024 21:44:16 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 00/15] add zpdesc memory descriptor for zswap.zpool To: Yosry Ahmed Cc: alexs@kernel.org, Vitaly Wool , Miaohe Lin , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, minchan@kernel.org, willy@infradead.org, senozhatsky@chromium.org, david@redhat.com, 42.hyeyoo@gmail.com References: <20240621054658.1220796-1-alexs@kernel.org> <2e9ce344-e25f-41e0-8ca4-b6d80e095735@gmail.com> Content-Language: en-US From: Alex Shi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 585BBA000F X-Stat-Signature: qqtasc7iw976c5ag4oouch6ptaxe5yei X-HE-Tag: 1719323062-271032 X-HE-Meta: U2FsdGVkX18+fHsWwUAubbQDmMp5FaaTgHUdKybsx/PmTFqNPoHpC9OQaz7ijOL8L0qZ3ai4ZR7s/ypqdys6s06hVD0WXBHNBFsHZjALqS05esPsawn5Wk9LYkb2+Pq4oFxwD0y8Bu6BjSBTOteg4Ewj/w6F6mwP+oYw01nnnK1Kiqwmo4a0QNce5uY3312y4v0CKs4uDQnv9ygXbEQXD1Yb7fB/UqcqjdsCJICk0jpytf92Gp/o3Utvp3HPnNm+rQDREUCuxMS1mbxb5pW0ViDAOJxPV+K1FL4c854yG6TmGV8r1v9d8yGbBK9T7sXsxGxaFmL3g3wHjThWHZZHZPL3C2pRVsy3/fQIxdpi7U58TOqym49or02SdAlaDk/sWRqB9MGlN9AUppsNc94+cORUuIV/lLAvLWUoDs65U+5Z36gX6E4pgTd5NyEkbTKi7lwsjziiWRc+mAlOtHAKd4Vk6fg8xbnSlD+ZoWz7H9GiFg6vVvVpEXmojuCEbBY6DEMMMgKhwlQyu9rW5db68ky42Hz0MMSD0jtDbixNEICQK4nMgvFC3F/viqPZeae7bDTHx8pzTJbQkcG3sqy4f10B3sUWqjb2tvupSzwlLXpm3Rh554N9z+jBAQkNmquXc196Kb32btiAdLvd0BW4ZpIT9jSE508No4HuqNP20GP60ZSMDi3qMoSzjTfp5kR4rKxbeUpsnSTIMsKyzDPLX8+k9grVISXrtcuqgpKeww015uUYyzhewuGvoRA5dleGoDJoOSKsjiIGqYtCd4f7uK1QS+zNvIKmLU6OekwoT/oOXAAKr1cWtgT/BoTjoP5+oBho+HNMGhQFaZ+Q1/B/IMF1o69n4gGy5cY3WiV6KZEcg9S3FVahPziKLcuP1/xZSNcjPei9O43AmKDKkREkK4gW2MTDq6A8g8IXCFD/wJodN2bFDn4hib5fKzWLkPIJX/cRZ248g9g/SQzSm1t G+ZTvuQH PGg5tpseASMsrjX3zuwRBYUsPk0fIrjwu1UfPo8eLyAbMDqHqBqbkdNz0mjpIjcUJZWQSzFz6gtTCPKVN4GSHuOmDKf16+CymCDxNSZoso2d13yEisp6CHsHVlTJuga6wC0+87WswSYXQ0aMxJVvIoDRbjG/LF/mkFlf3g76/7upHeLMUZ8aHxNzJqZchk0TaWaONCaKGqA5Th+TT+HWqcIaEFQZ/G0bBNbzBnaXQlGmAV3v52Ak1oFOZjnIcxn4aZ6iByAxwjI9GcaoH5+9eqLqUdw15w5HKoHVtUcsMP5610GfmPaaNHi0cUd53cbyeUN9i8FiSwWRTqxnU6xi5SJBWSbaEuPzvtYYLuqYjY2AFLDVqAcXyh/vVqZBETPVa37qTtl+HAj+D2fCQVjn5iwAOnFjNvdRoJt3HmKNyuPUoc5Ms7ZWU9NwpuOM2qJ5BlPO6wd/sYoPn+PXqnZC/Bq1YY8+QydOd1EdxXUiBKAJ+5IhlmU8k9j9dK3woiL7n51LxU9TSjS5ZNFwUM2RDr3iciFU0lUwzfhnY4PiFuYRLc98JK38jKo4soCxDOKPQAmyqBaKODtmKGstHXN2pnwNv2yFTPdhiUtwd86UK9vFQkxw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/25/24 6:30 PM, Yosry Ahmed wrote: > On Tue, Jun 25, 2024 at 1:11 AM Alex Shi wrote: >> >> >> >> On 6/25/24 5:46 AM, Yosry Ahmed wrote: >>> On Thu, Jun 20, 2024 at 10:42 PM wrote: >>>> >>>> From: Alex Shi >>>> >>>> According to Metthew's plan, the page descriptor will be replace by a 8 >>>> bytes mem_desc on destination purpose. >>>> https://lore.kernel.org/lkml/YvV1KTyzZ+Jrtj9x@casper.infradead.org/ >>>> >>>> Here is a implement on z3fold to replace page descriptor by zpdesc, >>>> which is still overlay on struct page now. but it's a step move forward >>>> above destination. >>>> >>>> To name the struct zpdesc instead of z3fold_desc, since there are 3 zpool >>>> usages under zswap, zbud, z3fold, zsmalloc. It looks like we may extend the >>>> zpdesc to zbud and zsmalloc, combined their usage into one. >>> >>> Please do not focus your development efforts on z3fold. We really want >>> to deprecate/remove it, as well as zbud eventually. See [1]. >>> >>> For zsmalloc, there is already an ongoing effort to split zsdesc from >>> struct page [2]. >>> >>> [1]https://lore.kernel.org/lkml/CAJD7tkbRF6od-2x_L8-A1QL3=2Ww13sCj4S3i4bNndqF+3+_Vg@mail.gmail.com/ >> >> Hi Yosry, >> >> Thanks a lot for the info and comments! It's my stupid w/o checking the email list before work on it. >> Anyway don't know if z3fold would be removed, jut left this tested patchset here if someone need it. > > It's partially our fault for leaving z3fold knowing that it is headed > toward deprecation/removal. FWIW, I tried to remove it or mark it as > deprecated, but there was some resistance :/ Yes, It happens. Community is too huge. Always someone want sth.