From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DDCCC3601E for ; Sun, 13 Apr 2025 20:05:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 238E72800FC; Sun, 13 Apr 2025 16:05:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1BF4F2800F7; Sun, 13 Apr 2025 16:05:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F2E0A2800FC; Sun, 13 Apr 2025 16:05:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D13D82800F7 for ; Sun, 13 Apr 2025 16:05:54 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 4D7E1140214 for ; Sun, 13 Apr 2025 20:05:55 +0000 (UTC) X-FDA: 83330101470.06.F8922E3 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf10.hostedemail.com (Postfix) with ESMTP id E7EDFC0008 for ; Sun, 13 Apr 2025 20:05:52 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iKQ+mW6X; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744574753; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=26kQaqxmClrkmqimyK/pAn0V/eLIFLyRyoGwKGCOpj0=; b=ZtUJKpffah9XG40othBT5Ph2HCA4RYMkC30Ixezn4+QXmsY3L/Bd4KclTAKcefmo9cy7iC OdPASbOzmCNRs0bobrEZ7+OL5XpsKbJDyM2HY+Yq5jSHzQI1yg/Pe/7Ruu84VTaSS71F7Z BAazCDqsPf3t6W8eE7oAhtDg1lym1W4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744574753; a=rsa-sha256; cv=none; b=GsCUJF7L64EmMi1MvS7vyB1RMlUIK5aV0/yIfoM8cMkHYdbSaLExh+60r4xzBsMqbnZaf3 yC6hF7iA7UAoLL919AfW2C6GamZfB25SySukKxXBuz0F7z2BTdiW6snxRfiE9ghVMaFszK 6TVkCMnr+DRktJ6g+wOvI1lucQKiIwg= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iKQ+mW6X; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744574752; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=26kQaqxmClrkmqimyK/pAn0V/eLIFLyRyoGwKGCOpj0=; b=iKQ+mW6XUnlrfh3lDbRkpth+C7qGAyvAFGniWjUffjzvASLw2KvVHAy6PA/J00s83WT48N Z3y+iYMCO9E/ZAyfsv2O/AS6zXt1+qTmPy5Yc3zslp7pfqQbNeonyfMaT7eLXWDaVXGv47 +bBoz289fQPAI4qMwCMdnwUKEpDx63Q= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-161-YPwhki6cMOuL6hjx7T0u_w-1; Sun, 13 Apr 2025 16:05:48 -0400 X-MC-Unique: YPwhki6cMOuL6hjx7T0u_w-1 X-Mimecast-MFC-AGG-ID: YPwhki6cMOuL6hjx7T0u_w_1744574748 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-43cf172ffe1so30998165e9.3 for ; Sun, 13 Apr 2025 13:05:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744574747; x=1745179547; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=26kQaqxmClrkmqimyK/pAn0V/eLIFLyRyoGwKGCOpj0=; b=N+XzAxJBH052dFswUuaQeYRB/rPetqzeD9oievbkDp8rhZ8d14OtxEXrAAeZkEnnEB H4gXBF7k2te1nakDpLu/CzVXm4/59XL5jX4rIF1j2rwBCJuw3/I4HIe1bVrD+LOxEbnQ gX8PdH9C45Lf/6/no22fWNVlJ58F6UfBxjJThl6M1t7qW3xAPhAEMTGn1ziSFEc9C+L7 hu8wZ/dSTIkRmhljoxmuMXJOE7XwSz0iU8Vxdg8scc4AGl5CShopBwe1bv736RMzBLiA O1UG9xJwYpc5bGGp23OI7FDFPXGwaQ7tii6apWK7ZQCZMKAew/lGvBkBtlSX1y551z4f o2FA== X-Forwarded-Encrypted: i=1; AJvYcCWTbXR8fk7eqgwiJwBWbxCdGhnc8abKnggw9SIdphDC+W5JqUG7kPtweIodorLarRZIM9OC2S0Svw==@kvack.org X-Gm-Message-State: AOJu0YyKjO5lqmYuXx6CEvT2318HE9LfZuzVqLnFuPSyKlUaa0IQkBZz PBoN2j/pmH8COSk8uJ28pLy7e0PspZEHDxXBkiYpSE+YgRbxIjC54WDQ1hn/fPgdMnY5GpJ+YRh yJ3Bog7FfWd5p48LjTI8pTmtP4zjpXab9Sr0XUck91bd2Ra6u X-Gm-Gg: ASbGncv4D6/rdAes9jndeAEfDwnm5NIw32/hUiyDg3/b70EMyjSbTxhSv2ZglTQ9tX/ SG331p+o7TmzO1jYI6vQpJy9BI8b1mMUMWffpoFm87/oWdjnAmrfAgHpgcGgSgwuvIjSMHwANng mZKIHuETkDM3hF7lCIqHyPCIhtAEtEuvuOTAf5kOhUNo8S3lXWpluFlYRxqSkMp3c7CuKFoYmBZ vsnfPpKnC0EMbZ1+1FktLycEQR+vq3ZvWSr/2pxCkFlrIEmXGAgr/yOjuqi6jdBWl14y1hBNXEO NEXC4/LmRwpN8ws+AKwJ1K1EScMPSjXSLUXG16KZaGWjxTmn+b4uZVV9YRQdQy9iQZfpN3vghEz EmRtZdcltQweOcFrXJLWdP4m0Py9k+PK6g942lC0= X-Received: by 2002:a5d:5989:0:b0:391:3915:cffb with SMTP id ffacd0b85a97d-39eaaec7870mr8568046f8f.43.1744574747476; Sun, 13 Apr 2025 13:05:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEj0NxM0N0abRhomL8K4YcFkTrVF5uys1Aj1DUWE1g435wGfrkYysdjnFb/nCc5L8Ln6JHViw== X-Received: by 2002:a5d:5989:0:b0:391:3915:cffb with SMTP id ffacd0b85a97d-39eaaec7870mr8568027f8f.43.1744574747090; Sun, 13 Apr 2025 13:05:47 -0700 (PDT) Received: from ?IPV6:2003:d8:2f02:2900:f54f:bad7:c5f4:9404? (p200300d82f022900f54fbad7c5f49404.dip0.t-ipconnect.de. [2003:d8:2f02:2900:f54f:bad7:c5f4:9404]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43f2338dc13sm159877575e9.3.2025.04.13.13.05.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 13 Apr 2025 13:05:46 -0700 (PDT) Message-ID: Date: Sun, 13 Apr 2025 22:05:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm: Introduce free_folio_and_swap_cache() to replace free_page_and_swap_cache() To: nifan.cxl@gmail.com, willy@infradead.org Cc: mcgrof@kernel.org, a.manzanares@samsung.com, dave@stgolabs.net, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, will@kernel.org, aneesh.kumar@kernel.org, hca@linux.ibm.com, gor@linux.ibm.com, linux-s390@vger.kernel.org, ziy@nvidia.com, Fan Ni , "Vishal Moola (Oracle)" References: <20250413042316.533763-1-nifan.cxl@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250413042316.533763-1-nifan.cxl@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Uh_1aLdLxTaB_eYf_dzZ-6dI95nHopLabjXxWzuhTek_1744574748 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: E7EDFC0008 X-Stat-Signature: 77wy1hthk1x49gbfa7ct19d6dbewe5of X-Rspam-User: X-HE-Tag: 1744574752-132502 X-HE-Meta: U2FsdGVkX19JIpiJfzZW54g8Fxtwbqss2UfsEC6pBHY/td+fnaPir8rG8BWysSdzn+jR8sjTmBEM5SEyZEqaSQBDbClgQ8anPNpA86qIhQK1qIs/ypw3xHeoPsCxRXfCpWd1K0Nw9g6p4w27qW0qM+grM6EGPhXCDQO2u31QbRxhhH4Fmyg/24h3Mu1n1sVYWPLQnedsrEvBCjJDZoBwQe+RDho6Dtm2TfjxZt4D4fw3NTgCQY3BG9G0pYHAEQTJ+ORy3DJZY5pIEbE1S/guOJZewE2X6CWkj+kl4W0pN+Fx52FRJ4yIZtsCg6Ywr39CxysWloA03vAEcpVT4tHs/nJbt+I9S8LDIPBJ3ktVD7Y+tyWO2GzbSiziUGYwhmTvKTyd/bUAqHvUkknpaZ1Hq0uRDcQhAzA2yFIpzJKwUqTKCS3dweGY99p0d+d2ywdy2hA3r9LpST4F8czIitb1rP1/Waqyx5NTKOOkArGxIfpjZnDVmFbzsPfr/WWL4TjKJlRlJbTTBfYtcB0e7OYs43Tip2QMv11yR5g+rNcjS28AZUs5LpAWjDXO5cwMme/MCJDgFFBtp0D5mhTVvSU7dI1lx5IuswAAHDQgrNF6E6rbEbPA6b03HiUevZ9IPGhyQinQkSvdEtcQAG0QvhlnyR0rEx9rbFPGK0/zhwjLohjrwNoVdbpKuSixeuRl4hddG5SP95pi0qkFCCjHDBpbqnUkFuBmBSInCBRKwIGlo7u00tmR5pMPuD5TxU2dqA1gA4cIZS+0GGX9af+fiUR7sIwUXOhnqyc4biTYX0Up5iT+91hyJHgI1p9yoSXgBtsDH/8dKxzjuBiYIG8S0exaq8j3t3CEwc4CBrYuL7Uyk6w34wv1EbWwn8jB1jjBpy/g69gsSRzqLNsGJ5Vj/rIoTWNDSEdUjR5dIA/+g1AMxS7vRZFHPb5ggQ3alljYdSixYBhMeJl5fZ4dYRv7dUY sSYzMeu3 Asd3Z5QJT9xlOfgcvcod/fVlHLV+/oaz5MKmvAdj9Ugd4M2YA9mErJ2QdhQ1/NvDeAxsk2KvFq961ONFREUGnTVCfKb8xDZ2H5UOdkwNj1kkZ8sM3buWG8/Rob0lLePcneP8ebMrlSmPRFKpc+JrdiL0CX1zfz1913d9Qrl8TVtk9qN8fDOESGzxkNuQ4QjCOs3F5UOwthQ7HlGySbsJYrVlyVeh3FG7hGgEACreNLjZhpoaXrFMnCO+aiQDh5Gyi+eZ//c2NtWCesQKlORcYM7zH9tUHp7HEdc/0KXj1fn/bLWNq8roanChh/bgA3BA+q9r1AxfgyIsbQX3daAlXkXOFYddJ9bOSdL+b8vkvFxagBUzvEFy9mfqycjWt8whgSdCQ8mQM+L5Q/h9Qc3QbRr1evDqw8uJwionR1Wxp/Yk2ma8P5Y2rwBhObNIHgqZN7EpNs8loC5IsjIY0lbtFhCqOt8tgJ6CVDp9mC+dDCxDLKq3BNgzBfBjRrd3AVl56yf49XSQz5PpoIbLDifIhx49NU70tVoe3puPTKS7hBg9E9qmoRqcbA4mRRC/fc8aIsJyNuq/6jQgFNezLZ4FGezK8WQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 13.04.25 06:22, nifan.cxl@gmail.com wrote: > From: Fan Ni > > The function free_page_and_swap_cache() takes a struct page pointer as > input parameter, but it will immediately convert it to folio and all > operations following within use folio instead of page. It makes more > sense to pass in folio directly. > > Introduce free_folio_and_swap_cache(), which takes folio as input to > replace free_page_and_swap_cache(). And apply it to all occurrences > where free_page_and_swap_cache() was used. Patch title should better be "mm: convert free_page_and_swap_cache() to free_folio_and_swap_cache()" and similarly adjust the patch description. Thanks! Acked-by: David Hildenbrand -- Cheers, David / dhildenb