From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76482EB64DA for ; Mon, 17 Jul 2023 03:41:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0025E6B0072; Sun, 16 Jul 2023 23:41:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EF5418D0002; Sun, 16 Jul 2023 23:41:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E0ACA8D0001; Sun, 16 Jul 2023 23:41:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D0BDD6B0072 for ; Sun, 16 Jul 2023 23:41:08 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 9878C402F0 for ; Mon, 17 Jul 2023 03:41:08 +0000 (UTC) X-FDA: 81019703016.05.4422C51 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf18.hostedemail.com (Postfix) with ESMTP id CEB0B1C0011 for ; Mon, 17 Jul 2023 03:41:06 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=JIRmxvod; spf=pass (imf18.hostedemail.com: domain of chao@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=chao@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689565267; a=rsa-sha256; cv=none; b=IfEtj5di3nvB88/LJvKN26ULlSLGuOocxPDpVooCJS9WKk6BT/CaaAA7b5vq6Wb9CCTH9c Xi3ut6rdJUiVkubupkPx8V/mYyN0mOfeDQXmof7rkbS9rKGuds3WJhsj67eqgZx3SLoss8 R4HRuC9LghQwKwtZpOquK1kYuMTaVbg= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=JIRmxvod; spf=pass (imf18.hostedemail.com: domain of chao@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=chao@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689565266; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=n59MWT9pv/mPkU8ybL+xWmRyxeYYry9uyWehZn05ZpU=; b=JkmU5bNuQX4l46VrDYEVLqnszmpv/Gxg922dq1MZfSbv+6CCJf1l1+RXLFxaZNQ/agZA/M tWqI8H4uwzIrf8NxR6dyWYn7LhcFb6wvU3IIABP4iRj6M/csTSN64KBJb2mYyp5ShNc2F6 kPtREayilXhs5uM5Za1K8lBiKwQkdaQ= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B462760B91; Mon, 17 Jul 2023 03:41:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D6C5CC433C7; Mon, 17 Jul 2023 03:41:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689565265; bh=hA/g9aS2y5CIfLc5yFsDNhX8Ew8lu1YlZr0MxnMf2e4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=JIRmxvodRVVUPrkNKLuPrh42JXKHsE1uTAf/t6aF0TMVxlI3PWT+y0lVHXHr1DBOC 8IFOcY1NypBmnR5GUsVCspKUFfUNL2S+ouwHfTPy+AAeLpQRKCmyAIa+ThnWjG2+j5 5vKMzS9hFXqw7PhXojROzT5Q+0Lv4MfBDYEDGLTpt64BNRPcIYXgmki7nlVwue9PET +jrjlbNJgVAlr4Kww5DwF2pHlv74iD0BRer6pCXXnYfpuTWHyFj0vr9DeUuCVgkhrt dy0PWtIWro0UplZHL1ONG9hyGcMWQ5mDQem+SyjDXJdZv3Hj0PdHUWBCiHno76cg1H xnpDlbX446Nag== Message-ID: Date: Mon, 17 Jul 2023 11:41:01 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 1/2] mm/damon/dbgfs: reduce stack usage in str_to_schemes() Content-Language: en-US To: sj@kernel.org, akpm@linux-foundation.org, damon@lists.linux.dev Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230716010927.3010606-1-chao@kernel.org> From: Chao Yu In-Reply-To: <20230716010927.3010606-1-chao@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: CEB0B1C0011 X-Stat-Signature: 7x1xugkkxnro8j8eytfpfrotmtpicnp5 X-Rspam-User: X-HE-Tag: 1689565266-922358 X-HE-Meta: U2FsdGVkX18VDUslecEbhBoIT61IDbjII84j17lb3Quge2blctE/LSZVm0S1UrGQRic1O4AiegxSvWkaXlb0zy6DYMdF7Y2uiajAp5+El/JXK0FWsfe5Z15OEXBz1kUokZGgpmsTGxTpXlwTb8qb5Rb4ZVRRJl4AgTtpYIV54T8rnWjo0oOVonpAidh2eI9KkcmFtqgGdZ/S5PySLudbgCMuL5Uri0a/l+7vfJ6Rt//eIVoCz6RL8QHB1mMcQ2U8KAm38ZQKdbAUUNpQWt3ffkDibAdsrFPiOFAhIvK5YVUwBzJdOyWJK4DW+iuDywSCa9jQpMw85ZAgxKfxEA6zofsYEqZPlXZ/K7bh7MjQ+BvCbUx/2Vu8UkPlUx7RJdrkGiPI2RJTdrIkt46Lp4AyLHtTrjTpA1BBFRvNzXx3QAGv5obo0Uxf8vaA57Do49TYNv2AfUiN5zvIex0MlNt/e8OH1rJDi0fL9XSnHyx7OE4O5IJVWnn9PmdhlOkKmEWBFeqZDTZuRT87NE+BT/iNzncr5/G8y6ddv5rH7webPxsFT24nGgyaMKbg5DCGfdPqFKRqvzzgQ/uzxKToTPP5gtOmtN8k1gG0AAvfAh9SD9/4wXZ1i9m302bpeXQkopeAvmvyZBGz8qWDePbL6R0S8NBtcrPCJy9/KI8tcmKqhdlDoWO877CSFc424GBE8yix/TrYmN4br4fhHHjmRwXRDfKpis5sJjTJX8xD11QUvhuwm2mztdno5xJElgIYnFcvzt93cPFQWvvhLEYfAe3IZnna5Kbouu6bf4LseT1eKp4W+WdU20ghXUiVIVEkSsnY8Zhu9vlIN66/u83snHpqRWcNgGb+xnnW77iwBj1kCnyX/OVRdZRew6w5rDAtBRuTxYmxfzigo4He1ZQBVQLueSW23w5C+TZBK9IM4uifCkYptVc9Cz+UQQabo7tB+KEO711H18usZdntarzTEaY dYFKomo/ qT+dU93pIydQNKdm0KLumzJgGu+Z70/H2xgJXvhluImhGPibRv2/AdsLeYzKl5GzdJ2RInXIjNfUao7xsBZY3S8TX+ebuHMDZN2iskXjLGJMQiis7wPE702FeIJ2uofnuPwywTNs91K3olR+XN7kMZlStd2jHgdsyefoS4+oq4UU/Zv7nb+TMfFKbsab72kMTB7u7S47HfPw+7uGzQ1GXJeEPfJ859Veul5eEvrXLvSv9mFYZVP8BdIJyPdqu0bf+QNm+xMT31mRFT2mFW+G993+45/UwcU33PyvN+JYtgmITuB9Atft8vxF1medmGqXro2ZOFc3bdzuUZ/nsMPuAPgl9VlHuEV6sAF2v2N1Rp+7Y/JS0aAlWUTBGRjQTZ9E+FDlByLNajbCdTsM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi all, It warned because my config is wrong, sorry for the mistake, please ignore the patchset. :-P Thanks, On 2023/7/16 9:09, Chao Yu wrote: > struct damos_quota quota caused the stack usage of str_to_schemes() to > grow beyond the warning limit on 32-bit architectures w/ gcc. > > mm/damon/dbgfs.c: In function ‘str_to_schemes’: > mm/damon/dbgfs.c:292:1: warning: the frame size of 1496 bytes is larger than 1024 bytes [-Wframe-larger-than=] > > Allocating dynamic memory in str_to_schemes() to fix this issue. > > Signed-off-by: Chao Yu > --- > mm/damon/dbgfs.c | 22 ++++++++++++++++------ > 1 file changed, 16 insertions(+), 6 deletions(-) > > diff --git a/mm/damon/dbgfs.c b/mm/damon/dbgfs.c > index 124f0f8c97b7..78acc7366895 100644 > --- a/mm/damon/dbgfs.c > +++ b/mm/damon/dbgfs.c > @@ -237,18 +237,26 @@ static struct damos **str_to_schemes(const char *str, ssize_t len, > int pos = 0, parsed, ret; > unsigned int action_input; > enum damos_action action; > + struct damos_quota *quota; > > schemes = kmalloc_array(max_nr_schemes, sizeof(scheme), > GFP_KERNEL); > if (!schemes) > return NULL; > > + quota = kmalloc(sizeof(struct damos_quota), GFP_KERNEL); > + if (!quota) { > + kfree(schemes); > + return NULL; > + } > + > *nr_schemes = 0; > while (pos < len && *nr_schemes < max_nr_schemes) { > struct damos_access_pattern pattern = {}; > - struct damos_quota quota = {}; > struct damos_watermarks wmarks; > > + memset(quota, 0, sizeof(struct damos_quota)); > + > ret = sscanf(&str[pos], > "%lu %lu %u %u %u %u %u %lu %lu %lu %u %u %u %u %lu %lu %lu %lu%n", > &pattern.min_sz_region, &pattern.max_sz_region, > @@ -256,10 +264,10 @@ static struct damos **str_to_schemes(const char *str, ssize_t len, > &pattern.max_nr_accesses, > &pattern.min_age_region, > &pattern.max_age_region, > - &action_input, "a.ms, > - "a.sz, "a.reset_interval, > - "a.weight_sz, "a.weight_nr_accesses, > - "a.weight_age, &wmarks.metric, > + &action_input, "a->ms, > + "a->sz, "a->reset_interval, > + "a->weight_sz, "a->weight_nr_accesses, > + "a->weight_age, &wmarks.metric, > &wmarks.interval, &wmarks.high, &wmarks.mid, > &wmarks.low, &parsed); > if (ret != 18) > @@ -278,15 +286,17 @@ static struct damos **str_to_schemes(const char *str, ssize_t len, > goto fail; > > pos += parsed; > - scheme = damon_new_scheme(&pattern, action, "a, &wmarks); > + scheme = damon_new_scheme(&pattern, action, quota, &wmarks); > if (!scheme) > goto fail; > > schemes[*nr_schemes] = scheme; > *nr_schemes += 1; > } > + kfree(quota); > return schemes; > fail: > + kfree(quota); > free_schemes_arr(schemes, *nr_schemes); > return NULL; > }