From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DFF3C76196 for ; Fri, 31 Mar 2023 09:38:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BF4336B0072; Fri, 31 Mar 2023 05:38:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BA4976B0074; Fri, 31 Mar 2023 05:38:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A6C6A6B0075; Fri, 31 Mar 2023 05:38:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 99F3C6B0072 for ; Fri, 31 Mar 2023 05:38:43 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 6F41BC0273 for ; Fri, 31 Mar 2023 09:38:43 +0000 (UTC) X-FDA: 80628693726.08.EB347F4 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by imf07.hostedemail.com (Postfix) with ESMTP id 216B140009 for ; Fri, 31 Mar 2023 09:38:40 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf07.hostedemail.com: domain of zhangpeng362@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=zhangpeng362@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680255521; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jsmS55Xx4vXy6jFsg6xbHpOr2yKMqHi6FAD2hcKXQ+0=; b=XT8ltTmJUM91wID383H82VKSUUhO4I1ulZ/E+joxae6J0iFWoWaOAvFEjSnMMa+M9mlLiU 2S616LpsL/cihL1KNApjCxoAn3V/M/XDTNIxxXlJDbOOuZQlsUG68zkwN/RTj7HU9sJyZo SKdS9YZRZTFw1MWdU+uMv/fVPOCfd7U= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf07.hostedemail.com: domain of zhangpeng362@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=zhangpeng362@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680255521; a=rsa-sha256; cv=none; b=mOmKdc0xNhpr4iJjOd6tkmB6m+7FfhTiL+BieKWupmZsrKvy9mwjWLv917oQOe8k/a2eNf pXz5o9twD9yWF6XQj9hhCwy0ZPUW6Jl2ymK32HpsnEIJu4cDlSobC4X3v+NZzaPjjOe5h7 J6Kt74kBe6mlhPhLGMOAJEiwwreyusk= Received: from kwepemm600020.china.huawei.com (unknown [172.30.72.53]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4PnwBH3p0yz17QQG; Fri, 31 Mar 2023 17:35:19 +0800 (CST) Received: from [10.174.179.160] (10.174.179.160) by kwepemm600020.china.huawei.com (7.193.23.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Fri, 31 Mar 2023 17:38:36 +0800 Message-ID: Date: Fri, 31 Mar 2023 17:38:36 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v4 5/6] mm: convert copy_user_huge_page() to copy_user_folio() Content-Language: en-US To: Matthew Wilcox CC: , , , , , , , , References: <20230330134045.375163-1-zhangpeng362@huawei.com> <20230330134045.375163-6-zhangpeng362@huawei.com> From: "zhangpeng (AS)" In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.160] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemm600020.china.huawei.com (7.193.23.147) X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: 216B140009 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: 4rcc7crpz6oryrrsck8rxh1we1htu5dk X-HE-Tag: 1680255520-459925 X-HE-Meta: U2FsdGVkX18eLevHSIoVUSTaf1LXffZEVUfKFHKU2ZyM4Cw0V3wJty9vJOv8sYL3oNLqrTLWkhERyLhb5cIHtzay6IphZ46RQV5fUrCS46Hlk6lXxCD+PxPmL8XIKdA96I3pYShTfgr9uX5bya9rN6oka3pCZqr3FICsfFziscEI/9yfhUgKovooWaOnjKW9El1Knc5TUQGgonHzTlp/OxFh3lTXMP0HWkY9rzix/vRq3dAwnFYOSFSF9BKnaTObm7OvtsP8Yawin8QXtCneHe5N0Wy0JutYRN2Njax1uKeumpbs6MAx+wIp/NCF4BYhpC0tKN+oSIekx9ZMylrIii5kC5MKmnJnGMTtoBGGJco070fmDmHxEjh2e8RILQLXqPtaSp6wDXJ87MTBxQJE6lasloPC3f92vUpTAhdMpvVtC+26I9OIOZRYXTckXLH10uCx+jJxcPrulsYxH5SDSmdsjNYhBlMZOuIa3K9OLeAMkHsEKrpELzAPcboKB9K7uN9fbtAXH2blnYgfpEAYARXoH4x8ayS9mRqFPjue8GSpTcyZkcVdkq2SZYmgVMIaJcQU7tKx6ehjs7DPWRV+cCfS+K74Iy9rrApVnRLdXBJ9Qz+XnoJzvOmFSYcfmdWcKXpghY5N0AKko5I3uqAS52msT2zFsK+6kVhYmOEE8nrcq80DC4yfzhGaiqv/Qw/bLWaPiz0NBEnnbf1C7EuScEfk48zRTp6adxpmp9txE5JeZVjxEMyv7UdkKlSKHUbu3DGrW77lyR8aECRqvPbA0g3w1K+c5Q6H0UEq0RYXq8PYBNBv5/vOMxOQzF+aagCFYq+p5F0dROZCuBAURp8IFJ8nSthXw4vtFIl1nF27632MX/Vt8t7/r01YiGLjbJqKcWdTTqt5tXxl/SsXs2WAxFgd6g5fK/QmOilisf3mu5hJsEQIa4dsCyqubpWdQxYhUIRBrElsRWso2rRZWwf mCiLfW8S 9xUUsoECu0n5yQ/i6TKgrRdJpdO6TeJbNCojtCSTw756PQFl5nZ1ValSdAOA4d02YSAYr8nBkOXXxiabb8DUnIAEvq3TfkI1ncDaWJIxVAbJvaxXo+9gg6fKAV4BSPnbbL4cZ+MkGu2TOGEaG66LIJ063R+hrxMX61AshUyZCmMmy7ueetBLg/sSiM5uNRmLi/y8Tit98gHTKtMMHr/AFo7bhU01xRcMp5Z4HbrX1KVuuBGcJoqZ/64F5U4ks4eqii54FiLrKWM8RfWY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/3/31 2:15, Matthew Wilcox wrote: > On Thu, Mar 30, 2023 at 09:40:44PM +0800, Peng Zhang wrote: >> +void copy_user_folio(struct folio *dst, struct folio *src, >> + unsigned long addr_hint, >> + struct vm_area_struct *vma, >> + unsigned int pages_per_huge_page); > Do we really want to pass in pages_per_huge_page here? We can get > that from folio_nr_pages(dst). Agreed. It's not necessary to pass in pages_per_huge_page. I'll remove it in a v5. >> +++ b/mm/hugetlb.c >> @@ -5097,8 +5097,8 @@ int copy_hugetlb_page_range(struct mm_struct *dst, struct mm_struct *src, >> ret = PTR_ERR(new_folio); >> break; >> } >> - copy_user_huge_page(&new_folio->page, ptepage, addr, dst_vma, >> - npages); >> + copy_user_folio(new_folio, page_folio(ptepage), addr, dst_vma, >> + npages); >> put_page(ptepage); > This function should be converted to s/ptepage/pte_folio/, but that's > not for this patch series. Appreciate your suggestion. I'll convert this function in a future patch set. >> - copy_user_huge_page(&new_folio->page, old_page, address, vma, >> - pages_per_huge_page(h)); >> + copy_user_folio(new_folio, page_folio(old_page), address, vma, >> + pages_per_huge_page(h)); > Likewise for s/old_page/old_folio/ Will also convert this. Best Regards, Peng