From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: Frederic Weisbecker <frederic@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Jonathan Corbet <corbet@lwn.net>,
Anna-Maria Behnsen <anna-maria@linutronix.de>
Cc: linux-kernel@vger.kernel.org, Len Brown <len.brown@intel.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Anna-Maria Behnsen <anna-maria@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
damon@lists.linux.dev, linux-mm@kvack.org,
SeongJae Park <sj@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
linux-arch@vger.kernel.org,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Andy Whitcroft <apw@canonical.com>, Joe Perches <joe@perches.com>,
Dwaipayan Ray <dwaipayanray1@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
netdev@vger.kernel.org, linux-sound@vger.kernel.org,
Michael Ellerman <mpe@ellerman.id.au>,
Nathan Lynch <nathanl@linux.ibm.com>,
linuxppc-dev@lists.ozlabs.org,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org
Subject: Re: [PATCH v2 00/15] timers: Cleanup delay/sleep related mess
Date: Mon, 16 Sep 2024 22:20:15 +0200 [thread overview]
Message-ID: <c794b4a6-468d-4552-a6d6-8185f49339d3@wanadoo.fr> (raw)
In-Reply-To: <20240911-devel-anna-maria-b4-timers-flseep-v2-0-b0d3f33ccfe0@linutronix.de>
Le 11/09/2024 à 07:13, Anna-Maria Behnsen a écrit :
> Hi,
>
> a question about which sleeping function should be used in acpi_os_sleep()
> started a discussion and examination about the existing documentation and
> implementation of functions which insert a sleep/delay.
>
> The result of the discussion was, that the documentation is outdated and
> the implemented fsleep() reflects the outdated documentation but doesn't
> help to reflect reality which in turns leads to the queue which covers the
> following things:
>
> - Split out all timeout and sleep related functions from hrtimer.c and timer.c
> into a separate file
>
> - Update function descriptions of sleep related functions
>
> - Change fsleep() to reflect reality
>
> - Rework all comments or users which obviously rely on the outdated
> documentation as they reference "Documentation/timers/timers-howto.rst"
>
> - Last but not least (as there are no more references): Update the outdated
> documentation and move it into a file with a self explaining file name
>
> The queue is available here and applies on top of tip/timers/core:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/anna-maria/linux-devel.git timers/misc
>
> Signed-off-by: Anna-Maria Behnsen <anna-maria@linutronix.de>
Hi,
not directly related to your serie, but some time ago I sent a patch to
micro-optimize Optimize usleep_range(). (See [1])
The idea is that the 2 parameters of usleep_range() are usually
constants and some code reordering could easily let the compiler compute
a few things at compilation time.
There was consensus on the value of the change (see [2]), but as you are
touching things here, maybe it makes sense now to save a few cycles at
runtime and a few bytes of code?
CJ
[1]:
https://lore.kernel.org/all/f0361b83a0a0b549f8ec5ab8134905001a6f2509.1659126514.git.christophe.jaillet@wanadoo.fr/
[2]:
https://lore.kernel.org/all/03c2bbe795fe4ddcab66eb852bae3715@AcuMS.aculab.com/
next prev parent reply other threads:[~2024-09-16 20:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-11 5:13 Anna-Maria Behnsen
2024-09-11 5:13 ` [PATCH v2 04/15] timers: Rename usleep_idle_range() to usleep_range_idle() Anna-Maria Behnsen
2024-09-11 5:13 ` [PATCH v2 08/15] mm/damon/core: Use generic upper bound recommondation for usleep_range() Anna-Maria Behnsen
2024-10-09 12:01 ` Frederic Weisbecker
2024-09-16 20:20 ` Christophe JAILLET [this message]
2024-09-17 5:22 ` [PATCH v2 00/15] timers: Cleanup delay/sleep related mess Christophe JAILLET
2024-09-23 15:12 ` Anna-Maria Behnsen
2024-10-02 15:02 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c794b4a6-468d-4552-a6d6-8185f49339d3@wanadoo.fr \
--to=christophe.jaillet@wanadoo.fr \
--cc=akpm@linux-foundation.org \
--cc=andrew@lunn.ch \
--cc=anna-maria@linutronix.de \
--cc=apw@canonical.com \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=corbet@lwn.net \
--cc=damon@lists.linux.dev \
--cc=davem@davemloft.net \
--cc=dwaipayanray1@gmail.com \
--cc=frederic@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=joe@perches.com \
--cc=len.brown@intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-sound@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mchehab@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=nathanl@linux.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=perex@perex.cz \
--cc=rafael@kernel.org \
--cc=sj@kernel.org \
--cc=tglx@linutronix.de \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox